RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

Alan Bateman Alan.Bateman at oracle.com
Wed Jan 16 08:50:37 UTC 2019

On 16/01/2019 08:42, Baesken, Matthias wrote:
> Hello,  please review this small  adjustment to  parse_manifest.c  .
> It adds support  for extended - length paths  (on Window)  .
> (see   https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#maximum-path-length-limitation
> For  extended length paths )
> Additionally ,  some small memory leaks   are fixed in  find_file .
> Bug/webrev :
> https://bugs.openjdk.java.net/browse/JDK-8217093
> http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.0/
If I read this correctly then it will prepend \\?\ which is consistent 
with what we do in other areas of the platform when presented with a 
long file name. Have you looked at moving open_jarfile to a platform 
specific source file?, in this case it might be better if the WIndows 
specific code were in src/java.base/windows/native/libjli for example.


More information about the core-libs-dev mailing list