RFR : 8217093: Support extended-length paths in parse_manifest.c on windows
matthias.baesken at sap.com
Wed Jan 16 09:07:35 UTC 2019
Hi Alan, I thought having UNIX+Windows code in this case together at one place would be okay .
However, if you prefer separating it, should I put it here ?
Or do you have a better suggestion ?
Best regards, Matthias
> From: Alan Bateman <Alan.Bateman at oracle.com>
> Sent: Mittwoch, 16. Januar 2019 09:51
> To: Baesken, Matthias <matthias.baesken at sap.com>; core-libs-
> dev at openjdk.java.net
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
> On 16/01/2019 08:42, Baesken, Matthias wrote:
> > Hello, please review this small adjustment to parse_manifest.c .
> > It adds support for extended - length paths (on Window) .
> > (see https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-
> > For extended length paths )
> > Additionally , some small memory leaks are fixed in find_file .
> > Bug/webrev :
> > https://bugs.openjdk.java.net/browse/JDK-8217093
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.0/
> If I read this correctly then it will prepend \\?\ which is consistent
> with what we do in other areas of the platform when presented with a
> long file name. Have you looked at moving open_jarfile to a platform
> specific source file?, in this case it might be better if the WIndows
> specific code were in src/java.base/windows/native/libjli for example.
More information about the core-libs-dev