RFR : 8217093: Support extended-length paths in parse_manifest.c on windows

Alan Bateman Alan.Bateman at oracle.com
Thu Jan 24 12:04:22 UTC 2019

On 23/01/2019 08:29, Baesken, Matthias wrote:
> Hello Alan,  here is a second webrev :
> http://cr.openjdk.java.net/~mbaesken/webrevs/8217093.1/
> I moved the  Windows-only code into a new file
> src/java.base/windows/native/libjli/parse_manifest_md.c
Did you consider adding a Unix version of open_jarfile to avoid #ifdef 
WIN32 ?

On the Windows version then your patch is low risk but the retrying 
after ENOENT is a bit icky. I'm just wondering if you've considered 
creating an absolute path and adding the prefix when the length is 247 
or greater. I also wonder about the share mode specified to CreateFileW 
where it might be better to specify FILE_SHARE_READ at least so that you 
don't exclude other processes from also opening the file to read.


More information about the core-libs-dev mailing list