RFR: JDK-8217792 : Investigate what modules are included

Alexander Matveev alexander.matveev at oracle.com
Wed Jan 30 22:40:14 UTC 2019

Hi Andy,

Line 272: Did you mean "if" here? I think it should be changed back to 
"else if".

Otherwise looks fine.


On 1/30/2019 2:05 PM, Andy Herrick wrote:
> Please review the jpackage fix for bug [1] at [2].
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
> JDK-8217792 : Investigate what modules are included
> For modules included in the runtime of a non-modular application, we 
> now computes all modules that export an API as the root modules and 
> compute their transitive closure, and do service binding.  As a 
> result, by default you get all modules except 10 internal modules.
> For jre-installer (without --runtime-image option) we revert to 
> including all modules.
> [1] https://bugs.openjdk.java.net/browse/JDK-8217792
> [2] http://cr.openjdk.java.net/~herrick/8217792/webrev.03/
> /Andy

More information about the core-libs-dev mailing list