RFR: JDK-8217792 : Investigate what modules are included
andy.herrick at oracle.com
Wed Jan 30 23:17:31 UTC 2019
yes - I will put the else back - no impact on functionality (both can't
be true), but it reads better with the else, conforms to the coding
style, and could be minutely faster.
On 1/30/2019 5:40 PM, Alexander Matveev wrote:
> Hi Andy,
> Line 272: Did you mean "if" here? I think it should be changed back to
> "else if".
> Otherwise looks fine.
> On 1/30/2019 2:05 PM, Andy Herrick wrote:
>> Please review the jpackage fix for bug  at .
>> This is a fix for the JDK-8200758-branch branch of the open sandbox
>> repository (jpackage).
>> JDK-8217792 : Investigate what modules are included
>> For modules included in the runtime of a non-modular application, we
>> now computes all modules that export an API as the root modules and
>> compute their transitive closure, and do service binding. As a
>> result, by default you get all modules except 10 internal modules.
>> For jre-installer (without --runtime-image option) we revert to
>> including all modules.
>>  https://bugs.openjdk.java.net/browse/JDK-8217792
>>  http://cr.openjdk.java.net/~herrick/8217792/webrev.03/
More information about the core-libs-dev