RFR: JDK-8217792 : Investigate what modules are included

Mandy Chung mandy.chung at oracle.com
Wed Jan 30 23:46:09 UTC 2019

On 1/30/19 2:05 PM, Andy Herrick wrote:
> Please review the jpackage fix for bug [1] at [2].
> This is a fix for the JDK-8200758-branch branch of the open sandbox 
> repository (jpackage).
> JDK-8217792 : Investigate what modules are included
> For modules included in the runtime of a non-modular application, we now 
> computes all modules that export an API as the root modules and compute 
> their transitive closure, and do service binding.  As a result, by 
> default you get all modules except 10 internal modules.
> For jre-installer (without --runtime-image option) we revert to 
> including all modules.
> [1] https://bugs.openjdk.java.net/browse/JDK-8217792
> [2] http://cr.openjdk.java.net/~herrick/8217792/webrev.03/

  368         ModuleFinder finder = ModuleFinder.ofSystem();

This means that you assume that the JMOD files used for linking
is the same version as the system module path.  This assumption
is fine since jlink currently does not support linking a different

You may want to add a comment if it helps.


More information about the core-libs-dev mailing list