[testbug] RFR: 8195716: BootstrapLoggerTest : Executor still alive

Daniel Fuchs daniel.fuchs at oracle.com
Thu Jan 31 14:56:59 UTC 2019

Hi Mandy,

Thanks for the review.

On 30/01/2019 22:24, Mandy Chung wrote:
> Looks okay.  This gets quite complicated to verify the executor
> gets GC'ed.  It may be helpful to add a comment to describe
> the situation when a new one may be created.

I have added some comments:

> The test can convert to use StackWalker rather than
> Thread::getAllStackTraces and it can then filter with Class instance.

I am not sure I see how the StackWalker could help here, a
better idea - that you suggested to me when we talked would
be to add more whitebox hooks to simplify the waiting logic
in the test.

I'd rather do that in a separate changeset though - and I have
logged https://bugs.openjdk.java.net/browse/JDK-8218141
to track all the suggestions I have received so far.

best regards

-- daniel

More information about the core-libs-dev mailing list