[OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte) with a method that has no throws clause
Roger.Riggs at oracle.com
Mon Jul 15 17:12:23 UTC 2019
Looks fine, Brian.
On 7/15/19 11:58 AM, Brian Burkhalter wrote:
> So updated: http://cr.openjdk.java.net/~bpb/8187898/webrev.02/ <http://cr.openjdk.java.net/~bpb/8187898/webrev.02/>
>> On Jul 12, 2019, at 4:15 PM, Philip Race <philip.race at oracle.com> wrote:
>> In that case just delete the comments and the commented out code ...
>> On 7/12/19, 3:12 PM, Brian Burkhalter wrote:
>>>> I think I'd be more inclined to make the code at 970 like that at 1036.
>>> Can’t do this exactly as drawImageBGR at 903 does not throw a PrinterException. Have to use RuntimeException.
>>>> On Jul 12, 2019, at 1:39 PM, Phil Race <philip.race at oracle.com <mailto:philip.race at oracle.com>> wrote:
>>>> oh well ... in which I suppose this is the best you can do here.
>>>> On 7/12/19 1:10 PM, Brian Burkhalter wrote:
>>>>>> (2) I don't know why at 1034 you changed from PrinterIOException to PrinterException.
>>>>> There is no PrinterIOException constructor which accepts a String as its only parameter and there is no IOException to pass to a PrinterIOException constructor.
More information about the core-libs-dev