8067801: Enforce null check for underlying I/O streams

Lance Andersen lance.andersen at oracle.com
Wed Jul 17 21:19:47 UTC 2019

Hi Brian
> On Jul 17, 2019, at 5:08 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> Hi Lance,
>> On Jul 17, 2019, at 1:55 PM, Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>> wrote:
>> I guess the next question(here he goes again ;-)  is do you want to test all of the constructors such as BufferedInputStream(InputStream, int) or just one per class?  I realize the BufferedInputStream(InputStream) just calls into BufferedInputStream(InputStream, int).
> Might as well add them in: http://cr.openjdk.java.net/~bpb/8067801/webrev.02/ <http://cr.openjdk.java.net/~bpb/8067801/webrev.02/>
>> Sorry for  the continual questions and extra work 
> No worries: it’s good to have things pointed out!

Looks good.  Maybe consider expanding to some of the other classes when you have cycles.  But in the meantime, ship it!
> Thanks,
> Brian

 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>

More information about the core-libs-dev mailing list