RFR: 8228434: jdk/net/Sockets/Test.java fails after JDK-8227642

Claes Redestad claes.redestad at oracle.com
Fri Jul 19 13:44:32 UTC 2019


why not just use the Platform.privilegedGetProperty method, which seems
purpose built for avoiding issues with reading properties like these
in tests running with a security manager?


On 2019-07-19 15:40, Severin Gehwolf wrote:
> Hi,
> Please review this fix for an issue introduced by JDK-8227642 pointed
> out by Alan Bateman. Thanks, Alan! That enhancement introduced a new
> constant in the test libraries' Platform class which can cause issues
> in tests which run with a security manager. One such instance is
> jdk/net/Sockets/Test.java.
> The proposed webrev addresses this issue by delaying loading of the
> DOCKER_COMMAND constant (which in turn triggers System.getProperty
> call).
> Bug: https://bugs.openjdk.java.net/browse/JDK-8228434
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8228434/01/webrev/
> Testing: tier1 on Linux x86_64, jdk/net jtreg tests. Docker/podman testing.
> Thoughts?
> Thanks,
> Severin

More information about the core-libs-dev mailing list