RFR: 8228434: jdk/net/Sockets/Test.java fails after JDK-8227642
igor.ignatyev at oracle.com
Fri Jul 19 22:39:49 UTC 2019
> On Jul 19, 2019, at 12:44 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 19/07/2019 18:59, Igor Ignatyev wrote:
>> haven't we identified and *fixed* all the tests which use j.t.l.Platform class and their own security policy (as part of 8210039 or other testlibrary refactoring)? in other words, all the tests which use j.t.l.Platform must have a policy file which grants Platform java.util.PropertyPermission read. so there should be no impact at all, unless there are tests which grants permissions to specific properties, and such policies are relatively easy to find and correct.
> Test infrastructure classes that need permissions are a bit of a pain for tests that want to run with a security manager or use their own policy files. It's just not easy to change these test libraries without fear of breaking tests in random places. I think we have to compartmentalize (as per the latest webrev) to avoid every test with a policy file needing to grant permissions do do container stuff when they aren't container tests.
good point, but I was rather suggesting that tests which use Platform should grant permissions to do "Platform" stuff which, one might argue, should have rights to read any system properties.
> One thing that would be helpful is to have a page on the wiki with info on how to these test libraries with a security manager - is this something that you (or maybe Mikhailo) would have cycles to do?
improving documentation of "common" test library classes has been in my todo list for a long time, and is definitely an overdue. I'll try to either reprioritize that work or at least compose the wiki-page you suggested.
More information about the core-libs-dev