RFR: 8228397: Missing license copyright header in some resource properties files
iris.clark at oracle.com
Wed Jul 24 00:18:16 UTC 2019
This updated webrev looks fine.
Thanks for fixing!
From: Leo Jiang
Sent: Tuesday, July 23, 2019 12:08 AM
To: Mandy Chung <mandy.chung at oracle.com>
Cc: jdk-dev <jdk-dev at openjdk.java.net>; core-libs-dev <core-libs-dev at openjdk.java.net>
Subject: Re: RFR: 8228397: Missing license copyright header in some resource properties files
Thank you for your reviewing.
Updated the webrev: http://cr.openjdk.java.net/~ljiang/8228397/webrev.01/
I know the update is trivial, if no more suggestion I will push the patch tomorrow.
On 7/23/19 3:55 AM, Mandy Chung wrote:
> Hi Leo,
> Thanks for adding the copyright and license header. The patch looks
> okay assuming you will separate the legal notices from the existing
> comment block in JFC properties files.
> On 7/22/19 9:23 AM, li.jiang at oracle.com wrote:
>> Hi all,
>> Please review this change.
>> We found the license copyright header are missing in some resource
>> properties files, some of them are very old and no hg log since code
>> forest consolidation. In this change, I added the license copyright
>> header in the English and its localized resource files.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8228397
>> Webrev: http://cr.openjdk.java.net/~ljiang/8228397/webrev.00/
More information about the core-libs-dev