[PING] RFR: 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp
sgehwolf at redhat.com
Mon Mar 18 10:06:02 UTC 2019
Could I get a review from an OpenJDK Reviewer for this, please? Bob is
already OK with it.
On Thu, 2019-03-14 at 13:58 -0400, Bob Vandette wrote:
> The change looks good. Thanks for fixing this.
> I’d send this to core-libs (cc’d).
> > On Mar 14, 2019, at 12:51 PM, Severin Gehwolf <sgehwolf at redhat.com> wrote:
> > Hi,
> > I'm not sure what the right list for Metrics.java is. Assuming it's
> > serviceability-dev:
> > Please review this one-liner for for SubSystem.java which currently
> > behaves differently from the native implementation in
> > osContainer_linux.cpp. Please see the details in the bug.
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8220579
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8220579/01/webrev/
> > Testing:
> > Manual testing of JDK-8217338 with Metrics.java support with/without
> > this fix on Linux x86_64. Metrics tests and Docker tests continue to
> > pass for fastdebug jvms (NOT for release jvms. see JDK-8220674, which
> > was fun).
> > Thoughts?
> > Thanks,
> > Severin
> >  http://hg.openjdk.java.net/jdk/jdk/file/641768acb12e/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java
More information about the core-libs-dev