RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields
adam.farley at uk.ibm.com
Thu Mar 21 16:51:23 UTC 2019
Good spot. Have updated the webrev.
Could you review the proposed change?
Also, I ran the invoke tests as advised, and the only one that
fails is "LFGarbageCollectedTest.java", which also fails in the
same way when run against a non-patched java, so I think we're ok.
Mandy Chung <mandy.chung at oracle.com> wrote on 20/03/2019 05:08:37:
> From: Mandy Chung <mandy.chung at oracle.com>
> To: Adam Farley8 <adam.farley at uk.ibm.com>
> Cc: core-libs-dev <core-libs-dev at openjdk.java.net>
> Date: 20/03/2019 05:10
> Subject: Re: RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails
> to throw IllegalAccessException for final fields
> Hi Adam,
> I imported your patch but there is one test failure:
> This test needs update of this change. Can you please send an updated
> patch and run all test/jdk/java/lang/invoke tests.
> On 3/6/19 8:28 AM, Adam Farley8 wrote:
> > Hi Mandy,
> > The webrev has been updated with the new test:
> > https://urldefense.proofpoint.com/v2/url?
> > Note that I included a handful of small improvements, and that the
> > fields are all setAccessible by default, because (a) it seemed cleaner
> > than adding a new control bit, and (b) nobody is meant to be changing
> > final fields anyway.
> > Open for review.
> > Best Regards
> > Adam Farley
> > IBM Runtimes
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
More information about the core-libs-dev