RFR: JDK-8237966,: Creating runtime pkg requires --mac-package-identifier
alexey.semenyuk at oracle.com
Thu Feb 27 16:52:50 UTC 2020
On 2/27/2020 10:02 AM, Andy Herrick wrote:
> sure - updated webrev  makes that private and static.
>  http://cr.openjdk.java.net/~herrick/8237966/webrev.02/
> On 2/26/2020 5:01 PM, Alexey Semenyuk wrote:
>> Looks good.
>> Minor note: I'd declare isValidBundleIdentifier() as static private.
>> - Alexey
>> On 2/26/2020 12:48 PM, Andy Herrick wrote:
>>> Please review the fix to issue  at .
>>> The initial concern with defaulting to the application or installer
>>> name was that is might not be a valid mac package identifier (use
>>> only alphanumeric, '.' , and '-' chars) but this can be true when
>>> the id is derived from main class (as in application case) or
>>> explicitly specified (using --mac-package-identifier). So this
>>> change now tests it in any case.
>>>  https://bugs.openjdk.java.net/browse/JDK-8237966
>>>  http://cr.openjdk.java.net/~herrick/8237966/webrev.01/
More information about the core-libs-dev