<i18n dev> [15] RFR: 8240626: Some of the java.time.chrono.Eras return empty display name for some styles and locales

Joe Wang huizhe.wang at oracle.com
Sat Mar 14 04:38:39 UTC 2020

Hi Naoto,

I see. That makes sense. The change looks good to me.


On 3/13/20 7:16 PM, naoto.sato at oracle.com wrote:
> Hi Joe,
> Thank you for the review. Since those names are filled at the JDK 
> build time, there is no way to confirm the localized ones are from the 
> locale itself or its parents, unless parsing CLDR's source XML files 
> in the test at the runtime. I think it is enough to just ensure 
> there's no empty names returned at the runtime, IMO.
> Naoto
> On 3/13/20 5:00 PM, Joe Wang wrote:
>> Hi Naoto,
>> The existing tests verifies that a display name matches an expected 
>> value. I wonder if you'd want to do a bit more than the Boolean 
>> assertion with a similar approach as the existing test, that is, 
>> check that the fallback values/alias names match expected names.
>> Best,
>> Joe
>> On 3/13/20 1:25 PM, naoto.sato at oracle.com wrote:
>>> Hello,
>>> Please review the fix to the following issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8240626
>>> The proposed chageset is located at:
>>> https://cr.openjdk.java.net/~naoto/8240626/webrev.00/
>>> In some locales, CLDR only provides partial translations of era 
>>> names, e.g., only HEISEI and REIWA are provided for Japanese 
>>> Calendar in Greek locale. CLDRConverter needs to supplement those 
>>> missing translations from parent locales.
>>> Naoto

More information about the core-libs-dev mailing list