[15] RFR: 8241082: Upgrade IANA Language Subtag Registry data to 03-16-2020 version

naoto.sato at oracle.com naoto.sato at oracle.com
Wed Mar 18 15:57:10 UTC 2020

Hi Roger, thanks for the review.

On 3/18/20 7:42 AM, Roger Riggs wrote:
> Hi Naoto,
> EquivMapsGenerator.java: 242
> It looks odd to put the warning about being an auto-generated file in 
> the middle of the declarations.
> Perhaps add it to the headerText.
> The existing maps are not pre-sized, is it important to pre-size the new 
> ones.
> There's no particular reason to pre-concatinate the new source lines. 
> Separate writes would be fine too.

Since we know the exact size of the map, specifying the size at the 
source creation time will save the map size increase (from the default 
16) at runtime. I would not call it as "important", but it would not hurt.

As to the warning message, yes it would be less odd if it were in the 
header text. Since I have already pushed the change, I'd like to correct 
it at the next opportunity. Would it be OK?


> Roger
> On 3/17/20 4:58 PM, naoto.sato at oracle.com wrote:
>> Hello,
>> Please review the fix to the following issue:
>> https://bugs.openjdk.java.net/browse/JDK-8241082
>> The proposed changeset is located at:
>> http://cr.openjdk.java.net/~naoto/8241082/webrev.00/
>> It is simply updating the data file. Since there is no change in 
>> equivalency of language tags, no code change and test change was 
>> needed except for the data release date. Instead, I modified the 
>> equiv-map source code generator to explicitly specify the initial 
>> capacity for hash maps.
>> Naoto

More information about the core-libs-dev mailing list