[PING] RFR(s): 8176894 Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute, merge in TreeMap

Martin Buchholz martinrb at google.com
Wed Mar 25 00:45:48 UTC 2020

Hi Tagir,

Looks good to me.

I can't find anything actually wrong, so here are some nitpicks you can

 676         V newValue;
 677         int mc = modCount;
 678         newValue = mappingFunction.apply(key);
I would never use a C style declaration when an initializing declaration
would work equally well.
Prevailing whitespace style here is Entry<K,V> rather than Entry<K, V> but
Intellij is on your side

On Mon, Mar 23, 2020 at 7:41 PM Tagir Valeev <amaembo at gmail.com> wrote:

> Hello!
> A gentle reminder to review the specialized implementation of TreeMap
> methods. The latest webrev is here:
> http://cr.openjdk.java.net/~tvaleev/webrev/8176894/r4/
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8176894
> CSR is already approved (thanks to Joe Darcy and Stuart Marks):
> https://bugs.openjdk.java.net/browse/JDK-8227666
> So only code review is necessary. Also, no sponsorship is necessary.
> Here's the previous discussion
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-October/062859.html
> Here's benchmarking results
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-February/064901.html
> Let's push it into Java 15!
> With best regards,
> Tagir Valeev.

More information about the core-libs-dev mailing list