RFR: 8232846: ProcessHandle.Info command with non-English shows question marks
Roger.Riggs at oracle.com
Thu Mar 26 13:48:20 UTC 2020
If the call fails, the command field in the info will not be set (and
I agree that a length of 512 (characters) is probably too small.
On 3/26/20 6:37 AM, Yasumasa Suenaga wrote:
> Hi Nakamura-san,
> Your change almost looks good, but I have one question.
> Length of exeName (1024) is enough?
> According to Microsoft Doc , exeName might not be null-terminated
> if it failed.
> I concern buffer overrun might occur when QueryFullProcessImageNameW
> On 2020/03/26 17:58, Toshio 5 Nakamura wrote:
>> Hi All,
>> Could you review this change? Additionally, I'd like to ask a sponsor
>> it, since I'm not a committer.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8232846
>> Webrev: http://cr.openjdk.java.net/~tnakamura/8232846/webrev.00
>> Under Windows environments, ProcessHandle.Info.command shows question
>> if the command has non-English characters. I'd like to change the
>> underlying API to Unicode version.
>> Tier1 tests passed.
>> Best regards,
>> Toshio Nakamura
More information about the core-libs-dev