RFR [15/java.xml] 8238183: SAX2StAXStreamWriter cannot deal with comments prior to the root element

naoto.sato at oracle.com naoto.sato at oracle.com
Mon Mar 30 18:23:06 UTC 2020

Hi Joe,

Can writeStartDocument() be simplified by checking "docLocator 
instanceof Locator2"? This way it won't need to catch CCE and issue 
no-arg version.

Otherwise looks good to me.


On 3/30/20 11:02 AM, Joe Wang wrote:
> Hi,
> Please review a fix for the StAXResult impl. The issue was that it 
> output comment prior to the declaration, resulting in an invalid XML 
> document. The patch focuses on fixing this issue, but it does not cover 
> other issues the StAXResult impl may have (e.g. JDK-8241711).
> JBS: https://bugs.openjdk.java.net/browse/JDK-8238183
> webrev: http://cr.openjdk.java.net/~joehw/jdk15/8238183/webrev/
> Thanks,
> Joe

More information about the core-libs-dev mailing list