[From nobody Wed Jun 1 15:16:53 2016 Message-ID: <5138664C.8060907@oracle.com> Date: Thu, 07 Mar 2013 02:05:00 -0800 From: "serguei.spitsyn@oracle.com" <serguei.spitsyn@oracle.com> User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130216 Thunderbird/17.0.3 MIME-Version: 1.0 To: Staffan Larsen <staffan.larsen@oracle.com> CC: "serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net" <serviceability-dev@openjdk.java.net>, "core-libs-dev@openjdk.java.net" <core-libs-dev@openjdk.java.net> Subject: Re: RFR(S): 8006637 Failure to filter out native frame events on Solaris References: <A7CA6A55-91DA-47F0-92D4-C873007AD166@oracle.com> <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> In-Reply-To: <47E924B8-0406-4EA9-B9C5-2C30B7E3EBE6@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Looks good. Thanks, Serguei On 3/7/13 12:10 AM, Staffan Larsen wrote: > Adding core-libs-dev and re-asking for a review. > > Thanks, > /Staffan > > On 27 feb 2013, at 15:59, Staffan Larsen <staffan.larsen@oracle.com> wrote: > >> Please review the following test fix. >> >> webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/ >> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637 >> >> The problem is that the test assumes that no other threads call String.intern() while the tests is running. This is normally ok, but when running with JFR there are other threads calling String.intern() in the background and the test fails. The solution is to add a thread filter to the method exit requests so that only calls to String.inter() in the main thread are reported. >> >> Thanks, >> /Staffan ]