Review request (S): 7140882 (Was: Re: Patch to fix build breakage with GCC 4.7)
david.holmes at oracle.com
Mon Jan 30 16:33:10 PST 2012
On 31/01/2012 1:38 AM, Andrew Hughes wrote:
> ----- Original Message -----
>> Deepak, I saw that you are an "author" for the JDK projects, but not
>> the HSX project. Thus, I can't create the changeset as your user.
>> Instead I list you as "Contributed-by". That field only supports
>> addresses. Here is what the changeset will look like:
> (ccing discuss)
> That seems wrong. No-one commits to the jdk projects directly, so
> what's the point in being a committer/reviewer there?
> Both Deepak and I have pushed patches to various repositories before.
> Why are our rights being taken away like this?
I think you have this backwards. No one externally can commit to hotspot
(HSX) directly due to the need to go through JPRT. But commits to JDK
repos (jdk8/*, jdk7/*) can be done directly (the jdkN/hotspot repos only
get populated by getting changes from the hsx/hotspot repo).
To submit hotspot patches you need the relevant role in the HSX project.
But until external pushes can be done the whole Contributor vs Author vs
Committer issue is somewhat moot.
More information about the discuss