<i18n dev> Jordan (Asia/Amman) versus SimpleTimeZone
Andrew John Hughes
gnu_andrew at member.fsf.org
Sun Aug 30 10:06:23 PDT 2009
2009/8/30 Mark Wielaard <mark at klomp.org>:
> Hi Sean (CC distro-pkg-dev added),
> On Sun, 2009-08-30 at 13:34 +0100, Sean Coffey wrote:
>> Mark Wielaard wrote:
>> > I was debugging the following bug report:
>> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=377
>> > "TimeZone.getOffset() fails for some TZ"
>> > The issue is caused because there is a start rule in the Asia/Amman
>> > timezone that starts at the end of a day. SimpleTimeZone doesn't allow
>> > that. I have a simple "fix" (attached), but I haven't fully tested it
>> > yet, and don't know if there could be other problems with allowing a
>> > rule to start on the last milisecond of a day.
>> > I noticed there is a similar bug report here:
>> > http://bugs.sun.com/view_bug.do?bug_id=6851214
>> > That is marked as "State 11-Closed, Verified, bug".
>> > There is however very little information on how this was fixed.
>> > Does anybody on this list know more?
>> Yes - that's the same fix that was put in the JDK releases.
>> The issue is only relevant for the Asia/Amman TZ as you mentioned.
> Thanks for the update and confirmation of the fix.
> I added it to IcedTea6 plus a new testcase for the general issue.
> 2009-08-30 Mark Wielaard <mark at klomp.org>
> PR377. SimpleTimeZone checks too strict for Asia/Amman TimeZone.
> * overlays/openjdk/jdk/test/java/util/SimpleTimeZone/EndOfDay.java:
> New test.
> * patches/icedtea-simpletimezone-relax.patch: New patch.
> * Makefile.am: Add new patch.
> * HACKING: Describe new patch.
Thanks for tracking down this issue. Could you add the Sun bug ID
somewhere too, either in the HACKING file or better still update the
wiki (http://icedtea.classpath.org/wiki/IcedTea_JDK6_Patches) with
this patch? Long term, we either need to submit your fix or backport
the Sun one when it appears in OpenJDK7 so that this is applied
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the distro-pkg-dev