From bugzilla-daemon at icedtea.classpath.org Wed Jul 1 01:19:19 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 01 Jul 2009 08:19:19 +0000 Subject: [Bug 359] New: Firefox crashed on Bandwidth Speed Test plugin Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=359 Summary: Firefox crashed on Bandwidth Speed Test plugin Product: IcedTea Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: mvyskocil at suse.cz Moved from https://bugzilla.novell.com/show_bug.cgi?id=486588 The Bandwidth Speed Test plugin [1] [2] causes a Firefox crash. Used versions MozillaFirefox-3.5b99-1.2 openjdk b16 with icedtea 1.5 [1] http://www.google.com/ig/adde?moduleurl=http://hosting.gmodules.com/ig/gadgets/file/111311123200664007084/speedtest.xml&source=imag [2] http://tinyurl.com/rarsga -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Wed Jul 1 01:20:19 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 01 Jul 2009 08:20:19 +0000 Subject: [Bug 359] Firefox crashed on Bandwidth Speed Test plugin Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=359 ------- Comment #1 from mvyskocil at suse.cz 2009-07-01 08:20 ------- Output of ICEDTEA_PLUGIN=1 firefox *** NSPlugin Viewer *** ERROR: /usr/lib/browser-plugins/nphelix.so: cannot open shared object file: No such file or directory *** nss-shared-helper: Shared database disabled (set NSS_USE_SHARED_DB to enable). ICEDTEA PLUGIN: Factory::IcedTeaPluginFactory CONSTRUCTING FACTORY ICEDTEAPLUGIN_DEBUG = 1 ICEDTEA PLUGIN: Factory::IcedTeaPluginFactory return ICEDTEA PLUGIN: Factory::Initialize ICEDTEA PLUGIN: Factory::Initialize: using /usr/lib64/jvm/java-1.6.0-openjdk-1.6.0/jre/lib/amd64/../../bin/java ICEDTEA PLUGIN: thread manager ICEDTEA PLUGIN: current thread Initializing JVM... ICEDTEA PLUGIN: get component manager ICEDTEA PLUGIN: liveconnect ICEDTEA PLUGIN: thread manager ICEDTEA PLUGIN: Instance::StartAppletviewer ICEDTEA PLUGIN: get component manager ICEDTEA PLUGIN: create local file ICEDTEA PLUGIN: init with path ICEDTEA PLUGIN: create process ICEDTEA PLUGIN: init process ICEDTEA PLUGIN: clearing old input fifo (if any): /home/mvyskocil/.icedteaplugin/icedtea-appletviewer-to-plugin ICEDTEA PLUGIN: creating input fifo: /home/mvyskocil/.icedteaplugin/icedtea-appletviewer-to-plugin ICEDTEA PLUGIN: created input fifo: /home/mvyskocil/.icedteaplugin/icedtea-appletviewer-to-plugin ICEDTEA PLUGIN: got confirmation that appletviewer is running ICEDTEA PLUGIN: clearing old output fifo (if any): /home/mvyskocil/.icedteaplugin/icedtea-plugin-to-appletviewer ICEDTEA PLUGIN: creating output fifo: /home/mvyskocil/.icedteaplugin/icedtea-plugin-to-appletviewer ICEDTEA PLUGIN: created output fifo: /home/mvyskocil/.icedteaplugin/icedtea-plugin-to-appletviewer ICEDTEA PLUGIN: run process Listening for transport dt_socket at address: 8787 ICEDTEA PLUGIN: Instance::StartAppletviewer return ICEDTEA PLUGIN: started appletviewer ICEDTEA PLUGIN: Factory::Initialize return ICEDTEA PLUGIN: Factory::CreateSecureEnv ICEDTEA PLUGIN: JNIEnv::IcedTeaJNIEnv ICEDTEA PLUGIN: JNIEnv::IcedTeaJNIEnv return CREATESECUREENV ICEDTEA PLUGIN: Factory::CreateSecureEnv return ICEDTEA PLUGIN: Factory::CreateInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance return ICEDTEA PLUGIN: Factory::CreateInstance return ICEDTEA PLUGIN: Instance::Initialize TAG FROM BROWSER = instance 1 tag http://wattaman.evonet.ro/speed-test-mare/?lang=en&country=us&.lang=en&.country=us&synd=ig&mid=10&use_hc=1&ifpctok=-428377367656088245&exp_split_js=1&exp_track_js=1&exp_ids=17259,300473&parent=http://www.google.com&libs=7GiCFv4OBq0/lib/liberror_tracker.js,VDxLZ7xAewY/lib/libcore.js&extern_js=/extern_js/f/CgJlbhICdXMrMAo4ACwrMBI4ACwrMBM4ACwrMBU4ACw/VuBgOjZjTd4.js&view=home ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 1 cookie Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 1 tag http://wattaman.evonet.ro/speed-test-mare/?lang=en&country=us&.lang=en&.country=us&synd=ig&mid=10&use_hc=1&ifpctok=-428377367656088245&exp_split_js=1&exp_track_js=1&exp_ids=17259,300473&parent=http://www.google.com&libs=7GiCFv4OBq0/lib/liberror_tracker.js,VDxLZ7xAewY/lib/libcore.js&extern_js=/extern_js/f/CgJlbhICdXMrMAo4ACwrMBI4ACwrMBM4ACwrMBU4ACw/VuBgOjZjTd4.js&view=home Wrote 901 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return SETTING PEER!!!: 0x7f38a0c3bc40 DONE SETTING PEER!!!: 0x7f38a0c3bc40 ICEDTEA PLUGIN: Instance::Initialize return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Start() ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return GETTING PEER!!!: 0x7f38a0c3bc40 DONE GETTING PEER!!!: 0x7f38a0c3bc40, 0x7f38a0c3bc40 ICEDTEA PLUGIN: Factory::GetValue ICEDTEA PLUGIN: Factory::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: setting window. ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 1 handle 33556662 Wrote 27 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::SetWindow IcedTeaPluginInstance::SetWindow: Instance 0x7f38a56d3f40 waiting for initialization... sh: pactl: command not found (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", (npviewer.bin:10790): Gtk-WARNING **: Unable to locate theme engine in module_path: "murrine", ICEDTEA PLUGIN: Instance::SetWindow IcedTeaPluginInstance::SetWindow: Instance 0x7f38a56d3f40 waiting for initialization... ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 1 status starting applet... PIPE: plugin read: instance 1 status starting applet... ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 1 status starting applet... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: plugin PluginProxyInfo http://wattaman.evonet.ro//speed-test-mare/speedometer.jar PIPE: plugin read: plugin PluginProxyInfo http://wattaman.evonet.ro//speed-test-mare/speedometer.jar ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: plugin PluginProxyInfo http://wattaman.evonet.ro//speed-test-mare/speedometer.jar http://wattaman.evonet.ro//speed-test-mare/speedometer.jar does not need a proxy No suitable proxy found for http://wattaman.evonet.ro//speed-test-mare/speedometer.jar ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: plugin PluginProxyInfo Wrote 24 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 1 status Applet loaded. PIPE: plugin read: instance 1 status Applet loaded. ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 1 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). PIPE: plugin read: instance 1 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 1 status Start: applet not initialized. PIPE: plugin read: instance 1 status Start: applet not initialized. ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 1 status Applet loaded. Processing complete received message: instance 1 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). Processing complete received message: instance 1 status Start: applet not initialized. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 1 initialized PIPE: plugin read: instance 1 initialized ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 1 initialized Setting instance.initialized for 0x7f38a56d3f40 from 0 to 1... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return Instance 0x7f38a56d3f40 initialization complete... ICEDTEA PLUGIN: Instance::SetWindow: window already exists. ICEDTEA PLUGIN: Instance::SetWindow: window width changed. ICEDTEA PLUGIN: Instance::SetWindow: window height changed. ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 1 width 407 height 157 Wrote 32 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SetWindow return Instance 0x7f38a56d3f40 initialization complete... ICEDTEA PLUGIN: Instance::SetWindow: window already exists. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: window already exists. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Factory::CreateInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance return ICEDTEA PLUGIN: Factory::CreateInstance return ICEDTEA PLUGIN: Instance::Initialize TAG FROM BROWSER = instance 2 tag http://atat.ro/page.php?104 ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 2 cookie __utma=77999940.298669121.1246435665.1246435665.1246435665.1; __utmb=77999940.3.10.1246435665; __utmz=77999940.1246435665.1.1.utmcsr=wattaman.evonet.ro|utmccn=(referral)|utmcmd=referral|utmcct=/speed-test-mare/; _csuid=49743b8a472a4f27; e107_tdOffset=1; e107_tdSetTime=1246435663; e107_tzOffset=-120; __utmc=77999940 Wrote 335 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 2 tag http://atat.ro/page.php?104 Wrote 513 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return SETTING PEER!!!: 0x7f389b597330 DONE SETTING PEER!!!: 0x7f389b597330 ICEDTEA PLUGIN: Instance::Initialize return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Start() ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return GETTING PEER!!!: 0x7f389b597330 DONE GETTING PEER!!!: 0x7f389b597330, 0x7f389b597330 ICEDTEA PLUGIN: Factory::GetValue ICEDTEA PLUGIN: Factory::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: setting window. ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 2 handle 33564937 Wrote 27 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::SetWindow IcedTeaPluginInstance::SetWindow: Instance 0x7f389bacf160 waiting for initialization... ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 2 status starting applet... PIPE: plugin read: instance 2 status starting applet... ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 2 status starting applet... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: plugin PluginProxyInfo http://atat.ro//speed_test/speedometer.jar PIPE: plugin read: plugin PluginProxyInfo http://atat.ro//speed_test/speedometer.jar ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: plugin PluginProxyInfo http://atat.ro//speed_test/speedometer.jar http://atat.ro//speed_test/speedometer.jar does not need a proxy No suitable proxy found for http://atat.ro//speed_test/speedometer.jar ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: plugin PluginProxyInfo Wrote 24 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 2 status Applet loaded. PIPE: plugin read: instance 2 status Applet loaded. ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 2 status Applet loaded. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 2 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). PIPE: plugin read: instance 2 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 2 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 2 status Start: applet not initialized. PIPE: plugin read: instance 2 status Start: applet not initialized. ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 2 status Start: applet not initialized. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: got NULL window. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Stop() ICEDTEA PLUGIN: Instance::Destroy ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 2 destroy Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::Destroy return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 2 initialized PIPE: plugin read: instance 2 initialized ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 2 initialized Setting instance.initialized for 0x7f389bacf160 from 0 to 1... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return Instance 0x7f389bacf160 initialization complete... ICEDTEA PLUGIN: Instance::SetWindow: window already exists. ICEDTEA PLUGIN: Instance::SetWindow: window width changed. ICEDTEA PLUGIN: Instance::SetWindow: window height changed. ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 2 width 407 height 157 Wrote 32 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: got NULL window. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Stop() ICEDTEA PLUGIN: Instance::Destroy ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 1 destroy Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::Destroy return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::~IcedTeaPluginInstance ICEDTEA PLUGIN: Instance::~IcedTeaPluginInstance return ICEDTEA PLUGIN: Factory::CreateInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance return ICEDTEA PLUGIN: Factory::CreateInstance return ICEDTEA PLUGIN: Instance::Initialize TAG FROM BROWSER = instance 3 tag http://wattaman.evonet.ro/speed-test-mare/?lang=en&country=us&.lang=en&.country=us&synd=ig&mid=10&use_hc=1&ifpctok=-428377367656088245&exp_split_js=1&exp_track_js=1&exp_ids=17259,300473&parent=http://www.google.com&libs=7GiCFv4OBq0/lib/liberror_tracker.js,VDxLZ7xAewY/lib/libcore.js&extern_js=/extern_js/f/CgJlbhICdXMrMAo4ACwrMBI4ACwrMBM4ACwrMBU4ACw/VuBgOjZjTd4.js&view=home ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 3 cookie Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 3 tag http://wattaman.evonet.ro/speed-test-mare/?lang=en&country=us&.lang=en&.country=us&synd=ig&mid=10&use_hc=1&ifpctok=-428377367656088245&exp_split_js=1&exp_track_js=1&exp_ids=17259,300473&parent=http://www.google.com&libs=7GiCFv4OBq0/lib/liberror_tracker.js,VDxLZ7xAewY/lib/libcore.js&extern_js=/extern_js/f/CgJlbhICdXMrMAo4ACwrMBI4ACwrMBM4ACwrMBU4ACw/VuBgOjZjTd4.js&view=home Wrote 901 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return SETTING PEER!!!: 0x7f389b27a470 DONE SETTING PEER!!!: 0x7f389b27a470 ICEDTEA PLUGIN: Instance::Initialize return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Start() ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return GETTING PEER!!!: 0x7f389b27a470 DONE GETTING PEER!!!: 0x7f389b27a470, 0x7f389b27a470 ICEDTEA PLUGIN: Factory::GetValue ICEDTEA PLUGIN: Factory::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: setting window. ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 3 handle 33569968 Wrote 27 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::SetWindow IcedTeaPluginInstance::SetWindow: Instance 0x7f389b629640 waiting for initialization... ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 3 status starting applet... PIPE: plugin read: instance 3 status starting applet... ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 3 status starting applet... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 3 status Applet loaded. PIPE: plugin read: instance 3 status Applet loaded. ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 3 status Applet loaded. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 3 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). PIPE: plugin read: instance 3 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 3 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 3 status Start: applet not initialized. PIPE: plugin read: instance 3 status Start: applet not initialized. ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 3 status Start: applet not initialized. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: got NULL window. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Stop() ICEDTEA PLUGIN: Instance::Destroy ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 3 destroy Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::Destroy return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Factory::CreateInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance return ICEDTEA PLUGIN: Factory::CreateInstance return ICEDTEA PLUGIN: Instance::Initialize TAG FROM BROWSER = instance 4 tag http://wattaman.evonet.ro/speed-test-mare/?lang=en&country=us&.lang=en&.country=us&synd=ig&mid=10&use_hc=1&ifpctok=-428377367656088245&exp_split_js=1&exp_track_js=1&exp_ids=17259,300473&parent=http://www.google.com&libs=7GiCFv4OBq0/lib/liberror_tracker.js,VDxLZ7xAewY/lib/libcore.js&extern_js=/extern_js/f/CgJlbhICdXMrMAo4ACwrMBI4ACwrMBM4ACwrMBU4ACw/VuBgOjZjTd4.js&view=home ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 4 cookie Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 4 tag http://wattaman.evonet.ro/speed-test-mare/?lang=en&country=us&.lang=en&.country=us&synd=ig&mid=10&use_hc=1&ifpctok=-428377367656088245&exp_split_js=1&exp_track_js=1&exp_ids=17259,300473&parent=http://www.google.com&libs=7GiCFv4OBq0/lib/liberror_tracker.js,VDxLZ7xAewY/lib/libcore.js&extern_js=/extern_js/f/CgJlbhICdXMrMAo4ACwrMBI4ACwrMBM4ACwrMBU4ACw/VuBgOjZjTd4.js&view=home Wrote 901 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return SETTING PEER!!!: 0x7f389b27a920 DONE SETTING PEER!!!: 0x7f389b27a920 ICEDTEA PLUGIN: Instance::Initialize return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Start() ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return GETTING PEER!!!: 0x7f389b27a920 DONE GETTING PEER!!!: 0x7f389b27a920, 0x7f389b27a920 ICEDTEA PLUGIN: Factory::GetValue ICEDTEA PLUGIN: Factory::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: setting window. ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 4 handle 33571725 Wrote 27 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::SetWindow IcedTeaPluginInstance::SetWindow: Instance 0x7f38ac13f940 waiting for initialization... ICEDTEA PLUGIN: Instance::SetWindow IcedTeaPluginInstance::SetWindow: Instance 0x7f38ac13f940 waiting for initialization... ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 3 initialized PIPE: plugin read: instance 3 initialized ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 3 initialized Setting instance.initialized for 0x7f389b629640 from 0 to 1... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 4 status starting applet... PIPE: plugin read: instance 4 status starting applet... ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 4 status starting applet... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 4 status Applet loaded. PIPE: plugin read: instance 4 status Applet loaded. ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 4 status Applet loaded. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 4 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). PIPE: plugin read: instance 4 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 4 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 4 status Start: applet not initialized. PIPE: plugin read: instance 4 status Start: applet not initialized. ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 4 status Start: applet not initialized. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 4 initialized PIPE: plugin read: instance 4 initialized ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 4 initialized Setting instance.initialized for 0x7f38ac13f940 from 0 to 1... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return Instance 0x7f38ac13f940 initialization complete... ICEDTEA PLUGIN: Instance::SetWindow: window already exists. ICEDTEA PLUGIN: Instance::SetWindow: window width changed. ICEDTEA PLUGIN: Instance::SetWindow: window height changed. ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 4 width 407 height 157 Wrote 32 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SetWindow return Instance 0x7f38ac13f940 initialization complete... ICEDTEA PLUGIN: Instance::SetWindow: window already exists. ICEDTEA PLUGIN: Instance::SetWindow return Instance 0x7f389b629640 initialization complete... ICEDTEA PLUGIN: Instance::SetWindow: parent window changed. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: window already exists. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: got NULL window. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Stop() ICEDTEA PLUGIN: Instance::Destroy ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 4 destroy Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::Destroy return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::~IcedTeaPluginInstance ICEDTEA PLUGIN: Instance::~IcedTeaPluginInstance return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 4 status Stop: applet not started. PIPE: plugin read: instance 4 status Stop: applet not started. ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 4 status Destroy: applet not stopped. PIPE: plugin read: instance 4 status Destroy: applet not stopped. ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 4 status Dispose: applet not destroyed. PIPE: plugin read: instance 4 status Dispose: applet not destroyed. ICEDTEA PLUGIN: plugin_in_pipe_callback return received message: instance 4 status Stop: applet not started. Processing complete received message: instance 4 status Destroy: applet not stopped. Processing complete received message: instance 4 status Dispose: applet not destroyed. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: Factory::CreateInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance ICEDTEA PLUGIN: Instance::IcedTeaPluginInstance return ICEDTEA PLUGIN: Factory::CreateInstance return ICEDTEA PLUGIN: Instance::Initialize TAG FROM BROWSER = instance 5 tag http://wattaman.evonet.ro/speed-test-mare/?lang=en&country=us&.lang=en&.country=us&synd=ig&mid=10&use_hc=1&ifpctok=-428377367656088245&exp_split_js=1&exp_track_js=1&exp_ids=17259,300473&parent=http://www.google.com&libs=7GiCFv4OBq0/lib/liberror_tracker.js,VDxLZ7xAewY/lib/libcore.js&extern_js=/extern_js/f/CgJlbhICdXMrMAo4ACwrMBI4ACwrMBM4ACwrMBU4ACw/VuBgOjZjTd4.js&view=home ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 5 cookie Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 5 tag http://wattaman.evonet.ro/speed-test-mare/?lang=en&country=us&.lang=en&.country=us&synd=ig&mid=10&use_hc=1&ifpctok=-428377367656088245&exp_split_js=1&exp_track_js=1&exp_ids=17259,300473&parent=http://www.google.com&libs=7GiCFv4OBq0/lib/liberror_tracker.js,VDxLZ7xAewY/lib/libcore.js&extern_js=/extern_js/f/CgJlbhICdXMrMAo4ACwrMBI4ACwrMBM4ACwrMBU4ACw/VuBgOjZjTd4.js&view=home Wrote 901 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return SETTING PEER!!!: 0x7f389b2b0d30 DONE SETTING PEER!!!: 0x7f389b2b0d30 ICEDTEA PLUGIN: Instance::Initialize return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Start() ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return GETTING PEER!!!: 0x7f389b2b0d30 DONE GETTING PEER!!!: 0x7f389b2b0d30, 0x7f389b2b0d30 ICEDTEA PLUGIN: Factory::GetValue ICEDTEA PLUGIN: Factory::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: setting window. ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 5 handle 33574333 Wrote 27 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::SetWindow IcedTeaPluginInstance::SetWindow: Instance 0x7f389bc6f100 waiting for initialization... ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 5 status starting applet... PIPE: plugin read: instance 5 status starting applet... ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 5 status starting applet... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return Pending event processed (this) ... 1 ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 5 status Applet loaded. PIPE: plugin read: instance 5 status Applet loaded. ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 5 status Applet loaded. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return Pending event processed (this) ... 1 ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 5 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). PIPE: plugin read: instance 5 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 5 status exception: java.security.AccessControlException: access denied (java.lang.RuntimePermission getClassLoader). Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return Pending event processed (this) ... 1 ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 5 status Start: applet not initialized. PIPE: plugin read: instance 5 status Start: applet not initialized. ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 5 status Start: applet not initialized. Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return Pending event processed (this) ... 1 ICEDTEA PLUGIN: plugin_in_pipe_callback return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::SetWindow ICEDTEA PLUGIN: Instance::SetWindow: got NULL window. ICEDTEA PLUGIN: Instance::SetWindow return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return NOT IMPLEMENTED: virtual nsresult IcedTeaPluginInstance::Stop() ICEDTEA PLUGIN: Instance::Destroy ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer Writing to JVM: instance 5 destroy Wrote 19 bytes to pipe ICEDTEA PLUGIN: Instance::SendMessageToAppletViewer return ICEDTEA PLUGIN: Instance::Destroy return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: Instance::GetValue ICEDTEA PLUGIN: Instance::GetValue return ICEDTEA PLUGIN: plugin_in_pipe_callback Received message: instance 5 initialized PIPE: plugin read: instance 5 initialized ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM received message: instance 5 initialized Setting instance.initialized for 0x7f389bc6f100 from 0 to 1... Processing complete ICEDTEA PLUGIN: Instance::ConsumeMsgFromJVM return ICEDTEA PLUGIN: plugin_in_pipe_callback return Instance 0x7f389bc6f100 initialization complete... ICEDTEA PLUGIN: Instance::SetWindow: parent window changed. ICEDTEA PLUGIN: Instance::SetWindow return /usr/bin/firefox: line 126: 10717 Segmentation fault (core dumped) $MOZ_PROGRAM "$@" -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Wed Jul 1 01:21:12 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 01 Jul 2009 08:21:12 +0000 Subject: [Bug 359] Firefox crashed on Bandwidth Speed Test plugin Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=359 ------- Comment #2 from mvyskocil at suse.cz 2009-07-01 08:21 ------- Created an attachment (id=234) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=234&action=view) ~/.icedteaplugin/java.stderr The java.stdout remains empty -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Wed Jul 1 01:22:11 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 01 Jul 2009 08:22:11 +0000 Subject: [Bug 359] Firefox crashed on Bandwidth Speed Test plugin Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=359 ------- Comment #3 from mvyskocil at suse.cz 2009-07-01 08:22 ------- Created an attachment (id=235) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=235&action=view) Core dump of firefox -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From Andrei.Dmitriev at Sun.COM Wed Jul 1 01:18:28 2009 From: Andrei.Dmitriev at Sun.COM (Andrei Dmitriev) Date: Wed, 01 Jul 2009 12:18:28 +0400 Subject: Patch for SelectionAutoscrollTest In-Reply-To: <1147001799.691391246393508970.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <1147001799.691391246393508970.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4A4B1BD4.90606@sun.com> Hi Man Lung Wong, generally speaking this approach is good enough but the better way is to use SunToolkit.realSync() method which synchronously guarantees the events from the queue are dispatched. You may notice that call from within some other tests in the test/ folder. Just make a "grep" for it to get an example. But from the other hand, we have similar defect: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6615847 and the report mentions some issues with this approach mentioned above. BTW, did you already created a defect in bugzilla? It would be just fine to have a reference for every patch suggested and not let them sunk in email boxes/mailing lists archives. :) Thanks, Andrei Man Wong wrote: > Hi > > I have encountered the jtreg failure of the selection autoscroll test (openjdk/jdk/test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest). I found out the problem occurs because in the test, the mouse is not pressed for long enough outside the text box to allow the highlight to reach the bottom (even though the behaviour is still correct). Hence, all that was needed was to add a delay on the mouse press event after it had moved outside of the text box. The only concern I have is whether the duration for the delay I set is reasonable (I have it at 2s) or would a more generalized approach be more suitable (i.e. find a way to check if the highlighting is still moving on to the next character). Let me know what you think and thanks. > > By the way, my system is Fedora 10 32 bits running on gnome 2.24.3, icedtea6 build with openjdk6. > > Man Lung Wong > From gbenson at redhat.com Fri Jul 3 03:50:53 2009 From: gbenson at redhat.com (Gary Benson) Date: Fri, 03 Jul 2009 10:50:53 +0000 Subject: changeset in /hg/icedtea6: 2009-07-03 Gary Benson changeset 308c172cd230 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=308c172cd230 description: 2009-07-03 Gary Benson * ports/hotspot/src/share/vm/shark/sharkEntry.hpp (SharkEntry::print_statistics): Removed. * ports/hotspot/src/share/vm/shark/sharkEntry.cpp: Removed. * ports/hotspot/src/share/vm/shark/sharkCompiler.cpp (SharkCompiler::compile_method): Save location of native code across the call to ciEnv::register_method (which frees the buffer blob it's in), and inline what was SharkEntry::print_statistics. * ports/hotspot/src/share/vm/includeDB_shark: Updated. diffstat: 5 files changed, 22 insertions(+), 49 deletions(-) ChangeLog | 13 ++++++ ports/hotspot/src/share/vm/includeDB_shark | 2 - ports/hotspot/src/share/vm/shark/sharkCompiler.cpp | 15 ++++--- ports/hotspot/src/share/vm/shark/sharkEntry.cpp | 38 -------------------- ports/hotspot/src/share/vm/shark/sharkEntry.hpp | 3 - diffs (119 lines): diff -r 9247751a966e -r 308c172cd230 ChangeLog --- a/ChangeLog Fri Jun 26 04:51:17 2009 -0400 +++ b/ChangeLog Fri Jul 03 11:52:45 2009 +0100 @@ -1,3 +1,16 @@ 2009-06-26 Gary Benson + + * ports/hotspot/src/share/vm/shark/sharkEntry.hpp + (SharkEntry::print_statistics): Removed. + * ports/hotspot/src/share/vm/shark/sharkEntry.cpp: Removed. + + * ports/hotspot/src/share/vm/shark/sharkCompiler.cpp + (SharkCompiler::compile_method): Save location of native code + across the call to ciEnv::register_method (which frees the buffer + blob it's in), and inline what was SharkEntry::print_statistics. + + * ports/hotspot/src/share/vm/includeDB_shark: Updated. + 2009-06-26 Gary Benson * ports/hotspot/src/share/vm/shark/sharkCompiler.cpp diff -r 9247751a966e -r 308c172cd230 ports/hotspot/src/share/vm/includeDB_shark --- a/ports/hotspot/src/share/vm/includeDB_shark Fri Jun 26 04:51:17 2009 -0400 +++ b/ports/hotspot/src/share/vm/includeDB_shark Fri Jul 03 11:52:45 2009 +0100 @@ -166,8 +166,6 @@ sharkConstant.hpp sharkConstant.hpp ciStreams.hpp sharkConstant.hpp sharkBuilder.hpp sharkConstant.hpp sharkValue.hpp - -sharkEntry.cpp sharkEntry.hpp sharkEntry.hpp llvmHeaders.hpp diff -r 9247751a966e -r 308c172cd230 ports/hotspot/src/share/vm/shark/sharkCompiler.cpp --- a/ports/hotspot/src/share/vm/shark/sharkCompiler.cpp Fri Jun 26 04:51:17 2009 -0400 +++ b/ports/hotspot/src/share/vm/shark/sharkCompiler.cpp Fri Jul 03 11:52:45 2009 +0100 @@ -166,12 +166,12 @@ void SharkCompiler::compile_method(ciEnv entry->set_entry_point( (ZeroEntry::method_entry_t) execution_engine()->getPointerToFunction(function)); + address code_start = entry->code_start(); + address code_limit = entry->code_limit(); // Register generated code for profiling, etc - if (JvmtiExport::should_post_dynamic_code_generated()) { - JvmtiExport::post_dynamic_code_generated( - name, entry->code_start(), entry->code_limit()); - } + if (JvmtiExport::should_post_dynamic_code_generated()) + JvmtiExport::post_dynamic_code_generated(name, code_start, code_limit); // Install the method into the VM CodeOffsets offsets; @@ -198,8 +198,11 @@ void SharkCompiler::compile_method(ciEnv false); // Print statistics, if requested - if (SharkTraceInstalls) - entry->print_statistics(name); + if (SharkTraceInstalls) { + tty->print_cr( + " [%p-%p): %s (%d bytes code)", + code_start, code_limit, name, code_limit - code_start); + } } const char* SharkCompiler::methodname(const ciMethod* target) diff -r 9247751a966e -r 308c172cd230 ports/hotspot/src/share/vm/shark/sharkEntry.cpp --- a/ports/hotspot/src/share/vm/shark/sharkEntry.cpp Fri Jun 26 04:51:17 2009 -0400 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,38 +0,0 @@ -/* - * Copyright 1999-2007 Sun Microsystems, Inc. All Rights Reserved. - * Copyright 2008, 2009 Red Hat, Inc. - * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * - * This code is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License version 2 only, as - * published by the Free Software Foundation. - * - * This code is distributed in the hope that it will be useful, but WITHOUT - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License - * version 2 for more details (a copy is included in the LICENSE file that - * accompanied this code). - * - * You should have received a copy of the GNU General Public License version - * 2 along with this work; if not, write to the Free Software Foundation, - * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, - * CA 95054 USA or visit www.sun.com if you need additional information or - * have any questions. - * - */ - -#include "incls/_precompiled.incl" -#include "incls/_sharkEntry.cpp.incl" - -#ifndef PRODUCT -void SharkEntry::print_statistics(const char* name) const -{ - address start = code_start(); - address limit = code_limit(); - - tty->print_cr( - " [%p-%p): %s (%d bytes code)", start, limit, name, limit - start); -} -#endif // !PRODUCT diff -r 9247751a966e -r 308c172cd230 ports/hotspot/src/share/vm/shark/sharkEntry.hpp --- a/ports/hotspot/src/share/vm/shark/sharkEntry.hpp Fri Jun 26 04:51:17 2009 -0400 +++ b/ports/hotspot/src/share/vm/shark/sharkEntry.hpp Fri Jul 03 11:52:45 2009 +0100 @@ -43,7 +43,4 @@ class SharkEntry : public ZeroEntry { { _code_limit = code_limit; } - - public: - void print_statistics(const char* name) const PRODUCT_RETURN; }; From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 04:47:53 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 11:47:53 +0000 Subject: [Bug 360] New: IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 Summary: IDE crashes and can't continue Product: IcedTea Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P4 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: mrjava.javaman at gmail.com One of my JAVA-developers team was developing under windows using Netbeans, he created a heavy bean that extends JPanel, its constructor simply contains initcomponents() and some variables initializations only. once he tried to drag and drop it into another JPanel, netbeans crashes and exit without any warnings. I then took the source code into my PC which is running fedora 11, and tried to do the same thing then I got the bug reporting tool with this text: ---start--- System: Linux 2.6.29.5-191.fc11.i686.PAE #1 SMP Tue Jun 16 23:19:53 EDT 2009 i686 X Vendor: The X.Org Foundation X Vendor Release: 10601901 Selinux: No Accessibility: Disabled GTK+ Theme: Nodoka Icon Theme: Fedora GTK+ Modules: canberra-gtk-module, pk-gtk-module, gnomebreakpad Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0 CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0 ----------- .xsession-errors --------------------- # V [libjvm.so+0x1b8ac2] # # An error report file with more information is saved as: # /home/Amahdy/hs_err_pid2953.log # # If you would like to submit a bug report, please include # instructions how to reproduce the bug and visit: # http://icedtea.classpath.org/bugzilla # [error occurred during error reporting , id 0xb] [error occurred during error reporting , id 0xb] -------------------------------------------------- ---End--- file "/home/Amahdy/hs_err_pid2953.log" will be attached, -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 04:50:45 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 11:50:45 +0000 Subject: [Bug 360] IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 ------- Comment #1 from mrjava.javaman at gmail.com 2009-07-03 11:50 ------- Created an attachment (id=236) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=236&action=view) the generated file by the bug reporting tool -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 06:35:01 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 13:35:01 +0000 Subject: [Bug 360] IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 ------- Comment #2 from jon.vanalten at redhat.com 2009-07-03 13:34 ------- I am curious - is your other Dev using openJDK (or derivative, such as IcedTea) on his Windows box? Or is this happening under Sun's non-open Java as well? If it happens also in Sun's Java then I would begin to suspect either Netbeans or the bean under deveopment. Also, can you attach source code? (or some example which can reproduce the crash). -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 07:18:13 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 14:18:13 +0000 Subject: [Bug 130] -XX:+TraceThreadEvents hangs or crashes Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=130 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #3 from jon.vanalten at redhat.com 2009-07-03 14:18 ------- If this problem is reproducible in current versions, please reopen and attach sample and/or log. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 07:42:15 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 14:42:15 +0000 Subject: [Bug 137] icedtea6 build fails on Debian unstable (sid) with "missing return value" Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=137 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #6 from jon.vanalten at redhat.com 2009-07-03 14:42 ------- Please reopen and include relevant information if necessary. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 07:53:02 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 14:53:02 +0000 Subject: [Bug 165] seg fault with sisc/jdbc Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=165 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #3 from jon.vanalten at redhat.com 2009-07-03 14:53 ------- Please reopen and include enough info to reproduce crash if applicable. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 08:03:28 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 15:03:28 +0000 Subject: [Bug 171] Crash running Solr 1.3 Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=171 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 08:06:59 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 15:06:59 +0000 Subject: [Bug 173] Cannot play two sounds simultaneously (Linux) Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=173 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 08:22:19 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 15:22:19 +0000 Subject: [Bug 210] Eclipse IDE for C/C++ crashes while running code Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=210 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #3 from jon.vanalten at redhat.com 2009-07-03 15:22 ------- Go ahead and reopen this if you still have this problem. Please provide info as indicated in previous comment. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 08:23:41 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 15:23:41 +0000 Subject: [Bug 216] OpenJDK java web start fails to open jnlp files version 1.5 Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=216 ------- Comment #6 from jon.vanalten at redhat.com 2009-07-03 15:23 ------- No other issues here. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 08:25:36 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 15:25:36 +0000 Subject: [Bug 228] Since I have installed Mandriva 2009, brutal breakdown of my eclipse 3.3.2 platform with JDK 1.6. Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=228 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #3 from jon.vanalten at redhat.com 2009-07-03 15:25 ------- As noted, if this is still a problem please reopen and provide info to reproduce this problem. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 08:36:15 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 15:36:15 +0000 Subject: [Bug 251] ubuntu 8.04 amd64 - Java applet loop: openjdk-6 icedtea6-plugin Firefox Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=251 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME ------- Comment #2 from jon.vanalten at redhat.com 2009-07-03 15:36 ------- If this is still an issue for you, please reopen and provide additional details. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 08:37:43 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 15:37:43 +0000 Subject: [Bug 254] dancing dude not vertically aligned in applet area Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=254 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME ------- Comment #4 from jon.vanalten at redhat.com 2009-07-03 15:37 ------- If this is still an issue for you, please reopen and provide additional details. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 08:40:24 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 15:40:24 +0000 Subject: [Bug 173] Cannot play two sounds simultaneously (Linux) Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=173 ------- Comment #6 from ryan at ryanheise.com 2009-07-03 15:40 ------- (In reply to comment #5) > Also it seems that in your case the > information in question has already been available in plain text on your own > web site for some time. > http://web.archive.org/web/20060619211335/http://www.ryanheise.com/ The email address on that page is actually obfuscated using Javascript. Although it'd be a good thing for publicly displayed email addressed to be truncated, in my case the damage has already been done so I have no motivation to file a bug report. I encourage the people of IcedTea to take it upon themselves to consider the privacy issue. > I am not able to reproduce your issue with current build. Are you still > experiencing this problem? > > (if no further response I will close this as FIXED in one week) Ah, that's good news, although since the time I submitted that bug report, I have actually stopped using the JVM and am unable to test it. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 13:48:16 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 20:48:16 +0000 Subject: [Bug 290] plugin crash on amd64 Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=290 ------- Comment #3 from jon.vanalten at redhat.com 2009-07-03 20:48 ------- I've tried this several more times. Managed to crash firefox once. Unfortunately didn't run from the command line that time.... However, I have come to realize something about what happens when it 'times out'. The web site goes to a page indicating applet timed out, however the applet keeps on running (java process using high CPU) for some time before ending. Tried running from the command line and the applet seems to terminate normally, and at the end spits out a URL whose page indicates satisfactory test results. Not sure yet why the browser believes it has timed out and doesn't get sent to the URL generated. I have occasionally had the applet simply fail to load, with output along the lines of: net.sourceforge.jnlp.LaunchException: Fatal: Initialization Error: Could not initialize applet. at net.sourceforge.jnlp.Launcher.createApplet(Launcher.java:495) at net.sourceforge.jnlp.Launcher.getApplet(Launcher.java:441) at net.sourceforge.jnlp.Launcher$TgThread.run(Launcher.java:620) Caused by: java.lang.NullPointerException at net.sourceforge.jnlp.Launcher.createApplet(Launcher.java:481) ... 2 more Caused by: java.lang.NullPointerException at net.sourceforge.jnlp.Launcher.createApplet(Launcher.java:481) at net.sourceforge.jnlp.Launcher.getApplet(Launcher.java:441) at net.sourceforge.jnlp.Launcher$TgThread.run(Launcher.java:620) java.lang.NullPointerException at net.sourceforge.jnlp.NetxPanel.runLoader(NetxPanel.java:102) at sun.applet.AppletPanel.run(AppletPanel.java:380) at java.lang.Thread.run(Thread.java:636) java.lang.NullPointerException at sun.applet.AppletPanel.run(AppletPanel.java:430) at java.lang.Thread.run(Thread.java:636) I've also been trying this with Sun's Java, and the timeout and failure to load issues happen there too (albeit with less frequency). I suppose I should mention that all of this is using Firefox 3.5. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 3 14:07:00 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 03 Jul 2009 21:07:00 +0000 Subject: [Bug 336] Add support for JSR-200 to javaws and appletviewer Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=336 ------- Comment #5 from omajid at redhat.com 2009-07-03 21:06 ------- Created an attachment (id=237) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=237&action=view) Add pack200 support - initial implementation -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From dbhole at redhat.com Fri Jul 3 14:49:31 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Fri, 3 Jul 2009 17:49:31 -0400 Subject: RFC: Rewrite of cookie support in plugin Message-ID: <20090703214931.GB28859@redhat.com> This patch rewrites cookie support in the plugin. The old way was static, set at initialization time. Additionally, it did not support cookie provision for connection requests made by the applet internally. This patch fixes all of that. Cookie information is now supplied to Java in real-time from Mozilla side, as it should be. Thanks to Omair for the initial error trace. This patch fixes rhbz 506730: https://bugzilla.redhat.com/show_bug.cgi?id=506730 http://www.sbm.no/ will now load correctly with this patch. ChangeLog: * IcedTeaPlugin.cc: Add suppport for cookie info requests from applets. * plugin/icedtea/sun/applet/PluginAppletViewer.java: Rework cookie support to make it dynamic. * plugin/icedtea/sun/applet/PluginMain.java: Wire in custom cookie store that dynamically requests cookie information from C++ side. * rt/net/sourceforge/jnlp/JNLPFile.java: Remove old cookie handling code. * rt/net/sourceforge/jnlp/Launcher.java: Same. * rt/net/sourceforge/jnlp/NetxPanel.java: Same. * rt/net/sourceforge/jnlp/PluginBridge.java: Same. * rt/net/sourceforge/jnlp/cache/CacheUtil.java: Same. * rt/net/sourceforge/jnlp/cache/Resource.java: Same. * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: Same. * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Same. Comments? Deepak -------------- next part -------------- diff -r 308c172cd230 IcedTeaPlugin.cc --- a/IcedTeaPlugin.cc Fri Jul 03 11:52:45 2009 +0100 +++ b/IcedTeaPlugin.cc Fri Jul 03 17:40:05 2009 -0400 @@ -1012,6 +1012,7 @@ void ProcessMessage(); void ConsumeMsgFromJVM(); nsresult GetProxyInfo(const char* siteAddr, char** proxyScheme, char** proxyHost, char** proxyPort); + nsresult GetCookieInfo(const char* siteAddr, char** cookieString); nsCOMPtr sink; nsCOMPtr transport; nsCOMPtr applet_viewer_process; @@ -1070,7 +1071,6 @@ IcedTeaPluginFactory* factory; PRUint32 instance_identifier; nsCString instanceIdentifierPrefix; - nsresult GetCookie(const char* siteAddr, char** cookieString); }; @@ -2380,16 +2380,6 @@ encodedAppletTag += tagMessage.get()[i]; } - nsCString cookieInfo(instanceIdentifierPrefix); - cookieInfo += "cookie "; - - char* cookieString; - if (GetCookie(documentbase, &cookieString) == NS_OK) - { - cookieInfo += cookieString; - } - - factory->SendMessageToAppletViewer (cookieInfo); factory->SendMessageToAppletViewer (encodedAppletTag); // Set back-pointer to peer instance. @@ -2760,8 +2750,15 @@ return NS_OK; } -NS_IMETHODIMP -IcedTeaPluginInstance::GetCookie(const char* siteAddr, char** cookieString) +/** + * Returns the cookie information for the given url + * + * @param siteAddr The URI to check (must be decoded) + * @return cookieString The cookie string for the given URI + */ + +NS_IMETHODIMP +IcedTeaPluginFactory::GetCookieInfo(const char* siteAddr, char** cookieString) { nsresult rv; @@ -3497,6 +3494,35 @@ // free allocated memory delete proxyScheme, proxyHost, proxyPort; + + } else if (command == "PluginCookieInfo") + { + + nsresult rv; + nsCOMPtr net_util = do_GetService(NS_NETUTIL_CONTRACTID, &rv); + + if (!net_util) + printf("Error instantiating NetUtil service.\n"); + + // decode the url + nsDependentCSubstring url; + net_util->UnescapeString(rest, 0, url); + + nsCString cookieInfo("plugin PluginCookieInfo "); + cookieInfo += rest; + cookieInfo += " "; + + char* cookieString; + if (GetCookieInfo(((nsCString) url).get(), &cookieString) == NS_OK) + { + cookieInfo += cookieString; + PLUGIN_DEBUG_2ARG("Cookie for %s is %s\n", ((nsCString) url).get(), cookieString); + } else { + PLUGIN_DEBUG_1ARG("No cookie found for %s\n", ((nsCString) url).get()); + } + + // send back what we found + SendMessageToAppletViewer (cookieInfo); } } diff -r 308c172cd230 plugin/icedtea/sun/applet/PluginAppletViewer.java --- a/plugin/icedtea/sun/applet/PluginAppletViewer.java Fri Jul 03 11:52:45 2009 +0100 +++ b/plugin/icedtea/sun/applet/PluginAppletViewer.java Fri Jul 03 17:40:05 2009 -0400 @@ -84,6 +84,7 @@ import java.io.PrintStream; import java.io.Reader; import java.io.StringReader; +import java.io.UnsupportedEncodingException; import java.lang.reflect.InvocationTargetException; import java.net.MalformedURLException; import java.net.SocketPermission; @@ -180,9 +181,6 @@ private static PluginStreamHandler streamhandler; private static PluginCallRequestFactory requestFactory; - - private static HashMap siteCookies = - new HashMap(); private static HashMap status = new HashMap(); @@ -226,7 +224,7 @@ AccessController.doPrivileged(new PrivilegedAction() { public Object run() { try { - panel = new NetxPanel(doc, siteCookies.get(identifier), atts, false); + panel = new NetxPanel(doc, atts, false); AppletViewerPanel.debug("Using NetX panel"); PluginDebug.debug(atts.toString()); } catch (Exception ex) { @@ -483,16 +481,6 @@ PluginDebug.debug ("REQUEST TAG NOT SET: " + request.tag + ". BYPASSING"); } } - } else if (message.startsWith("cookie")) { - - int cookieStrIndex = message.indexOf(" "); - String cookieStr = null; - - if (cookieStrIndex > 0) - cookieStr = message.substring(cookieStrIndex); - - // Always set the cookie -- even if it is null - siteCookies.put(identifier, cookieStr); } else { PluginDebug.debug ("Handling message: " + message + " instance " + identifier + " " + Thread.currentThread()); @@ -842,7 +830,6 @@ * applets on this page. */ public Enumeration getApplets() { - AppletSecurity security = (AppletSecurity)System.getSecurityManager(); Vector v = new Vector(); SocketPermission panelSp = new SocketPermission(panel.getCodeBase().getHost(), "connect"); @@ -896,7 +883,7 @@ // streamhandler.pluginOutputStream has been closed. } } - + public long getWindow() { PluginDebug.debug ("STARTING getWindow"); PluginCallRequest request = requestFactory.getPluginCallRequest("window", @@ -1113,6 +1100,40 @@ return request.getObject(); } + public static Object requestPluginCookieInfo(URI uri) { + + PluginCallRequest request; + try + { + String encodedURI = UrlUtil.encode(uri.toString(), "UTF-8"); + request = requestFactory.getPluginCallRequest("cookieinfo", + "plugin PluginCookieInfo " + encodedURI, + "plugin PluginCookieInfo " + encodedURI); + + } catch (UnsupportedEncodingException e) + { + e.printStackTrace(); + return null; + } + + streamhandler.postCallRequest(request); + streamhandler.write(request.getMessage()); + try { + PluginDebug.debug ("wait cookieinfo request 1"); + synchronized(request) { + PluginDebug.debug ("wait cookieinfo request 2"); + while (request.isDone() == false) + request.wait(); + PluginDebug.debug ("wait cookieinfo request 3"); + } + } catch (InterruptedException e) { + throw new RuntimeException("Interrupted waiting for cookieinfo request.", + e); + } + PluginDebug.debug (" Cookieinfo DONE"); + return request.getObject(); + } + public static Object requestPluginProxyInfo(URI uri) { String requestURI = null; @@ -1623,10 +1644,6 @@ public static void parse(int identifier, long handle, Reader in, URL url) throws IOException { - // wait until cookie is set (even if cookie is null, it needs to be - // "set" to that first - while (!siteCookies.containsKey(identifier)); - final int fIdentifier = identifier; final long fHandle = handle; final Reader fIn = in; diff -r 308c172cd230 plugin/icedtea/sun/applet/PluginCallRequestFactory.java --- a/plugin/icedtea/sun/applet/PluginCallRequestFactory.java Fri Jul 03 11:52:45 2009 +0100 +++ b/plugin/icedtea/sun/applet/PluginCallRequestFactory.java Fri Jul 03 17:40:05 2009 -0400 @@ -51,6 +51,8 @@ return new GetWindowPluginCallRequest(message, returnString); } else if (id == "proxyinfo") { return new PluginProxyInfoRequest(message, returnString); + } else if (id == "cookieinfo") { + return new PluginCookieInfoRequest(message, returnString); } else { throw new RuntimeException ("Unknown plugin call request type requested from factory"); } diff -r 308c172cd230 plugin/icedtea/sun/applet/PluginMain.java --- a/plugin/icedtea/sun/applet/PluginMain.java Fri Jul 03 11:52:45 2009 +0100 +++ b/plugin/icedtea/sun/applet/PluginMain.java Fri Jul 03 17:40:05 2009 -0400 @@ -68,10 +68,11 @@ import java.io.IOException; import java.io.PrintStream; import java.net.Authenticator; +import java.net.CookieHandler; +import java.net.CookieManager; import java.net.PasswordAuthentication; import java.net.ProxySelector; import java.util.Enumeration; -import java.util.HashMap; import java.util.Properties; import javax.net.ssl.HttpsURLConnection; @@ -218,6 +219,9 @@ // plug in a custom authenticator and proxy selector Authenticator.setDefault(new CustomAuthenticator()); ProxySelector.setDefault(new PluginProxySelector()); + + CookieManager ckManager = new CookieManager(new PluginCookieStore(), null); + CookieHandler.setDefault(ckManager); } static boolean messageAvailable() { diff -r 308c172cd230 rt/net/sourceforge/jnlp/JNLPFile.java --- a/rt/net/sourceforge/jnlp/JNLPFile.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/JNLPFile.java Fri Jul 03 17:40:05 2009 -0400 @@ -69,9 +69,6 @@ /** the URL used to resolve relative URLs in the file */ protected URL codeBase; - - /** cookie string to send alongwith resource requests */ - protected String cookieStr; /** file version */ protected Version fileVersion; @@ -159,7 +156,6 @@ parse(root, strict, location); this.fileLocation = location; - this.cookieStr = cookieStr; } /** @@ -196,7 +192,7 @@ try { ResourceTracker tracker = new ResourceTracker(false); // no prefetch - tracker.addResource(location, cookieStr, null/*version*/, policy); + tracker.addResource(location, null/*version*/, policy); return tracker.getInputStream(location); } @@ -255,13 +251,6 @@ */ public URL getCodeBase() { return codeBase; - } - - /** - * Returns the cookie string that will be send when resources for this file are requested - */ - public String getCookieStr() { - return cookieStr; } /** diff -r 308c172cd230 rt/net/sourceforge/jnlp/Launcher.java --- a/rt/net/sourceforge/jnlp/Launcher.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/Launcher.java Fri Jul 03 17:40:06 2009 -0400 @@ -389,7 +389,7 @@ IconDesc.SPLASH, preferredWidth, preferredHeight); if (splashImageURL != null) { ResourceTracker resourceTracker = new ResourceTracker(true); - resourceTracker.addResource(splashImageURL, "SPLASH", file.getFileVersion(), updatePolicy); + resourceTracker.addResource(splashImageURL, file.getFileVersion(), updatePolicy); splashScreen = new JNLPSplashScreen(resourceTracker, null, null); splashScreen.setSplashImageURL(splashImageURL); if (splashScreen.isSplashScreenValid()) { diff -r 308c172cd230 rt/net/sourceforge/jnlp/NetxPanel.java --- a/rt/net/sourceforge/jnlp/NetxPanel.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/NetxPanel.java Fri Jul 03 17:40:06 2009 -0400 @@ -41,7 +41,6 @@ private PluginBridge bridge = null; private boolean exitOnFailure = true; private AppletInstance appInst = null; - private String cookieStr; private boolean appletAlive; public NetxPanel(URL documentURL, Hashtable atts) @@ -50,11 +49,10 @@ } // overloaded constructor, called when initialized via plugin - public NetxPanel(URL documentURL, String cookieStr, Hashtable atts, boolean exitOnFailure) + public NetxPanel(URL documentURL, Hashtable atts, boolean exitOnFailure) { this(documentURL, atts); this.exitOnFailure = exitOnFailure; - this.cookieStr = cookieStr; this.appletAlive = true; } @@ -64,7 +62,6 @@ try { bridge = new PluginBridge(baseURL, - cookieStr, getDocumentBase(), getJarFiles(), getCode(), diff -r 308c172cd230 rt/net/sourceforge/jnlp/PluginBridge.java --- a/rt/net/sourceforge/jnlp/PluginBridge.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/PluginBridge.java Fri Jul 03 17:40:06 2009 -0400 @@ -43,7 +43,7 @@ String[] cache_ex_jars = new String[0]; Hashtable atts; - public PluginBridge(URL codebase, String cookieStr, URL documentBase, String jar, String main, + public PluginBridge(URL codebase, URL documentBase, String jar, String main, int width, int height, Hashtable atts) throws Exception { @@ -104,7 +104,6 @@ else security = null; - this.cookieStr = cookieStr; } public String getTitle() diff -r 308c172cd230 rt/net/sourceforge/jnlp/cache/CacheUtil.java --- a/rt/net/sourceforge/jnlp/cache/CacheUtil.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/cache/CacheUtil.java Fri Jul 03 17:40:06 2009 -0400 @@ -75,9 +75,9 @@ * @param version the version, or null * @return either the location in the cache or the original location */ - public static URL getCachedResource(URL location, String cookieStr, Version version, UpdatePolicy policy) { + public static URL getCachedResource(URL location, Version version, UpdatePolicy policy) { ResourceTracker rt = new ResourceTracker(); - rt.addResource(location, cookieStr, version, policy); + rt.addResource(location, version, policy); try { File f = rt.getCacheFile(location); return f.toURL(); diff -r 308c172cd230 rt/net/sourceforge/jnlp/cache/Resource.java --- a/rt/net/sourceforge/jnlp/cache/Resource.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/cache/Resource.java Fri Jul 03 17:40:06 2009 -0400 @@ -68,9 +68,6 @@ /** the remote location of the resource */ URL location; - /** cookie string to send with the resource request */ - String cookieStr; - /** the local file downloaded to */ File localFile; @@ -98,20 +95,19 @@ /** * Create a resource. */ - private Resource(URL location, String cookieStr, UpdatePolicy updatePolicy, Version requestVersion) { + private Resource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { this.location = location; this.requestVersion = requestVersion; this.updatePolicy = updatePolicy; - this.cookieStr = cookieStr; } /** * Return a shared Resource object representing the given * location and version. */ - public static Resource getResource(URL location, String cookieStr, UpdatePolicy updatePolicy, Version requestVersion) { + public static Resource getResource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { synchronized (resources) { - Resource resource = new Resource(location, cookieStr, updatePolicy, requestVersion); + Resource resource = new Resource(location, updatePolicy, requestVersion); int index = resources.indexOf(resource); if (index >= 0) { // return existing object @@ -132,13 +128,6 @@ */ public URL getLocation() { return location; - } - - /** - * Returns the cookie string associated with this resource - */ - public String getCookieStr() { - return cookieStr; } /** diff -r 308c172cd230 rt/net/sourceforge/jnlp/cache/ResourceTracker.java --- a/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Fri Jul 03 17:40:06 2009 -0400 @@ -148,11 +148,11 @@ * @param version the resource version * @param updatePolicy whether to check for updates if already in cache */ - public void addResource(URL location, String cookieStr, Version version, UpdatePolicy updatePolicy) { + public void addResource(URL location, Version version, UpdatePolicy updatePolicy) { if (location == null) throw new IllegalArgumentException("location==null"); - Resource resource = Resource.getResource(location, cookieStr, updatePolicy, version); + Resource resource = Resource.getResource(location, updatePolicy, version); boolean downloaded = false; synchronized (resources) { @@ -606,9 +606,6 @@ try { // create out second in case in does not exist URLConnection con = getVersionedResourceURL(resource).openConnection(); - - if (resource.getCookieStr() != null && resource.getCookieStr().length() > 0) - con.setRequestProperty("Cookie", resource.getCookieStr()); InputStream in = new BufferedInputStream(con.getInputStream()); OutputStream out = CacheUtil.getOutputStream(resource.location, resource.downloadVersion); @@ -657,9 +654,6 @@ // connect URLConnection connection = getVersionedResourceURL(resource).openConnection(); // this won't change so should be okay unsynchronized - - if (resource.getCookieStr() != null && resource.getCookieStr().length() > 0) - connection.setRequestProperty("Cookie", resource.getCookieStr()); int size = connection.getContentLength(); boolean current = CacheUtil.isCurrent(resource.location, resource.requestVersion, connection) && resource.getUpdatePolicy() != UpdatePolicy.FORCE; diff -r 308c172cd230 rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java --- a/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Fri Jul 03 17:40:06 2009 -0400 @@ -314,7 +314,6 @@ initialJars.add(jars[i]); // regardless of part tracker.addResource(jars[i].getLocation(), - file.getCookieStr(), jars[i].getVersion(), jars[i].isCacheable() ? JNLPRuntime.getDefaultUpdatePolicy() : UpdatePolicy.FORCE ); @@ -776,8 +775,7 @@ available.add(desc); - tracker.addResource(desc.getLocation(), - file.getCookieStr(), + tracker.addResource(desc.getLocation(), desc.getVersion(), JNLPRuntime.getDefaultUpdatePolicy() ); From dbhole at redhat.com Fri Jul 3 15:30:03 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Fri, 3 Jul 2009 18:30:03 -0400 Subject: RFC: Rewrite of cookie support in plugin In-Reply-To: <20090703214931.GB28859@redhat.com> References: <20090703214931.GB28859@redhat.com> Message-ID: <20090703223003.GA21560@redhat.com> Oops. Original message is missing 2 new files from the patch. Sorry about that. New patch attached. Deepak * Deepak Bhole [2009-07-03 17:48]: > This patch rewrites cookie support in the plugin. The old way was > static, set at initialization time. Additionally, it did not support > cookie provision for connection requests made by the applet internally. > > This patch fixes all of that. Cookie information is now supplied to Java > in real-time from Mozilla side, as it should be. > > Thanks to Omair for the initial error trace. > > This patch fixes rhbz 506730: > https://bugzilla.redhat.com/show_bug.cgi?id=506730 > > http://www.sbm.no/ will now load correctly with this patch. > > ChangeLog: > * IcedTeaPlugin.cc: Add suppport for cookie info requests from applets. > * plugin/icedtea/sun/applet/PluginAppletViewer.java: Rework cookie support > to make it dynamic. > * plugin/icedtea/sun/applet/PluginMain.java: Wire in custom cookie store > that dynamically requests cookie information from C++ side. > * rt/net/sourceforge/jnlp/JNLPFile.java: Remove old cookie handling code. > * rt/net/sourceforge/jnlp/Launcher.java: Same. > * rt/net/sourceforge/jnlp/NetxPanel.java: Same. > * rt/net/sourceforge/jnlp/PluginBridge.java: Same. > * rt/net/sourceforge/jnlp/cache/CacheUtil.java: Same. > * rt/net/sourceforge/jnlp/cache/Resource.java: Same. > * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: Same. > * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Same. > > Comments? > > Deepak -------------- next part -------------- diff -r 308c172cd230 IcedTeaPlugin.cc --- a/IcedTeaPlugin.cc Fri Jul 03 11:52:45 2009 +0100 +++ b/IcedTeaPlugin.cc Fri Jul 03 18:28:13 2009 -0400 @@ -1012,6 +1012,7 @@ void ProcessMessage(); void ConsumeMsgFromJVM(); nsresult GetProxyInfo(const char* siteAddr, char** proxyScheme, char** proxyHost, char** proxyPort); + nsresult GetCookieInfo(const char* siteAddr, char** cookieString); nsCOMPtr sink; nsCOMPtr transport; nsCOMPtr applet_viewer_process; @@ -1070,7 +1071,6 @@ IcedTeaPluginFactory* factory; PRUint32 instance_identifier; nsCString instanceIdentifierPrefix; - nsresult GetCookie(const char* siteAddr, char** cookieString); }; @@ -2380,16 +2380,6 @@ encodedAppletTag += tagMessage.get()[i]; } - nsCString cookieInfo(instanceIdentifierPrefix); - cookieInfo += "cookie "; - - char* cookieString; - if (GetCookie(documentbase, &cookieString) == NS_OK) - { - cookieInfo += cookieString; - } - - factory->SendMessageToAppletViewer (cookieInfo); factory->SendMessageToAppletViewer (encodedAppletTag); // Set back-pointer to peer instance. @@ -2760,8 +2750,15 @@ return NS_OK; } -NS_IMETHODIMP -IcedTeaPluginInstance::GetCookie(const char* siteAddr, char** cookieString) +/** + * Returns the cookie information for the given url + * + * @param siteAddr The URI to check (must be decoded) + * @return cookieString The cookie string for the given URI + */ + +NS_IMETHODIMP +IcedTeaPluginFactory::GetCookieInfo(const char* siteAddr, char** cookieString) { nsresult rv; @@ -3497,6 +3494,35 @@ // free allocated memory delete proxyScheme, proxyHost, proxyPort; + + } else if (command == "PluginCookieInfo") + { + + nsresult rv; + nsCOMPtr net_util = do_GetService(NS_NETUTIL_CONTRACTID, &rv); + + if (!net_util) + printf("Error instantiating NetUtil service.\n"); + + // decode the url + nsDependentCSubstring url; + net_util->UnescapeString(rest, 0, url); + + nsCString cookieInfo("plugin PluginCookieInfo "); + cookieInfo += rest; + cookieInfo += " "; + + char* cookieString; + if (GetCookieInfo(((nsCString) url).get(), &cookieString) == NS_OK) + { + cookieInfo += cookieString; + PLUGIN_DEBUG_2ARG("Cookie for %s is %s\n", ((nsCString) url).get(), cookieString); + } else { + PLUGIN_DEBUG_1ARG("No cookie found for %s\n", ((nsCString) url).get()); + } + + // send back what we found + SendMessageToAppletViewer (cookieInfo); } } diff -r 308c172cd230 plugin/icedtea/sun/applet/PluginAppletViewer.java --- a/plugin/icedtea/sun/applet/PluginAppletViewer.java Fri Jul 03 11:52:45 2009 +0100 +++ b/plugin/icedtea/sun/applet/PluginAppletViewer.java Fri Jul 03 18:28:13 2009 -0400 @@ -84,6 +84,7 @@ import java.io.PrintStream; import java.io.Reader; import java.io.StringReader; +import java.io.UnsupportedEncodingException; import java.lang.reflect.InvocationTargetException; import java.net.MalformedURLException; import java.net.SocketPermission; @@ -180,9 +181,6 @@ private static PluginStreamHandler streamhandler; private static PluginCallRequestFactory requestFactory; - - private static HashMap siteCookies = - new HashMap(); private static HashMap status = new HashMap(); @@ -226,7 +224,7 @@ AccessController.doPrivileged(new PrivilegedAction() { public Object run() { try { - panel = new NetxPanel(doc, siteCookies.get(identifier), atts, false); + panel = new NetxPanel(doc, atts, false); AppletViewerPanel.debug("Using NetX panel"); PluginDebug.debug(atts.toString()); } catch (Exception ex) { @@ -483,16 +481,6 @@ PluginDebug.debug ("REQUEST TAG NOT SET: " + request.tag + ". BYPASSING"); } } - } else if (message.startsWith("cookie")) { - - int cookieStrIndex = message.indexOf(" "); - String cookieStr = null; - - if (cookieStrIndex > 0) - cookieStr = message.substring(cookieStrIndex); - - // Always set the cookie -- even if it is null - siteCookies.put(identifier, cookieStr); } else { PluginDebug.debug ("Handling message: " + message + " instance " + identifier + " " + Thread.currentThread()); @@ -842,7 +830,6 @@ * applets on this page. */ public Enumeration getApplets() { - AppletSecurity security = (AppletSecurity)System.getSecurityManager(); Vector v = new Vector(); SocketPermission panelSp = new SocketPermission(panel.getCodeBase().getHost(), "connect"); @@ -896,7 +883,7 @@ // streamhandler.pluginOutputStream has been closed. } } - + public long getWindow() { PluginDebug.debug ("STARTING getWindow"); PluginCallRequest request = requestFactory.getPluginCallRequest("window", @@ -1113,6 +1100,40 @@ return request.getObject(); } + public static Object requestPluginCookieInfo(URI uri) { + + PluginCallRequest request; + try + { + String encodedURI = UrlUtil.encode(uri.toString(), "UTF-8"); + request = requestFactory.getPluginCallRequest("cookieinfo", + "plugin PluginCookieInfo " + encodedURI, + "plugin PluginCookieInfo " + encodedURI); + + } catch (UnsupportedEncodingException e) + { + e.printStackTrace(); + return null; + } + + streamhandler.postCallRequest(request); + streamhandler.write(request.getMessage()); + try { + PluginDebug.debug ("wait cookieinfo request 1"); + synchronized(request) { + PluginDebug.debug ("wait cookieinfo request 2"); + while (request.isDone() == false) + request.wait(); + PluginDebug.debug ("wait cookieinfo request 3"); + } + } catch (InterruptedException e) { + throw new RuntimeException("Interrupted waiting for cookieinfo request.", + e); + } + PluginDebug.debug (" Cookieinfo DONE"); + return request.getObject(); + } + public static Object requestPluginProxyInfo(URI uri) { String requestURI = null; @@ -1623,10 +1644,6 @@ public static void parse(int identifier, long handle, Reader in, URL url) throws IOException { - // wait until cookie is set (even if cookie is null, it needs to be - // "set" to that first - while (!siteCookies.containsKey(identifier)); - final int fIdentifier = identifier; final long fHandle = handle; final Reader fIn = in; diff -r 308c172cd230 plugin/icedtea/sun/applet/PluginCallRequestFactory.java --- a/plugin/icedtea/sun/applet/PluginCallRequestFactory.java Fri Jul 03 11:52:45 2009 +0100 +++ b/plugin/icedtea/sun/applet/PluginCallRequestFactory.java Fri Jul 03 18:28:13 2009 -0400 @@ -51,6 +51,8 @@ return new GetWindowPluginCallRequest(message, returnString); } else if (id == "proxyinfo") { return new PluginProxyInfoRequest(message, returnString); + } else if (id == "cookieinfo") { + return new PluginCookieInfoRequest(message, returnString); } else { throw new RuntimeException ("Unknown plugin call request type requested from factory"); } diff -r 308c172cd230 plugin/icedtea/sun/applet/PluginCookieInfoRequest.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/plugin/icedtea/sun/applet/PluginCookieInfoRequest.java Fri Jul 03 18:28:13 2009 -0400 @@ -0,0 +1,122 @@ +/* PluginCookieInfoRequest -- Object representing a request for cookie information from the browser + Copyright (C) 2009 Red Hat + +This file is part of IcedTea. + +IcedTea is free software; you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation; either version 2, or (at your option) +any later version. + +IcedTea is distributed in the hope that it will be useful, but +WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +General Public License for more details. + +You should have received a copy of the GNU General Public License +along with IcedTea; see the file COPYING. If not, write to the +Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +02110-1301 USA. + +Linking this library statically or dynamically with other modules is +making a combined work based on this library. Thus, the terms and +conditions of the GNU General Public License cover the whole +combination. + +As a special exception, the copyright holders of this library give you +permission to link this library with independent modules to produce an +executable, regardless of the license terms of these independent +modules, and to copy and distribute the resulting executable under +terms of your choice, provided that you also meet, for each linked +independent module, the terms and conditions of the license of that +module. An independent module is a module which is not derived from +or based on this library. If you modify this library, you may extend +this exception to your version of the library, but you are not +obligated to do so. If you do not wish to do so, delete this +exception statement from your version. */ + +package sun.applet; + +import java.net.HttpCookie; +import java.net.URI; +import java.util.ArrayList; +import java.util.List; + +import com.sun.jndi.toolkit.url.UrlUtil; + +/** + * This class represents a request object for cookie information for a given URI + */ + +public class PluginCookieInfoRequest extends PluginCallRequest { + + List cookieObjects = new ArrayList(); + + public PluginCookieInfoRequest(String message, String returnString) { + super(message, returnString); + } + + public void parseReturn(String cookieInfo) { + + // try to parse the proxy information. If things go wrong, do nothing .. + // this will keep internal = null which forces a direct connection + + PluginDebug.debug ("PluginCookieInfoRequest GOT: " + cookieInfo); + + String encodedURI = cookieInfo.split(" ")[2]; + + // Skip the first 3 components. We are guaranteed 3 components, + // so no index -1 to worry about + cookieInfo = cookieInfo.substring(cookieInfo.indexOf(' ')+1); + cookieInfo = cookieInfo.substring(cookieInfo.indexOf(' ')+1); + cookieInfo = cookieInfo.substring(cookieInfo.indexOf(' ')+1); + + URI siteURI; + try + { + siteURI = new URI(UrlUtil.decode(encodedURI, "UTF-8")); + } catch (Exception e) + { + e.printStackTrace(); + return; + } + + if (cookieInfo != null && cookieInfo.length() > 0) + { + String[] cookies = cookieInfo.split(";"); + + for (int i = 0; i < cookies.length; i++) + { + ArrayList l = new ArrayList(); + + String cookie = cookies[i]; + cookie = cookie.trim(); + String cookieName = cookie.substring(0, cookie.indexOf("=")); + String cookieValue = cookie.substring(cookie.indexOf("=")+1); + + HttpCookie httpCookieObj = new HttpCookie(cookieName, cookieValue); + httpCookieObj.setPath(siteURI.getPath()); + httpCookieObj.setVersion(0); // force v0 + + PluginDebug.debug("Adding cookie info COOKIEN=" + cookieName + " and COOKIEV=" + cookieValue); + cookieObjects.add(httpCookieObj); + } + } + + setDone(true); + } + + /** + * Returns whether the given message is serviceable by this object + * + * @param message The message to service + * @return boolean indicating if message is serviceable + */ + public boolean serviceable(String message) { + return message.startsWith(returnString); + } + + public List getObject() { + return this.cookieObjects; + } +} diff -r 308c172cd230 plugin/icedtea/sun/applet/PluginCookieStore.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/plugin/icedtea/sun/applet/PluginCookieStore.java Fri Jul 03 18:28:13 2009 -0400 @@ -0,0 +1,73 @@ +/* PluginCookieStore -- Storage for cookie information + Copyright (C) 2009 Red Hat + +This file is part of IcedTea. + +IcedTea is free software; you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation; either version 2, or (at your option) +any later version. + +IcedTea is distributed in the hope that it will be useful, but +WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +General Public License for more details. + +You should have received a copy of the GNU General Public License +along with IcedTea; see the file COPYING. If not, write to the +Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +02110-1301 USA. + +Linking this library statically or dynamically with other modules is +making a combined work based on this library. Thus, the terms and +conditions of the GNU General Public License cover the whole +combination. + +As a special exception, the copyright holders of this library give you +permission to link this library with independent modules to produce an +executable, regardless of the license terms of these independent +modules, and to copy and distribute the resulting executable under +terms of your choice, provided that you also meet, for each linked +independent module, the terms and conditions of the license of that +module. An independent module is a module which is not derived from +or based on this library. If you modify this library, you may extend +this exception to your version of the library, but you are not +obligated to do so. If you do not wish to do so, delete this +exception statement from your version. */ + +package sun.applet; + +import java.net.HttpCookie; +import java.net.URI; +import java.util.List; + +import sun.net.www.protocol.http.InMemoryCookieStore; + +public class PluginCookieStore extends InMemoryCookieStore +{ + public List get(URI uri) + { + List cookies; + + // Try to fetch it from the plugin, but if something goes + // wrong, fall back. Don't crash! + try + { + cookies = (List) PluginAppletViewer.requestPluginCookieInfo(uri); + + // If cookies is null, something went wrong. Fall back. + if (cookies == null) throw new NullPointerException("Null cookie"); + + } catch (Exception e) + { + PluginDebug.debug("Unable to fetch cookie information from plugin. " + + "Falling back to default."); + e.printStackTrace(); + cookies = super.get(uri); + } + + PluginDebug.debug("Returning cookies " + cookies + " for site: " + uri); + + return cookies; + } +} diff -r 308c172cd230 plugin/icedtea/sun/applet/PluginMain.java --- a/plugin/icedtea/sun/applet/PluginMain.java Fri Jul 03 11:52:45 2009 +0100 +++ b/plugin/icedtea/sun/applet/PluginMain.java Fri Jul 03 18:28:13 2009 -0400 @@ -68,10 +68,11 @@ import java.io.IOException; import java.io.PrintStream; import java.net.Authenticator; +import java.net.CookieHandler; +import java.net.CookieManager; import java.net.PasswordAuthentication; import java.net.ProxySelector; import java.util.Enumeration; -import java.util.HashMap; import java.util.Properties; import javax.net.ssl.HttpsURLConnection; @@ -218,6 +219,9 @@ // plug in a custom authenticator and proxy selector Authenticator.setDefault(new CustomAuthenticator()); ProxySelector.setDefault(new PluginProxySelector()); + + CookieManager ckManager = new CookieManager(new PluginCookieStore(), null); + CookieHandler.setDefault(ckManager); } static boolean messageAvailable() { diff -r 308c172cd230 rt/net/sourceforge/jnlp/JNLPFile.java --- a/rt/net/sourceforge/jnlp/JNLPFile.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/JNLPFile.java Fri Jul 03 18:28:13 2009 -0400 @@ -69,9 +69,6 @@ /** the URL used to resolve relative URLs in the file */ protected URL codeBase; - - /** cookie string to send alongwith resource requests */ - protected String cookieStr; /** file version */ protected Version fileVersion; @@ -159,7 +156,6 @@ parse(root, strict, location); this.fileLocation = location; - this.cookieStr = cookieStr; } /** @@ -196,7 +192,7 @@ try { ResourceTracker tracker = new ResourceTracker(false); // no prefetch - tracker.addResource(location, cookieStr, null/*version*/, policy); + tracker.addResource(location, null/*version*/, policy); return tracker.getInputStream(location); } @@ -255,13 +251,6 @@ */ public URL getCodeBase() { return codeBase; - } - - /** - * Returns the cookie string that will be send when resources for this file are requested - */ - public String getCookieStr() { - return cookieStr; } /** diff -r 308c172cd230 rt/net/sourceforge/jnlp/Launcher.java --- a/rt/net/sourceforge/jnlp/Launcher.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/Launcher.java Fri Jul 03 18:28:13 2009 -0400 @@ -389,7 +389,7 @@ IconDesc.SPLASH, preferredWidth, preferredHeight); if (splashImageURL != null) { ResourceTracker resourceTracker = new ResourceTracker(true); - resourceTracker.addResource(splashImageURL, "SPLASH", file.getFileVersion(), updatePolicy); + resourceTracker.addResource(splashImageURL, file.getFileVersion(), updatePolicy); splashScreen = new JNLPSplashScreen(resourceTracker, null, null); splashScreen.setSplashImageURL(splashImageURL); if (splashScreen.isSplashScreenValid()) { diff -r 308c172cd230 rt/net/sourceforge/jnlp/NetxPanel.java --- a/rt/net/sourceforge/jnlp/NetxPanel.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/NetxPanel.java Fri Jul 03 18:28:13 2009 -0400 @@ -41,7 +41,6 @@ private PluginBridge bridge = null; private boolean exitOnFailure = true; private AppletInstance appInst = null; - private String cookieStr; private boolean appletAlive; public NetxPanel(URL documentURL, Hashtable atts) @@ -50,11 +49,10 @@ } // overloaded constructor, called when initialized via plugin - public NetxPanel(URL documentURL, String cookieStr, Hashtable atts, boolean exitOnFailure) + public NetxPanel(URL documentURL, Hashtable atts, boolean exitOnFailure) { this(documentURL, atts); this.exitOnFailure = exitOnFailure; - this.cookieStr = cookieStr; this.appletAlive = true; } @@ -64,7 +62,6 @@ try { bridge = new PluginBridge(baseURL, - cookieStr, getDocumentBase(), getJarFiles(), getCode(), diff -r 308c172cd230 rt/net/sourceforge/jnlp/PluginBridge.java --- a/rt/net/sourceforge/jnlp/PluginBridge.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/PluginBridge.java Fri Jul 03 18:28:13 2009 -0400 @@ -43,7 +43,7 @@ String[] cache_ex_jars = new String[0]; Hashtable atts; - public PluginBridge(URL codebase, String cookieStr, URL documentBase, String jar, String main, + public PluginBridge(URL codebase, URL documentBase, String jar, String main, int width, int height, Hashtable atts) throws Exception { @@ -104,7 +104,6 @@ else security = null; - this.cookieStr = cookieStr; } public String getTitle() diff -r 308c172cd230 rt/net/sourceforge/jnlp/cache/CacheUtil.java --- a/rt/net/sourceforge/jnlp/cache/CacheUtil.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/cache/CacheUtil.java Fri Jul 03 18:28:13 2009 -0400 @@ -75,9 +75,9 @@ * @param version the version, or null * @return either the location in the cache or the original location */ - public static URL getCachedResource(URL location, String cookieStr, Version version, UpdatePolicy policy) { + public static URL getCachedResource(URL location, Version version, UpdatePolicy policy) { ResourceTracker rt = new ResourceTracker(); - rt.addResource(location, cookieStr, version, policy); + rt.addResource(location, version, policy); try { File f = rt.getCacheFile(location); return f.toURL(); diff -r 308c172cd230 rt/net/sourceforge/jnlp/cache/Resource.java --- a/rt/net/sourceforge/jnlp/cache/Resource.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/cache/Resource.java Fri Jul 03 18:28:13 2009 -0400 @@ -68,9 +68,6 @@ /** the remote location of the resource */ URL location; - /** cookie string to send with the resource request */ - String cookieStr; - /** the local file downloaded to */ File localFile; @@ -98,20 +95,19 @@ /** * Create a resource. */ - private Resource(URL location, String cookieStr, UpdatePolicy updatePolicy, Version requestVersion) { + private Resource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { this.location = location; this.requestVersion = requestVersion; this.updatePolicy = updatePolicy; - this.cookieStr = cookieStr; } /** * Return a shared Resource object representing the given * location and version. */ - public static Resource getResource(URL location, String cookieStr, UpdatePolicy updatePolicy, Version requestVersion) { + public static Resource getResource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { synchronized (resources) { - Resource resource = new Resource(location, cookieStr, updatePolicy, requestVersion); + Resource resource = new Resource(location, updatePolicy, requestVersion); int index = resources.indexOf(resource); if (index >= 0) { // return existing object @@ -132,13 +128,6 @@ */ public URL getLocation() { return location; - } - - /** - * Returns the cookie string associated with this resource - */ - public String getCookieStr() { - return cookieStr; } /** diff -r 308c172cd230 rt/net/sourceforge/jnlp/cache/ResourceTracker.java --- a/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Fri Jul 03 18:28:13 2009 -0400 @@ -148,11 +148,11 @@ * @param version the resource version * @param updatePolicy whether to check for updates if already in cache */ - public void addResource(URL location, String cookieStr, Version version, UpdatePolicy updatePolicy) { + public void addResource(URL location, Version version, UpdatePolicy updatePolicy) { if (location == null) throw new IllegalArgumentException("location==null"); - Resource resource = Resource.getResource(location, cookieStr, updatePolicy, version); + Resource resource = Resource.getResource(location, updatePolicy, version); boolean downloaded = false; synchronized (resources) { @@ -606,9 +606,6 @@ try { // create out second in case in does not exist URLConnection con = getVersionedResourceURL(resource).openConnection(); - - if (resource.getCookieStr() != null && resource.getCookieStr().length() > 0) - con.setRequestProperty("Cookie", resource.getCookieStr()); InputStream in = new BufferedInputStream(con.getInputStream()); OutputStream out = CacheUtil.getOutputStream(resource.location, resource.downloadVersion); @@ -657,9 +654,6 @@ // connect URLConnection connection = getVersionedResourceURL(resource).openConnection(); // this won't change so should be okay unsynchronized - - if (resource.getCookieStr() != null && resource.getCookieStr().length() > 0) - connection.setRequestProperty("Cookie", resource.getCookieStr()); int size = connection.getContentLength(); boolean current = CacheUtil.isCurrent(resource.location, resource.requestVersion, connection) && resource.getUpdatePolicy() != UpdatePolicy.FORCE; diff -r 308c172cd230 rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java --- a/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Fri Jul 03 11:52:45 2009 +0100 +++ b/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Fri Jul 03 18:28:13 2009 -0400 @@ -314,7 +314,6 @@ initialJars.add(jars[i]); // regardless of part tracker.addResource(jars[i].getLocation(), - file.getCookieStr(), jars[i].getVersion(), jars[i].isCacheable() ? JNLPRuntime.getDefaultUpdatePolicy() : UpdatePolicy.FORCE ); @@ -776,8 +775,7 @@ available.add(desc); - tracker.addResource(desc.getLocation(), - file.getCookieStr(), + tracker.addResource(desc.getLocation(), desc.getVersion(), JNLPRuntime.getDefaultUpdatePolicy() ); From xerxes at zafena.se Fri Jul 3 17:34:04 2009 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Sat, 04 Jul 2009 02:34:04 +0200 Subject: RFC: shark + llvm2.6svn LLVMContext api change Message-ID: <4A4EA37C.2000309@zafena.se> LLVM 2.6svn trunk now require the passing of a LLVMContext while creating a LLVM Module in order for LLVM clients to use the LLVM JIT multithreaded. [1] Fortunate for us LLVM have also provided a new backward compatible API, by using getGlobalContext() a LLVMContext are returned that can be used by current singlethreaded compiler clients to quickly fullfill this change. [2] I have added some comments to help future shark hackers find what needs to change if someone wants to make the shark compiler multi-threaded. I have tested this patch using llvm r74781 and icedtea6 http://icedtea.classpath.org/hg/icedtea6/rev/308c172cd230 on ia32 / F11 [1] http://lists.cs.uiuc.edu/pipermail/llvmdev/2009-June/023505.html - [LLVMdev] MAJOR API CHANGE: LLVMContext [2] http://lists.cs.uiuc.edu/pipermail/llvmdev/2009-June/023507.html Cheers Xerxes -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: 4jun_shark_llvm2.6svn_LLVMContext.patch Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090704/658827d6/attachment.ksh From bugzilla-daemon at icedtea.classpath.org Sat Jul 4 04:45:27 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Sat, 04 Jul 2009 11:45:27 +0000 Subject: [Bug 360] IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 ------- Comment #3 from mrjava.javaman at gmail.com 2009-07-04 11:45 ------- Well I'm pretty sure it's a Netbeans problem, the Bean itself doesn't contain something different from what's needed to make a bean works in a drag and drop manner, moreover when I add the Bean to my form pragmatically it works just fine. The problem is that I want to change its size and anchor in the design view. Well if you ask why I'm posting here instead of Netbeans bugzilla that it was written in the bug report to post here (refer to my first post) ... should I repost this to netbeans? -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 02:44:33 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 09:44:33 +0000 Subject: [Bug 361] New: Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 Summary: Arithmetic problems Product: IcedTea Version: unspecified Platform: Other OS/Version: Linux Status: NEW Severity: major Priority: P3 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: interface at bitoffice.at For some reason, the repeated execution of the same calculations fails after some thousand iterations (Testcase attached). This happens on PPC32 (Freescale MPC5121e, e300c PowerPC) with IcedTea-1.5 and Shark. The problem does not occur with IcedTea-1.4.1, no matter if JITted or interpreted and not with the interpreted version of zero (-Xint) on the exact same system. LLVM version is 2.4. java version "1.6.0_0" OpenJDK Runtime Environment (IcedTea6 1.5) (build 1.6.0_0-b16) OpenJDK Shark VM (build 14.0-b15, mixed mode) It also looks like the number of iterations needed to fail depends on the CPU usage by other processes. On an idle CPU I only need ~2500 iterations, on a busy CPU ~9500. The problem seems to be at line 37 of the testcase. getVoltage() always returns the same value (1950.2075), however the division fails after some time (0.9928497 instead of 0.97510374). -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 02:45:17 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 09:45:17 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #1 from interface at bitoffice.at 2009-07-06 09:45 ------- Created an attachment (id=238) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=238&action=view) Test Case -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 03:15:35 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 10:15:35 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #2 from xerxes at zafena.se 2009-07-06 10:15 ------- This might be a duplicate of bug: 350 http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=350 it would be great if you could run the testcase of bug 350: ./appletviewer ../demo/applets/MoleculeViewer/example1.html using shark/icedtea6 1.4.1 on PPC to see if icedtea6 1.4.1 are immune to all linear algebra truncations on PPC. Thank you. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 03:24:41 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 10:24:41 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #3 from xerxes at zafena.se 2009-07-06 10:24 ------- try running your testcase using java -XX:+PrintCompilation ArithFail to see what method got compiler before to the getVoltage output change and before the division change. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 03:32:33 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 10:32:33 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #4 from interface at bitoffice.at 2009-07-06 10:32 ------- # java -XX:+PrintCompilation ArithFail 1 java.lang.String::hashCode (60 bytes) 2 java.lang.Object:: (1 bytes) 21.815643 3 ! sun.nio.cs.US_ASCII$Encoder::encodeArrayLoop (279 bytes) 21.815643 21.815643 21.815643 21.815643 21.815643 21.815643 21.815643 4 java.lang.Number:: (5 bytes) 5 ArithFail::calculate (67 bytes) 21.815643 6 ArithFail::getVoltage (20 bytes) Failed with 1.514903 after 9591 iterations 1950.2075 1950.2075 true 0.9928497 0.97510374 false 7 ArithFail::convertValue (6 bytes) -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 03:35:01 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 10:35:01 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #5 from interface at bitoffice.at 2009-07-06 10:35 ------- I have to see if I can get X up and running to test the applet. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 03:50:39 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 10:50:39 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #6 from xerxes at zafena.se 2009-07-06 10:50 ------- Thank you for the clean testcase!, i think we have quite a lot to work at right now. The compilation are done in a separate thread and the compiled method gets inserted into the jvm a bit after PrintCompilation reports it begun compiling so the order of the messages are all in order. If you want to create a shark debug build that can print the llvm bitcode then apply the mixtec-hacks.patch found in http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-April/005361.html it enables some more shark specific debug options like: -XX:+SharkTraceInstalls that will print when the compilation are finnished and the method are inserted into the jvm -XX:SharkPrintBitcodeOf=ArithFail::convertValue displays the llvm ir -XX:SharkPrintAsmOf=ArithFail::convertValue hopefully displays the generated PPC assembler -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 03:58:37 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 10:58:37 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #7 from interface at bitoffice.at 2009-07-06 10:58 ------- 1. I can reproduce bug #350 with IcedTea6-1.5 2. I can also reproduce #350 with IcedTea6-1.4.1 The output of -J-XX:PrintCompilation with 1.4.1 is attached. I will see if I can test the patches, however that system is rather slow and compiling IcedTea takes quite some time (and I didn't want to fiddle around with the experimental cross compilation). -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 04:00:34 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 11:00:34 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #8 from interface at bitoffice.at 2009-07-06 11:00 ------- Created an attachment (id=239) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=239&action=view) PrintCompilation output Output of molecule test with 1.4.1 and -XX:PrintCompilation enabled. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 05:05:00 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 12:05:00 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #9 from xerxes at zafena.se 2009-07-06 12:05 ------- > I will see if I can test the patches, however that system is rather slow and > compiling IcedTea takes quite some time (and I didn't want to fiddle around > with the experimental cross compilation). > The only project currently making use of the experimental cross compilation are jalimo. The fastest way if you want to use cross compilation then follow the instructions on: http://icedtea.classpath.org/wiki/CrossCompileFaq the shark builds generated by following that guide will contains all the shark debugging out of the box. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 06:40:37 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 13:40:37 +0000 Subject: [Bug 360] IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 ------- Comment #4 from jon.vanalten at redhat.com 2009-07-06 13:40 ------- Indeed, when the IcedTea java virtual machine crashes the error report refers you to this bugzilla. Natural reaction for you to follow such instructions. I believe whether this is a bug in NetBeans or a bug in IcedTea depends mainly depends on whether the same behaviour occurs under Sun's proprietary JRE. If the same crash happens in JRE, then bug is likely with NetBeans (and so should be reported with them). If, however, you can take the same action under Sun's JRE without a crash, this is a bug restricted to openJKD/IcedTea. Note that IcedTea can be built for windows as well, so knowing that the crash was initially observed on a windows box does not answer the critical question. On either windows or linux you can type 'java -version' at command prompt to find out what flavour of java you are using. Can you check if this crash also happens under Sun's JRE, and/or provide source and specific instructions to reproduce crash so that we can test? -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 06:48:10 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 13:48:10 +0000 Subject: [Bug 259] i found that error in my ~/ so i`m adding it Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=259 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #2 from jon.vanalten at redhat.com 2009-07-06 13:48 ------- Unable to reproduce, and original reporter not responding. Please reopen if this can be reproduced. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 07:10:12 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 14:10:12 +0000 Subject: [Bug 262] Alt Graph doesnot generate any key event when pressing in French locale Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=262 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 07:31:15 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 14:31:15 +0000 Subject: [Bug 280] icedtea-bin-3.3.0-r1 fails to open HP WebAdmin interface on HP4050n Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=280 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX ------- Comment #3 from jon.vanalten at redhat.com 2009-07-06 14:31 ------- We won't be able to fix this unless someone with same/similar printer is willing to do some testing. Such a person should reopen this bug if they find similar issue under current IcedTea version. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 07:36:01 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 14:36:01 +0000 Subject: [Bug 286] problems running the eclipse, Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=286 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME ------- Comment #2 from jon.vanalten at redhat.com 2009-07-06 14:36 ------- I do not have the problem reported using current IcedTea build. If this is still happening, please reopen and include appropriate details. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 11:09:23 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 18:09:23 +0000 Subject: [Bug 287] crash during eclipse update or aptana installation Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=287 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID ------- Comment #2 from jon.vanalten at redhat.com 2009-07-06 18:09 ------- Please reopen and attach log with other relevant details, if applicable. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 11:24:13 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 18:24:13 +0000 Subject: [Bug 294] JavaFX sample not starting as applet due to ZipException, runs fine with javaws or java Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=294 ------- Comment #4 from jon.vanalten at redhat.com 2009-07-06 18:24 ------- Odd that this would show up in .xsessionerrors... I tried this with current IcedTea build, not exactly working but I get different results. I get a security dialog and once confirmed the browser (Firefox 3.5) believes the applet starts. But nothing shows up. If I do this with firefox started from the command line I get this: JNLPAppletLauncher: static initializer Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException at javax.swing.ImageIcon.(ImageIcon.java:155) at com.sun.javafx.eula.EulaDialog$2.(Unknown Source) at com.sun.javafx.eula.EulaDialog.getBackgroundPanel(Unknown Source) at com.sun.javafx.eula.EulaDialog.(Unknown Source) at com.sun.javafx.eula.EulaDialog$12.run(Unknown Source) at com.sun.javafx.eula.EulaDialog.askUserAcceptEULA(Unknown Source) at com.sun.javafx.eula.EulaImpl.askUserAcceptEULA(Unknown Source) at com.sun.javafx.eula.EulaImpl.show(Unknown Source) at com.sun.javafx.tk.swing.SwingToolkit$StartupRoutine.run(Unknown Source) at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:226) at java.awt.EventQueue.dispatchEvent(EventQueue.java:602) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:275) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:200) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:190) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:185) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:177) at java.awt.EventDispatchThread.run(EventDispatchThread.java:138) -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 11:39:24 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 18:39:24 +0000 Subject: [Bug 356] keytool doesn't handle SHA384withECDSA signatures Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=356 ------- Comment #1 from pktoss at gmail.com 2009-07-06 18:39 ------- Created an attachment (id=240) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=240&action=view) A small testcase that illustrates the missing SHA384withECDSA Signature Algorithm problem. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 12:14:33 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 19:14:33 +0000 Subject: [Bug 298] An unexpected error has been detected by Java Runtime Environment: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=298 ------- Comment #1 from jon.vanalten at redhat.com 2009-07-06 19:14 ------- Hi, Going through some stale bug reports here. Are you still having this crash? Is it reliably reproducible, and if so can you provide details so that we can further debug this? (if no response in 1 week, will assume that this is no longer happening in current version and close this bug). thx -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 12:26:18 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 19:26:18 +0000 Subject: [Bug 297] icedtea crash maybe because of libpolyester ... Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=297 ------- Comment #2 from jon.vanalten at redhat.com 2009-07-06 19:26 ------- I have polyester-2.0-0.4.beta1.fc9.x86_64 installed in F11, and do not have Eclipse crashing problems. Are you still experiencing this crash? If so, can you provide more details on how it can be reproduced (ie what are you doing when it crashes). Will assume this is fixed in current IcedTea/Eclipse/polyester versions if no response after 1 week. thx -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 13:02:34 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 20:02:34 +0000 Subject: [Bug 336] Add support for JSR-200 to javaws and appletviewer Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=336 omajid at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #237 is|0 |1 obsolete| | ------- Comment #6 from omajid at redhat.com 2009-07-06 20:02 ------- Created an attachment (id=241) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=241&action=view) pack200 support for plugin - second implementation Rely on http headers instead of file extensions. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 13:18:17 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 20:18:17 +0000 Subject: [Bug 299] eclipse crashes during file download in a tomcat test scenario Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=299 ------- Comment #2 from jon.vanalten at redhat.com 2009-07-06 20:18 ------- Hi, is this still happening for you? If so, even more useful than log files would be a reliable way to reproduce this crash. A thorough description of what you do to produce this crash would suffice, but even better would be a simple test case. Any files you have to submit can be added to this bug as an attachment. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 13:35:37 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 20:35:37 +0000 Subject: [Bug 302] JRE fatal error Problematic frame Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=302 ------- Comment #2 from jon.vanalten at redhat.com 2009-07-06 20:35 ------- Hi, Are you still seeing this crash? If this is happening with current builds of Vuze/xulrunner/IcedTea can you post a fresh log? thx -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 13:44:30 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 20:44:30 +0000 Subject: [Bug 327] SIGSEGV (0xb) at pc=0xa5fd779c, pid=6255, tid=2833329040 Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=327 mwong at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #3 from mwong at redhat.com 2009-07-06 20:44 ------- If the bug is still a problem for you, feel free to reopen it. Man Lung Wong -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 13:59:21 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 20:59:21 +0000 Subject: [Bug 305] eclipse crashes if I try to configure PyDev plugin Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=305 ------- Comment #6 from jon.vanalten at redhat.com 2009-07-06 20:59 ------- Hi, I also do not reproduce this issue. Fedora 11 java version "1.6.0_0" OpenJDK Runtime Environment (IcedTea6 1.5) (fedora-22.b16.fc11-x86_64) OpenJDK 64-Bit Server VM (build 14.0-b15, mixed mode) Eclipse Version: 3.4.2 Based on build id: 20090211-1700 PyDev 1.4.4.2636 Python 2-6.9 Is this still happening for you? If so can you post a fresh log of this using up-to-date Java and Python packages? (otherwise will assume this is no longer an issue and close this bug after 1 week). -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Mon Jul 6 16:53:57 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 06 Jul 2009 23:53:57 +0000 Subject: [Bug 302] JRE fatal error Problematic frame Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=302 ------- Comment #3 from dgahling at hotmail.com 2009-07-06 23:53 ------- this is still happening, recently, the version is recent. latest release won't even load at all, no indication of loading, its even worse. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From gbenson at redhat.com Tue Jul 7 01:38:02 2009 From: gbenson at redhat.com (Gary Benson) Date: Tue, 7 Jul 2009 09:38:02 +0100 Subject: RFC: shark + llvm2.6svn LLVMContext api change In-Reply-To: <4A4EA37C.2000309@zafena.se> References: <4A4EA37C.2000309@zafena.se> Message-ID: <20090707083801.GA3224@redhat.com> Please commit this, it's better than the solution I made :) Cheers, Gary Xerxes R?nby wrote: > LLVM 2.6svn trunk now require the passing of a LLVMContext while > creating a LLVM Module in order for LLVM clients to use the LLVM JIT > multithreaded. [1] > Fortunate for us LLVM have also provided a new backward compatible API, > by using getGlobalContext() a LLVMContext are returned that can be used > by current singlethreaded compiler clients to quickly fullfill this > change. [2] > > I have added some comments to help future shark hackers find what needs > to change if someone wants to make the shark compiler multi-threaded. > > I have tested this patch using llvm r74781 and icedtea6 > http://icedtea.classpath.org/hg/icedtea6/rev/308c172cd230 on ia32 / F11 > > [1] http://lists.cs.uiuc.edu/pipermail/llvmdev/2009-June/023505.html - > [LLVMdev] MAJOR API CHANGE: LLVMContext > [2] http://lists.cs.uiuc.edu/pipermail/llvmdev/2009-June/023507.html > > Cheers > Xerxes > > > > Index: icedtea6/ports/hotspot/src/share/vm/shark/sharkCompiler.cpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/sharkCompiler.cpp > +++ icedtea6/ports/hotspot/src/share/vm/shark/sharkCompiler.cpp > @@ -43,7 +43,15 @@ SharkCompiler::SharkCompiler() > #endif > > // Create a module to build our functions into > +#if SHARK_LLVM_VERSION >= 26 > + // LLVM 2.6 and later requires passing a LLVMContext during module > + // creation. The LLVM API getGlobalContext() returns a LLVMContext that > + // can be used safely as long as the shark compiler stays single threaded > + // and only uses one module. > + _module = new Module("shark", getGlobalContext()); > +#else > _module = new Module("shark"); > +#endif > > // Create the builder to build our functions > _builder = new SharkBuilder(this); > Index: icedtea6/ports/hotspot/src/share/vm/shark/llvmHeaders.hpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/llvmHeaders.hpp > +++ icedtea6/ports/hotspot/src/share/vm/shark/llvmHeaders.hpp > @@ -32,6 +32,9 @@ > #include > #include > #include > +#if SHARK_LLVM_VERSION >= 26 > +#include > +#endif > #include > #include > #include -- http://gbenson.net/ From xerxes at zafena.se Tue Jul 7 01:57:37 2009 From: xerxes at zafena.se (Xerxes R?nby) Date: Tue, 07 Jul 2009 08:57:37 +0000 Subject: changeset in /hg/icedtea6: 2009-07-07 Xerxes R?nby changeset 051f9a48387c in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=051f9a48387c description: 2009-07-07 Xerxes R?nby * ports/hotspot/src/share/vm/shark/llvmHeaders.hpp Include llvm/LLVMContext.h used by getGlobalContext() when llvm version are 2.6 or later. * ports/hotspot/src/share/vm/shark/sharkCompiler.cpp (SharkCompiler::SharkCompiler): Pass the LLVMContext returned from getGlobalContext() to the new Module constructor when llvm version are 2.6 or later to handle LLVM API change. diffstat: 3 files changed, 21 insertions(+) ChangeLog | 10 ++++++++++ ports/hotspot/src/share/vm/shark/llvmHeaders.hpp | 3 +++ ports/hotspot/src/share/vm/shark/sharkCompiler.cpp | 8 ++++++++ diffs (49 lines): diff -r 308c172cd230 -r 051f9a48387c ChangeLog --- a/ChangeLog Fri Jul 03 11:52:45 2009 +0100 +++ b/ChangeLog Tue Jul 07 10:58:02 2009 +0200 @@ -1,3 +1,13 @@ 2009-07-03 Gary Benson + + * ports/hotspot/src/share/vm/shark/llvmHeaders.hpp + Include llvm/LLVMContext.h used by getGlobalContext() + when llvm version are 2.6 or later. + * ports/hotspot/src/share/vm/shark/sharkCompiler.cpp + (SharkCompiler::SharkCompiler): Pass the LLVMContext returned + from getGlobalContext() to the new Module constructor + when llvm version are 2.6 or later to handle LLVM API change. + 2009-07-03 Gary Benson * ports/hotspot/src/share/vm/shark/sharkEntry.hpp diff -r 308c172cd230 -r 051f9a48387c ports/hotspot/src/share/vm/shark/llvmHeaders.hpp --- a/ports/hotspot/src/share/vm/shark/llvmHeaders.hpp Fri Jul 03 11:52:45 2009 +0100 +++ b/ports/hotspot/src/share/vm/shark/llvmHeaders.hpp Tue Jul 07 10:58:02 2009 +0200 @@ -32,6 +32,9 @@ #include #include #include +#if SHARK_LLVM_VERSION >= 26 +#include +#endif #include #include #include diff -r 308c172cd230 -r 051f9a48387c ports/hotspot/src/share/vm/shark/sharkCompiler.cpp --- a/ports/hotspot/src/share/vm/shark/sharkCompiler.cpp Fri Jul 03 11:52:45 2009 +0100 +++ b/ports/hotspot/src/share/vm/shark/sharkCompiler.cpp Tue Jul 07 10:58:02 2009 +0200 @@ -43,7 +43,15 @@ SharkCompiler::SharkCompiler() #endif // Create a module to build our functions into +#if SHARK_LLVM_VERSION >= 26 + // LLVM 2.6 and later requires passing a LLVMContext during module + // creation. The LLVM API getGlobalContext() returns a LLVMContext that + // can be used safely as long as the shark compiler stays single threaded + // and only uses one module. + _module = new Module("shark", getGlobalContext()); +#else _module = new Module("shark"); +#endif // Create the builder to build our functions _builder = new SharkBuilder(this); From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 02:40:53 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 09:40:53 +0000 Subject: [Bug 305] eclipse crashes if I try to configure PyDev plugin Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=305 ------- Comment #7 from nikita.manovich at gmail.com 2009-07-07 09:40 ------- I will check it as soon as possible... Please give me some time. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 03:34:51 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 10:34:51 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #10 from interface at bitoffice.at 2009-07-07 10:34 ------- Here it is, I hope it helps: # java -XX:+SharkTraceInstalls -XX:SharkPrintBitcodeOf=ArithFail::convertValue -XX:SharkPrintAsmOf=ArithFail::convertValue ArithFail [0x6e9da010-0x6e9da314): java.lang.String::charAt (772 bytes code) [0x6e9da320-0x6e9da7c4): java.lang.String::hashCode (1188 bytes code) [0x6e9da7d0-0x6e9db068): java.lang.String::indexOf (2200 bytes code) [0x6e9db070-0x6e9db1cc): java.lang.Object:: (348 bytes code) [0x6e9db1d0-0x6e9db3d0): java.lang.Number:: (512 bytes code) [0x6e9db3f8-0x6e9db7c8): ArithFail::calculate (976 bytes code) [0x6e9db7d0-0x6e9dbb44): ArithFail::getVoltage (884 bytes code) define internal void @"ArithFail::convertValue"([84 x i8]* %method, i32 %base_pc, [788 x i8]* %thread) { %1 = getelementptr [788 x i8]* %thread, i32 0, i32 756 ; [#uses=1] %zero_stack = bitcast i8* %1 to [12 x i8]* ; <[12 x i8]*> [#uses=2] %2 = getelementptr [12 x i8]* %zero_stack, i32 0, i32 0 ; [#uses=1] %3 = bitcast i8* %2 to i32* ; [#uses=1] %zero_stack_base = load i32* %3 ; [#uses=1] %4 = getelementptr [12 x i8]* %zero_stack, i32 0, i32 8 ; [#uses=1] %zero_stack_pointer_addr = bitcast i8* %4 to i32* ; [#uses=5] %5 = getelementptr [788 x i8]* %thread, i32 0, i32 768 ; [#uses=1] %zero_frame_pointer_addr = bitcast i8* %5 to i32* ; [#uses=7] %6 = load i32* %zero_stack_pointer_addr ; [#uses=1] %7 = sub i32 %6, 32 ; [#uses=4] %8 = icmp ult i32 %7, %zero_stack_base ; [#uses=1] br i1 %8, label %stack_overflow, label %no_overflow stack_overflow: ; preds = %0 call void @report_unimplemented(i32 ptrtoint (i32* @pointer_constant_0xfbe586c24 to i32), i32 181) unreachable no_overflow: ; preds = %0 store i32 %7, i32* %zero_stack_pointer_addr %frame = inttoptr i32 %7 to [10 x i32]* ; <[10 x i32]*> [#uses=14] %9 = getelementptr [10 x i32]* %frame, i32 0, i32 2 ; [#uses=1] %exception_slot = bitcast i32* %9 to [8 x i8]** ; <[8 x i8]**> [#uses=1] store [8 x i8]* null, [8 x i8]** %exception_slot %10 = getelementptr [10 x i32]* %frame, i32 0, i32 4 ; [#uses=1] store i32 %7, i32* %10 %11 = getelementptr [10 x i32]* %frame, i32 0, i32 6 ; [#uses=1] store i32 -889275712, i32* %11 %12 = getelementptr [10 x i32]* %frame, i32 0, i32 7 ; [#uses=2] %13 = load i32* %zero_frame_pointer_addr ; [#uses=1] store i32 %13, i32* %12 %14 = ptrtoint i32* %12 to i32 ; [#uses=1] store i32 %14, i32* %zero_frame_pointer_addr %15 = getelementptr [10 x i32]* %frame, i32 0, i32 3 ; [#uses=1] %method_slot = bitcast i32* %15 to [84 x i8]** ; <[84 x i8]**> [#uses=1] store [84 x i8]* %method, [84 x i8]** %method_slot %16 = getelementptr [10 x i32]* %frame, i32 0, i32 9 ; [#uses=1] %17 = bitcast i32* %16 to [8 x i8]** ; <[8 x i8]**> [#uses=1] %18 = load [8 x i8]** %17 ; <[8 x i8]*> [#uses=1] %19 = getelementptr [10 x i32]* %frame, i32 0, i32 8 ; [#uses=1] %20 = load i32* %19 ; [#uses=3] br label %bci_0 bci_0: ; preds = %no_overflow %21 = sitofp i32 %20 to float ; [#uses=1] %22 = mul float %21, 0x3F74050140000000 ; [#uses=2] %state = load i32* inttoptr (i32 ptrtoint (i32* @pointer_constant_0xfd541b025 to i32) to i32*) ; [#uses=1] %23 = icmp eq i32 %state, 1 ; [#uses=1] br i1 %23, label %do_safepoint, label %safepointed do_safepoint: ; preds = %bci_0 %24 = getelementptr [10 x i32]* %frame, i32 0, i32 1 ; [#uses=1] %25 = ptrtoint i32* %24 to i32 ; [#uses=1] store i32 %25, i32* %zero_stack_pointer_addr %26 = getelementptr [10 x i32]* %frame, i32 0, i32 3 ; [#uses=1] %27 = bitcast i32* %26 to [84 x i8]** ; <[84 x i8]**> [#uses=1] store [84 x i8]* %method, [84 x i8]** %27 %28 = add i32 %base_pc, 12 ; [#uses=1] %29 = getelementptr [10 x i32]* %frame, i32 0, i32 5 ; [#uses=1] store i32 %28, i32* %29 %30 = load i32* %zero_frame_pointer_addr ; [#uses=1] %31 = getelementptr [788 x i8]* %thread, i32 0, i32 280 ; [#uses=1] %last_Java_sp_addr = bitcast i8* %31 to i32* ; [#uses=1] store i32 %30, i32* %last_Java_sp_addr call void @SafepointSynchronize__block([788 x i8]* %thread) %32 = getelementptr [788 x i8]* %thread, i32 0, i32 280 ; [#uses=1] %last_Java_sp_addr1 = bitcast i8* %32 to i32* ; [#uses=1] store i32 0, i32* %last_Java_sp_addr1 %33 = getelementptr [10 x i32]* %frame, i32 0, i32 3 ; [#uses=1] %34 = bitcast i32* %33 to [84 x i8]** ; <[84 x i8]**> [#uses=1] %35 = load [84 x i8]** %34 ; <[84 x i8]*> [#uses=1] %36 = getelementptr [10 x i32]* %frame, i32 0, i32 9 ; [#uses=1] %37 = bitcast i32* %36 to [8 x i8]** ; <[8 x i8]**> [#uses=1] %38 = load [8 x i8]** %37 ; <[8 x i8]*> [#uses=1] %39 = getelementptr [788 x i8]* %thread, i32 0, i32 4 ; [#uses=1] %pending_exception_addr = bitcast i8* %39 to [8 x i8]** ; <[8 x i8]**> [#uses=2] %pending_exception = load [8 x i8]** %pending_exception_addr ; <[8 x i8]*> [#uses=2] %40 = icmp eq [8 x i8]* %pending_exception, null ; [#uses=1] br i1 %40, label %no_exception, label %exception safepointed: ; preds = %no_exception, %bci_0 %method5 = phi [84 x i8]* [ %35, %no_exception ], [ %method, %bci_0 ] ; <[84 x i8]*> [#uses=0] %local_0_ = phi [8 x i8]* [ %38, %no_exception ], [ %18, %bci_0 ] ; <[8 x i8]*> [#uses=0] %local_1_ = phi i32 [ %20, %no_exception ], [ %20, %bci_0 ] ; [#uses=0] %stack_0_ = phi float [ %22, %no_exception ], [ %22, %bci_0 ] ; [#uses=1] %41 = load i32* %zero_frame_pointer_addr ; [#uses=2] %42 = add i32 %41, 8 ; [#uses=2] store i32 %42, i32* %zero_stack_pointer_addr %43 = inttoptr i32 %41 to i32* ; [#uses=1] %44 = load i32* %43 ; [#uses=1] store i32 %44, i32* %zero_frame_pointer_addr %45 = inttoptr i32 %42 to float* ; [#uses=1] store float %stack_0_, float* %45 ret void exception: ; preds = %do_safepoint store [8 x i8]* null, [8 x i8]** %pending_exception_addr %46 = getelementptr [10 x i32]* %frame, i32 0, i32 2 ; [#uses=1] %exception_slot2 = bitcast i32* %46 to [8 x i8]** ; <[8 x i8]**> [#uses=1] store [8 x i8]* %pending_exception, [8 x i8]** %exception_slot2 %47 = getelementptr [10 x i32]* %frame, i32 0, i32 2 ; [#uses=1] %exception_slot3 = bitcast i32* %47 to [8 x i8]** ; <[8 x i8]**> [#uses=1] %48 = load [8 x i8]** %exception_slot3 ; <[8 x i8]*> [#uses=1] %49 = getelementptr [788 x i8]* %thread, i32 0, i32 4 ; [#uses=1] %pending_exception_addr4 = bitcast i8* %49 to [8 x i8]** ; <[8 x i8]**> [#uses=1] store [8 x i8]* %48, [8 x i8]** %pending_exception_addr4 %50 = load i32* %zero_frame_pointer_addr ; [#uses=2] %51 = add i32 %50, 12 ; [#uses=1] store i32 %51, i32* %zero_stack_pointer_addr %52 = inttoptr i32 %50 to i32* ; [#uses=1] %53 = load i32* %52 ; [#uses=1] store i32 %53, i32* %zero_frame_pointer_addr ret void no_exception: ; preds = %do_safepoint br label %safepointed } [0x6e9dbb58-0x6e9dbcf4): ArithFail::convertValue (412 bytes code) [0x6e9dbd08-0x6e9dbe74): ArithFail::getRSerial (364 bytes code) [0x6e9dbe88-0x6e9dbff4): ArithFail::getU0 (364 bytes code) [0x6e9dc000-0x6e9dc188): java.lang.Math::sqrt (392 bytes code) [0x6e9dc190-0x6e9dc4f0): java.lang.Float::valueOf (864 bytes code) [0x6e9dc500-0x6e9dc71c): java.lang.Float:: (540 bytes code) [0x6e9dc720-0x6e9dc888): java.lang.Float::floatValue (360 bytes code) Failed with 1.514903 after 1617 iterations 1950.2075 1950.2075 true 0.9928497 0.97510374 false -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 03:36:48 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 10:36:48 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 ------- Comment #11 from interface at bitoffice.at 2009-07-07 10:36 ------- Created an attachment (id=242) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=242&action=view) Debug output Testcase The paste is quite unreadable, sorry. Someone may delete my previous post. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 03:37:35 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 10:37:35 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 interface at bitoffice.at changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #242|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 04:19:28 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 11:19:28 +0000 Subject: [Bug 361] Arithmetic problems Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=361 gbenson at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|unassigned at icedtea.classpath|gbenson at redhat.com |.org | -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 07:08:35 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 14:08:35 +0000 Subject: [Bug 302] JRE fatal error Problematic frame Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=302 ------- Comment #4 from jon.vanalten at redhat.com 2009-07-07 14:08 ------- This looks very similar to http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=354 , in which the problem is not within java but in libxul.so, which is mozilla's xulrunner library. Your log from March indicates that this is the problem frame. I notice that my xulrunner is newer than the one in the log you posted. The tldr in the thread referenced in above bug is: Firefox 3 and newer bundles its own (current) xulrunner libraries, you probably don't need xulrunner installed separately, and other people have had problems with vuze evaporate by removing older xulrunner packages from their systems or updating to newer version. I haven't looked at the internals of Vuze but from vuze forum posts I've seen it will use the bundled Firefox xulrunner if a separate package is not there. On my system however I have xulrunner package separate (but as noted above a newer/current version). If this does not help with your crash, can you be more specific about what version of these components you are running? My Vuze/Azureus is: azureus-4.0.0.4-3 My xulrunner library: xulrunner-1.9.1-1 And my Java: $ java -version java version "1.6.0_0" OpenJDK Runtime Environment (IcedTea6 1.5) (fedora-22.b16.fc11-x86_64) OpenJDK 64-Bit Server VM (build 14.0-b15, mixed mode) In this combination I am able to run Vuze. Can you post details about your versions *and* a fresh log please? Also it would be helpful if you try running from command line and post output (type either 'vuze' or 'azureus' at command prompt). -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From omajid at redhat.com Tue Jul 7 07:11:36 2009 From: omajid at redhat.com (Omair Majid) Date: Tue, 07 Jul 2009 14:11:36 +0000 Subject: changeset in /hg/icedtea6: 2009-07-07 Omair Majid changeset 742216fd1f8f in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=742216fd1f8f description: 2009-07-07 Omair Majid * rt/net/sourceforge/jnlp/resources/Messages.properties: Add RNestedJarExtration. * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java (activateJar): Create parent directories for nested jars. diffstat: 3 files changed, 12 insertions(+) ChangeLog | 7 +++++++ rt/net/sourceforge/jnlp/resources/Messages.properties | 1 + rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java | 4 ++++ diffs (39 lines): diff -r 051f9a48387c -r 742216fd1f8f ChangeLog --- a/ChangeLog Tue Jul 07 10:58:02 2009 +0200 +++ b/ChangeLog Tue Jul 07 10:12:31 2009 -0400 @@ -1,3 +1,10 @@ 2009-07-07 Xerxes R??nby + + * rt/net/sourceforge/jnlp/resources/Messages.properties: Add + RNestedJarExtration. + * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java + (activateJar): Create parent directories for nested jars. + 2009-07-07 Xerxes R??nby * ports/hotspot/src/share/vm/shark/llvmHeaders.hpp diff -r 051f9a48387c -r 742216fd1f8f rt/net/sourceforge/jnlp/resources/Messages.properties --- a/rt/net/sourceforge/jnlp/resources/Messages.properties Tue Jul 07 10:58:02 2009 +0200 +++ b/rt/net/sourceforge/jnlp/resources/Messages.properties Tue Jul 07 10:12:31 2009 -0400 @@ -111,6 +111,7 @@ RDenyStopped=Stopped applications have n RDenyStopped=Stopped applications have no permissions. RExitNoApp=Can not exit the JVM because the current application cannot be determined. RNoLockDir=Unable to create locks directory ({0}) +RNestedJarExtration=Unable to extract nested jar. RUnexpected=Unexpected {0} at {1} # Boot options, message should be shorter than this ----------------> diff -r 051f9a48387c -r 742216fd1f8f rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java --- a/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Tue Jul 07 10:58:02 2009 +0200 +++ b/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Tue Jul 07 10:12:31 2009 -0400 @@ -521,6 +521,10 @@ public class JNLPClassLoader extends URL // with standard classloader methods) String extractedJarLocation = localFile.getParent() + "/" + je.getName(); + File parentDir = new File(extractedJarLocation).getParentFile(); + if (!parentDir.isDirectory() && !parentDir.mkdirs()) { + throw new RuntimeException(R("RNestedJarExtration")); + } FileOutputStream extractedJar = new FileOutputStream(extractedJarLocation); InputStream is = jarFile.getInputStream(je); From omajid at redhat.com Tue Jul 7 07:15:00 2009 From: omajid at redhat.com (Omair Majid) Date: Tue, 07 Jul 2009 10:15:00 -0400 Subject: RFC: Bug in JNLPClassloader when using nested jars In-Reply-To: <20090629205118.GA15067@redhat.com> References: <4A492375.5050308@redhat.com> <20090629205118.GA15067@redhat.com> Message-ID: <4A535864.90604@redhat.com> Deepak Bhole wrote: > * Omair Majid [2009-06-29 16:27]: >> Hi, >> >> The attached patch fixes a bug in JNLPClassloader that occurs when >> JNLPClassloader tries to load nested jars in nested directories. >> >> To reproduce the issue: >> $ javaws http://dnld0.sparkom.com/sparkangels/sangels/sparkangels.jnlp >> [snip] >> Caused by: java.lang.NoClassDefFoundError: sparkangels/vb >> at com.sparkom.launcher.Main.main(Unknown Source) >> ... 6 more >> [snip] >> > > Looks good to me. > Thanks. Pushed as changeset 742216fd1f8f. Cheers, Omair From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 07:30:35 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 14:30:35 +0000 Subject: [Bug 216] OpenJDK java web start fails to open jnlp files version 1.5 Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=216 omajid at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #7 from omajid at redhat.com 2009-07-07 14:30 ------- Closing bug as FIXED. Please file any specific issues as separate bugs. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From jon.vanalten at redhat.com Tue Jul 7 07:43:14 2009 From: jon.vanalten at redhat.com (jon.vanalten at redhat.com) Date: Tue, 7 Jul 2009 10:43:14 -0400 (EDT) Subject: RFC: Minor build correctness patch In-Reply-To: <1883048676.122321246977742772.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> Message-ID: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> Hi, The attached patch corrects a minor issue noted in http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=289 Include statements for the .c files affected are missing, resulting in compiler warnings. While this wasn't affecting the build or correct performance, it is good practice to include headers where appropriate. This patch, adapted from that provided by the original bug reporter above, adds the include statements. Comments welcome. jon -------------- next part -------------- A non-text attachment was scrubbed... Name: header_correctness.patch Type: application/octet-stream Size: 1625 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090707/d5b34af0/attachment.obj From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 07:46:32 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 14:46:32 +0000 Subject: [Bug 311] JAVA-Based programs won't run and craches Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=311 ------- Comment #5 from jon.vanalten at redhat.com 2009-07-07 14:46 ------- Hi, cleaning up some stale bug reports here. Has this problem been happening still for you? Or does it seem to be resolved? (will leave open for 1 week then assume fixed by updates as noted above) -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From langel at redhat.com Tue Jul 7 08:04:29 2009 From: langel at redhat.com (Lillian Angel) Date: Tue, 07 Jul 2009 11:04:29 -0400 Subject: RFC: Minor build correctness patch In-Reply-To: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> References: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> Message-ID: <4A5363FD.801@redhat.com> jon.vanalten at redhat.com wrote: > Hi, > > The attached patch corrects a minor issue noted in http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=289 > > Include statements for the .c files affected are missing, resulting in compiler warnings. While this wasn't affecting the build or correct performance, it is good practice to include headers where appropriate. This patch, adapted from that provided by the original bug reporter above, adds the include statements. > > Comments welcome. As per Andrew Hughes comments in the bug, I would like to see this filed upstream to Sun. I have CC'ed Matthew Flaschen. For now, it is fine to commit. Cheers, Lillian From omajid at redhat.com Tue Jul 7 08:27:09 2009 From: omajid at redhat.com (Omair Majid) Date: Tue, 07 Jul 2009 11:27:09 -0400 Subject: RFC: Use correct node object when parsing ext-download elements Message-ID: <4A53694D.9000100@redhat.com> Hi, The attached patch fixes typos in the node name in Parser.getExtension. The variable node refers to the extension node, and dload[i] refers to the ext-download node. This patch was originally posted for bug 271: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=271 ChangeLog: 2009-07-07 Omair Majid * rt/net/sourceforge/jnlp/Parser.java (getExtension): Fix typo. Any comments? Cheers, Omair -------------- next part -------------- A non-text attachment was scrubbed... Name: netx-parser-ext-node-name.patch Type: text/x-patch Size: 835 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090707/656c5ce6/attachment.bin From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 08:26:01 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 15:26:01 +0000 Subject: [Bug 356] keytool doesn't handle SHA384withECDSA signatures Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=356 ------- Comment #2 from ankostis at gmail.com 2009-07-07 15:26 ------- * Needed to add a suitable for 'SHA384withECDSA' provider into 'java.security' config-file. * Supposedly SHA384withECDSA provided by sun.security.pkcs11.SunPKCS11 with NSS as the native backend, as described in: http://blogs.sun.com/andreas/entry/the_java_pkcs_11_provider with the following config-file: name = NSS nssLibraryDirectory = /opt/tests/nss/lib nssDbMode = noDb attributes = compatibility * In fedora needed to install nss-devel-3.12.3-4.fc11.i586 due to a missing NSS lib. * Debug java-prop: java.security.debug={all|provider|sunpkcs11} * But NSS does *NOT* by default compile ECC! according to: http://www.mozilla.org/projects/security/pki/nss/nss-3.11/nss-3.11-algorithms.html * BUT Testcrypto.java TestCase also fails in sun's jdk!! -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 09:35:11 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 16:35:11 +0000 Subject: [Bug 356] keytool doesn't handle SHA384withECDSA signatures Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=356 ------- Comment #3 from ankostis at gmail.com 2009-07-07 16:35 ------- Managed to import COMODO's ECC certificate. This bug is present also in sun's JDK and it gets fixed as prescribed by Andreas Sterbenz: http://blogs.sun.com/andreas/entry/the_java_pkcs_11_provider We need to add the 'sun.security.pkcs11.SunPKCS11' provider with a single config-arg pointing to a file containing the following properties: name = NSS nssLibraryDirectory = /usr/lib nssDbMode = noDb attributes = compatibility Tested on: * Gentoo, needs devlibs/nss installed and a minor config modification: nssLibraryDirectory=/usr/lib/nss and it works ok. * Debian just needs libnss3-1d installed, and it also works ok. * Fedora's NSS, by default is compiled most probably *without* ECC! So it fails. (see: http://www.mozilla.org/projects/security/pki/nss/nss-3.11/nss-3.11-algorithms.html) -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 09:51:07 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 16:51:07 +0000 Subject: [Bug 311] JAVA-Based programs won't run and craches Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=311 mrjava.javaman at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED ------- Comment #6 from mrjava.javaman at gmail.com 2009-07-07 16:51 ------- As announced somewhere at redhat website, this was a known bug in imsetting and was fixed a while ago in fedora 10. Thanks! -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From dbhole at redhat.com Tue Jul 7 09:59:13 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Tue, 7 Jul 2009 12:59:13 -0400 Subject: RFC: Use correct node object when parsing ext-download elements In-Reply-To: <4A53694D.9000100@redhat.com> References: <4A53694D.9000100@redhat.com> Message-ID: <20090707165913.GA11824@redhat.com> * Omair Majid [2009-07-07 11:27]: > Hi, > > The attached patch fixes typos in the node name in Parser.getExtension. > The variable node refers to the extension node, and dload[i] refers to > the ext-download node. > > This patch was originally posted for bug 271: > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=271 > > ChangeLog: > 2009-07-07 Omair Majid > > * rt/net/sourceforge/jnlp/Parser.java > (getExtension): Fix typo. > > Any comments? > Looks good. Deepak > Cheers, > Omair From omajid at redhat.com Tue Jul 7 10:43:46 2009 From: omajid at redhat.com (Omair Majid) Date: Tue, 07 Jul 2009 17:43:46 +0000 Subject: changeset in /hg/icedtea6: 2009-07-07 Omair Majid changeset b4bb02c70835 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=b4bb02c70835 description: 2009-07-07 Omair Majid * rt/net/sourceforge/jnlp/Parser.java (getExtension): Fix typo in node name. diffstat: 2 files changed, 9 insertions(+), 4 deletions(-) ChangeLog | 5 +++++ rt/net/sourceforge/jnlp/Parser.java | 8 ++++---- diffs (30 lines): diff -r 742216fd1f8f -r b4bb02c70835 ChangeLog --- a/ChangeLog Tue Jul 07 10:12:31 2009 -0400 +++ b/ChangeLog Tue Jul 07 13:44:35 2009 -0400 @@ -1,3 +1,8 @@ 2009-07-07 Omair Majid + + * rt/net/sourceforge/jnlp/Parser.java + (getExtension): Fix typo in node name. + 2009-07-07 Omair Majid * rt/net/sourceforge/jnlp/resources/Messages.properties: Add diff -r 742216fd1f8f -r b4bb02c70835 rt/net/sourceforge/jnlp/Parser.java --- a/rt/net/sourceforge/jnlp/Parser.java Tue Jul 07 10:12:31 2009 -0400 +++ b/rt/net/sourceforge/jnlp/Parser.java Tue Jul 07 13:44:35 2009 -0400 @@ -336,10 +336,10 @@ class Parser { Node dload[] = getChildNodes(node, "ext-download"); for (int i=0; i < dload.length; i++) { - boolean lazy = "lazy".equals(getAttribute(node, "download", "eager")); - - ext.addPart(getRequiredAttribute(node, "ext-part", null), - getAttribute(node, "part", null), + boolean lazy = "lazy".equals(getAttribute(dload[i], "download", "eager")); + + ext.addPart(getRequiredAttribute(dload[i], "ext-part", null), + getAttribute(dload[i], "part", null), lazy); } From omajid at redhat.com Tue Jul 7 10:46:38 2009 From: omajid at redhat.com (Omair Majid) Date: Tue, 07 Jul 2009 13:46:38 -0400 Subject: RFC: Use correct node object when parsing ext-download elements In-Reply-To: <20090707165913.GA11824@redhat.com> References: <4A53694D.9000100@redhat.com> <20090707165913.GA11824@redhat.com> Message-ID: <4A5389FE.2060002@redhat.com> Deepak Bhole wrote: > * Omair Majid [2009-07-07 11:27]: >> Hi, >> >> The attached patch fixes typos in the node name in Parser.getExtension. >> The variable node refers to the extension node, and dload[i] refers to >> the ext-download node. >> >> This patch was originally posted for bug 271: >> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=271 >> >> ChangeLog: >> 2009-07-07 Omair Majid >> >> * rt/net/sourceforge/jnlp/Parser.java >> (getExtension): Fix typo. >> >> Any comments? >> > > Looks good. > Pushed as changeset b4bb02c70835. Thanks, Omair From gnu_andrew at member.fsf.org Tue Jul 7 11:21:39 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 7 Jul 2009 19:21:39 +0100 Subject: RFC: Minor build correctness patch In-Reply-To: <4A5363FD.801@redhat.com> References: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> <4A5363FD.801@redhat.com> Message-ID: <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> 2009/7/7 Lillian Angel : > jon.vanalten at redhat.com wrote: >> >> Hi, >> >> The attached patch corrects a minor issue noted in >> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=289 >> >> Include statements for the .c files affected are missing, resulting in >> compiler warnings. ?While this wasn't affecting the build or correct >> performance, it is good practice to include headers where appropriate. ?This >> patch, adapted from that provided by the original bug reporter above, adds >> the include statements. >> >> Comments welcome. > > > As per Andrew Hughes comments in the bug, I would like to see this filed > upstream to Sun. I have CC'ed Matthew Flaschen. > > For now, it is fine to commit. > > > Cheers, > Lillian > I'd much prefer we didn't commit this to IcedTea, as it is just another patch we have to manage and maintain. The arguments Jon makes for including this (it doesn't affect performance or the build) can equally be used as very good reasons for not including it in IcedTea. The majority of the developers on this list, who have been hacking on IcedTea for a while, will be aware of how much of a pain it is to have to test the build with different patches applied and to have to recreate them when a new build drop appears upstream. The current aim (at least of those at Red Hat) is to try and reduce this burden by getting the majority of patches upstream. Jon, as you're still new to the project, you're probably unaware of a lot of this pain so you'll have to take what we say on trust for now :) Believe me, I think your efforts would be better spent applying this to the appropriate JDK7 tree and creating a webrev for it. I can't see an appropriate tree, but presumably those on the net-dev mailing list can provide appropriate hints. Lillian: there already is a bug, http://bugs.sun.com/view_bug.do?bug_id=6562614 (referenced in our IcedTea bug) so it should be a simple matter of just getting the patch approved (the bug has been) and someone pushing it. BTW, I'm aware I said 'I'd commit this' on the bug, but take the fact that I didn't as a reconsideration on my part... ;) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From langel at redhat.com Tue Jul 7 11:27:18 2009 From: langel at redhat.com (Lillian Angel) Date: Tue, 07 Jul 2009 14:27:18 -0400 Subject: RFC: Minor build correctness patch In-Reply-To: <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> References: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> <4A5363FD.801@redhat.com> <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> Message-ID: <4A539386.1040801@redhat.com> Andrew John Hughes wrote: > 2009/7/7 Lillian Angel : > >> jon.vanalten at redhat.com wrote: >> >>> Hi, >>> >>> The attached patch corrects a minor issue noted in >>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=289 >>> >>> Include statements for the .c files affected are missing, resulting in >>> compiler warnings. ? While this wasn't affecting the build or correct >>> performance, it is good practice to include headers where appropriate. ? This >>> patch, adapted from that provided by the original bug reporter above, adds >>> the include statements. >>> >>> Comments welcome. >>> >> As per Andrew Hughes comments in the bug, I would like to see this filed >> upstream to Sun. I have CC'ed Matthew Flaschen. >> >> For now, it is fine to commit. >> >> >> Cheers, >> Lillian >> >> > > I'd much prefer we didn't commit this to IcedTea, as it is just > another patch we have to manage and maintain. The arguments Jon makes > for including this (it doesn't affect performance or the build) can > equally be used as very good reasons for not including it in IcedTea. > The majority of the developers on this list, who have been hacking on > IcedTea for a while, will be aware of how much of a pain it is to have > to test the build with different patches applied and to have to > recreate them when a new build drop appears upstream. The current aim > (at least of those at Red Hat) is to try and reduce this burden by > getting the majority of patches upstream. > > Jon, as you're still new to the project, you're probably unaware of a > lot of this pain so you'll have to take what we say on trust for now > :) Believe me, I think your efforts would be better spent applying > this to the appropriate JDK7 tree and creating a webrev for it. I > can't see an appropriate tree, but presumably those on the net-dev > mailing list can provide appropriate hints. > > Lillian: there already is a bug, > http://bugs.sun.com/view_bug.do?bug_id=6562614 (referenced in our > IcedTea bug) so it should be a simple matter of just getting the patch > approved (the bug has been) and someone pushing it. > > BTW, I'm aware I said 'I'd commit this' on the bug, but take the fact > that I didn't as a reconsideration on my part... ;) Agreed. But there is a good chance if no one takes responsibility for this patch, it will never get committed. IcedTea is a place where we keep track of what needs to go upstream, and make sure we follow up on this. If Jon hadn't been doing a bug clean up, how long would it have been until we came across this again? While the patch doesn't fix any build/performance issues, it is still a bug that should be fixed. Who should be responsible for watching it? Should we leave this up to the reporter? Cheers, Lillian From gnu_andrew at member.fsf.org Tue Jul 7 11:44:55 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 7 Jul 2009 19:44:55 +0100 Subject: RFC: Minor build correctness patch In-Reply-To: <4A539386.1040801@redhat.com> References: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> <4A5363FD.801@redhat.com> <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> <4A539386.1040801@redhat.com> Message-ID: <17c6771e0907071144y5039508eh69ad77da025b787e@mail.gmail.com> 2009/7/7 Lillian Angel : > Andrew John Hughes wrote: >> >> 2009/7/7 Lillian Angel : >> >>> >>> jon.vanalten at redhat.com wrote: >>> >>>> >>>> Hi, >>>> >>>> The attached patch corrects a minor issue noted in >>>> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=289 >>>> >>>> Include statements for the .c files affected are missing, resulting in >>>> compiler warnings. ? While this wasn't affecting the build or correct >>>> performance, it is good practice to include headers where appropriate. ? >>>> This >>>> patch, adapted from that provided by the original bug reporter above, >>>> adds >>>> the include statements. >>>> >>>> Comments welcome. >>>> >>> >>> As per Andrew Hughes comments in the bug, I would like to see this filed >>> upstream to Sun. I have CC'ed Matthew Flaschen. >>> >>> For now, it is fine to commit. >>> >>> >>> Cheers, >>> Lillian >>> >>> >> >> I'd much prefer we didn't commit this to IcedTea, as it is just >> another patch we have to manage and maintain. ?The arguments Jon makes >> for including this (it doesn't affect performance or the build) can >> equally be used as very good reasons for not including it in IcedTea. >> The majority of the developers on this list, who have been hacking on >> IcedTea for a while, will be aware of how much of a pain it is to have >> to test the build with different patches applied and to have to >> recreate them when a new build drop appears upstream. ?The current aim >> (at least of those at Red Hat) is to try and reduce this burden by >> getting the majority of patches upstream. >> >> Jon, as you're still new to the project, you're probably unaware of a >> lot of this pain so you'll have to take what we say on trust for now >> :) ?Believe me, I think your efforts would be better spent applying >> this to the appropriate JDK7 tree and creating a webrev for it. ?I >> can't see an appropriate tree, but presumably those on the net-dev >> mailing list can provide appropriate hints. >> >> Lillian: there already is a bug, >> http://bugs.sun.com/view_bug.do?bug_id=6562614 (referenced in our >> IcedTea bug) so it should be a simple matter of just getting the patch >> approved (the bug has been) and someone pushing it. >> >> BTW, I'm aware I said 'I'd commit this' on the bug, but take the fact >> that I didn't as a reconsideration on my part... ;) > > > Agreed. But there is a good chance if no one takes responsibility for this > patch, it will never get committed. IcedTea is a place where we keep track > of what needs to go upstream, and make sure we follow up on this. If Jon > hadn't been doing a bug clean up, how long would it have been until we came > across this again? > > While the patch doesn't fix any build/performance issues, it is still a bug > that should be fixed. Who should be responsible for watching it? Should we > leave this up to the reporter? > I agree that IcedTea has a place as an envoy, tracking fixes from users and pushing them upstream. But there is a difference between IcedTea as in the repository with our code and patches in, and IcedTea as a project. Jon is certainly right in doing such bug cleanup and helping push this patch forward. I just don't see any advantage in having a festering copy in our repository when you need to recreate the patch against OpenJDK to push it upstream anyway. As I suggested above, the better solution is for Jon to use this as a trivial patch to get some experience in pushing a patch upstream. My feeling is that we only want to be adding more patches to the IcedTea pile when we need it for some functionality only we support, where it isn't appropriate for upstream or it's so critical (e.g. a security or TCK fix) that we need it now. In the latter case, it's expected to become obsolete in time. I know this isn't the easiest option, but I think in the long run we want to be doing most work on one project - OpenJDK - with IcedTea being more a stepping stone between the distros and OpenJDK, which avoids divergence between packaged binaries and acts as a workplace for things yet to go upstream (like the plugin). I'm biased though because I feel this whole patch thing a lot more. While with IcedTea6, rerolling the patches is becoming almost a biannually event, there are some patches I'm already recreating on a weekly basis with IcedTea7... > > Cheers, > Lillian > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From martinrb at google.com Tue Jul 7 11:48:27 2009 From: martinrb at google.com (Martin Buchholz) Date: Tue, 7 Jul 2009 11:48:27 -0700 Subject: RFC: Minor build correctness patch In-Reply-To: <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> References: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> <4A5363FD.801@redhat.com> <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> Message-ID: <1ccfd1c10907071148n49038004r3faa0caec922b7d3@mail.gmail.com> On Tue, Jul 7, 2009 at 11:21, Andrew John Hughes wrote: > 2009/7/7 Lillian Angel : > > jon.vanalten at redhat.com wrote: > >> > >> Hi, > >> > >> The attached patch corrects a minor issue noted in > >> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=289 > >> > >> Include statements for the .c files affected are missing, resulting in > >> compiler warnings. While this wasn't affecting the build or correct > >> performance, it is good practice to include headers where appropriate. > This > >> patch, adapted from that provided by the original bug reporter above, > adds > >> the include statements. > >> > >> Comments welcome. > > > > > > As per Andrew Hughes comments in the bug, I would like to see this filed > > upstream to Sun. I have CC'ed Matthew Flaschen. > > > > For now, it is fine to commit. > > > > > > Cheers, > > Lillian > > > > I'd much prefer we didn't commit this to IcedTea, as it is just > another patch we have to manage and maintain. The arguments Jon makes > for including this (it doesn't affect performance or the build) can > equally be used as very good reasons for not including it in IcedTea. > The majority of the developers on this list, who have been hacking on > IcedTea for a while, will be aware of how much of a pain it is to have > to test the build with different patches applied and to have to > recreate them when a new build drop appears upstream. The current aim > (at least of those at Red Hat) is to try and reduce this burden by > getting the majority of patches upstream. > > Jon, as you're still new to the project, you're probably unaware of a > lot of this pain so you'll have to take what we say on trust for now > :) Believe me, I think your efforts would be better spent applying > this to the appropriate JDK7 tree and creating a webrev for it. I > can't see an appropriate tree, but presumably those on the net-dev > mailing list can provide appropriate hints. > The tl forest is the right tree. You can use me ("martin") as a "reviewer" when pushing this upstream. Martin > > Lillian: there already is a bug, > http://bugs.sun.com/view_bug.do?bug_id=6562614 (referenced in our > IcedTea bug) so it should be a simple matter of just getting the patch > approved (the bug has been) and someone pushing it. > > BTW, I'm aware I said 'I'd commit this' on the bug, but take the fact > that I didn't as a reconsideration on my part... ;) > -- > Andrew :-) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090707/bb0a0004/attachment.html From Tim.Bell at Sun.COM Tue Jul 7 11:57:15 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Tue, 07 Jul 2009 11:57:15 -0700 Subject: RFC: Minor build correctness patch In-Reply-To: <1ccfd1c10907071148n49038004r3faa0caec922b7d3@mail.gmail.com> References: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> <4A5363FD.801@redhat.com> <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> <1ccfd1c10907071148n49038004r3faa0caec922b7d3@mail.gmail.com> Message-ID: <4A539A8B.9000601@sun.com> Martin Buchholz wrote: > The tl forest is the right tree. > You can use me ("martin") as a "reviewer" when pushing this upstream. > > Martin That is correct. TL is open for b66 fixes at the moment [1]. Tim (gatekeeper for TL) [1] http://openjdk.java.net/projects/jdk7/builds/ From gnu_andrew at member.fsf.org Tue Jul 7 12:47:08 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 7 Jul 2009 20:47:08 +0100 Subject: RFC: Minor build correctness patch In-Reply-To: <4A539A8B.9000601@sun.com> References: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> <4A5363FD.801@redhat.com> <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> <1ccfd1c10907071148n49038004r3faa0caec922b7d3@mail.gmail.com> <4A539A8B.9000601@sun.com> Message-ID: <17c6771e0907071247u4fe9fa57s86d91a6bc778213@mail.gmail.com> 2009/7/7 Tim Bell : > Martin Buchholz wrote: > >> The tl forest is the right tree. You can use me ("martin") as a "reviewer" >> when pushing this upstream. >> >> Martin > > That is correct. ?TL is open for b66 fixes at the moment [1]. > > Tim (gatekeeper for TL) > > [1] http://openjdk.java.net/projects/jdk7/builds/ > Oh that's interesting... I didn't realise tl only got to integrate every other week. Not that I'm complaining; given how much tl includes, this probably greatly reduces the amount of change in some of the build drops! -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From omajid at redhat.com Tue Jul 7 12:48:57 2009 From: omajid at redhat.com (Omair Majid) Date: Tue, 07 Jul 2009 15:48:57 -0400 Subject: RFC: Rewrite of cookie support in plugin In-Reply-To: <20090703223003.GA21560@redhat.com> References: <20090703214931.GB28859@redhat.com> <20090703223003.GA21560@redhat.com> Message-ID: <4A53A6A9.1030802@redhat.com> Hi, Deepak Bhole wrote: > Oops. Original message is missing 2 new files from the patch. Sorry > about that. New patch attached. > > Deepak > > * Deepak Bhole [2009-07-03 17:48]: >> This patch rewrites cookie support in the plugin. The old way was >> static, set at initialization time. Additionally, it did not support >> cookie provision for connection requests made by the applet internally. >> >> This patch fixes all of that. Cookie information is now supplied to Java >> in real-time from Mozilla side, as it should be. >> >> Thanks to Omair for the initial error trace. >> >> This patch fixes rhbz 506730: >> https://bugzilla.redhat.com/show_bug.cgi?id=506730 >> >> http://www.sbm.no/ will now load correctly with this patch. >> >> ChangeLog: >> * IcedTeaPlugin.cc: Add suppport for cookie info requests from applets. >> * plugin/icedtea/sun/applet/PluginAppletViewer.java: Rework cookie support >> to make it dynamic. >> * plugin/icedtea/sun/applet/PluginMain.java: Wire in custom cookie store >> that dynamically requests cookie information from C++ side. >> * rt/net/sourceforge/jnlp/JNLPFile.java: Remove old cookie handling code. >> * rt/net/sourceforge/jnlp/Launcher.java: Same. >> * rt/net/sourceforge/jnlp/NetxPanel.java: Same. >> * rt/net/sourceforge/jnlp/PluginBridge.java: Same. >> * rt/net/sourceforge/jnlp/cache/CacheUtil.java: Same. >> * rt/net/sourceforge/jnlp/cache/Resource.java: Same. >> * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: Same. >> * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Same. >> >> Comments? >> >> Deepak > I am assuming that aside from the classes that manage cookies, nothing should be storing or passing them around. However, there are still many references to cookies. For example,net.sourceforge.jnlp.ExtensionDesc contains: public ExtensionDesc(String name, Version version, URL location, String cookieStr) Please remove all unused references to cookies. Thanks, Omair From Tim.Bell at Sun.COM Tue Jul 7 12:54:25 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Tue, 07 Jul 2009 12:54:25 -0700 Subject: RFC: Minor build correctness patch In-Reply-To: <17c6771e0907071247u4fe9fa57s86d91a6bc778213@mail.gmail.com> References: <1598841206.122401246977794055.JavaMail.root@zmail01.collab.prod.int.phx2.redhat.com> <4A5363FD.801@redhat.com> <17c6771e0907071121l2396190fi5fbb121a83cd2aab@mail.gmail.com> <1ccfd1c10907071148n49038004r3faa0caec922b7d3@mail.gmail.com> <4A539A8B.9000601@sun.com> <17c6771e0907071247u4fe9fa57s86d91a6bc778213@mail.gmail.com> Message-ID: <4A53A7F1.1050409@sun.com> Andrew John Hughes wrote: >> [1] http://openjdk.java.net/projects/jdk7/builds/ >> > > Oh that's interesting... I didn't realise tl only got to integrate > every other week. Not that I'm complaining; given how much tl > includes, this probably greatly reduces the amount of change in some > of the build drops! That is correct. At the moment tl is hitting the even numbered builds. If tl integrated every week, not only would it completely take over my life as gatekeeper, it would put extra demands on the test teams. We build and test every night, but PIT (Pre Integration Testing) calls for extra effort from many people. Also, as you see on the schedule, there are not very many open slots during business days. If every team tried to integrate every week, we would be stepping all over each other. Tim From dbhole at redhat.com Tue Jul 7 13:26:58 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Tue, 7 Jul 2009 16:26:58 -0400 Subject: RFC: Rewrite of cookie support in plugin In-Reply-To: <4A53A6A9.1030802@redhat.com> References: <20090703214931.GB28859@redhat.com> <20090703223003.GA21560@redhat.com> <4A53A6A9.1030802@redhat.com> Message-ID: <20090707202658.GA6352@redhat.com> * Omair Majid [2009-07-07 15:48]: > Hi, > > Deepak Bhole wrote: >> Oops. Original message is missing 2 new files from the patch. Sorry >> about that. New patch attached. >> >> Deepak >> >> * Deepak Bhole [2009-07-03 17:48]: >>> This patch rewrites cookie support in the plugin. The old way was >>> static, set at initialization time. Additionally, it did not support >>> cookie provision for connection requests made by the applet internally. >>> >>> This patch fixes all of that. Cookie information is now supplied to Java >>> in real-time from Mozilla side, as it should be. >>> >>> Thanks to Omair for the initial error trace. >>> >>> This patch fixes rhbz 506730: >>> https://bugzilla.redhat.com/show_bug.cgi?id=506730 >>> >>> http://www.sbm.no/ will now load correctly with this patch. >>> >>> ChangeLog: >>> * IcedTeaPlugin.cc: Add suppport for cookie info requests from applets. >>> * plugin/icedtea/sun/applet/PluginAppletViewer.java: Rework cookie support >>> to make it dynamic. >>> * plugin/icedtea/sun/applet/PluginMain.java: Wire in custom cookie store >>> that dynamically requests cookie information from C++ side. >>> * rt/net/sourceforge/jnlp/JNLPFile.java: Remove old cookie handling code. >>> * rt/net/sourceforge/jnlp/Launcher.java: Same. >>> * rt/net/sourceforge/jnlp/NetxPanel.java: Same. >>> * rt/net/sourceforge/jnlp/PluginBridge.java: Same. >>> * rt/net/sourceforge/jnlp/cache/CacheUtil.java: Same. >>> * rt/net/sourceforge/jnlp/cache/Resource.java: Same. >>> * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: Same. >>> * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Same. >>> >>> Comments? >>> >>> Deepak >> > > I am assuming that aside from the classes that manage cookies, nothing > should be storing or passing them around. However, there are still many > references to cookies. For example,net.sourceforge.jnlp.ExtensionDesc > contains: > public ExtensionDesc(String name, Version version, URL location, String > cookieStr) > > Please remove all unused references to cookies. > Good catch! New patch attached. Cheers, Deepak -------------- next part -------------- A non-text attachment was scrubbed... Name: ITP-cookie-support-rewrite2.patch Type: text/x-patch Size: 33277 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090707/08114f1d/attachment.bin From dbhole at redhat.com Tue Jul 7 13:39:28 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Tue, 7 Jul 2009 16:39:28 -0400 Subject: RFC: Rewrite of cookie support in plugin In-Reply-To: <20090707202658.GA6352@redhat.com> References: <20090703214931.GB28859@redhat.com> <20090703223003.GA21560@redhat.com> <4A53A6A9.1030802@redhat.com> <20090707202658.GA6352@redhat.com> Message-ID: <20090707203928.GB6352@redhat.com> * Deepak Bhole [2009-07-07 16:25]: > * Omair Majid [2009-07-07 15:48]: > > Hi, > > > > Deepak Bhole wrote: > >> Oops. Original message is missing 2 new files from the patch. Sorry > >> about that. New patch attached. > >> > >> Deepak > >> > >> * Deepak Bhole [2009-07-03 17:48]: > >>> This patch rewrites cookie support in the plugin. The old way was > >>> static, set at initialization time. Additionally, it did not support > >>> cookie provision for connection requests made by the applet internally. > >>> > >>> This patch fixes all of that. Cookie information is now supplied to Java > >>> in real-time from Mozilla side, as it should be. > >>> > >>> Thanks to Omair for the initial error trace. > >>> > >>> This patch fixes rhbz 506730: > >>> https://bugzilla.redhat.com/show_bug.cgi?id=506730 > >>> > >>> http://www.sbm.no/ will now load correctly with this patch. > >>> > >>> ChangeLog: > >>> * IcedTeaPlugin.cc: Add suppport for cookie info requests from applets. > >>> * plugin/icedtea/sun/applet/PluginAppletViewer.java: Rework cookie support > >>> to make it dynamic. > >>> * plugin/icedtea/sun/applet/PluginMain.java: Wire in custom cookie store > >>> that dynamically requests cookie information from C++ side. > >>> * rt/net/sourceforge/jnlp/JNLPFile.java: Remove old cookie handling code. > >>> * rt/net/sourceforge/jnlp/Launcher.java: Same. > >>> * rt/net/sourceforge/jnlp/NetxPanel.java: Same. > >>> * rt/net/sourceforge/jnlp/PluginBridge.java: Same. > >>> * rt/net/sourceforge/jnlp/cache/CacheUtil.java: Same. > >>> * rt/net/sourceforge/jnlp/cache/Resource.java: Same. > >>> * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: Same. > >>> * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Same. > >>> > >>> Comments? > >>> > >>> Deepak > >> > > > > I am assuming that aside from the classes that manage cookies, nothing > > should be storing or passing them around. However, there are still many > > references to cookies. For example,net.sourceforge.jnlp.ExtensionDesc > > contains: > > public ExtensionDesc(String name, Version version, URL location, String > > cookieStr) > > > > Please remove all unused references to cookies. > > > > Good catch! New patch attached. > Just my luck. That patch breaks javaws (not sure how it compiled in the first place when I tested it :/). Anyways, THIS one should work. The previous one was missing a change to the JNLPFile constructor call in Boot.java Deepak -------------- next part -------------- A non-text attachment was scrubbed... Name: ITP-cookie-support-rewrite3.patch Type: text/x-patch Size: 33780 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090707/93ce679c/attachment.bin From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 13:46:45 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 20:46:45 +0000 Subject: [Bug 271] JavaFX sample no longer runs with javaws, runs fine with java Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=271 ------- Comment #9 from omajid at redhat.com 2009-07-07 20:46 ------- (In reply to comment #8) > This patch causes the extensions to load. It now fails at a later stage trying > to load http://dl.javafx.com/jogl.jnlp > Netx isnt using versioned downloads for jnlp files :(. http://dl.javafx.com/jogl.jnlp?version-id=1.1.1a works just fine. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 7 16:00:28 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 07 Jul 2009 23:00:28 +0000 Subject: [Bug 362] New: graphical window appears blank when using icedtea instead of Sun's JRE Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=362 Summary: graphical window appears blank when using icedtea instead of Sun's JRE Product: IcedTea Version: unspecified Platform: PC URL: http://sourceforge.net/projects/arianne/ OS/Version: Linux Status: NEW Severity: blocker Priority: P2 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: oslsach at yahoo.com The game client's graphical window appears blank when using IcedTea/OpenJDK instead of Sun's JRE, making this online game unplayable with the former JVM. JVM Version used (though the problem has always appeared in any version or flavour ;-) - IcedTea or not): OpenJDK Runtime Environment (build 1.6.0_0-b11) OpenJDK Client VM (build 1.6.0_0-b11, mixed mode, sharing) 1) Download the game client zip at http://sourceforge.net/projects/arianne/ stendhal-0.74.zip (lighter version, without sounds) or stendhal-FULL-0.74.zip and unpack it into a directory. 2) Run from the command line using: java -jar stendhal-0.74.jar 3) Create an account and connect to the server. Result: The main window, which is a graphical window, appears blank, making the game unplayable. The chat/event window below it works normally, though. No error message is reported on the console: either from the application or the JVM. 4)Quit the game. 5)Switch to Sun's JRE (version 5 or later required): 6) Repeat the previous procedure from step 2)(no need to create a new account, though) Result: The graphical window renders the game image and the game is flawlessly playable. This bug is always reproducible. The game developers failed trying to isolate a minimal test case, though their knowledge about awt/swing (which is where it is suspected that the problem may reside, given the graphical nature of the symptom) is admittedly limited. Being a project hosted in Sourceforge the source code is freely available for inspection. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From xerxes at zafena.se Wed Jul 8 02:09:57 2009 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Wed, 08 Jul 2009 11:09:57 +0200 Subject: RFC: GlobalVariable shark + llvm2.6svn LLVMContext api change Message-ID: <4A546265.4040206@zafena.se> Similar to yesterdays llvm2.6svn api change patch, today the llvm GlobalVariable constructor got LLVMContextifyed and shark needs patching accordingly. Cheers Xerxes -------------- next part -------------- A non-text attachment was scrubbed... Name: LLVMContext_sharkBuilder_GlobalVariable.patch Type: text/x-patch Size: 1838 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090708/6a7bc457/attachment.bin From gbenson at redhat.com Wed Jul 8 02:15:43 2009 From: gbenson at redhat.com (Gary Benson) Date: Wed, 8 Jul 2009 10:15:43 +0100 Subject: RFC: GlobalVariable shark + llvm2.6svn LLVMContext api change In-Reply-To: <4A546265.4040206@zafena.se> References: <4A546265.4040206@zafena.se> Message-ID: <20090708091542.GB3236@redhat.com> Hi Xerxes, Please commit this. Cheers, Gary Xerxes R?nby wrote: > Similar to yesterdays llvm2.6svn api change patch, today the llvm > GlobalVariable constructor got LLVMContextifyed and shark needs patching > accordingly. > > Cheers > Xerxes > Index: icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.hpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/sharkBuilder.hpp 2009-07-08 10:31:09.000000000 +0200 > +++ icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.hpp 2009-07-08 10:44:05.000000000 +0200 > @@ -174,7 +174,14 @@ > char name[128]; > snprintf(name, sizeof name - 1, "pointer_constant_%p", ptr); > > - GlobalVariable *value = new GlobalVariable(SharkType::intptr_type(), > + GlobalVariable *value = new GlobalVariable( > +#if SHARK_LLVM_VERSION >= 26 > + // LLVM 2.6 requires a LLVMContext during GlobalVariable construction. > + // getGlobalConext() returns one that can be used as long as the shark > + // compiler are single-threaded. > + getGlobalContext(), > +#endif > + SharkType::intptr_type(), > false, GlobalValue::ExternalLinkage, > NULL, name, module()); > execution_engine()->addGlobalMapping(value, const_cast(ptr)); > Index: icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp 2009-07-08 10:43:34.000000000 +0200 > +++ icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp 2009-07-08 10:44:43.000000000 +0200 > @@ -187,6 +187,12 @@ > Value *name = CreatePtrToInt( > CreateStructGEP( > new GlobalVariable( > +#if SHARK_LLVM_VERSION >= 26 > + // LLVM 2.6 requires a LLVMContext during GlobalVariable construction. > + // getGlobalConext() returns one that can be used as long as the shark > + // compiler are single-threaded. > + getGlobalContext(), > +#endif > const_name->getType(), > true, GlobalValue::InternalLinkage, > const_name, "dump", module()), -- http://gbenson.net/ From xerxes at zafena.se Wed Jul 8 02:26:47 2009 From: xerxes at zafena.se (Xerxes R?nby) Date: Wed, 08 Jul 2009 09:26:47 +0000 Subject: changeset in /hg/icedtea6: 2009-07-08 Xerxes R?nby changeset 36ad06193338 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=36ad06193338 description: 2009-07-08 Xerxes R?nby * ports/hotspot/src/share/vm/shark/sharkBuilder.hpp (SharkBuilder::pointer_constant): Pass the LLVMContext returned from getGlobalContext() to the new GlobalVariable constructor when llvm version are 2.6 or later to handle LLVM API change. * ports/hotspot/src/share/vm/shark/sharkBuilder.cpp (SharkBuilder::CreateDump): Likewise. diffstat: 3 files changed, 23 insertions(+), 1 deletion(-) ChangeLog | 9 +++++++++ ports/hotspot/src/share/vm/shark/sharkBuilder.cpp | 6 ++++++ ports/hotspot/src/share/vm/shark/sharkBuilder.hpp | 9 ++++++++- diffs (51 lines): diff -r b4bb02c70835 -r 36ad06193338 ChangeLog --- a/ChangeLog Tue Jul 07 13:44:35 2009 -0400 +++ b/ChangeLog Wed Jul 08 11:28:08 2009 +0200 @@ -1,3 +1,12 @@ 2009-07-07 Omair Majid + + * ports/hotspot/src/share/vm/shark/sharkBuilder.hpp + (SharkBuilder::pointer_constant): Pass the LLVMContext returned + from getGlobalContext() to the new GlobalVariable constructor + when llvm version are 2.6 or later to handle LLVM API change. + * ports/hotspot/src/share/vm/shark/sharkBuilder.cpp + (SharkBuilder::CreateDump): Likewise. + 2009-07-07 Omair Majid * rt/net/sourceforge/jnlp/Parser.java diff -r b4bb02c70835 -r 36ad06193338 ports/hotspot/src/share/vm/shark/sharkBuilder.cpp --- a/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp Tue Jul 07 13:44:35 2009 -0400 +++ b/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp Wed Jul 08 11:28:08 2009 +0200 @@ -187,6 +187,12 @@ CallInst* SharkBuilder::CreateDump(llvm: Value *name = CreatePtrToInt( CreateStructGEP( new GlobalVariable( +#if SHARK_LLVM_VERSION >= 26 + // LLVM 2.6 requires a LLVMContext during GlobalVariable construction. + // getGlobalConext() returns one that can be used as long as the shark + // compiler are single-threaded. + getGlobalContext(), +#endif const_name->getType(), true, GlobalValue::InternalLinkage, const_name, "dump", module()), diff -r b4bb02c70835 -r 36ad06193338 ports/hotspot/src/share/vm/shark/sharkBuilder.hpp --- a/ports/hotspot/src/share/vm/shark/sharkBuilder.hpp Tue Jul 07 13:44:35 2009 -0400 +++ b/ports/hotspot/src/share/vm/shark/sharkBuilder.hpp Wed Jul 08 11:28:08 2009 +0200 @@ -174,7 +174,14 @@ class SharkBuilder : public llvm::IRBuil char name[128]; snprintf(name, sizeof name - 1, "pointer_constant_%p", ptr); - GlobalVariable *value = new GlobalVariable(SharkType::intptr_type(), + GlobalVariable *value = new GlobalVariable( +#if SHARK_LLVM_VERSION >= 26 + // LLVM 2.6 requires a LLVMContext during GlobalVariable construction. + // getGlobalConext() returns one that can be used as long as the shark + // compiler are single-threaded. + getGlobalContext(), +#endif + SharkType::intptr_type(), false, GlobalValue::ExternalLinkage, NULL, name, module()); execution_engine()->addGlobalMapping(value, const_cast(ptr)); From bugzilla-daemon at icedtea.classpath.org Wed Jul 8 09:16:20 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 08 Jul 2009 16:16:20 +0000 Subject: [Bug 363] New: SIGBUS error at [libzip.so+0x40d1] Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=363 Summary: SIGBUS error at [libzip.so+0x40d1] Product: IcedTea Version: unspecified Platform: PC OS/Version: Other Status: NEW Severity: normal Priority: P2 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: m.a.young at durham.ac.uk We have a big teaching and learning application called blackboard on RHEL5 using the java-1.6.0-openjdk-1.6.0.0-0.30.b09.el5.x86_64 package, which is crashing occasionally. The crash trace starts # # An unexpected error has been detected by Java Runtime Environment: # # SIGBUS (0x7) at pc=0x00002aaaab1120d1, pid=14875, tid=1098516800 # # Java VM: OpenJDK 64-Bit Server VM (1.6.0-b09 mixed mode linux-amd64) # Problematic frame: # C [libzip.so+0x40d1] # # If you would like to submit a bug report, please visit: # http://icedtea.classpath.org/bugzilla # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # --------------- T H R E A D --------------- Current thread (0x00002aab24359c00): JavaThread "Timer-0" daemon [_thread_in_native, id=14902, stack(0x0000000041750000,0x00000000417a1000)] siginfo:si_signo=SIGBUS: si_errno=0, si_code=2 (BUS_ADRERR), si_addr=0x00002aab2842c7c0 Registers: RAX=0x00002aab24724ff0, RBX=0x00002aab2842c7a3, RCX=0x00002aab24359c00, RDX=0x0000000000000008 RSP=0x000000004179e0e0, RBP=0x000000004179e120, RSI=0x0000000000000040, RDI=0x00002aab24000020 R8 =0x7373616c632e6769, R9 =0x62702f6e6f697470, R10=0x6769666e6f632f65, R11=0x0000000000000000 R12=0x00002aab2500f0f0, R13=0x00002aab24724ff0, R14=0x0000000092e08077, R15=0x000000004179e190 RIP=0x00002aaaab1120d1, EFL=0x0000000000010206, CSGSFS=0x0000000000000033, ERR=0x0000000000000004 TRAPNO=0x000000000000000e Top of Stack: (sp=0x000000004179e0e0) 0x000000004179e0e0: 00002aab25308f00 00002b247912501c 0x000000004179e0f0: 00002aab24724ff0 00002aab247875f0 0x000000004179e100: 00002aab2500f0f0 0000000000000000 0x000000004179e110: 0000000092e08077 000000004179e190 0x000000004179e120: 000000004179e160 00002aaaab1124ae 0x000000004179e130: 0000003024359c00 00002aab24359d98 0x000000004179e140: 000000004179e190 0000000000000030 0x000000004179e150: 000000004179e5e8 0000000000000030 0x000000004179e160: 000000004179e5d0 00002aaaab1115b5 0x000000004179e170: 000000001e660740 000000004179e190 0x000000004179e180: 01002b24795e8610 00002aab2500f0f0 0x000000004179e190: 7973616a2f67726f 7972636e652f7470 0x000000004179e1a0: 62702f6e6f697470 6769666e6f632f65 0x000000004179e1b0: 666e6f434542502f 7373616c632e6769 0x000000004179e1c0: 00002aab24350000 0000000000000000 0x000000004179e1d0: 00002aaaae3e1290 00002aab15ee3038 0x000000004179e1e0: 000000004179e280 00002b24791a8f01 0x000000004179e1f0: 000000004179e210 000000004179e240 0x000000004179e200: 000000004179e210 000000001e660748 0x000000004179e210: 00002aab24359c00 00002aab24001b20 0x000000004179e220: 00002aab20400b40 00002aab20400d60 0x000000004179e230: 00002aab20408b28 000000004179eb70 0x000000004179e240: 0000000000000000 0000000100000000 0x000000004179e250: 8000000100000001 00002aab24359c60 0x000000004179e260: 0000000000000001 00002aab24359c60 0x000000004179e270: 0000000000000029 00002b2479637c38 0x000000004179e280: 000000004179e2b0 00002b247923a08f 0x000000004179e290: 000000004179e2b0 00002b2479239e7a 0x000000004179e2a0: 000000000000018f 000000000000018f 0x000000004179e2b0: 000000004179e2f0 00002b2478eac86d 0x000000004179e2c0: 00002aaaaef30428 0000000000000029 0x000000004179e2d0: 00002b2479637c38 0000000000000096 Instructions: (pc=0x00002aaaab1120d1) 0x00002aaaab1120c1: 00 00 00 8b 5b 04 49 03 5c 24 18 49 2b 5c 24 28 0x00002aaaab1120d1: 44 0f b6 73 1d 0f b6 43 1c 41 c1 e6 08 41 09 c6 Stack: [0x0000000041750000,0x00000000417a1000], sp=0x000000004179e0e0, free space=312k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)C [libzip.so+0x40d1] C [libzip.so+0x44ae] ZIP_GetEntry+0xae C [libzip.so+0x35b5] Java_java_util_zip_ZipFile_getEntry+0x115 J java.util.zip.ZipFile.getEntry(JLjava/lang/String;Z)J Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) J java.util.zip.ZipFile.getEntry(JLjava/lang/String;Z)J J java.util.jar.JarFile.getEntry(Ljava/lang/String;)Ljava/util/zip/ZipEntry; J org.apache.catalina.loader.WebappClassLoader.findResourceInternal(Ljava/lang/String;Ljava/lang/String;)Lorg/apache/catalina/loader/ResourceEntry; J org.apache.catalina.loader.WebappClassLoader.findClassInternal(Ljava/lang/String;)Ljava/lang/Class; J org.apache.catalina.loader.WebappClassLoader.findClass(Ljava/lang/String;)Ljava/lang/Class; J org.apache.catalina.loader.WebappClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class; J org.apache.catalina.loader.WebappClassLoader.loadClass(Ljava/lang/String;)Ljava/lang/Class; v ~BufferBlob::Interpreter v ~BufferBlob::StubRoutines (1) v ~BufferBlob::Interpreter J java.lang.Class.privateGetDeclaredFields(Z)[Ljava/lang/reflect/Field; v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter J blackboard.persist.BbPersistenceManager.runSignalUpdate()V v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::Interpreter v ~BufferBlob::StubRoutines (1) and the error in the log file leading up to this is java.util.zip.ZipException: error reading zip file at java.util.zip.ZipFile.read(Native Method) at java.util.zip.ZipFile.access$1200(ZipFile.java:46) at java.util.zip.ZipFile$ZipFileInputStream.read(ZipFile.java:464) at java.util.zip.ZipFile$1.fill(ZipFile.java:247) at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158) at org.apache.catalina.loader.WebappClassLoader.findResourceInternal(WebappClassLoader.java:2093) at org.apache.catalina.loader.WebappClassLoader.findClassInternal(WebappClassLoader.java:1786) at org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.java:890) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1354) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1233) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:336) at java.lang.Class.getDeclaredFields0(Native Method) at java.lang.Class.privateGetDeclaredFields(Class.java:2308) at java.lang.Class.getDeclaredFields(Class.java:1760) at org.apache.catalina.loader.WebappClassLoader.clearReferences(WebappClassLoader.java:1627) at org.apache.catalina.loader.WebappClassLoader.stop(WebappClassLoader.java:1524) at org.apache.catalina.loader.WebappLoader.stop(WebappLoader.java:707) at org.apache.catalina.core.StandardContext.stop(StandardContext.java:4557) at blackboard.tomcat.servletcontainer.TomcatContainerAdapter.removeWebApp(TomcatContainerAdapter.java:158) at blackboard.platform.plugin.Deployer.unregisterWebApp(Deployer.java:425) at blackboard.platform.plugin.Deployer.undeploy(Deployer.java:127) at blackboard.platform.plugin.PlugInManager.checkDeployAction(PlugInManager.java:1379) at blackboard.platform.plugin.PlugInManager.initVICache(PlugInManager.java:805) at blackboard.platform.plugin.PlugInManager.refreshCachedInfo(PlugInManager.java:247) at blackboard.platform.plugin.PlugInManager.reInit(PlugInManager.java:268) at blackboard.platform.plugin.impl.PlugInDbLoaderImpl.refreshCache(PlugInDbLoaderImpl.java:50) at blackboard.persist.CachingLoaderListener.refresh(CachingLoaderListener.java:58) at blackboard.persist.BbPersistenceManager.runSignalUpdate(BbPersistenceManager.java:744) at blackboard.persist.PersistenceCacheTask.updateCache(PersistenceCacheTask.java:85) at blackboard.persist.PersistenceCacheTask.run(PersistenceCacheTask.java:69) at blackboard.platform.impl.services.task.TaskManagerService$TimerTaskProxy.run(TaskManagerService.java:328) at java.util.TimerThread.mainLoop(Timer.java:534) at java.util.TimerThread.run(Timer.java:484) so I am guessing there is some read failure that is subsequently causing the java process to crash. I had a quick look at the code and I think the problem is as a result of ZIP_GetEntry doing ze = newEntry(zip, zc, ACCESS_RANDOM); (at about line 990 of jdk/src/share/native/java/util/zip/zip_util.c) with the crash happening within the newEntry call. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Wed Jul 8 10:34:08 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 08 Jul 2009 17:34:08 +0000 Subject: [Bug 360] IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 ------- Comment #5 from mrjava.javaman at gmail.com 2009-07-08 17:34 ------- Under windows we use the JRE from SUN version 1.6u11 Again I'm sure it's a netbeans problem, please tell me if I should re-post this in a netbeans forums? * I haven't a specific steps that reproduce the problem, sometimes when I change sometimes when I open the design view, sometimes when I drag or even touch the object ... I'll attach a class "test3D" that reproduce the problem, to reproduce the problem try this: (required is java3d) - USE netbeans! - create a new JFrame using wizard - drag the "test3D" class into the JFrame from the design view - try resize and move the "test3D" many times to many locations until it crashes :D - if it didnt crash, try open the "design" of "test3D" while changing in the newly created JFrame, and also try to add other objets to the JFrame, or maybe drag another object from "test3D" -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Wed Jul 8 10:36:41 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 08 Jul 2009 17:36:41 +0000 Subject: [Bug 360] IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 ------- Comment #6 from mrjava.javaman at gmail.com 2009-07-08 17:36 ------- Created an attachment (id=244) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=244&action=view) the bean that reproduce the problem -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Wed Jul 8 10:58:23 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 08 Jul 2009 17:58:23 +0000 Subject: [Bug 360] IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID ------- Comment #7 from jon.vanalten at redhat.com 2009-07-08 17:58 ------- >Under windows we use the JRE from SUN version 1.6u11 >Again I'm sure it's a netbeans problem, please tell me if I should re-post this >in a netbeans forums? Yep, if same behavior occurs under JRE then this is not an openJDK/IcedTea bug. Thanks for the details, but it looks like this should be reported to netbeans after all. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Wed Jul 8 13:30:41 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Wed, 08 Jul 2009 20:30:41 +0000 Subject: [Bug 360] IDE crashes and can't continue Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=360 ------- Comment #8 from mrjava.javaman at gmail.com 2009-07-08 20:30 ------- I'm just wondering why the bug reporting tool told me to post here "giving me link to here" not to netbeans or anything similar. well netbeans itself wasn't able to handel the exception and didnt displayed any crash report or message. in all cases here is the bug re-opened at netbeans for reference: http://www.netbeans.org/issues/show_bug.cgi?id=168304 Thanks! -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From xerxes at zafena.se Thu Jul 9 03:15:23 2009 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Thu, 09 Jul 2009 12:15:23 +0200 Subject: RFC: IRBuilder shark + llvm2.6svn LLVMContext api change + shark mm Message-ID: <4A55C33B.2000003@zafena.se> This patch fixes the following build errors: /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkBuilder.cpp: In constructor 'SharkBuilder::SharkBuilder(SharkCompiler*)': /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkBuilder.cpp:65: error: no matching function for call to 'llvm::IRBuilder::IRBuilder()' /usr/local/include/llvm/Support/IRBuilder.h:56: note: candidates are: llvm::IRBuilder::IRBuilder(llvm::BasicBlock*, llvm::ilist_iterator, const T&) [with bool preserveNames = true, T = llvm::ConstantFolder] /usr/local/include/llvm/Support/IRBuilder.h:51: note: llvm::IRBuilder::IRBuilder(llvm::BasicBlock*, const T&) [with bool preserveNames = true, T = llvm::ConstantFolder] /usr/local/include/llvm/Support/IRBuilder.h:48: note: llvm::IRBuilder::IRBuilder(llvm::LLVMContext&, const T&) [with bool preserveNames = true, T = llvm::ConstantFolder] /usr/local/include/llvm/Support/IRBuilder.h:42: note: llvm::IRBuilder::IRBuilder(const llvm::IRBuilder&) make[7]: *** [sharkBuilder.o] Error 1 and /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkCompiler.cpp: In constructor 'SharkCompiler::SharkCompiler()': /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkCompiler.cpp:67: error: cannot allocate an object of abstract type 'SharkMemoryManager' /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkMemoryManager.hpp:30: note: because the following virtual functions are pure within 'SharkMemoryManager': /usr/local/include/llvm/ExecutionEngine/JITMemoryManager.h:50: note: virtual void llvm::JITMemoryManager::setPoisonMemory(bool) /usr/local/include/llvm/ExecutionEngine/JITMemoryManager.h:125: note: virtual uint8_t* llvm::JITMemoryManager::allocateGlobal(uintptr_t, unsigned int) with this patch it builds fine but... I have had a bit trouble running shark using the latest llvm svn tip. r75126 got segfaults compiling string::indexOf on ia32 Cheers Xerxes -------------- next part -------------- A non-text attachment was scrubbed... Name: IRBuilder_LLVMContext.patch Type: text/x-patch Size: 2208 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090709/eb9938b8/attachment.bin From gbenson at redhat.com Thu Jul 9 03:35:23 2009 From: gbenson at redhat.com (Gary Benson) Date: Thu, 9 Jul 2009 11:35:23 +0100 Subject: RFC: IRBuilder shark + llvm2.6svn LLVMContext api change + shark mm In-Reply-To: <4A55C33B.2000003@zafena.se> References: <4A55C33B.2000003@zafena.se> Message-ID: <20090709103522.GE3175@redhat.com> Commit away! Xerxes R?nby wrote: > This patch fixes the following build errors: > > /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkBuilder.cpp: > In constructor 'SharkBuilder::SharkBuilder(SharkCompiler*)': > /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkBuilder.cpp:65: > error: no matching function for call to 'llvm::IRBuilder llvm::ConstantFolder>::IRBuilder()' > /usr/local/include/llvm/Support/IRBuilder.h:56: note: candidates are: > llvm::IRBuilder::IRBuilder(llvm::BasicBlock*, > llvm::ilist_iterator, const T&) [with bool > preserveNames = true, T = llvm::ConstantFolder] > /usr/local/include/llvm/Support/IRBuilder.h:51: note: > llvm::IRBuilder::IRBuilder(llvm::BasicBlock*, const > T&) [with bool preserveNames = true, T = llvm::ConstantFolder] > /usr/local/include/llvm/Support/IRBuilder.h:48: note: > llvm::IRBuilder::IRBuilder(llvm::LLVMContext&, const > T&) [with bool preserveNames = true, T = llvm::ConstantFolder] > /usr/local/include/llvm/Support/IRBuilder.h:42: note: > llvm::IRBuilder::IRBuilder(const > llvm::IRBuilder&) > make[7]: *** [sharkBuilder.o] Error 1 > > and > > /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkCompiler.cpp: > In constructor 'SharkCompiler::SharkCompiler()': > /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkCompiler.cpp:67: > error: cannot allocate an object of abstract type 'SharkMemoryManager' > /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkMemoryManager.hpp:30: > note: because the following virtual functions are pure within > 'SharkMemoryManager': > /usr/local/include/llvm/ExecutionEngine/JITMemoryManager.h:50: note: > virtual void llvm::JITMemoryManager::setPoisonMemory(bool) > /usr/local/include/llvm/ExecutionEngine/JITMemoryManager.h:125: note: > virtual uint8_t* llvm::JITMemoryManager::allocateGlobal(uintptr_t, > unsigned int) > > with this patch it builds fine but... > > I have had a bit trouble running shark using the latest llvm svn tip. r75126 > got segfaults compiling string::indexOf on ia32 > > Cheers > Xerxes > Index: icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp 2009-07-09 11:02:37.000000000 +0200 > +++ icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp 2009-07-09 11:13:29.000000000 +0200 > @@ -61,7 +61,14 @@ > #endif > > SharkBuilder::SharkBuilder(SharkCompiler* compiler) > +#if SHARK_LLVM_VERSION >= 26 > + // LLVM 2.6 requires a LLVMContext during IRBuilder construction. > + // getGlobalConext() returns one that can be used as long as the shark > + // compiler are single-threaded. > + : IRBuilder<>(getGlobalContext()), > +#else > : IRBuilder<>(), > +#endif > _compiler(compiler) > { > init_external_functions(); > Index: icedtea6/ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp 2009-07-09 11:24:52.000000000 +0200 > +++ icedtea6/ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp 2009-07-09 11:32:14.000000000 +0200 > @@ -92,6 +92,11 @@ > } > > #if SHARK_LLVM_VERSION >= 26 > +uint8_t* SharkMemoryManager::allocateGlobal(uintptr_t Size, unsigned int Alignment) > +{ > + return mm()->allocateGlobal(Size, Alignment); > +} > + > void* SharkMemoryManager::getDlsymTable() const > { > return mm()->getDlsymTable(); > @@ -102,6 +107,11 @@ > mm()->SetDlsymTable(ptr); > } > > +void SharkMemoryManager::setPoisonMemory(bool poison) > +{ > + mm()->setPoisonMemory(poison); > +} > + > #endif > > #if SHARK_LLVM_VERSION >= 25 > Index: icedtea6/ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp 2009-07-09 11:14:47.000000000 +0200 > +++ icedtea6/ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp 2009-07-09 11:16:31.000000000 +0200 > @@ -74,6 +74,8 @@ > #if SHARK_LLVM_VERSION >= 26 > void* getDlsymTable() const; > void SetDlsymTable(void *ptr); > + void setPoisonMemory(bool); > + uint8_t* allocateGlobal(uintptr_t, unsigned int); > #endif > void setMemoryWritable(); > void setMemoryExecutable(); -- http://gbenson.net/ From xerxes at zafena.se Thu Jul 9 03:47:50 2009 From: xerxes at zafena.se (Xerxes R?nby) Date: Thu, 09 Jul 2009 10:47:50 +0000 Subject: changeset in /hg/icedtea6: 2009-07-09 Xerxes R?nby changeset bb7ad7d43804 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=bb7ad7d43804 description: 2009-07-09 Xerxes R?nby * ports/hotspot/src/share/vm/shark/sharkBuilder.cpp (SharkBuilder::SharkBuilder): Pass the LLVMContext returned from getGlobalContext() to the new IRBuilder constructor when llvm version are 2.6 or later to handle LLVM API change. * ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp: New methods allocateGlobal, setPoisonMemory, dependent on the llvm version. * ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp: Likewise. diffstat: 4 files changed, 31 insertions(+) ChangeLog | 12 ++++++++++++ ports/hotspot/src/share/vm/shark/sharkBuilder.cpp | 7 +++++++ ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp | 10 ++++++++++ ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp | 2 ++ diffs (76 lines): diff -r 36ad06193338 -r bb7ad7d43804 ChangeLog --- a/ChangeLog Wed Jul 08 11:28:08 2009 +0200 +++ b/ChangeLog Thu Jul 09 12:49:11 2009 +0200 @@ -1,3 +1,15 @@ 2009-07-08 Xerxes R??nby + + * ports/hotspot/src/share/vm/shark/sharkBuilder.cpp + (SharkBuilder::SharkBuilder): Pass the LLVMContext returned + from getGlobalContext() to the new IRBuilder constructor + when llvm version are 2.6 or later to handle LLVM API change. + * ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp: + New methods allocateGlobal, setPoisonMemory, dependent on the + llvm version. + * ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp: + Likewise. + 2009-07-08 Xerxes R??nby * ports/hotspot/src/share/vm/shark/sharkBuilder.hpp diff -r 36ad06193338 -r bb7ad7d43804 ports/hotspot/src/share/vm/shark/sharkBuilder.cpp --- a/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp Wed Jul 08 11:28:08 2009 +0200 +++ b/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp Thu Jul 09 12:49:11 2009 +0200 @@ -61,7 +61,14 @@ extern "C" { #endif SharkBuilder::SharkBuilder(SharkCompiler* compiler) +#if SHARK_LLVM_VERSION >= 26 + // LLVM 2.6 requires a LLVMContext during IRBuilder construction. + // getGlobalConext() returns one that can be used as long as the shark + // compiler are single-threaded. + : IRBuilder<>(getGlobalContext()), +#else : IRBuilder<>(), +#endif _compiler(compiler) { init_external_functions(); diff -r 36ad06193338 -r bb7ad7d43804 ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp --- a/ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp Wed Jul 08 11:28:08 2009 +0200 +++ b/ports/hotspot/src/share/vm/shark/sharkMemoryManager.cpp Thu Jul 09 12:49:11 2009 +0200 @@ -92,6 +92,11 @@ void SharkMemoryManager::deallocateMemFo } #if SHARK_LLVM_VERSION >= 26 +uint8_t* SharkMemoryManager::allocateGlobal(uintptr_t Size, unsigned int Alignment) +{ + return mm()->allocateGlobal(Size, Alignment); +} + void* SharkMemoryManager::getDlsymTable() const { return mm()->getDlsymTable(); @@ -100,6 +105,11 @@ void SharkMemoryManager::SetDlsymTable(v void SharkMemoryManager::SetDlsymTable(void *ptr) { mm()->SetDlsymTable(ptr); +} + +void SharkMemoryManager::setPoisonMemory(bool poison) +{ + mm()->setPoisonMemory(poison); } #endif diff -r 36ad06193338 -r bb7ad7d43804 ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp --- a/ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp Wed Jul 08 11:28:08 2009 +0200 +++ b/ports/hotspot/src/share/vm/shark/sharkMemoryManager.hpp Thu Jul 09 12:49:11 2009 +0200 @@ -74,6 +74,8 @@ class SharkMemoryManager : public llvm:: #if SHARK_LLVM_VERSION >= 26 void* getDlsymTable() const; void SetDlsymTable(void *ptr); + void setPoisonMemory(bool); + uint8_t* allocateGlobal(uintptr_t, unsigned int); #endif void setMemoryWritable(); void setMemoryExecutable(); From omajid at redhat.com Thu Jul 9 08:57:43 2009 From: omajid at redhat.com (Omair Majid) Date: Thu, 09 Jul 2009 11:57:43 -0400 Subject: RFC: Netx - Set JNLPClassloader as the classloader for system created threads Message-ID: <4A561377.2020705@redhat.com> Hi, The attached patch makes JNLPClassLoader the context classloader for threads created before the JNLP application starts. This deals with the case where the JNLP application needs a previously created thread (such as the Swing Event Dispatch Thread) to load a resource provided by the application. Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=509301 http://kenai.com/jira/browse/TRIDENT-1?focusedCommentId=15776&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_15776 ChangeLog: 2009-07-09 Omair Majid * rt/net/sourceforge/jnlp/Launcher.java (launchApplication): Call setContextClassLoaderForAllThreads. (setContextClassLoaderForAllThreads): New function. Any comments? Cheers, Omair -------------- next part -------------- A non-text attachment was scrubbed... Name: netx-classloader-all-threads.patch Type: text/x-patch Size: 2752 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090709/cb02e8c9/attachment.bin From ahughes at redhat.com Thu Jul 9 09:21:23 2009 From: ahughes at redhat.com (Andrew John Hughes) Date: Thu, 09 Jul 2009 16:21:23 +0000 Subject: changeset in /hg/icedtea: Bump to b63. Message-ID: changeset 3340f0afa232 in /hg/icedtea details: http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=3340f0afa232 description: Bump to b63. 2009-07-09 Andrew John Hughes * Makefile.am: Bump to b63 and latest IcedTea changesets. Add ANT_RESPECT_JAVA_HOME for Gentoo ant support. Support patches for PR40616 and PR40630. Only apply Scanner patches when needed. * acinclude.m4: (IT_LIBRARY_CHECK): Check for PR40616, missing PrintStream constructors in GCJ. (IT_SCANNER_CHECK): Check for PR30436, missing java.util.Scanner class. (IT_PR40630_CHECK): Check for PR40630, broken java.util.Scanner#hasNextLine(). * configure.ac: Apply new macros. * patches/ecj/icedtea-dbcs.patch: Replace java.util.Scanner in GenerateDBCS. * patches/ecj/icedtea-sbcs.patch, * patches/ecj/icedtea.patch, * patches/hotspot/default/icedtea-shark.patch, * patches/icedtea-libraries.patch, * patches/icedtea-liveconnect.patch, * patches/icedtea-webstart.patch: Recreated. diffstat: 11 files changed, 424 insertions(+), 249 deletions(-) ChangeLog | 24 +++ Makefile.am | 56 +++++--- acinclude.m4 | 101 ++++++++++++++ configure.ac | 3 patches/ecj/icedtea-dbcs.patch | 40 +++++ patches/ecj/icedtea-sbcs.patch | 12 - patches/ecj/icedtea.patch | 183 ++++++++++++--------------- patches/hotspot/default/icedtea-shark.patch | 40 ++--- patches/icedtea-libraries.patch | 90 ++++++------- patches/icedtea-liveconnect.patch | 10 - patches/icedtea-webstart.patch | 114 ++++++++-------- diffs (truncated from 1440 to 500 lines): diff -r cba3ed800419 -r 3340f0afa232 ChangeLog --- a/ChangeLog Wed Jun 24 10:31:06 2009 +0200 +++ b/ChangeLog Thu Jul 09 16:43:16 2009 +0100 @@ -1,3 +1,27 @@ 2009-06-24 Matthias Klose + + * Makefile.am: + Bump to b63 and latest IcedTea changesets. + Add ANT_RESPECT_JAVA_HOME for Gentoo ant support. + Support patches for PR40616 and PR40630. Only + apply Scanner patches when needed. + * acinclude.m4: + (IT_LIBRARY_CHECK): Check for PR40616, missing + PrintStream constructors in GCJ. + (IT_SCANNER_CHECK): Check for PR30436, missing + java.util.Scanner class. + (IT_PR40630_CHECK): Check for PR40630, broken + java.util.Scanner#hasNextLine(). + * configure.ac: Apply new macros. + * patches/ecj/icedtea-dbcs.patch: Replace java.util.Scanner + in GenerateDBCS. + * patches/ecj/icedtea-sbcs.patch, + * patches/ecj/icedtea.patch, + * patches/hotspot/default/icedtea-shark.patch, + * patches/icedtea-libraries.patch, + * patches/icedtea-liveconnect.patch, + * patches/icedtea-webstart.patch: Recreated. + 2009-06-24 Matthias Klose * patches/cacao/no-strict-aliasing.patch: Apply for configure.ac. diff -r cba3ed800419 -r 3340f0afa232 Makefile.am --- a/Makefile.am Wed Jun 24 10:31:06 2009 +0200 +++ b/Makefile.am Thu Jul 09 16:43:16 2009 +0100 @@ -1,20 +1,20 @@ OPENJDK_VERSION = b60 -OPENJDK_VERSION = b60 - -OPENJDK_CHANGESET = 472c21584cfd -CORBA_CHANGESET = e906b16a12a9 -JAXP_CHANGESET = f1ac756616ea -JAXWS_CHANGESET = 55ffcbca5f46 -JDK_CHANGESET = 1a01c90431a7 -LANGTOOLS_CHANGESET = 522520757dd3 -HOTSPOT_CHANGESET = 86092459c54d - -OPENJDK_MD5SUM = 9f5e15067cf5207760a83cea8ba41da8 -CORBA_MD5SUM = 7f00e0b5d16046d116cd53c9f43c7122 -JAXP_MD5SUM = 2de0ec54014eb7f25c811e40fc2e3e3f -JAXWS_MD5SUM = 9c0131755eefaa929ca8e47abe21cc58 -JDK_MD5SUM = 1fd637880521f3e2c274a1db8bfed89b -LANGTOOLS_MD5SUM = e7c0ac7a9d67d361cc64fc15312d4a85 -HOTSPOT_MD5SUM = 18c922319545d7e907a2d6cbb265865d +OPENJDK_VERSION = b63 + +OPENJDK_CHANGESET = 57f7e028c7ad +CORBA_CHANGESET = d20e45cd539f +JAXP_CHANGESET = ae449e9c04c1 +JAXWS_CHANGESET = 5b9e8315aab2 +JDK_CHANGESET = 6388560a8d7e +LANGTOOLS_CHANGESET = 5c2c81120555 +HOTSPOT_CHANGESET = 32c83fb84370 + +OPENJDK_MD5SUM = 01a2fe09452d8579fb251120e37dc45a +CORBA_MD5SUM = 865e397135e2b9f8e4a256b4146b6852 +JAXP_MD5SUM = 008c8971c40aca1759dd0129a025f9b8 +JAXWS_MD5SUM = 86d18ba378cb83a2bd33b334c7bd610e +JDK_MD5SUM = 68b034a7d0906a0f7b471e080b45407a +LANGTOOLS_MD5SUM = 5ff432cec3ddf86ae5dbd147da1a7f92 +HOTSPOT_MD5SUM = a97947d03665b39b806ddcf2e48b9fc8 CACAO_VERSION = 0.99.4 CACAO_MD5SUM = 63220327925ace13756ae334c55a3baa @@ -1567,6 +1567,7 @@ ICEDTEA_ENV = \ "ALT_PARALLEL_COMPILE_JOBS=$(PARALLEL_JOBS)" \ "HOTSPOT_BUILD_JOBS=$(PARALLEL_JOBS)" \ "JAVAC=" \ + "ANT_RESPECT_JAVA_HOME=TRUE" \ "RHINO_JAR=$(RHINO_JAR)" \ "DISTRIBUTION_ID=$(DIST_ID)" \ "ALT_JIBX_LIBS_PATH=$(JIBX_DEPS_DIR)" \ @@ -2479,9 +2480,7 @@ stamps/ports-ecj.stamp: stamps/clone-ecj # Patch OpenJDK for ecj/gcj builds. ICEDTEA_ECJ_PATCHES = patches/ecj/icedtea.patch \ patches/ecj/icedtea-hotspot-$(HSBUILD).patch \ - patches/ecj/icedtea-spp.patch \ patches/ecj/icedtea-jopt.patch \ - patches/ecj/icedtea-sbcs.patch \ patches/ecj/icedtea-dyn.patch if CP39408_JAVAH @@ -2490,6 +2489,25 @@ endif if CP40188_JAVAH ICEDTEA_ECJ_PATCHES += patches/ecj/icedtea-pr40188.patch +endif + +if CP40616 +ICEDTEA_ECJ_PATCHES += patches/ecj/icedtea-pr40616.patch +endif + +# Patches for when java.util.Scanner is missing +# or has the bug #40630 (all these classes rely +# on Scanner#hasNextLine() looping behaviour) +SCANNER_PATCHES = patches/ecj/icedtea-spp.patch \ + patches/ecj/icedtea-sbcs.patch \ + patches/ecj/icedtea-dbcs.patch + +if LACKS_JAVA_UTIL_SCANNER +ICEDTEA_ECJ_PATCHES += $(SCANNER_PATCHES) +else +if CP40630 +ICEDTEA_ECJ_PATCHES += $(SCANNER_PATCHES) +endif endif stamps/patch-ecj.stamp: stamps/clone-ecj.stamp diff -r cba3ed800419 -r 3340f0afa232 acinclude.m4 --- a/acinclude.m4 Wed Jun 24 10:31:06 2009 +0200 +++ b/acinclude.m4 Thu Jul 09 16:43:16 2009 +0100 @@ -1561,3 +1561,104 @@ if test "x${ADD_ZERO_BUILD_TRUE}" = x && AC_MSG_ERROR([build of additional zero/shark VM requires build with srcdir != builddir]) fi ]) + +AC_DEFUN([IT_LIBRARY_CHECK],[ +AC_CACHE_CHECK([if java.io.PrintStream is missing the 1.5 constructors (PR40616)], it_cv_cp40616, [ +CLASS=Test.java +mkdir tmp.$$ +cd tmp.$$ +cat << \EOF > $CLASS +/* [#]line __oline__ "configure" */ +public class Test +{ + public static void main(String[] args) + throws Exception + { + new java.io.PrintStream(new java.io.File("bluh"), "UTF-8"); + } +} +EOF +if $JAVAC -cp . $JAVACFLAGS $CLASS >/dev/null 2>&1; then + it_cv_cp40616=no; +else + it_cv_cp40616=yes; +fi +]) +rm -f $CLASS *.class +cd .. +rmdir tmp.$$ +AM_CONDITIONAL([CP40616], test x"${it_cv_cp40616}" = "xyes") +AC_PROVIDE([$0])dnl +]) + +AC_DEFUN([IT_SCANNER_CHECK],[ +AC_CACHE_CHECK([if java.util.Scanner is missing], it_cv_cp30436, [ +CLASS=Test.java +BYTECODE=$(echo $CLASS|sed 's#\.java##') +mkdir tmp.$$ +cd tmp.$$ +cat << \EOF > $CLASS +/* [#]line __oline__ "configure" */ +public class Test +{ + public static void main(String[] args) + throws Exception + { + new java.util.Scanner("Hello"); + } +} +EOF +if $JAVAC -cp . $JAVACFLAGS $CLASS >/dev/null 2>&1; then + if $JAVA -classpath . $BYTECODE 2>&1 | grep 'Exception'; then + it_cv_cp30436=yes; + else + it_cv_cp30436=no; + fi +else + it_cv_cp30436=yes; +fi +]) +rm -f $CLASS *.class +cd .. +rmdir tmp.$$ +AM_CONDITIONAL([LACKS_JAVA_UTIL_SCANNER], test x"${it_cv_cp30436}" = "xyes") +AC_PROVIDE([$0])dnl +]) + +AC_DEFUN([IT_PR40630_CHECK],[ +if test "x${it_cv_cp30436}" = "xno"; then + AC_CACHE_CHECK([if java.util.Scanner exhibits Classpath bug 40630], it_cv_cp40630, [ + CLASS=Test.java + mkdir tmp.$$ + cd tmp.$$ + cat << \EOF > $CLASS + /* [#]line __oline__ "configure" */ +public class Test +{ + public static void main(String[] args) + throws Exception + { + Scanner s = new Scanner("Blah\nBlah\n\nBlah\n\n"); + for (int i = 0; i < 5; ++i) + s.nextLine(); + s.hasNextLine(); + } +} +EOF + if $JAVAC -cp . $JAVACFLAGS $CLASS >/dev/null 2>&1; then + if $JAVA -classpath . $CLASS 2>&1 | grep 'Exception'; then + it_cv_cp40630=yes; + else + it_cv_cp40630=no; + fi + else + it_cv_cp40630=yes; + fi + ]) + rm -f $CLASS *.class + cd .. + rmdir tmp.$$ +fi +AM_CONDITIONAL([CP40630], test x"${it_cv_cp40630}" = "xyes") +AC_PROVIDE([$0])dnl +]) diff -r cba3ed800419 -r 3340f0afa232 configure.ac --- a/configure.ac Wed Jun 24 10:31:06 2009 +0200 +++ b/configure.ac Thu Jul 09 16:43:16 2009 +0100 @@ -290,6 +290,9 @@ fi fi fi IT_JAVAH +IT_LIBRARY_CHECK +IT_SCANNER_CHECK +IT_PR40630_CHECK FIND_RHINO_JAR WITH_OPENJDK_SRC_ZIP WITH_HOTSPOT_SRC_ZIP diff -r cba3ed800419 -r 3340f0afa232 patches/ecj/icedtea-dbcs.patch --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/patches/ecj/icedtea-dbcs.patch Thu Jul 09 16:43:16 2009 +0100 @@ -0,0 +1,40 @@ +diff -Nru openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java +--- openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java 2009-07-08 18:00:55.000000000 +0100 ++++ openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java 2009-07-08 23:45:44.000000000 +0100 +@@ -27,7 +27,6 @@ + import java.io.*; + import java.util.Arrays; + import java.util.ArrayList; +-import java.util.Scanner; + import java.util.Formatter; + import java.util.regex.*; + import java.nio.charset.*; +@@ -38,9 +37,8 @@ + static Pattern mPattern = Pattern.compile("(\\p{XDigit}++)\\s++(\\p{XDigit}++)(\\s++#.*)?"); + public static void genDBCS(String args[]) throws Exception { + +- Scanner s = new Scanner(new File(args[0], args[2])); +- while (s.hasNextLine()) { +- String line = s.nextLine(); ++ BufferedReader s = new BufferedReader(new FileReader(new File(args[0], args[2]))); ++ for (String line = s.readLine(); line != null; line = s.readLine()) { + if (line.startsWith("#") || line.length() == 0) + continue; + String[] fields = line.split("\\s+"); +@@ -239,14 +237,13 @@ + String b2cNR = b2cNRSB.toString(); + String c2bNR = c2bNRSB.toString(); + +- Scanner s = new Scanner(new File(srcDir, template)); ++ BufferedReader s = new BufferedReader(new FileReader(new File(srcDir, template))); + PrintStream out = new PrintStream(new FileOutputStream( + new File(dstDir, clzName + ".java"))); + if (hisName == null) + hisName = ""; + +- while (s.hasNextLine()) { +- String line = s.nextLine(); ++ for (String line = s.readLine(); line != null; line = s.readLine()) { + if (line.indexOf("$") == -1) { + out.println(line); + continue; diff -r cba3ed800419 -r 3340f0afa232 patches/ecj/icedtea-sbcs.patch --- a/patches/ecj/icedtea-sbcs.patch Wed Jun 24 10:31:06 2009 +0200 +++ b/patches/ecj/icedtea-sbcs.patch Thu Jul 09 16:43:16 2009 +0100 @@ -1,6 +1,6 @@ diff -Nru openjdk-ecj.orig/jdk/make/tool diff -Nru openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateSBCS.java openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateSBCS.java ---- openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateSBCS.java 2009-01-18 03:30:42.000000000 +0000 -+++ openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateSBCS.java 2009-01-19 00:55:58.000000000 +0000 +--- openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateSBCS.java 2009-07-01 11:39:50.000000000 +0100 ++++ openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateSBCS.java 2009-07-01 12:24:04.000000000 +0100 @@ -27,7 +27,6 @@ import java.io.*; @@ -9,9 +9,9 @@ diff -Nru openjdk-ecj.orig/jdk/make/tool import java.util.Formatter; import java.util.regex.*; import java.nio.charset.*; -@@ -40,9 +39,8 @@ - System.exit(1); - } +@@ -37,9 +36,8 @@ + + public static void genSBCS(String args[]) throws Exception { - Scanner s = new Scanner(new File(args[0], args[2])); - while (s.hasNextLine()) { @@ -21,7 +21,7 @@ diff -Nru openjdk-ecj.orig/jdk/make/tool if (line.startsWith("#") || line.length() == 0) continue; String[] fields = line.split("\\s+"); -@@ -201,12 +199,10 @@ +@@ -198,12 +196,10 @@ int c2blen) throws Exception { diff -r cba3ed800419 -r 3340f0afa232 patches/ecj/icedtea.patch --- a/patches/ecj/icedtea.patch Wed Jun 24 10:31:06 2009 +0200 +++ b/patches/ecj/icedtea.patch Thu Jul 09 16:43:16 2009 +0100 @@ -1,6 +1,6 @@ diff -Nru openjdk-ecj.orig/corba/make/co diff -Nru openjdk-ecj.orig/corba/make/com/sun/corba/se/Makefile openjdk-ecj/corba/make/com/sun/corba/se/Makefile --- openjdk-ecj.orig/corba/make/com/sun/corba/se/Makefile 2009-03-30 17:13:01.000000000 +0100 -+++ openjdk-ecj/corba/make/com/sun/corba/se/Makefile 2009-06-15 17:19:32.000000000 +0100 ++++ openjdk-ecj/corba/make/com/sun/corba/se/Makefile 2009-07-01 13:52:45.000000000 +0100 @@ -42,7 +42,7 @@ # the rmic iiop backend needs some classes that are part of the impl/util # package. These classes use log wrappers, so they must be built after @@ -12,7 +12,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co diff -Nru openjdk-ecj.orig/corba/make/com/sun/corba/se/org/Makefile openjdk-ecj/corba/make/com/sun/corba/se/org/Makefile --- openjdk-ecj.orig/corba/make/com/sun/corba/se/org/Makefile 1970-01-01 01:00:00.000000000 +0100 -+++ openjdk-ecj/corba/make/com/sun/corba/se/org/Makefile 2009-05-28 09:03:57.000000000 +0100 ++++ openjdk-ecj/corba/make/com/sun/corba/se/org/Makefile 2009-07-01 13:52:45.000000000 +0100 @@ -0,0 +1,38 @@ +# +# Copyright 2001-2005 Sun Microsystems, Inc. All Rights Reserved. @@ -54,7 +54,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co +include $(BUILDDIR)/common/Classes.gmk diff -Nru openjdk-ecj.orig/corba/make/common/Defs.gmk openjdk-ecj/corba/make/common/Defs.gmk --- openjdk-ecj.orig/corba/make/common/Defs.gmk 2009-03-30 17:13:01.000000000 +0100 -+++ openjdk-ecj/corba/make/common/Defs.gmk 2009-06-15 17:19:32.000000000 +0100 ++++ openjdk-ecj/corba/make/common/Defs.gmk 2009-07-01 13:52:45.000000000 +0100 @@ -53,6 +53,13 @@ _OUTPUTDIR=$(TOPDIR)/build/$(PLATFORM)-$(ARCH) @@ -88,8 +88,8 @@ diff -Nru openjdk-ecj.orig/corba/make/co vpath %.java $(VPATH.java) vpath %.class $(CLASSBINDIR) diff -Nru openjdk-ecj.orig/corba/make/common/Defs-linux.gmk openjdk-ecj/corba/make/common/Defs-linux.gmk ---- openjdk-ecj.orig/corba/make/common/Defs-linux.gmk 2009-06-15 17:14:30.000000000 +0100 -+++ openjdk-ecj/corba/make/common/Defs-linux.gmk 2009-06-15 17:19:32.000000000 +0100 +--- openjdk-ecj.orig/corba/make/common/Defs-linux.gmk 2009-07-01 13:42:16.000000000 +0100 ++++ openjdk-ecj/corba/make/common/Defs-linux.gmk 2009-07-01 13:52:45.000000000 +0100 @@ -276,7 +276,7 @@ fi; \ done) @@ -101,7 +101,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co # We want to privatize JVM symbols on Solaris. This is so the user can diff -Nru openjdk-ecj.orig/corba/make/common/Rules.gmk openjdk-ecj/corba/make/common/Rules.gmk --- openjdk-ecj.orig/corba/make/common/Rules.gmk 2009-03-30 23:07:09.000000000 +0100 -+++ openjdk-ecj/corba/make/common/Rules.gmk 2009-06-15 17:19:32.000000000 +0100 ++++ openjdk-ecj/corba/make/common/Rules.gmk 2009-07-01 13:52:45.000000000 +0100 @@ -201,8 +201,10 @@ $(ECHO) "# Java sources to be compiled: (listed in file $(JAVA_SOURCE_LIST))"; \ $(CAT) $(JAVA_SOURCE_LIST); \ @@ -117,7 +117,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co diff -Nru openjdk-ecj.orig/corba/make/common/shared/Defs-java.gmk openjdk-ecj/corba/make/common/shared/Defs-java.gmk --- openjdk-ecj.orig/corba/make/common/shared/Defs-java.gmk 2009-03-30 23:07:09.000000000 +0100 -+++ openjdk-ecj/corba/make/common/shared/Defs-java.gmk 2009-06-15 17:19:32.000000000 +0100 ++++ openjdk-ecj/corba/make/common/shared/Defs-java.gmk 2009-07-01 13:52:45.000000000 +0100 @@ -120,31 +120,14 @@ JAVACFLAGS += $(OTHER_JAVACFLAGS) @@ -158,7 +158,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co ifdef JAVAC diff -Nru openjdk-ecj.orig/corba/make/org/omg/sources/Makefile openjdk-ecj/corba/make/org/omg/sources/Makefile --- openjdk-ecj.orig/corba/make/org/omg/sources/Makefile 2009-03-30 17:13:01.000000000 +0100 -+++ openjdk-ecj/corba/make/org/omg/sources/Makefile 2009-06-15 17:19:32.000000000 +0100 ++++ openjdk-ecj/corba/make/org/omg/sources/Makefile 2009-07-01 13:52:45.000000000 +0100 @@ -93,8 +93,6 @@ POAHELHOLFILES = $(POA_GENERATED_HELP_HOL_java:%=$(GENSRCDIR)/%) @@ -237,7 +237,7 @@ diff -Nru openjdk-ecj.orig/corba/make/or diff -Nru openjdk-ecj.orig/corba/make/sun/rmi/corbalogsources/Makefile openjdk-ecj/corba/make/sun/rmi/corbalogsources/Makefile --- openjdk-ecj.orig/corba/make/sun/rmi/corbalogsources/Makefile 2009-03-30 23:07:09.000000000 +0100 -+++ openjdk-ecj/corba/make/sun/rmi/corbalogsources/Makefile 2009-06-15 17:19:32.000000000 +0100 ++++ openjdk-ecj/corba/make/sun/rmi/corbalogsources/Makefile 2009-07-01 13:52:45.000000000 +0100 @@ -172,7 +172,6 @@ ACTIVATIONFILES = $(com_sun_corba_se_spi_activation_java:%=$(GENSRCDIR)/%) @@ -255,8 +255,8 @@ diff -Nru openjdk-ecj.orig/corba/make/su portableactivation.idl.compile: $(PORTABLEACTIVATIONFILES) diff -Nru openjdk-ecj.orig/jaxp/make/build.xml openjdk-ecj/jaxp/make/build.xml ---- openjdk-ecj.orig/jaxp/make/build.xml 2009-06-15 14:57:04.000000000 +0100 -+++ openjdk-ecj/jaxp/make/build.xml 2009-06-15 17:21:10.000000000 +0100 +--- openjdk-ecj.orig/jaxp/make/build.xml 2009-06-30 14:24:48.000000000 +0100 ++++ openjdk-ecj/jaxp/make/build.xml 2009-07-01 13:55:31.000000000 +0100 @@ -71,7 +71,10 @@ -@@ -86,7 +89,9 @@ - memoryInitialSize="${javac.memoryInitialSize}" +@@ -87,7 +90,8 @@ memoryMaximumSize="${javac.memoryMaximumSize}" + source="${javac.source}" debug="${javac.debug}" - target="${javac.target}"> + target="${javac.target}" -+ executable="${javac.executable}" -+ source="1.5"> ++ executable="${javac.executable}"> diff -Nru openjdk-ecj.orig/jaxp/make/Makefile openjdk-ecj/jaxp/make/Makefile ---- openjdk-ecj.orig/jaxp/make/Makefile 2009-06-15 17:14:26.000000000 +0100 -+++ openjdk-ecj/jaxp/make/Makefile 2009-06-15 17:19:32.000000000 +0100 -@@ -84,7 +84,7 @@ - endif +--- openjdk-ecj.orig/jaxp/make/Makefile 2009-07-01 13:42:16.000000000 +0100 ++++ openjdk-ecj/jaxp/make/Makefile 2009-07-01 13:52:45.000000000 +0100 +@@ -92,7 +92,7 @@ + endif ifdef ALT_BOOTDIR - ANT_JAVA_HOME = JAVA_HOME=$(ALT_BOOTDIR) @@ -293,9 +292,9 @@ diff -Nru openjdk-ecj.orig/jaxp/make/Mak ifdef ALT_OUTPUTDIR diff -Nru openjdk-ecj.orig/jaxws/make/build.properties openjdk-ecj/jaxws/make/build.properties ---- openjdk-ecj.orig/jaxws/make/build.properties 2009-06-15 17:14:30.000000000 +0100 -+++ openjdk-ecj/jaxws/make/build.properties 2009-06-15 17:19:32.000000000 +0100 -@@ -36,7 +36,7 @@ +--- openjdk-ecj.orig/jaxws/make/build.properties 2009-07-01 13:42:16.000000000 +0100 ++++ openjdk-ecj/jaxws/make/build.properties 2009-07-01 13:52:45.000000000 +0100 +@@ -37,7 +37,7 @@ # set the following to -version to verify the versions of javac being used javac.version.opt = # in time, there should be no exceptions to -Xlint:all @@ -305,8 +304,8 @@ diff -Nru openjdk-ecj.orig/jaxws/make/bu # JVM memory size javac.memoryInitialSize = 128m diff -Nru openjdk-ecj.orig/jaxws/make/build.xml openjdk-ecj/jaxws/make/build.xml ---- openjdk-ecj.orig/jaxws/make/build.xml 2009-06-15 14:57:13.000000000 +0100 -+++ openjdk-ecj/jaxws/make/build.xml 2009-06-15 17:22:06.000000000 +0100 +--- openjdk-ecj.orig/jaxws/make/build.xml 2009-06-30 14:24:56.000000000 +0100 ++++ openjdk-ecj/jaxws/make/build.xml 2009-07-01 13:52:45.000000000 +0100 @@ -93,7 +93,10 @@ -@@ -105,11 +108,14 @@ - -+ excludes="com/sun/tools/internal/txw2/**" -+ source="1.5"> -+ + excludes="com/sun/tools/internal/txw2/**"> ++ diff -Nru openjdk-ecj.orig/jaxws/make/Makefile openjdk-ecj/jaxws/make/Makefile ---- openjdk-ecj.orig/jaxws/make/Makefile 2009-06-15 17:14:26.000000000 +0100 -+++ openjdk-ecj/jaxws/make/Makefile 2009-06-15 17:19:32.000000000 +0100 -@@ -84,8 +84,8 @@ - endif +--- openjdk-ecj.orig/jaxws/make/Makefile 2009-07-01 13:42:16.000000000 +0100 ++++ openjdk-ecj/jaxws/make/Makefile 2009-07-01 13:52:45.000000000 +0100 +@@ -92,8 +92,8 @@ + endif ifdef ALT_BOOTDIR - ANT_OPTIONS += -Dplugs=$(ALT_BINARY_PLUGS_PATH) @@ -351,7 +342,7 @@ diff -Nru openjdk-ecj.orig/jaxws/make/Ma ifdef ALT_OUTPUTDIR diff -Nru openjdk-ecj.orig/jdk/make/common/BuildToolJar.gmk openjdk-ecj/jdk/make/common/BuildToolJar.gmk --- openjdk-ecj.orig/jdk/make/common/BuildToolJar.gmk 2009-03-30 17:23:03.000000000 +0100 -+++ openjdk-ecj/jdk/make/common/BuildToolJar.gmk 2009-06-15 17:19:32.000000000 +0100 ++++ openjdk-ecj/jdk/make/common/BuildToolJar.gmk 2009-07-01 13:52:45.000000000 +0100 @@ -43,7 +43,8 @@ @$(prep-target) @$(MKDIR) -p $(BUILDTOOLCLASSDIR) From omajid at redhat.com Thu Jul 9 11:34:14 2009 From: omajid at redhat.com (Omair Majid) Date: Thu, 09 Jul 2009 14:34:14 -0400 Subject: RFC: Netx/Plugin - Add support for pack200 and gzip compression Message-ID: <4A563826.3010406@redhat.com> Hi, The attached patch adds support for pack200 and gzip compression to Netx and plugin. ChangeLog: 2009-07-09 Omair Majid * rt/net/sourceforge/jnlp/cache/ResourceTracker.java (downloadResource): Accept and download content with pack200 or gzip compression and uncompress it on the fly. (initializeResource): Accept content with pack200 or gzip compression. (getVersionedResourceURL): Add javadoc. Any comments? Cheers, Omair -------------- next part -------------- A non-text attachment was scrubbed... Name: icedtea-pack200.patch Type: text/x-patch Size: 6783 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090709/b28e2c96/attachment.bin From dbhole at redhat.com Thu Jul 9 11:41:30 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Thu, 9 Jul 2009 14:41:30 -0400 Subject: RFC: Rewrite of cookie support in plugin In-Reply-To: <20090707203928.GB6352@redhat.com> References: <20090703214931.GB28859@redhat.com> <20090703223003.GA21560@redhat.com> <4A53A6A9.1030802@redhat.com> <20090707202658.GA6352@redhat.com> <20090707203928.GB6352@redhat.com> Message-ID: <20090709184130.GB18099@redhat.com> * Deepak Bhole [2009-07-07 16:37]: > * Deepak Bhole [2009-07-07 16:25]: > > * Omair Majid [2009-07-07 15:48]: > > > Hi, > > > > > > Deepak Bhole wrote: > > >> Oops. Original message is missing 2 new files from the patch. Sorry > > >> about that. New patch attached. > > >> Patch has been approved by Omair. Posting final version for reference. Deepak -------------- next part -------------- A non-text attachment was scrubbed... Name: ITP-cookie-support-rewrite.patch Type: text/x-patch Size: 25008 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090709/26387308/attachment.bin From dbhole at redhat.com Thu Jul 9 11:38:21 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Thu, 09 Jul 2009 18:38:21 +0000 Subject: changeset in /hg/icedtea6: Rewrote cookie support for the plugin... Message-ID: changeset a50daec5fab4 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=a50daec5fab4 description: Rewrote cookie support for the plugin so that cookies are aquired dynamically from Mozilla for each http/https connection. diffstat: 16 files changed, 127 insertions(+), 108 deletions(-) ChangeLog | 16 ++++ IcedTeaPlugin.cc | 52 ++++++++++--- plugin/icedtea/sun/applet/PluginAppletViewer.java | 57 +++++++++------ plugin/icedtea/sun/applet/PluginCallRequestFactory.java | 2 plugin/icedtea/sun/applet/PluginMain.java | 6 + rt/net/sourceforge/jnlp/ExtensionDesc.java | 16 ---- rt/net/sourceforge/jnlp/JNLPFile.java | 27 ++----- rt/net/sourceforge/jnlp/Launcher.java | 6 - rt/net/sourceforge/jnlp/NetxPanel.java | 5 - rt/net/sourceforge/jnlp/Parser.java | 2 rt/net/sourceforge/jnlp/PluginBridge.java | 3 rt/net/sourceforge/jnlp/cache/CacheUtil.java | 4 - rt/net/sourceforge/jnlp/cache/Resource.java | 17 ---- rt/net/sourceforge/jnlp/cache/ResourceTracker.java | 10 -- rt/net/sourceforge/jnlp/runtime/Boot.java | 2 rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java | 10 +- diffs (truncated from 645 to 500 lines): diff -r bb7ad7d43804 -r a50daec5fab4 ChangeLog --- a/ChangeLog Thu Jul 09 12:49:11 2009 +0200 +++ b/ChangeLog Thu Jul 09 14:42:44 2009 -0400 @@ -1,3 +1,19 @@ 2009-07-09 Xerxes R??nby + + * IcedTeaPlugin.cc: Add suppport for cookie info requests from applets. + * plugin/icedtea/sun/applet/PluginAppletViewer.java: Rework cookie support + to make it dynamic. + * plugin/icedtea/sun/applet/PluginMain.java: Wire in custom cookie store + that dynamically requests cookie information from C++ side. + * rt/net/sourceforge/jnlp/JNLPFile.java: Remove old cookie handling code. + * rt/net/sourceforge/jnlp/Launcher.java: Same. + * rt/net/sourceforge/jnlp/NetxPanel.java: Same. + * rt/net/sourceforge/jnlp/PluginBridge.java: Same. + * rt/net/sourceforge/jnlp/cache/CacheUtil.java: Same. + * rt/net/sourceforge/jnlp/cache/Resource.java: Same. + * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: Same. + * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Same. + 2009-07-09 Xerxes R??nby * ports/hotspot/src/share/vm/shark/sharkBuilder.cpp diff -r bb7ad7d43804 -r a50daec5fab4 IcedTeaPlugin.cc --- a/IcedTeaPlugin.cc Thu Jul 09 12:49:11 2009 +0200 +++ b/IcedTeaPlugin.cc Thu Jul 09 14:42:44 2009 -0400 @@ -1012,6 +1012,7 @@ private: void ProcessMessage(); void ConsumeMsgFromJVM(); nsresult GetProxyInfo(const char* siteAddr, char** proxyScheme, char** proxyHost, char** proxyPort); + nsresult GetCookieInfo(const char* siteAddr, char** cookieString); nsCOMPtr sink; nsCOMPtr transport; nsCOMPtr applet_viewer_process; @@ -1070,7 +1071,6 @@ private: IcedTeaPluginFactory* factory; PRUint32 instance_identifier; nsCString instanceIdentifierPrefix; - nsresult GetCookie(const char* siteAddr, char** cookieString); }; @@ -2380,16 +2380,6 @@ IcedTeaPluginInstance::Initialize (nsIPl encodedAppletTag += tagMessage.get()[i]; } - nsCString cookieInfo(instanceIdentifierPrefix); - cookieInfo += "cookie "; - - char* cookieString; - if (GetCookie(documentbase, &cookieString) == NS_OK) - { - cookieInfo += cookieString; - } - - factory->SendMessageToAppletViewer (cookieInfo); factory->SendMessageToAppletViewer (encodedAppletTag); // Set back-pointer to peer instance. @@ -2760,8 +2750,15 @@ IcedTeaPluginFactory::GetProxyInfo(const return NS_OK; } -NS_IMETHODIMP -IcedTeaPluginInstance::GetCookie(const char* siteAddr, char** cookieString) +/** + * Returns the cookie information for the given url + * + * @param siteAddr The URI to check (must be decoded) + * @return cookieString The cookie string for the given URI + */ + +NS_IMETHODIMP +IcedTeaPluginFactory::GetCookieInfo(const char* siteAddr, char** cookieString) { nsresult rv; @@ -3497,6 +3494,35 @@ IcedTeaPluginFactory::HandleMessage (nsC // free allocated memory delete proxyScheme, proxyHost, proxyPort; + + } else if (command == "PluginCookieInfo") + { + + nsresult rv; + nsCOMPtr net_util = do_GetService(NS_NETUTIL_CONTRACTID, &rv); + + if (!net_util) + printf("Error instantiating NetUtil service.\n"); + + // decode the url + nsDependentCSubstring url; + net_util->UnescapeString(rest, 0, url); + + nsCString cookieInfo("plugin PluginCookieInfo "); + cookieInfo += rest; + cookieInfo += " "; + + char* cookieString; + if (GetCookieInfo(((nsCString) url).get(), &cookieString) == NS_OK) + { + cookieInfo += cookieString; + PLUGIN_DEBUG_2ARG("Cookie for %s is %s\n", ((nsCString) url).get(), cookieString); + } else { + PLUGIN_DEBUG_1ARG("No cookie found for %s\n", ((nsCString) url).get()); + } + + // send back what we found + SendMessageToAppletViewer (cookieInfo); } } diff -r bb7ad7d43804 -r a50daec5fab4 plugin/icedtea/sun/applet/PluginAppletViewer.java --- a/plugin/icedtea/sun/applet/PluginAppletViewer.java Thu Jul 09 12:49:11 2009 +0200 +++ b/plugin/icedtea/sun/applet/PluginAppletViewer.java Thu Jul 09 14:42:44 2009 -0400 @@ -84,6 +84,7 @@ import java.io.PrintStream; import java.io.PrintStream; import java.io.Reader; import java.io.StringReader; +import java.io.UnsupportedEncodingException; import java.lang.reflect.InvocationTargetException; import java.net.MalformedURLException; import java.net.SocketPermission; @@ -180,9 +181,6 @@ import com.sun.jndi.toolkit.url.UrlUtil; private static PluginStreamHandler streamhandler; private static PluginCallRequestFactory requestFactory; - - private static HashMap siteCookies = - new HashMap(); private static HashMap status = new HashMap(); @@ -226,7 +224,7 @@ import com.sun.jndi.toolkit.url.UrlUtil; AccessController.doPrivileged(new PrivilegedAction() { public Object run() { try { - panel = new NetxPanel(doc, siteCookies.get(identifier), atts, false); + panel = new NetxPanel(doc, atts, false); AppletViewerPanel.debug("Using NetX panel"); PluginDebug.debug(atts.toString()); } catch (Exception ex) { @@ -483,16 +481,6 @@ import com.sun.jndi.toolkit.url.UrlUtil; PluginDebug.debug ("REQUEST TAG NOT SET: " + request.tag + ". BYPASSING"); } } - } else if (message.startsWith("cookie")) { - - int cookieStrIndex = message.indexOf(" "); - String cookieStr = null; - - if (cookieStrIndex > 0) - cookieStr = message.substring(cookieStrIndex); - - // Always set the cookie -- even if it is null - siteCookies.put(identifier, cookieStr); } else { PluginDebug.debug ("Handling message: " + message + " instance " + identifier + " " + Thread.currentThread()); @@ -842,7 +830,6 @@ import com.sun.jndi.toolkit.url.UrlUtil; * applets on this page. */ public Enumeration getApplets() { - AppletSecurity security = (AppletSecurity)System.getSecurityManager(); Vector v = new Vector(); SocketPermission panelSp = new SocketPermission(panel.getCodeBase().getHost(), "connect"); @@ -896,7 +883,7 @@ import com.sun.jndi.toolkit.url.UrlUtil; // streamhandler.pluginOutputStream has been closed. } } - + public long getWindow() { PluginDebug.debug ("STARTING getWindow"); PluginCallRequest request = requestFactory.getPluginCallRequest("window", @@ -1113,6 +1100,40 @@ import com.sun.jndi.toolkit.url.UrlUtil; return request.getObject(); } + public static Object requestPluginCookieInfo(URI uri) { + + PluginCallRequest request; + try + { + String encodedURI = UrlUtil.encode(uri.toString(), "UTF-8"); + request = requestFactory.getPluginCallRequest("cookieinfo", + "plugin PluginCookieInfo " + encodedURI, + "plugin PluginCookieInfo " + encodedURI); + + } catch (UnsupportedEncodingException e) + { + e.printStackTrace(); + return null; + } + + streamhandler.postCallRequest(request); + streamhandler.write(request.getMessage()); + try { + PluginDebug.debug ("wait cookieinfo request 1"); + synchronized(request) { + PluginDebug.debug ("wait cookieinfo request 2"); + while (request.isDone() == false) + request.wait(); + PluginDebug.debug ("wait cookieinfo request 3"); + } + } catch (InterruptedException e) { + throw new RuntimeException("Interrupted waiting for cookieinfo request.", + e); + } + PluginDebug.debug (" Cookieinfo DONE"); + return request.getObject(); + } + public static Object requestPluginProxyInfo(URI uri) { String requestURI = null; @@ -1623,10 +1644,6 @@ import com.sun.jndi.toolkit.url.UrlUtil; public static void parse(int identifier, long handle, Reader in, URL url) throws IOException { - // wait until cookie is set (even if cookie is null, it needs to be - // "set" to that first - while (!siteCookies.containsKey(identifier)); - final int fIdentifier = identifier; final long fHandle = handle; final Reader fIn = in; diff -r bb7ad7d43804 -r a50daec5fab4 plugin/icedtea/sun/applet/PluginCallRequestFactory.java --- a/plugin/icedtea/sun/applet/PluginCallRequestFactory.java Thu Jul 09 12:49:11 2009 +0200 +++ b/plugin/icedtea/sun/applet/PluginCallRequestFactory.java Thu Jul 09 14:42:44 2009 -0400 @@ -51,6 +51,8 @@ public class PluginCallRequestFactory { return new GetWindowPluginCallRequest(message, returnString); } else if (id == "proxyinfo") { return new PluginProxyInfoRequest(message, returnString); + } else if (id == "cookieinfo") { + return new PluginCookieInfoRequest(message, returnString); } else { throw new RuntimeException ("Unknown plugin call request type requested from factory"); } diff -r bb7ad7d43804 -r a50daec5fab4 plugin/icedtea/sun/applet/PluginMain.java --- a/plugin/icedtea/sun/applet/PluginMain.java Thu Jul 09 12:49:11 2009 +0200 +++ b/plugin/icedtea/sun/applet/PluginMain.java Thu Jul 09 14:42:44 2009 -0400 @@ -68,10 +68,11 @@ import java.io.IOException; import java.io.IOException; import java.io.PrintStream; import java.net.Authenticator; +import java.net.CookieHandler; +import java.net.CookieManager; import java.net.PasswordAuthentication; import java.net.ProxySelector; import java.util.Enumeration; -import java.util.HashMap; import java.util.Properties; import javax.net.ssl.HttpsURLConnection; @@ -218,6 +219,9 @@ public class PluginMain // plug in a custom authenticator and proxy selector Authenticator.setDefault(new CustomAuthenticator()); ProxySelector.setDefault(new PluginProxySelector()); + + CookieManager ckManager = new CookieManager(new PluginCookieStore(), null); + CookieHandler.setDefault(ckManager); } static boolean messageAvailable() { diff -r bb7ad7d43804 -r a50daec5fab4 rt/net/sourceforge/jnlp/ExtensionDesc.java --- a/rt/net/sourceforge/jnlp/ExtensionDesc.java Thu Jul 09 12:49:11 2009 +0200 +++ b/rt/net/sourceforge/jnlp/ExtensionDesc.java Thu Jul 09 14:42:44 2009 -0400 @@ -40,9 +40,6 @@ public class ExtensionDesc { /** the location of the extension JNLP file */ private URL location; - - /** the cookie string sent with resource requests */ - private String cookieStr; /** the JNLPFile the extension refers to */ private JNLPFile file; @@ -61,11 +58,10 @@ public class ExtensionDesc { * @param version the required version of the extention JNLPFile * @param location the location of the extention JNLP file */ - public ExtensionDesc(String name, Version version, URL location, String cookieStr) { + public ExtensionDesc(String name, Version version, URL location) { this.name = name; this.version = version; this.location = location; - this.cookieStr = cookieStr; } /** @@ -125,7 +121,7 @@ public class ExtensionDesc { */ public void resolve() throws ParseException, IOException { if (file == null) { - file = new JNLPFile(location, cookieStr); + file = new JNLPFile(location); if (JNLPRuntime.isDebug()) System.out.println("Resolve: "+file.getInformation().getTitle()); @@ -144,14 +140,6 @@ public class ExtensionDesc { public JNLPFile getJNLPFile() { return file; } - - /** - * Returns the cookie associated with this instance - */ - public String getCookieStr() { - return cookieStr; - } - } diff -r bb7ad7d43804 -r a50daec5fab4 rt/net/sourceforge/jnlp/JNLPFile.java --- a/rt/net/sourceforge/jnlp/JNLPFile.java Thu Jul 09 12:49:11 2009 +0200 +++ b/rt/net/sourceforge/jnlp/JNLPFile.java Thu Jul 09 14:42:44 2009 -0400 @@ -69,9 +69,6 @@ public class JNLPFile { /** the URL used to resolve relative URLs in the file */ protected URL codeBase; - - /** cookie string to send alongwith resource requests */ - protected String cookieStr; /** file version */ protected Version fileVersion; @@ -127,8 +124,8 @@ public class JNLPFile { * @throws IOException if an IO exception occurred * @throws ParseException if the JNLP file was invalid */ - public JNLPFile(URL location, String cookieStr) throws IOException, ParseException { - this(location, cookieStr, false); // not strict + public JNLPFile(URL location) throws IOException, ParseException { + this(location, false); // not strict } /** @@ -140,8 +137,8 @@ public class JNLPFile { * @throws IOException if an IO exception occurred * @throws ParseException if the JNLP file was invalid */ - public JNLPFile(URL location, String cookieStr, boolean strict) throws IOException, ParseException { - this(location, cookieStr, strict, JNLPRuntime.getDefaultUpdatePolicy()); + public JNLPFile(URL location, boolean strict) throws IOException, ParseException { + this(location, strict, JNLPRuntime.getDefaultUpdatePolicy()); } /** @@ -154,12 +151,11 @@ public class JNLPFile { * @throws IOException if an IO exception occurred * @throws ParseException if the JNLP file was invalid */ - public JNLPFile(URL location, String cookieStr, boolean strict, UpdatePolicy policy) throws IOException, ParseException { - Node root = Parser.getRootNode(openURL(location, cookieStr, policy)); + public JNLPFile(URL location, boolean strict, UpdatePolicy policy) throws IOException, ParseException { + Node root = Parser.getRootNode(openURL(location, policy)); parse(root, strict, location); this.fileLocation = location; - this.cookieStr = cookieStr; } /** @@ -190,13 +186,13 @@ public class JNLPFile { * Open the jnlp file URL from the cache if there, otherwise * download to the cache. Called from constructor. */ - private static InputStream openURL(URL location, String cookieStr, UpdatePolicy policy) throws IOException { + private static InputStream openURL(URL location, UpdatePolicy policy) throws IOException { if (location == null || policy == null) throw new IllegalArgumentException(R("NullParameter")); try { ResourceTracker tracker = new ResourceTracker(false); // no prefetch - tracker.addResource(location, cookieStr, null/*version*/, policy); + tracker.addResource(location, null/*version*/, policy); return tracker.getInputStream(location); } @@ -255,13 +251,6 @@ public class JNLPFile { */ public URL getCodeBase() { return codeBase; - } - - /** - * Returns the cookie string that will be send when resources for this file are requested - */ - public String getCookieStr() { - return cookieStr; } /** diff -r bb7ad7d43804 -r a50daec5fab4 rt/net/sourceforge/jnlp/Launcher.java --- a/rt/net/sourceforge/jnlp/Launcher.java Thu Jul 09 12:49:11 2009 +0200 +++ b/rt/net/sourceforge/jnlp/Launcher.java Thu Jul 09 14:42:44 2009 -0400 @@ -335,10 +335,10 @@ public class Launcher { JNLPFile file = null; try { - file = new JNLPFile(location, null, true, updatePolicy); // strict + file = new JNLPFile(location, true, updatePolicy); // strict } catch (ParseException ex) { - file = new JNLPFile(location, null, false, updatePolicy); + file = new JNLPFile(location, false, updatePolicy); // only here if strict failed but lax did not fail LaunchException lex = @@ -389,7 +389,7 @@ public class Launcher { IconDesc.SPLASH, preferredWidth, preferredHeight); if (splashImageURL != null) { ResourceTracker resourceTracker = new ResourceTracker(true); - resourceTracker.addResource(splashImageURL, "SPLASH", file.getFileVersion(), updatePolicy); + resourceTracker.addResource(splashImageURL, file.getFileVersion(), updatePolicy); splashScreen = new JNLPSplashScreen(resourceTracker, null, null); splashScreen.setSplashImageURL(splashImageURL); if (splashScreen.isSplashScreenValid()) { diff -r bb7ad7d43804 -r a50daec5fab4 rt/net/sourceforge/jnlp/NetxPanel.java --- a/rt/net/sourceforge/jnlp/NetxPanel.java Thu Jul 09 12:49:11 2009 +0200 +++ b/rt/net/sourceforge/jnlp/NetxPanel.java Thu Jul 09 14:42:44 2009 -0400 @@ -41,7 +41,6 @@ public class NetxPanel extends AppletVie private PluginBridge bridge = null; private boolean exitOnFailure = true; private AppletInstance appInst = null; - private String cookieStr; private boolean appletAlive; public NetxPanel(URL documentURL, Hashtable atts) @@ -50,11 +49,10 @@ public class NetxPanel extends AppletVie } // overloaded constructor, called when initialized via plugin - public NetxPanel(URL documentURL, String cookieStr, Hashtable atts, boolean exitOnFailure) + public NetxPanel(URL documentURL, Hashtable atts, boolean exitOnFailure) { this(documentURL, atts); this.exitOnFailure = exitOnFailure; - this.cookieStr = cookieStr; this.appletAlive = true; } @@ -64,7 +62,6 @@ public class NetxPanel extends AppletVie try { bridge = new PluginBridge(baseURL, - cookieStr, getDocumentBase(), getJarFiles(), getCode(), diff -r bb7ad7d43804 -r a50daec5fab4 rt/net/sourceforge/jnlp/Parser.java --- a/rt/net/sourceforge/jnlp/Parser.java Thu Jul 09 12:49:11 2009 +0200 +++ b/rt/net/sourceforge/jnlp/Parser.java Thu Jul 09 14:42:44 2009 -0400 @@ -332,7 +332,7 @@ class Parser { Version version = getVersion(node, "version", null); URL location = getRequiredURL(node, "href", base); - ExtensionDesc ext = new ExtensionDesc(name, version, location, null); + ExtensionDesc ext = new ExtensionDesc(name, version, location); Node dload[] = getChildNodes(node, "ext-download"); for (int i=0; i < dload.length; i++) { diff -r bb7ad7d43804 -r a50daec5fab4 rt/net/sourceforge/jnlp/PluginBridge.java --- a/rt/net/sourceforge/jnlp/PluginBridge.java Thu Jul 09 12:49:11 2009 +0200 +++ b/rt/net/sourceforge/jnlp/PluginBridge.java Thu Jul 09 14:42:44 2009 -0400 @@ -43,7 +43,7 @@ public class PluginBridge extends JNLPFi String[] cache_ex_jars = new String[0]; Hashtable atts; - public PluginBridge(URL codebase, String cookieStr, URL documentBase, String jar, String main, + public PluginBridge(URL codebase, URL documentBase, String jar, String main, int width, int height, Hashtable atts) throws Exception { @@ -104,7 +104,6 @@ public class PluginBridge extends JNLPFi else security = null; - this.cookieStr = cookieStr; } public String getTitle() diff -r bb7ad7d43804 -r a50daec5fab4 rt/net/sourceforge/jnlp/cache/CacheUtil.java --- a/rt/net/sourceforge/jnlp/cache/CacheUtil.java Thu Jul 09 12:49:11 2009 +0200 +++ b/rt/net/sourceforge/jnlp/cache/CacheUtil.java Thu Jul 09 14:42:44 2009 -0400 @@ -75,9 +75,9 @@ public class CacheUtil { * @param version the version, or null * @return either the location in the cache or the original location */ - public static URL getCachedResource(URL location, String cookieStr, Version version, UpdatePolicy policy) { + public static URL getCachedResource(URL location, Version version, UpdatePolicy policy) { ResourceTracker rt = new ResourceTracker(); - rt.addResource(location, cookieStr, version, policy); + rt.addResource(location, version, policy); try { File f = rt.getCacheFile(location); From dbhole at redhat.com Thu Jul 9 11:43:16 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Thu, 9 Jul 2009 14:43:16 -0400 Subject: RFC: Netx/Plugin - Add support for pack200 and gzip compression In-Reply-To: <4A563826.3010406@redhat.com> References: <4A563826.3010406@redhat.com> Message-ID: <20090709184316.GC18099@redhat.com> * Omair Majid [2009-07-09 14:34]: > Hi, > > The attached patch adds support for pack200 and gzip compression to Netx > and plugin. > > ChangeLog: > 2009-07-09 Omair Majid > > * rt/net/sourceforge/jnlp/cache/ResourceTracker.java > (downloadResource): Accept and download content with pack200 or gzip > compression and uncompress it on the fly. > (initializeResource): Accept content with pack200 or gzip compression. > (getVersionedResourceURL): Add javadoc. > > Any comments? > > Cheers, > Omair Already reviewed this patch attachment to the bug. Looks good to me. Deepak > diff -r bb7ad7d43804 rt/net/sourceforge/jnlp/cache/ResourceTracker.java > --- a/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Thu Jul 09 12:49:11 2009 +0200 > +++ b/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Thu Jul 09 14:02:35 2009 -0400 > @@ -17,14 +17,30 @@ > > package net.sourceforge.jnlp.cache; > > -import java.io.*; > -import java.net.*; > -import java.util.*; > +import java.io.BufferedInputStream; > +import java.io.BufferedOutputStream; > +import java.io.File; > +import java.io.FileInputStream; > +import java.io.FileOutputStream; > +import java.io.IOException; > +import java.io.InputStream; > +import java.io.OutputStream; > +import java.net.HttpURLConnection; > +import java.net.MalformedURLException; > +import java.net.URL; > +import java.net.URLConnection; > +import java.util.ArrayList; > +import java.util.List; > +import java.util.jar.JarOutputStream; > +import java.util.jar.Pack200; > +import java.util.jar.Pack200.Unpacker; > +import java.util.zip.GZIPInputStream; > > -import net.sourceforge.jnlp.*; > -import net.sourceforge.jnlp.event.*; > -import net.sourceforge.jnlp.runtime.*; > -import net.sourceforge.jnlp.util.*; > +import net.sourceforge.jnlp.Version; > +import net.sourceforge.jnlp.event.DownloadEvent; > +import net.sourceforge.jnlp.event.DownloadListener; > +import net.sourceforge.jnlp.runtime.JNLPRuntime; > +import net.sourceforge.jnlp.util.WeakList; > > /** > * This class tracks the downloading of various resources of a > @@ -598,7 +614,9 @@ > } > > /** > - * Downloads an resource to a file. > + * Downloads a resource to a file, uncompressing it if required > + * > + * @param resource the resource to download > */ > private void downloadResource(Resource resource) { > resource.fireDownloadEvent(); // fire DOWNLOADING > @@ -606,12 +624,37 @@ > try { > // create out second in case in does not exist > URLConnection con = getVersionedResourceURL(resource).openConnection(); > + con.addRequestProperty("Accept-Encoding", "pack200-gzip, gzip"); > > if (resource.getCookieStr() != null && resource.getCookieStr().length() > 0) > con.setRequestProperty("Cookie", resource.getCookieStr()); > > + con.connect(); > + > + /* > + * We dont really know what we are downloading. If we ask for > + * foo.jar, the server might send us foo.jar.pack.gz or foo.jar.gz > + * instead. So we save the file with the appropriate extension > + */ > + URL downloadLocation = resource.location; > + > + String contentEncoding = con.getContentEncoding(); > + > + if (JNLPRuntime.isDebug()) { > + System.err.println("Content encoding for " + resource.location + ": " > + + contentEncoding); > + } > + > + if (contentEncoding != null) { > + if (contentEncoding.equals("gzip")) { > + downloadLocation = new URL(downloadLocation.toString() + ".gz"); > + } else if (contentEncoding.equals("pack200-gzip")) { > + downloadLocation = new URL(downloadLocation.toString() + ".pack.gz"); > + } > + } > + > InputStream in = new BufferedInputStream(con.getInputStream()); > - OutputStream out = CacheUtil.getOutputStream(resource.location, resource.downloadVersion); > + OutputStream out = CacheUtil.getOutputStream(downloadLocation, resource.downloadVersion); > byte buf[] = new byte[1024]; > int rlen; > > @@ -626,7 +669,45 @@ > // explicitly close the URLConnection. > if (con instanceof HttpURLConnection) > ((HttpURLConnection)con).disconnect(); > + > + /* > + * If the file was compressed, uncompress it. > + */ > + if (contentEncoding != null) { > + if (contentEncoding.equals("gzip")) { > + GZIPInputStream gzInputStream = new GZIPInputStream(new FileInputStream(CacheUtil > + .getCacheFile(downloadLocation, resource.downloadVersion))); > + InputStream inputStream = new BufferedInputStream(gzInputStream); > > + BufferedOutputStream outputStream = new BufferedOutputStream( > + new FileOutputStream(CacheUtil.getCacheFile(resource.location, > + resource.downloadVersion))); > + > + while (-1 != (rlen = inputStream.read(buf))) { > + outputStream.write(buf, 0, rlen); > + } > + > + outputStream.close(); > + inputStream.close(); > + gzInputStream.close(); > + > + } else if (contentEncoding.equals("pack200-gzip")) { > + GZIPInputStream gzInputStream = new GZIPInputStream(new FileInputStream( > + CacheUtil.getCacheFile(downloadLocation, resource.downloadVersion))); > + InputStream inputStream = new BufferedInputStream(gzInputStream); > + > + JarOutputStream outputStream = new JarOutputStream(new FileOutputStream( > + CacheUtil.getCacheFile(resource.location, resource.downloadVersion))); > + > + Unpacker unpacker = Pack200.newUnpacker(); > + unpacker.unpack(inputStream, outputStream); > + > + outputStream.close(); > + inputStream.close(); > + gzInputStream.close(); > + } > + } > + > resource.changeStatus(DOWNLOADING, DOWNLOADED); > synchronized(lock) { > lock.notifyAll(); // wake up wait's to check for completion > @@ -657,6 +738,7 @@ > > // connect > URLConnection connection = getVersionedResourceURL(resource).openConnection(); // this won't change so should be okay unsynchronized > + connection.addRequestProperty("Accept-Encoding", "pack200-gzip, gzip"); > > if (resource.getCookieStr() != null && resource.getCookieStr().length() > 0) > connection.setRequestProperty("Cookie", resource.getCookieStr()); > @@ -704,8 +786,10 @@ > } > } > > - > - > + /** > + * Returns the versioned url for a resource > + * @param resource the resource to get the url for > + */ > private URL getVersionedResourceURL(Resource resource) { > String actualLocation = resource.location.getProtocol() + "://" > + resource.location.getHost(); From dbhole at redhat.com Thu Jul 9 11:45:05 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Thu, 9 Jul 2009 14:45:05 -0400 Subject: RFC: Netx - Set JNLPClassloader as the classloader for system created threads In-Reply-To: <4A561377.2020705@redhat.com> References: <4A561377.2020705@redhat.com> Message-ID: <20090709184505.GD18099@redhat.com> * Omair Majid [2009-07-09 11:58]: > Hi, > > The attached patch makes JNLPClassLoader the context classloader for > threads created before the JNLP application starts. This deals with the > case where the JNLP application needs a previously created thread (such > as the Swing Event Dispatch Thread) to load a resource provided by the > application. > > Bugs: > https://bugzilla.redhat.com/show_bug.cgi?id=509301 > http://kenai.com/jira/browse/TRIDENT-1?focusedCommentId=15776&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_15776 > > > ChangeLog: > 2009-07-09 Omair Majid > > * rt/net/sourceforge/jnlp/Launcher.java > (launchApplication): Call setContextClassLoaderForAllThreads. > (setContextClassLoaderForAllThreads): New function. > > Any comments? > > Cheers, > Omair > diff -r b4bb02c70835 rt/net/sourceforge/jnlp/Launcher.java > --- a/rt/net/sourceforge/jnlp/Launcher.java Tue Jul 07 13:44:35 2009 -0400 > +++ b/rt/net/sourceforge/jnlp/Launcher.java Thu Jul 09 11:16:04 2009 -0400 > @@ -23,6 +23,8 @@ > import java.io.File; > import java.io.IOException; > import java.io.InputStream; > +import java.lang.management.ManagementFactory; > +import java.lang.management.ThreadMXBean; > import java.lang.reflect.Method; > import java.net.URL; > import java.util.LinkedList; > @@ -425,8 +427,7 @@ > Method main = mainClass.getDeclaredMethod("main", new Class[] {String[].class} ); > String args[] = file.getApplication().getArguments(); > > - // required to make some apps work right > - Thread.currentThread().setContextClassLoader(app.getClassLoader()); > + setContextClassLoaderForAllThreads(app.getClassLoader()); > > if (splashScreen != null) { > if (splashScreen.isSplashScreenValid()) { > @@ -447,6 +448,45 @@ > } > } > > + /** > + * Set the classloader as the context classloader for all threads. This is > + * required to make some applications work. For example, an application that > + * provides a custom Swing LnF may ask the swing thread to load resources > + * from their JNLP, which would only work if the Swing thread knows about > + * the JNLPClassLoader. > + * > + * @param classLoader the classloader to set as the context classloader > + */ > + private void setContextClassLoaderForAllThreads(ClassLoader classLoader) { > + ThreadMXBean threadBean = ManagementFactory.getThreadMXBean(); > + ThreadGroup root; > + > + root = Thread.currentThread().getThreadGroup(); > + while (root.getParent() != null) { > + root = root.getParent(); > + } > + > + /* be prepared for change in thread size */ > + int threadCountGuess = threadBean.getThreadCount(); > + Thread[] threads; > + do { > + threadCountGuess = threadCountGuess * 2; > + threads = new Thread[threadCountGuess]; > + root.enumerate(threads, true); > + } while (threads[threadCountGuess-1] != null); > + > + > + for (Thread thread: threads) { > + if (thread != null) { > + if (JNLPRuntime.isDebug()) { > + System.err.println("Setting " + classLoader + " as the classloader for thread " + thread.getName()); > + } > + thread.setContextClassLoader(classLoader); > + } > + } > + > + } > + Assuming you have tested this, go ahead and apply. Deepak > /** > * Launches a JNLP applet. This method should be called from a > * thread in the application's thread group.

From ahughes at redhat.com Thu Jul 9 11:50:28 2009 From: ahughes at redhat.com (Andrew John Hughes) Date: Thu, 09 Jul 2009 18:50:28 +0000 Subject: changeset in /hg/icedtea: Add missing patch. Message-ID: changeset e944184d6eda in /hg/icedtea details: http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=e944184d6eda description: Add missing patch. 2009-07-09 Andrew John Hughes * patches/ecj/icedtea-pr40616.patch: Add missing patch. diffstat: 2 files changed, 20 insertions(+) ChangeLog | 5 +++++ patches/ecj/icedtea-pr40616.patch | 15 +++++++++++++++ diffs (31 lines): diff -r 3340f0afa232 -r e944184d6eda ChangeLog --- a/ChangeLog Thu Jul 09 16:43:16 2009 +0100 +++ b/ChangeLog Thu Jul 09 19:52:10 2009 +0100 @@ -1,3 +1,8 @@ 2009-07-09 Andrew John Hughes + + * patches/ecj/icedtea-pr40616.patch: + Add missing patch. + 2009-07-09 Andrew John Hughes * Makefile.am: diff -r 3340f0afa232 -r e944184d6eda patches/ecj/icedtea-pr40616.patch --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/patches/ecj/icedtea-pr40616.patch Thu Jul 09 19:52:10 2009 +0100 @@ -0,0 +1,15 @@ +diff -Nru openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java +--- openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java 2009-07-02 12:04:10.000000000 +0100 ++++ openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java 2009-07-02 12:13:09.000000000 +0100 +@@ -36,8 +36,10 @@ + public class GenerateEUC_TW { + + public static void genEUC_TW(String args[]) throws Exception { ++ FileOutputStream fos = ++ new FileOutputStream(new File(args[1], "EUC_TWMapping.java")); + genClass(new FileInputStream(new File(args[0], "euc_tw.map")), +- new PrintStream(new File(args[1], "EUC_TWMapping.java"), "ISO-8859-1"), ++ new PrintStream(fos, false, "ISO-8859-1"), + getCopyright(new File(args[3]))); + } + From dbhole at redhat.com Thu Jul 9 12:24:11 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Thu, 09 Jul 2009 19:24:11 +0000 Subject: changeset in /hg/icedtea6: Adding new plugin cookie related files. Message-ID: changeset d0694a669da3 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=d0694a669da3 description: Adding new plugin cookie related files. diffstat: 2 files changed, 195 insertions(+) plugin/icedtea/sun/applet/PluginCookieInfoRequest.java | 122 ++++++++++++++++ plugin/icedtea/sun/applet/PluginCookieStore.java | 73 +++++++++ diffs (203 lines): diff -r a50daec5fab4 -r d0694a669da3 plugin/icedtea/sun/applet/PluginCookieInfoRequest.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/plugin/icedtea/sun/applet/PluginCookieInfoRequest.java Thu Jul 09 15:28:30 2009 -0400 @@ -0,0 +1,122 @@ +/* PluginCookieInfoRequest -- Object representing a request for cookie information from the browser + Copyright (C) 2009 Red Hat + +This file is part of IcedTea. + +IcedTea is free software; you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation; either version 2, or (at your option) +any later version. + +IcedTea is distributed in the hope that it will be useful, but +WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +General Public License for more details. + +You should have received a copy of the GNU General Public License +along with IcedTea; see the file COPYING. If not, write to the +Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +02110-1301 USA. + +Linking this library statically or dynamically with other modules is +making a combined work based on this library. Thus, the terms and +conditions of the GNU General Public License cover the whole +combination. + +As a special exception, the copyright holders of this library give you +permission to link this library with independent modules to produce an +executable, regardless of the license terms of these independent +modules, and to copy and distribute the resulting executable under +terms of your choice, provided that you also meet, for each linked +independent module, the terms and conditions of the license of that +module. An independent module is a module which is not derived from +or based on this library. If you modify this library, you may extend +this exception to your version of the library, but you are not +obligated to do so. If you do not wish to do so, delete this +exception statement from your version. */ + +package sun.applet; + +import java.net.HttpCookie; +import java.net.URI; +import java.util.ArrayList; +import java.util.List; + +import com.sun.jndi.toolkit.url.UrlUtil; + +/** + * This class represents a request object for cookie information for a given URI + */ + +public class PluginCookieInfoRequest extends PluginCallRequest { + + List cookieObjects = new ArrayList(); + + public PluginCookieInfoRequest(String message, String returnString) { + super(message, returnString); + } + + public void parseReturn(String cookieInfo) { + + // try to parse the proxy information. If things go wrong, do nothing .. + // this will keep internal = null which forces a direct connection + + PluginDebug.debug ("PluginCookieInfoRequest GOT: " + cookieInfo); + + String encodedURI = cookieInfo.split(" ")[2]; + + // Skip the first 3 components. We are guaranteed 3 components, + // so no index -1 to worry about + cookieInfo = cookieInfo.substring(cookieInfo.indexOf(' ')+1); + cookieInfo = cookieInfo.substring(cookieInfo.indexOf(' ')+1); + cookieInfo = cookieInfo.substring(cookieInfo.indexOf(' ')+1); + + URI siteURI; + try + { + siteURI = new URI(UrlUtil.decode(encodedURI, "UTF-8")); + } catch (Exception e) + { + e.printStackTrace(); + return; + } + + if (cookieInfo != null && cookieInfo.length() > 0) + { + String[] cookies = cookieInfo.split(";"); + + for (int i = 0; i < cookies.length; i++) + { + ArrayList l = new ArrayList(); + + String cookie = cookies[i]; + cookie = cookie.trim(); + String cookieName = cookie.substring(0, cookie.indexOf("=")); + String cookieValue = cookie.substring(cookie.indexOf("=")+1); + + HttpCookie httpCookieObj = new HttpCookie(cookieName, cookieValue); + httpCookieObj.setPath(siteURI.getPath()); + httpCookieObj.setVersion(0); // force v0 + + PluginDebug.debug("Adding cookie info COOKIEN=" + cookieName + " and COOKIEV=" + cookieValue); + cookieObjects.add(httpCookieObj); + } + } + + setDone(true); + } + + /** + * Returns whether the given message is serviceable by this object + * + * @param message The message to service + * @return boolean indicating if message is serviceable + */ + public boolean serviceable(String message) { + return message.startsWith(returnString); + } + + public List getObject() { + return this.cookieObjects; + } +} diff -r a50daec5fab4 -r d0694a669da3 plugin/icedtea/sun/applet/PluginCookieStore.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/plugin/icedtea/sun/applet/PluginCookieStore.java Thu Jul 09 15:28:30 2009 -0400 @@ -0,0 +1,73 @@ +/* PluginCookieStore -- Storage for cookie information + Copyright (C) 2009 Red Hat + +This file is part of IcedTea. + +IcedTea is free software; you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation; either version 2, or (at your option) +any later version. + +IcedTea is distributed in the hope that it will be useful, but +WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +General Public License for more details. + +You should have received a copy of the GNU General Public License +along with IcedTea; see the file COPYING. If not, write to the +Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +02110-1301 USA. + +Linking this library statically or dynamically with other modules is +making a combined work based on this library. Thus, the terms and +conditions of the GNU General Public License cover the whole +combination. + +As a special exception, the copyright holders of this library give you +permission to link this library with independent modules to produce an +executable, regardless of the license terms of these independent +modules, and to copy and distribute the resulting executable under +terms of your choice, provided that you also meet, for each linked +independent module, the terms and conditions of the license of that +module. An independent module is a module which is not derived from +or based on this library. If you modify this library, you may extend +this exception to your version of the library, but you are not +obligated to do so. If you do not wish to do so, delete this +exception statement from your version. */ + +package sun.applet; + +import java.net.HttpCookie; +import java.net.URI; +import java.util.List; + +import sun.net.www.protocol.http.InMemoryCookieStore; + +public class PluginCookieStore extends InMemoryCookieStore +{ + public List get(URI uri) + { + List cookies; + + // Try to fetch it from the plugin, but if something goes + // wrong, fall back. Don't crash! + try + { + cookies = (List) PluginAppletViewer.requestPluginCookieInfo(uri); + + // If cookies is null, something went wrong. Fall back. + if (cookies == null) throw new NullPointerException("Null cookie"); + + } catch (Exception e) + { + PluginDebug.debug("Unable to fetch cookie information from plugin. " + + "Falling back to default."); + e.printStackTrace(); + cookies = super.get(uri); + } + + PluginDebug.debug("Returning cookies " + cookies + " for site: " + uri); + + return cookies; + } +} From bugzilla-daemon at icedtea.classpath.org Thu Jul 9 13:20:25 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Thu, 09 Jul 2009 20:20:25 +0000 Subject: [Bug 320] daylight savings time status not reported correctly Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=320 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #4 from jon.vanalten at redhat.com 2009-07-09 20:20 ------- Hi, The bug in RedHat bugzilla has been marked as fixed as of new version (java-1.6.0-openjdk-1.6.0.0-18.b16.fc10 or java-1.6.0-openjdk-1.6.0.0-22.b16.fc11). I can confirm this in F11: $cat /etc/sysconfig/clock # The time zone of the system is defined by the contents of /etc/localtime. # This file is only for evaluation by system-config-date, do not rely on its # contents elsewhere. ZONE="America/New York" $ java TimeZoneTest 2009_07_09_1616_22_Eastern Daylight Time DST? = yes Note that ZONE has the space; the correction was made in the JDK and the workaround of replacing the space with underscore is not necessary. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Thu Jul 9 13:46:01 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Thu, 09 Jul 2009 20:46:01 +0000 Subject: [Bug 321] SIGSEGV (0xb) at pc=0x00a3dcab with Java VM: OpenJDK Server VM (1.6.0-b09 mixed mode linux-x86) Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=321 ------- Comment #1 from jon.vanalten at redhat.com 2009-07-09 20:45 ------- Hi, cleaning up some bug reports here. Is this still happening for you? If so, can you provide details for how to reproduce this crash? Incidentally, since F9 is about to go EOL so you may wish to upgrade and see if the problem persists in F10 or F11. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From omajid at redhat.com Thu Jul 9 14:18:01 2009 From: omajid at redhat.com (Omair Majid) Date: Thu, 09 Jul 2009 21:18:01 +0000 Subject: changeset in /hg/icedtea6: Support pack200/gzip compression in Netx Message-ID: changeset 02e02b5a01c0 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=02e02b5a01c0 description: Support pack200/gzip compression in Netx 2009-07-09 Omair Majid * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: (downloadResource): Accept and download content with pack200 or gzip compression and uncompress it on the fly. (initializeResource): Accept content with pack200 or gzip compression. (getVersionedResourceURL): Add javadoc. diffstat: 2 files changed, 105 insertions(+), 13 deletions(-) ChangeLog | 8 + rt/net/sourceforge/jnlp/cache/ResourceTracker.java | 110 +++++++++++++++++--- diffs (172 lines): diff -r d0694a669da3 -r 02e02b5a01c0 ChangeLog --- a/ChangeLog Thu Jul 09 15:28:30 2009 -0400 +++ b/ChangeLog Thu Jul 09 17:18:02 2009 -0400 @@ -1,3 +1,11 @@ 2009-07-09 Deepak Bhole + + * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: + (downloadResource): Accept and download content with pack200 or gzip + compression and uncompress it on the fly. + (initializeResource): Accept content with pack200 or gzip compression. + (getVersionedResourceURL): Add javadoc. + 2009-07-09 Deepak Bhole * IcedTeaPlugin.cc: Add suppport for cookie info requests from applets. diff -r d0694a669da3 -r 02e02b5a01c0 rt/net/sourceforge/jnlp/cache/ResourceTracker.java --- a/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Thu Jul 09 15:28:30 2009 -0400 +++ b/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Thu Jul 09 17:18:02 2009 -0400 @@ -17,14 +17,30 @@ package net.sourceforge.jnlp.cache; -import java.io.*; -import java.net.*; -import java.util.*; - -import net.sourceforge.jnlp.*; -import net.sourceforge.jnlp.event.*; -import net.sourceforge.jnlp.runtime.*; -import net.sourceforge.jnlp.util.*; +import java.io.BufferedInputStream; +import java.io.BufferedOutputStream; +import java.io.File; +import java.io.FileInputStream; +import java.io.FileOutputStream; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.net.HttpURLConnection; +import java.net.MalformedURLException; +import java.net.URL; +import java.net.URLConnection; +import java.util.ArrayList; +import java.util.List; +import java.util.jar.JarOutputStream; +import java.util.jar.Pack200; +import java.util.jar.Pack200.Unpacker; +import java.util.zip.GZIPInputStream; + +import net.sourceforge.jnlp.Version; +import net.sourceforge.jnlp.event.DownloadEvent; +import net.sourceforge.jnlp.event.DownloadListener; +import net.sourceforge.jnlp.runtime.JNLPRuntime; +import net.sourceforge.jnlp.util.WeakList; /** * This class tracks the downloading of various resources of a @@ -598,7 +614,9 @@ public class ResourceTracker { } /** - * Downloads an resource to a file. + * Downloads a resource to a file, uncompressing it if required + * + * @param resource the resource to download */ private void downloadResource(Resource resource) { resource.fireDownloadEvent(); // fire DOWNLOADING @@ -606,9 +624,34 @@ public class ResourceTracker { try { // create out second in case in does not exist URLConnection con = getVersionedResourceURL(resource).openConnection(); + con.addRequestProperty("Accept-Encoding", "pack200-gzip, gzip"); + + con.connect(); + + /* + * We dont really know what we are downloading. If we ask for + * foo.jar, the server might send us foo.jar.pack.gz or foo.jar.gz + * instead. So we save the file with the appropriate extension + */ + URL downloadLocation = resource.location; + + String contentEncoding = con.getContentEncoding(); + + if (JNLPRuntime.isDebug()) { + System.err.println("Content encoding for " + resource.location + ": " + + contentEncoding); + } + + if (contentEncoding != null) { + if (contentEncoding.equals("gzip")) { + downloadLocation = new URL(downloadLocation.toString() + ".gz"); + } else if (contentEncoding.equals("pack200-gzip")) { + downloadLocation = new URL(downloadLocation.toString() + ".pack.gz"); + } + } InputStream in = new BufferedInputStream(con.getInputStream()); - OutputStream out = CacheUtil.getOutputStream(resource.location, resource.downloadVersion); + OutputStream out = CacheUtil.getOutputStream(downloadLocation, resource.downloadVersion); byte buf[] = new byte[1024]; int rlen; @@ -623,7 +666,45 @@ public class ResourceTracker { // explicitly close the URLConnection. if (con instanceof HttpURLConnection) ((HttpURLConnection)con).disconnect(); - + + /* + * If the file was compressed, uncompress it. + */ + if (contentEncoding != null) { + if (contentEncoding.equals("gzip")) { + GZIPInputStream gzInputStream = new GZIPInputStream(new FileInputStream(CacheUtil + .getCacheFile(downloadLocation, resource.downloadVersion))); + InputStream inputStream = new BufferedInputStream(gzInputStream); + + BufferedOutputStream outputStream = new BufferedOutputStream( + new FileOutputStream(CacheUtil.getCacheFile(resource.location, + resource.downloadVersion))); + + while (-1 != (rlen = inputStream.read(buf))) { + outputStream.write(buf, 0, rlen); + } + + outputStream.close(); + inputStream.close(); + gzInputStream.close(); + + } else if (contentEncoding.equals("pack200-gzip")) { + GZIPInputStream gzInputStream = new GZIPInputStream(new FileInputStream( + CacheUtil.getCacheFile(downloadLocation, resource.downloadVersion))); + InputStream inputStream = new BufferedInputStream(gzInputStream); + + JarOutputStream outputStream = new JarOutputStream(new FileOutputStream( + CacheUtil.getCacheFile(resource.location, resource.downloadVersion))); + + Unpacker unpacker = Pack200.newUnpacker(); + unpacker.unpack(inputStream, outputStream); + + outputStream.close(); + inputStream.close(); + gzInputStream.close(); + } + } + resource.changeStatus(DOWNLOADING, DOWNLOADED); synchronized(lock) { lock.notifyAll(); // wake up wait's to check for completion @@ -654,6 +735,7 @@ public class ResourceTracker { // connect URLConnection connection = getVersionedResourceURL(resource).openConnection(); // this won't change so should be okay unsynchronized + connection.addRequestProperty("Accept-Encoding", "pack200-gzip, gzip"); int size = connection.getContentLength(); boolean current = CacheUtil.isCurrent(resource.location, resource.requestVersion, connection) && resource.getUpdatePolicy() != UpdatePolicy.FORCE; @@ -698,8 +780,10 @@ public class ResourceTracker { } } - - + /** + * Returns the versioned url for a resource + * @param resource the resource to get the url for + */ private URL getVersionedResourceURL(Resource resource) { String actualLocation = resource.location.getProtocol() + "://" + resource.location.getHost(); From omajid at redhat.com Thu Jul 9 14:21:00 2009 From: omajid at redhat.com (Omair Majid) Date: Thu, 09 Jul 2009 17:21:00 -0400 Subject: RFC: Netx/Plugin - Add support for pack200 and gzip compression In-Reply-To: <20090709184316.GC18099@redhat.com> References: <4A563826.3010406@redhat.com> <20090709184316.GC18099@redhat.com> Message-ID: <4A565F3C.8070302@redhat.com> Deepak Bhole wrote: > * Omair Majid [2009-07-09 14:34]: >> >> The attached patch adds support for pack200 and gzip compression to Netx >> and plugin. >> >> ChangeLog: >> 2009-07-09 Omair Majid >> >> * rt/net/sourceforge/jnlp/cache/ResourceTracker.java >> (downloadResource): Accept and download content with pack200 or gzip >> compression and uncompress it on the fly. >> (initializeResource): Accept content with pack200 or gzip compression. >> (getVersionedResourceURL): Add javadoc. >> >> Any comments? > > Already reviewed this patch attachment to the bug. Looks good to me. > Thanks. Pushed as changeset 02e02b5a01c0. Cheers, Omair From omajid at redhat.com Thu Jul 9 14:27:41 2009 From: omajid at redhat.com (Omair Majid) Date: Thu, 09 Jul 2009 21:27:41 +0000 Subject: changeset in /hg/icedtea6: Netx: Set context classloader for all... Message-ID: changeset 7acbff01007f in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=7acbff01007f description: Netx: Set context classloader for all threads in an application 2009-07-09 Omair Majid * rt/net/sourceforge/jnlp/Launcher.java (launchApplication): Call setContextClassLoaderForAllThreads. (setContextClassLoaderForAllThreads): New function. diffstat: 2 files changed, 48 insertions(+), 2 deletions(-) ChangeLog | 6 ++++ rt/net/sourceforge/jnlp/Launcher.java | 44 +++++++++++++++++++++++++++++++-- diffs (81 lines): diff -r 02e02b5a01c0 -r 7acbff01007f ChangeLog --- a/ChangeLog Thu Jul 09 17:18:02 2009 -0400 +++ b/ChangeLog Thu Jul 09 17:29:13 2009 -0400 @@ -1,3 +1,9 @@ 2009-07-09 Omair Majid + + * rt/net/sourceforge/jnlp/Launcher.java + (launchApplication): Call setContextClassLoaderForAllThreads. + (setContextClassLoaderForAllThreads): New function. + 2009-07-09 Omair Majid * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: diff -r 02e02b5a01c0 -r 7acbff01007f rt/net/sourceforge/jnlp/Launcher.java --- a/rt/net/sourceforge/jnlp/Launcher.java Thu Jul 09 17:18:02 2009 -0400 +++ b/rt/net/sourceforge/jnlp/Launcher.java Thu Jul 09 17:29:13 2009 -0400 @@ -23,6 +23,8 @@ import java.io.File; import java.io.File; import java.io.IOException; import java.io.InputStream; +import java.lang.management.ManagementFactory; +import java.lang.management.ThreadMXBean; import java.lang.reflect.Method; import java.net.URL; import java.util.LinkedList; @@ -425,8 +427,7 @@ public class Launcher { Method main = mainClass.getDeclaredMethod("main", new Class[] {String[].class} ); String args[] = file.getApplication().getArguments(); - // required to make some apps work right - Thread.currentThread().setContextClassLoader(app.getClassLoader()); + setContextClassLoaderForAllThreads(app.getClassLoader()); if (splashScreen != null) { if (splashScreen.isSplashScreenValid()) { @@ -445,6 +446,45 @@ public class Launcher { catch (Exception ex) { throw launchError(new LaunchException(file, ex, R("LSFatal"), R("LCLaunching"), R("LCouldNotLaunch"), R("LCouldNotLaunchInfo"))); } + } + + /** + * Set the classloader as the context classloader for all threads. This is + * required to make some applications work. For example, an application that + * provides a custom Swing LnF may ask the swing thread to load resources + * from their JNLP, which would only work if the Swing thread knows about + * the JNLPClassLoader. + * + * @param classLoader the classloader to set as the context classloader + */ + private void setContextClassLoaderForAllThreads(ClassLoader classLoader) { + ThreadMXBean threadBean = ManagementFactory.getThreadMXBean(); + ThreadGroup root; + + root = Thread.currentThread().getThreadGroup(); + while (root.getParent() != null) { + root = root.getParent(); + } + + /* be prepared for change in thread size */ + int threadCountGuess = threadBean.getThreadCount(); + Thread[] threads; + do { + threadCountGuess = threadCountGuess * 2; + threads = new Thread[threadCountGuess]; + root.enumerate(threads, true); + } while (threads[threadCountGuess-1] != null); + + + for (Thread thread: threads) { + if (thread != null) { + if (JNLPRuntime.isDebug()) { + System.err.println("Setting " + classLoader + " as the classloader for thread " + thread.getName()); + } + thread.setContextClassLoader(classLoader); + } + } + } /** From omajid at redhat.com Thu Jul 9 14:30:39 2009 From: omajid at redhat.com (Omair Majid) Date: Thu, 09 Jul 2009 17:30:39 -0400 Subject: RFC: Netx - Set JNLPClassloader as the classloader for system created threads In-Reply-To: <20090709184505.GD18099@redhat.com> References: <4A561377.2020705@redhat.com> <20090709184505.GD18099@redhat.com> Message-ID: <4A56617F.6050302@redhat.com> Deepak Bhole wrote: > * Omair Majid [2009-07-09 11:58]: >> Hi, >> >> The attached patch makes JNLPClassLoader the context classloader for >> threads created before the JNLP application starts. This deals with the >> case where the JNLP application needs a previously created thread (such >> as the Swing Event Dispatch Thread) to load a resource provided by the >> application. >> >> Bugs: >> https://bugzilla.redhat.com/show_bug.cgi?id=509301 >> http://kenai.com/jira/browse/TRIDENT-1?focusedCommentId=15776&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_15776 >> >> >> ChangeLog: >> 2009-07-09 Omair Majid >> >> * rt/net/sourceforge/jnlp/Launcher.java >> (launchApplication): Call setContextClassLoaderForAllThreads. >> (setContextClassLoaderForAllThreads): New function. >> >> Any comments? >> > > Assuming you have tested this, go ahead and apply. > Thanks. Pushed as changeset 7acbff01007f. Cheers, Omair From bugzilla-daemon at icedtea.classpath.org Thu Jul 9 15:00:33 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Thu, 09 Jul 2009 22:00:33 +0000 Subject: [Bug 364] New: NPE in AccessControlContext Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=364 Summary: NPE in AccessControlContext Product: IcedTea Version: unspecified Platform: PC URL: https://jira.jboss.org/jira/browse/JBAS-7049 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: david.lloyd at redhat.com There's a null check missing in OpenJDK 6 that was fixed in 7. we (well, another jboss guy really) found an NPE in AccessControlContext.java that's already fixed in 7 dmlloyd_, if you happen to know the commit that fixed it, then it will be easy to backport. hmm now we learn how well I know hg :) yes! looks like ref 65, but I'll double-check to be sure rev* yup, rev 65 of src/share/classes/java/security/AccessControlContext.java, back in 2008 I guess ref 65 is your local ref but indeed, I found it. changeset: 74:7dc3b56f220f user: xuelei date: Sat Mar 15 13:43:05 2008 -0400 summary: 6648816: REGRESSION: setting -Djava.security.debug=failure result in NPE in ACC dmlloyd_, feel free to create a bug report in http://icedtea.classpath.org/bugzilla and we take it from there. for now though, good night and sleep well ok, thanks -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From a.radke at arcor.de Thu Jul 9 23:34:24 2009 From: a.radke at arcor.de (Andreas Radke) Date: Fri, 10 Jul 2009 08:34:24 +0200 Subject: Interactive brokers fails to start Message-ID: <20090710083424.565b2bd8@workstation64.home> I'm running ArchLinux with openjdk6 java -version java version "1.6.0_0" OpenJDK Runtime Environment (IcedTea6 1.5) (ArchLinux-1.5-4-x86_64) OpenJDK 64-Bit Server VM (build 14.0-b15, mixed mode) and I cannot open the broker software from http://www.interactivebrokers.com/de/p.php?f=tws&ib_entity=de the browser will stop to open it and the downloaded version under "UNIX Download" fails with the attached log. I confirmed that the downloaded version works with SUNs jre. Any idea? -Andy -------------- next part -------------- A non-text attachment was scrubbed... Name: hs_err_pid7301.log Type: text/x-log Size: 27283 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090710/5ac4bea4/attachment.bin From bugzilla-daemon at icedtea.classpath.org Fri Jul 10 06:12:44 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 10 Jul 2009 13:12:44 +0000 Subject: [Bug 365] New: IntelliJ IDEA crashes due to SIGSEGV in libjvm.so+0x4760e6 Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=365 Summary: IntelliJ IDEA crashes due to SIGSEGV in libjvm.so+0x4760e6 Product: IcedTea Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: odoepner at gmail.com # This happens frequently on Debian Lenny with OpenJDK 6b11-9.1+lenny2 : # An unexpected error has been detected by Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007fcb60fce0e6, pid=17711, tid=1102248272 # # Java VM: OpenJDK 64-Bit Server VM (1.6.0_0-b11 mixed mode linux-amd64) # Problematic frame: # V [libjvm.so+0x4760e6] # # An error report file with more information is saved as: # /tmp/hs_err_pid17711.log # # If you would like to submit a bug report, please visit: # http://icedtea.classpath.org/bugzilla # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Fri Jul 10 06:14:58 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 10 Jul 2009 13:14:58 +0000 Subject: [Bug 365] IntelliJ IDEA crashes due to SIGSEGV in libjvm.so+0x4760e6 Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=365 ------- Comment #1 from odoepner at gmail.com 2009-07-10 13:14 ------- Created an attachment (id=245) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=245&action=view) generated error report file Attached the generated error report file (/tmp/hs_err_pid17711.log). -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From langel at redhat.com Fri Jul 10 06:40:02 2009 From: langel at redhat.com (Lillian Angel) Date: Fri, 10 Jul 2009 09:40:02 -0400 Subject: glibc/execvpe issue and openjdk In-Reply-To: <4A5645B1.2040608@redhat.com> References: <4A5645B1.2040608@redhat.com> Message-ID: <4A5744B2.8010404@redhat.com> CC'ing distro in case anyone else knows about this. Lillian Angel wrote: > Hi Martin, > > I am having trouble building IcedTea6 on Fedora 12 > (http://koji.fedoraproject.org/koji/getfile?taskID=1463798&name=build.log), > it seems because this bug was fixed in glibc-2.10-3: > http://sourceware.org/bugzilla/show_bug.cgi?id=10221 > > Do you have a patch for IcedTea/OpenJDK to get around this? > > > Cheers, > Lillian > From langel at redhat.com Fri Jul 10 07:18:40 2009 From: langel at redhat.com (Lillian Angel) Date: Fri, 10 Jul 2009 10:18:40 -0400 Subject: execvpe and glibc 2.10 In-Reply-To: <1ccfd1c10907091407q1557c49s6338614925808a23@mail.gmail.com> References: <1ccfd1c10907091407q1557c49s6338614925808a23@mail.gmail.com> Message-ID: <4A574DC0.1020104@redhat.com> Thanks! Martin Buchholz wrote: > Sorry, I should never have named a function (not even a static one) > 'execvpe'. It's amusing that I broke myself by requesting that glibc > implement 'execvpe'. > > Here's the webrev: > > http://cr.openjdk.java.net/~martin/webrevs/openjdk7/rename-execvpe/ > > > For those following things, there are now 3 pending patches for > UNIXProcess_md.c: > > rename-execvpe > vfork-exec > RESTARTABLE > > and there are more to come. > > Martin > > On Thu, Jul 9, 2009 at 12:32, Lillian Angel > wrote: > > Hi Martin, > > I am having trouble building IcedTea6 on Fedora 12 > (http://koji.fedoraproject.org/koji/getfile?taskID=1463798&name=build.log > ), > it seems because this bug was fixed in glibc-2.10-3: > http://sourceware.org/bugzilla/show_bug.cgi?id=10221 > > Do you have a patch for IcedTea/OpenJDK to get around this? > From omajid at redhat.com Fri Jul 10 08:51:07 2009 From: omajid at redhat.com (Omair Majid) Date: Fri, 10 Jul 2009 11:51:07 -0400 Subject: RFC: Netx - Use version based download protocol for JNLP files Message-ID: <4A57636B.7000503@redhat.com> Hi, This patch makes Netx use the version based download protocol for JNLP files. Netx tries to use the version based download protocol whenever possible to download files. This wasn't being done for JNLP file that were specified as extensions by other JNLP files. This patch fixes the issue making JNLP applications like aerith[1] work. This is also required to run JavaFX applications. While adding that support, I noticed that function arguments that involved Urls and versions were inconsistent: some used function(URL, Version, blah) while others used function(URL, blah, Version). I have tried to fix them to be function(URL, Version, blah) consistently. ChangeLog: 2009-07-10 Omair Majid * rt/net/sourceforge/jnlp/JNLPFile.java (JNLPFile): Delegate to the Version-based constructor. (JNLPFile): New constructor. (JNLPFile): Modified to take an additional version argument used in downloading the JNLP file. (openURL): Take an additional version argument and use when downloading the URL. * rt/net/sourceforge/jnlp/Launcher.java (toFile): Use the new JNLPFile constructor. * rt/net/sourceforge/jnlp/cache/Resource.java (Resource): Rearrange argument order. (getResource): Likewise. Fix parameters to constructor. * rt/net/sourceforge/jnlp/cache/ResourceTracker.java (addResource): Fix arguments to Resource.getResource. * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java (getInstance): Take additional version argument and useit when creating a JNLPFile. (initializeExtensions): Use the extension version when requesting a JNLPClassLoader. Any comments? Cheers, Omair [1] https://aerith.dev.java.net/ -------------- next part -------------- A non-text attachment was scrubbed... Name: netx-versioned-jnlp.patch Type: text/x-patch Size: 7497 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090710/8396ada0/attachment.bin From bugzilla-daemon at icedtea.classpath.org Fri Jul 10 11:03:08 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 10 Jul 2009 18:03:08 +0000 Subject: [Bug 332] An unexpected error has been detected by Java Runtime Environment: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=332 ------- Comment #1 from mwong at redhat.com 2009-07-10 18:03 ------- Yes, the log can be uploaded, just click Create a New Attachment. Man Lung Wong -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From a.radke at arcor.de Fri Jul 10 11:10:51 2009 From: a.radke at arcor.de (Andreas Radke) Date: Fri, 10 Jul 2009 20:10:51 +0200 Subject: Interactive brokers fails to start In-Reply-To: <20090710083424.565b2bd8@workstation64.home> References: <20090710083424.565b2bd8@workstation64.home> Message-ID: <20090710201051.3f50ce06@workstation64.home> Am Fri, 10 Jul 2009 08:34:24 +0200 schrieb Andreas Radke : > I'm running ArchLinux with openjdk6 java -version > java version "1.6.0_0" > OpenJDK Runtime Environment (IcedTea6 1.5) (ArchLinux-1.5-4-x86_64) > OpenJDK 64-Bit Server VM (build 14.0-b15, mixed mode) > > and I cannot open the broker software from > http://www.interactivebrokers.com/de/p.php?f=tws&ib_entity=de > > the browser will stop to open it and the downloaded version under > "UNIX Download" fails with the attached log. I confirmed that the > downloaded version works with SUNs jre. > > Any idea? > > -Andy This is probably because we have updated to libjpeg ver.7 Where are the libjpeg62 hardcoded paths? Is there a patch available? -Andy From a.radke at arcor.de Fri Jul 10 12:21:32 2009 From: a.radke at arcor.de (Andreas Radke) Date: Fri, 10 Jul 2009 21:21:32 +0200 Subject: Interactive brokers fails to start In-Reply-To: <20090710201051.3f50ce06@workstation64.home> References: <20090710083424.565b2bd8@workstation64.home> <20090710201051.3f50ce06@workstation64.home> Message-ID: <20090710212132.59cb778e@workstation64.home> Am Fri, 10 Jul 2009 20:10:51 +0200 schrieb Andreas Radke : > Am Fri, 10 Jul 2009 08:34:24 +0200 > schrieb Andreas Radke : > > > I'm running ArchLinux with openjdk6 java -version > > java version "1.6.0_0" > > OpenJDK Runtime Environment (IcedTea6 1.5) (ArchLinux-1.5-4-x86_64) > > OpenJDK 64-Bit Server VM (build 14.0-b15, mixed mode) > > > > and I cannot open the broker software from > > http://www.interactivebrokers.com/de/p.php?f=tws&ib_entity=de > > > > the browser will stop to open it and the downloaded version under > > "UNIX Download" fails with the attached log. I confirmed that the > > downloaded version works with SUNs jre. > > > > Any idea? > > > > -Andy > > This is probably because we have updated to libjpeg ver.7 > > Where are the libjpeg62 hardcoded paths? Is there a patch available? > > -Andy > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-February/001142.html reverted that patch. application still crashes the same way. -Andy From bugzilla-daemon at icedtea.classpath.org Fri Jul 10 12:20:48 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Fri, 10 Jul 2009 19:20:48 +0000 Subject: [Bug 336] Add support for JSR-200 to javaws and appletviewer Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=336 omajid at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #7 from omajid at redhat.com 2009-07-10 19:20 ------- Patch applied as changeset 02e02b5a01c0: http://icedtea.classpath.org/hg/icedtea6/rev/02e02b5a01c0 Please reopen this bug if you experience any issues. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From dbhole at redhat.com Fri Jul 10 15:44:47 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Fri, 10 Jul 2009 18:44:47 -0400 Subject: RFE: Patch to fix jar signature verification Message-ID: <20090710224447.GA32059@redhat.com> Hi, Currently, we use JarInputStream when reading the jar to verify signatures. JarInputStream does not work unless manifest file is the first file in the jar. As a result, signed jars end up being treated as unsigned, causing those applets to not work. This patch fixes that by using JarFile instead, which does not have the "manifest must be first" restriction. Fixes: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=325 https://bugzilla.redhat.com/show_bug.cgi?id=502318 ChangeLog: * plugin/icedtea/sun/applet/PluginMessageConsumer.java: Fix minor typo in how max worker count is interpreted. * rt/net/sourceforge/jnlp/tools/JarSigner.java: use JarFile instead of JarInputstream when verifying jars. Deepak -------------- next part -------------- A non-text attachment was scrubbed... Name: IT-325-RHBZ-502318.patch Type: text/x-patch Size: 3182 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090710/92f3aae7/attachment.bin From dbhole at redhat.com Fri Jul 10 15:57:41 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Fri, 10 Jul 2009 22:57:41 +0000 Subject: changeset in /hg/icedtea6: Commit changes to the new np plugin. ... Message-ID: changeset dd1ce0a6da73 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=dd1ce0a6da73 description: Commit changes to the new np plugin. These changes do a lot of things to list. But most notably, they: - Lay down the scriptability framework. - Implement the new MessageBus architecture that is independent of how messages are passed. - Implement GetWindow and GetMember (partially) as proof of concept for message passing, threading, unicode translation, etc. ChangeLog: * Makefile.am: Update makefile to pick up plugin C++ files from new location. * plugin/icedtea/sun/applet/PluginMessageConsumer.java : Minor typo fix. * plugin/icedteanp/IcedTeaJavaRequestProcessor.cc: New file. Processes requests from JS/C++ side to JavaSide. * plugin/icedteanp/IcedTeaJavaRequestProcessor.h: New file. Header for IcedTeaJavaRequestProcessor.cc. * plugin/icedteanp/IcedTeaNPPlugin.cc: Modified to work with the new MessageBus archtecture for the new plugin. Also, moved from top level directory. * plugin/icedteanp/IcedTeaNPPlugin.h: New file. Header for IcedTeaNPPlugin.cc. * plugin/icedteanp/IcedTeaPluginRequestProcessor.cc: New file. Processes plugin data requests from Java side. * plugin/icedteanp/IcedTeaPluginRequestProcessor.h: new file. Header for IcedTeaPluginRequestProcessor.cc. * plugin/icedteanp/IcedTeaPluginUtils.cc: New file. Utility functions for the rest of the plugin code. * plugin/icedteanp/IcedTeaPluginUtils.h: New file. Header for IcedTeaPluginUtils.cc. * plugin/icedteanp/IcedTeaScriptablePluginObject.cc: New file. Scriptable object that extends NPObject and implements hooks from NPClass. * plugin/icedteanp/IcedTeaScriptablePluginObject.h: New file. Header for IcedTeaScriptablePluginObject.h * plugin/icedtea/sun/applet/PluginMessageConsumer.java: Sync with current plugin. * plugin/icedteanp/sun/applet/PluginAppletSecurityContext.java: Same. * plugin/icedteanp/sun/applet/PluginAppletViewer.java: Same. * plugin/icedteanp/sun/applet/PluginCallRequestFactory.java: Same. * plugin/icedteanp/sun/applet/PluginCookieInfoRequest.java: Same * plugin/icedteanp/sun/applet/PluginCookieStore.java: Same. * plugin/icedteanp/sun/applet/PluginMain.java: Same. * plugin/icedteanp/sun/applet/PluginMessageConsumer.java: Same. * rt/net/sourceforge/jnlp/tools/JarSigner.java: Use JarFile instead of JarInputstream when verifying jars. diffstat: 22 files changed, 4471 insertions(+), 2087 deletions(-) ChangeLog | 38 IcedTeaNPPlugin.cc | 2006 --------- Makefile.am | 26 plugin/icedtea/sun/applet/PluginMessageConsumer.java | 2 plugin/icedteanp/IcedTeaJavaRequestProcessor.cc | 195 plugin/icedteanp/IcedTeaJavaRequestProcessor.h | 107 plugin/icedteanp/IcedTeaNPPlugin.cc | 2071 ++++++++++ plugin/icedteanp/IcedTeaNPPlugin.h | 90 plugin/icedteanp/IcedTeaPluginRequestProcessor.cc | 420 ++ plugin/icedteanp/IcedTeaPluginRequestProcessor.h | 108 plugin/icedteanp/IcedTeaPluginUtils.cc | 583 ++ plugin/icedteanp/IcedTeaPluginUtils.h | 244 + plugin/icedteanp/IcedTeaScriptablePluginObject.cc | 113 plugin/icedteanp/IcedTeaScriptablePluginObject.h | 87 plugin/icedteanp/sun/applet/PluginAppletSecurityContext.java | 2 plugin/icedteanp/sun/applet/PluginAppletViewer.java | 238 - plugin/icedteanp/sun/applet/PluginCallRequestFactory.java | 2 plugin/icedteanp/sun/applet/PluginCookieInfoRequest.java | 122 plugin/icedteanp/sun/applet/PluginCookieStore.java | 73 plugin/icedteanp/sun/applet/PluginMain.java | 6 plugin/icedteanp/sun/applet/PluginMessageConsumer.java | 2 rt/net/sourceforge/jnlp/tools/JarSigner.java | 23 diffs (truncated from 6899 to 500 lines): diff -r 1c9399ade69e -r dd1ce0a6da73 ChangeLog --- a/ChangeLog Fri Jul 10 13:12:21 2009 -0400 +++ b/ChangeLog Fri Jul 10 19:02:10 2009 -0400 @@ -1,3 +1,41 @@ 2009-07-10 Lillian Angel + + * Makefile.am: Update makefile to pick up plugin C++ files from new + location. + * plugin/icedtea/sun/applet/PluginMessageConsumer.java : Minor typo fix. + * plugin/icedteanp/IcedTeaJavaRequestProcessor.cc: New file. Processes + requests from JS/C++ side to JavaSide. + * plugin/icedteanp/IcedTeaJavaRequestProcessor.h: New file. Header for + IcedTeaJavaRequestProcessor.cc. + * plugin/icedteanp/IcedTeaNPPlugin.cc: Modified to work with the new + MessageBus archtecture for the new plugin. Also, moved from top level + directory. + * plugin/icedteanp/IcedTeaNPPlugin.h: New file. Header for + IcedTeaNPPlugin.cc. + * plugin/icedteanp/IcedTeaPluginRequestProcessor.cc: New file. Processes + plugin data requests from Java side. + * plugin/icedteanp/IcedTeaPluginRequestProcessor.h: new file. Header for + IcedTeaPluginRequestProcessor.cc. + * plugin/icedteanp/IcedTeaPluginUtils.cc: New file. Utility functions for + the rest of the plugin code. + * plugin/icedteanp/IcedTeaPluginUtils.h: New file. Header for + IcedTeaPluginUtils.cc. + * plugin/icedteanp/IcedTeaScriptablePluginObject.cc: New file. Scriptable + object that extends NPObject and implements hooks from NPClass. + * plugin/icedteanp/IcedTeaScriptablePluginObject.h: New file. Header for + IcedTeaScriptablePluginObject.h + * plugin/icedtea/sun/applet/PluginMessageConsumer.java: Sync with current + plugin. + * plugin/icedteanp/sun/applet/PluginAppletSecurityContext.java: Same. + * plugin/icedteanp/sun/applet/PluginAppletViewer.java: Same. + * plugin/icedteanp/sun/applet/PluginCallRequestFactory.java: Same. + * plugin/icedteanp/sun/applet/PluginCookieInfoRequest.java: Same + * plugin/icedteanp/sun/applet/PluginCookieStore.java: Same. + * plugin/icedteanp/sun/applet/PluginMain.java: Same. + * plugin/icedteanp/sun/applet/PluginMessageConsumer.java: Same. + * rt/net/sourceforge/jnlp/tools/JarSigner.java: Use JarFile instead of + JarInputstream when verifying jars. + 2009-07-10 Lillian Angel * patches/icedtea-graphics.patch: Updated patch to fix Sun bugs 6491856 and diff -r 1c9399ade69e -r dd1ce0a6da73 IcedTeaNPPlugin.cc --- a/IcedTeaNPPlugin.cc Fri Jul 10 13:12:21 2009 -0400 +++ /dev/null Thu Jan 01 00:00:00 1970 +0000 @@ -1,2006 +0,0 @@ -/* gcjwebplugin.cc -- web browser plugin to execute Java applets - Copyright (C) 2003, 2004, 2006, 2007 Free Software Foundation, Inc. - -This file is part of GNU Classpath. - -GNU Classpath is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 2, or (at your option) -any later version. - -GNU Classpath is distributed in the hope that it will be useful, but -WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -General Public License for more details. - -You should have received a copy of the GNU General Public License -along with GNU Classpath; see the file COPYING. If not, write to the -Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA -02110-1301 USA. - -Linking this library statically or dynamically with other modules is -making a combined work based on this library. Thus, the terms and -conditions of the GNU General Public License cover the whole -combination. - -As a special exception, the copyright holders of this library give you -permission to link this library with independent modules to produce an -executable, regardless of the license terms of these independent -modules, and to copy and distribute the resulting executable under -terms of your choice, provided that you also meet, for each linked -independent module, the terms and conditions of the license of that -module. An independent module is a module which is not derived from -or based on this library. If you modify this library, you may extend -this exception to your version of the library, but you are not -obligated to do so. If you do not wish to do so, delete this -exception statement from your version. */ - -// System includes. -#include -#include -#include -#include -#include -#include -#include -#include - -// Netscape plugin API includes. -#include -#include - -// GLib includes. -#include -#include - -// GTK includes. -#include - -// Documentbase retrieval includes. -#include -#include -#include - -// API's into Mozilla -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - - -// Debugging macros. -#define PLUGIN_DEBUG(message) \ - g_print ("GCJ PLUGIN: thread %p: %s\n", g_thread_self (), message) - -#define PLUGIN_DEBUG_TWO(first, second) \ - g_print ("GCJ PLUGIN: thread %p: %s %s\n", g_thread_self (), \ - first, second) - -// Error reporting macros. -#define PLUGIN_ERROR(message) \ - g_printerr ("%s:%d: thread %p: Error: %s\n", __FILE__, __LINE__, \ - g_thread_self (), message) - -#define PLUGIN_ERROR_TWO(first, second) \ - g_printerr ("%s:%d: thread %p: Error: %s: %s\n", __FILE__, __LINE__, \ - g_thread_self (), first, second) - -#define PLUGIN_ERROR_THREE(first, second, third) \ - g_printerr ("%s:%d: thread %p: Error: %s: %s: %s\n", __FILE__, \ - __LINE__, g_thread_self (), first, second, third) - -// Plugin information passed to about:plugins. -#define PLUGIN_NAME "IcedTea NPR Web Browser Plugin (using IcedTea)" -#define PLUGIN_DESC "The " PLUGIN_NAME PLUGIN_VERSION " executes Java applets." -#define PLUGIN_MIME_DESC \ - "application/x-java-vm:class,jar:IcedTea;" \ - "application/x-java-applet:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.1:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.1.1:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.1.2:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.1.3:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.2:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.2.1:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.2.2:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.3:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.3.1:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.4:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.4.1:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.4.2:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.5:class,jar:IcedTea;" \ - "application/x-java-applet;version=1.6:class,jar:IcedTea;" \ - "application/x-java-applet;jpi-version=1.6.0_00:class,jar:IcedTea;" \ - "application/x-java-bean:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.1:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.1.1:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.1.2:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.1.3:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.2:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.2.1:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.2.2:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.3:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.3.1:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.4:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.4.1:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.4.2:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.5:class,jar:IcedTea;" \ - "application/x-java-bean;version=1.6:class,jar:IcedTea;" \ - "application/x-java-bean;jpi-version=1.6.0_00:class,jar:IcedTea;" -#define PLUGIN_URL NS_INLINE_PLUGIN_CONTRACTID_PREFIX NS_JVM_MIME_TYPE -#define PLUGIN_MIME_TYPE "application/x-java-vm" -#define PLUGIN_FILE_EXTS "class,jar,zip" -#define PLUGIN_MIME_COUNT 1 - -#define FAILURE_MESSAGE "gcjwebplugin error: Failed to run %s." \ - " For more detail rerun \"firefox -g\" in a terminal window." - -static int plugin_debug = 1; - -#define PLUGIN_DEBUG_0ARG(str) \ - do \ - { \ - if (plugin_debug) \ - { \ - fprintf(stderr, "GCJ PLUGIN: thread %p: ", g_thread_self ()); \ - fprintf(stderr, str); \ - } \ - } while (0) - -#define PLUGIN_DEBUG_1ARG(str, arg1) \ - do \ - { \ - if (plugin_debug) \ - { \ - fprintf(stderr, "GCJ PLUGIN: thread %p: ", g_thread_self ()); \ - fprintf(stderr, str, arg1); \ - } \ - } while (0) - -#define PLUGIN_DEBUG_2ARG(str, arg1, arg2) \ - do \ - { \ - if (plugin_debug) \ - { \ - fprintf(stderr, "GCJ PLUGIN: thread %p: ", g_thread_self ()); \ - fprintf(stderr, str, arg1, arg2); \ - } \ - } while (0) - -#define PLUGIN_DEBUG_3ARG(str, arg1, arg2, arg3) \ - do \ - { \ - if (plugin_debug) \ - { \ - fprintf(stderr, "GCJ PLUGIN: thread %p: ", g_thread_self ()); \ - fprintf(stderr, str, arg1, arg2, arg3); \ - } \ - } while (0) - -#define PLUGIN_DEBUG_4ARG(str, arg1, arg2, arg3, arg4) \ - do \ - { \ - if (plugin_debug) \ - { \ - fprintf(stderr, "GCJ PLUGIN: thread %p: ", g_thread_self ()); \ - fprintf(stderr, str, arg1, arg2, arg3, arg4); \ - } \ - } while (0) - -// Documentbase retrieval required definition. -static NS_DEFINE_IID (kIPluginTagInfo2IID, NS_IPLUGINTAGINFO2_IID); - -// Browser function table. -static NPNetscapeFuncs browserFunctions; - -// Data directory for plugin. -static gchar* data_directory = NULL; - -// Fully-qualified appletviewer executable. -static gchar* appletviewer_executable = NULL; - -// Applet viewer input channel (needs to be static because it is used in plugin_in_pipe_callback) -static GIOChannel* in_from_appletviewer = NULL; - -// Applet viewer input pipe name. -gchar* in_pipe_name; - -// Applet viewer input watch source. -gint in_watch_source; - -// Applet viewer output pipe name. -gchar* out_pipe_name; - -// Applet viewer output watch source. -gint out_watch_source; - -// Applet viewer output channel. -GIOChannel* out_to_appletviewer; - -// Tracks jvm status -gboolean jvm_up = FALSE; - -// Keeps track of initialization. NP_Initialize should only be -// called once. -gboolean initialized = false; - -GQuark ITNP_PLUGIN_ERROR = g_quark_from_string("IcedTeaNPPlugin"); - -// GCJPluginData stores all the data associated with a single plugin -// instance. A separate plugin instance is created for each -// tag. For now, each plugin instance spawns its own applet viewer -// process but this may need to change if we find pages containing -// multiple applets that expect to be running in the same VM. -struct GCJPluginData -{ - // A unique identifier for this plugin window. - gchar* instance_string; - // Mutex to protect appletviewer_alive. - GMutex* appletviewer_mutex; - // Back-pointer to the plugin instance to which this data belongs. - // This should not be freed but instead simply set to NULL. - NPP owner; - // The address of the plugin window. This should not be freed but - // instead simply set to NULL. - gpointer window_handle; - // The last plugin window width sent to us by the browser. - guint32 window_width; - // The last plugin window height sent to us by the browser. - guint32 window_height; -}; - -// Documentbase retrieval type-punning union. -typedef union -{ - void** void_field; - nsIPluginTagInfo2** info_field; -} info_union; - -// Static instance helper functions. -// Have the browser allocate a new GCJPluginData structure. -static void plugin_data_new (GCJPluginData** data); -// Retrieve the current document's documentbase. -static gchar* plugin_get_documentbase (NPP instance); -// Notify the user that the appletviewer is not installed correctly. -static void plugin_display_failure_dialog (); -// Callback used to monitor input pipe status. -static gboolean plugin_in_pipe_callback (GIOChannel* source, - GIOCondition condition, - gpointer plugin_data); -// Callback used to monitor output pipe status. -static gboolean plugin_out_pipe_callback (GIOChannel* source, - GIOCondition condition, - gpointer plugin_data); -static NPError plugin_start_appletviewer (GCJPluginData* data); -static gchar* plugin_create_applet_tag (int16 argc, char* argn[], - char* argv[]); -static void plugin_send_message_to_appletviewer (gchar const* message); -static void plugin_stop_appletviewer (); -// Uninitialize GCJPluginData structure -static void plugin_data_destroy (NPP instance); - -NS_IMETHODIMP get_cookie_info(const char* siteAddr, char** cookieString); -void get_proxy_info(const char* siteAddr, char** proxy_scheme, char** proxy_host, char** proxy_port, GError *error); -void decode_url(const gchar* url, gchar** decoded_url); -void consume_message(gchar* message); -void start_jvm_if_needed(); -static void appletviewer_monitor(GPid pid, gint status, gpointer data); - -// Global instance counter. -// Mutex to protect plugin_instance_counter. -static GMutex* plugin_instance_mutex = NULL; -// A global variable for reporting GLib errors. This must be free'd -// and set to NULL after each use. -static GError* channel_error = NULL; - -static GHashTable* instance_to_id_map = g_hash_table_new(NULL, NULL); -static GHashTable* id_to_instance_map = g_hash_table_new(NULL, NULL); -static gint instance_counter = 1; -static GPid appletviewer_pid = -1; -static guint appletviewer_watch_id = -1; - -// Functions prefixed by GCJ_ are instance functions. They are called -// by the browser and operate on instances of GCJPluginData. -// Functions prefixed by plugin_ are static helper functions. -// Functions prefixed by NP_ are factory functions. They are called -// by the browser and provide functionality needed to create plugin -// instances. - -// INSTANCE FUNCTIONS - -// Creates a new gcjwebplugin instance. This function creates a -// GCJPluginData* and stores it in instance->pdata. The following -// GCJPluginData fiels are initialized: instance_string, in_pipe_name, -// in_from_appletviewer, in_watch_source, out_pipe_name, -// out_to_appletviewer, out_watch_source, appletviewer_mutex, owner, -// appletviewer_alive. In addition two pipe files are created. All -// of those fields must be properly destroyed, and the pipes deleted, -// by GCJ_Destroy. If an error occurs during initialization then this -// function will free anything that's been allocated so far, set -// instance->pdata to NULL and return an error code. -NPError -GCJ_New (NPMIMEType pluginType, NPP instance, uint16 mode, - int16 argc, char* argn[], char* argv[], - NPSavedData* saved) -{ - PLUGIN_DEBUG ("GCJ_New"); - - NPError np_error = NPERR_NO_ERROR; - GCJPluginData* data = NULL; - - gchar* documentbase = NULL; - gchar* read_message = NULL; - gchar* applet_tag = NULL; - gchar* tag_message = NULL; - gchar* cookie_info = NULL; - - if (!instance) - { - PLUGIN_ERROR ("Browser-provided instance pointer is NULL."); - np_error = NPERR_INVALID_INSTANCE_ERROR; - goto cleanup_done; - } - - // data - plugin_data_new (&data); - if (data == NULL) - { - PLUGIN_ERROR ("Failed to allocate plugin data."); - np_error = NPERR_OUT_OF_MEMORY_ERROR; - goto cleanup_done; - } - - // start the jvm if needed - start_jvm_if_needed(); - - // Initialize data->instance_string. - // - // instance_string should be unique for this process so we use a - // combination of getpid and plugin_instance_counter. - // - // Critical region. Reference and increment plugin_instance_counter - // global. - g_mutex_lock (plugin_instance_mutex); - - // data->instance_string - data->instance_string = g_strdup_printf ("%d", - instance_counter); - - g_mutex_unlock (plugin_instance_mutex); - - // data->appletviewer_mutex - data->appletviewer_mutex = g_mutex_new (); - - g_mutex_lock (data->appletviewer_mutex); - - // Documentbase retrieval. - documentbase = plugin_get_documentbase (instance); - if (!documentbase) - { - PLUGIN_ERROR ("Documentbase retrieval failed." - " Browser not Mozilla-based?"); - goto cleanup_appletviewer_mutex; - } - - // Send applet tag message to appletviewer. - applet_tag = plugin_create_applet_tag (argc, argn, argv); - - tag_message = (gchar*) malloc(strlen(applet_tag)*sizeof(gchar) + 1024); - g_sprintf(tag_message, "instance %d tag %s %s", instance_counter, documentbase, applet_tag); - - //plugin_send_message_to_appletviewer (data, data->instance_string); - plugin_send_message_to_appletviewer (tag_message); - - //send cookie information - char* cookie_string; - if (get_cookie_info(documentbase, &cookie_string) == NS_OK) - { - cookie_info = (gchar*) malloc(sizeof(cookie_string) + 1024); - g_sprintf(cookie_info, "instance %d cookie %s", instance_counter, cookie_string); - } - else - { - cookie_info = (gchar*) malloc(1024); - g_sprintf(cookie_info, "instance %d cookie", instance_counter); - } - - plugin_send_message_to_appletviewer (cookie_info); - - g_mutex_unlock (data->appletviewer_mutex); - - // If initialization succeeded entirely then we store the plugin - // data in the instance structure and return. Otherwise we free the - // data we've allocated so far and set instance->pdata to NULL. - - // Set back-pointer to owner instance. - data->owner = instance; - instance->pdata = data; - goto cleanup_done; - - cleanup_appletviewer_mutex: - g_free (data->appletviewer_mutex); - data->appletviewer_mutex = NULL; - - // cleanup_instance_string: - g_free (data->instance_string); - data->instance_string = NULL; - - // cleanup_data: - // Eliminate back-pointer to plugin instance. - data->owner = NULL; - (*browserFunctions.memfree) (data); - data = NULL; - - // Initialization failed so return a NULL pointer for the browser - // data. - instance->pdata = NULL; - - cleanup_done: - g_free (tag_message); - tag_message = NULL; - g_free (applet_tag); - applet_tag = NULL; - g_free (read_message); From bugzilla-daemon at icedtea.classpath.org Fri Jul 10 23:04:03 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Sat, 11 Jul 2009 06:04:03 +0000 Subject: [Bug 366] New: [powerpc] shark enabled openjdk-6 20090710 fails with llvm 20090710 Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=366 Summary: [powerpc] shark enabled openjdk-6 20090710 fails with llvm 20090710 Product: IcedTea Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: doko at ubuntu.com the stage1 jvm built with gcj fails with: mkdir -p stamps touch stamps/bootstrap-directory.stamp mkdir -p bootstrap rm -f bootstrap/jdk1.6.0 ln -sf /home/doko/openjdk/openjdk-6-6b16~pre4/build/bootstrap/icedtea bootstrap/jdk1.6.0; \ if ! bootstrap/jdk1.6.0/bin/java -version ; \ then \ echo "bootstrap/jdk1.6.0/bin/java" \ "cannot be found or is corrupted." ; \ exit 1; \ fi java version "1.6.0_0" OpenJDK Runtime Environment (IcedTea6 1.5) (6b16~pre4-0ubuntu4) OpenJDK Shark VM (build 14.0-b15, mixed mode) java: /build/buildd/llvm-2.5+svn20090710/lib/Target/PowerPC/PPCISelLowering.cpp:1159: llvm::SDValue llvm::PPCTargetLowering::LowerGlobalTLSAddress(llvm::SDValue, llvm::SelectionDAG&): Assertion `0 && "TLS not implemented for PPC."' failed. Stack dump: 0. Running pass 'PowerPC DAG->DAG Pattern Instruction Selection' on function '@"java.lang.String::hashCode"' /bin/bash: line 6: 25211 Aborted bootstrap/jdk1.6.0/bin/java -version bootstrap/jdk1.6.0/bin/java cannot be found or is corrupted. make[1]: *** [stamps/bootstrap-directory-symlink.stamp] Error 1 -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Sat Jul 11 09:20:35 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Sat, 11 Jul 2009 16:20:35 +0000 Subject: [Bug 367] New: Interactive brokers fails / libjpeg7 related? Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=367 Summary: Interactive brokers fails / libjpeg7 related? Product: IcedTea Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: IcedTea AssignedTo: unassigned at icedtea.classpath.org ReportedBy: a.radke at arcor.de I'm running ArchLinux with openjdk6 java -version java version "1.6.0_0" OpenJDK Runtime Environment (IcedTea6 1.5) (ArchLinux-1.5-4-x86_64) OpenJDK 64-Bit Server VM (build 14.0-b15, mixed mode) and I cannot open the broker software from http://www.interactivebrokers.com/de/p.php?f=tws&ib_entity=de the browser will stop to open it and the downloaded version under "UNIX Download" fails. I confirmed that the downloaded version works with SUNs jre. I have another report Openjdk6 failing another application on jpeg action. I've already tried to revert the hardcoded paths to libjpeg.so.7 http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2008-February/001142.html without success. Any idea if libjpeg update indeed causes the crash and how to solve it? -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Sat Jul 11 09:21:29 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Sat, 11 Jul 2009 16:21:29 +0000 Subject: [Bug 367] Interactive brokers fails / libjpeg7 related? Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=367 ------- Comment #1 from a.radke at arcor.de 2009-07-11 16:21 ------- Created an attachment (id=246) --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=246&action=view) crash.log -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From a.radke at arcor.de Sat Jul 11 09:25:32 2009 From: a.radke at arcor.de (Andreas Radke) Date: Sat, 11 Jul 2009 18:25:32 +0200 Subject: Interactive brokers fails to start In-Reply-To: <20090710212132.59cb778e@workstation64.home> References: <20090710083424.565b2bd8@workstation64.home> <20090710201051.3f50ce06@workstation64.home> <20090710212132.59cb778e@workstation64.home> Message-ID: <20090711182532.2cfdadef@workstation64.home> filed a bug... http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=367 From bugzilla-daemon at icedtea.classpath.org Sat Jul 11 13:08:05 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Sat, 11 Jul 2009 20:08:05 +0000 Subject: [Bug 289] Gentoo QA Notice: "poor programming practices" Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=289 gnu_andrew at member.fsf.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED ------- Comment #8 from gnu_andrew at member.fsf.org 2009-07-11 20:08 ------- Upstream: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/880896883a47 -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From braden at endoframe.com Mon Jul 13 01:50:27 2009 From: braden at endoframe.com (Braden McDaniel) Date: Mon, 13 Jul 2009 04:50:27 -0400 Subject: Finding OpenJDK include paths Message-ID: <1247475027.6944.8503.camel@localhost> When building a Fedora package that uses JNI, I've found it necessary to set CPPFLAGS as such: CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" Is there any more clever mechanism available? -- Braden McDaniel From omajid at redhat.com Mon Jul 13 06:43:17 2009 From: omajid at redhat.com (Omair Majid) Date: Mon, 13 Jul 2009 09:43:17 -0400 Subject: Finding OpenJDK include paths In-Reply-To: <1247475027.6944.8503.camel@localhost> References: <1247475027.6944.8503.camel@localhost> Message-ID: <4A5B39F5.9080000@redhat.com> Braden McDaniel wrote: > When building a Fedora package that uses JNI, I've found it necessary to > set CPPFLAGS as such: > > CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" > > Is there any more clever mechanism available? > You might want to take a look at this: http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 Cheers, Omair From bugzilla-daemon at icedtea.classpath.org Mon Jul 13 06:54:34 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Mon, 13 Jul 2009 13:54:34 +0000 Subject: [Bug 330] Fedora 10 vuze SWT crash Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=330 ------- Comment #2 from jon.vanalten at redhat.com 2009-07-13 13:54 ------- Hi Stu, Are you still getting these crashes post-upgrade? If so, can you post log as attachment and describe what prompts this (if anything in particular). I have not been able to reproduce this. (will close if no response in ~1 week). thx -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From dbhole at redhat.com Mon Jul 13 11:07:48 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Mon, 13 Jul 2009 14:07:48 -0400 Subject: RFC: Netx - Use version based download protocol for JNLP files In-Reply-To: <4A57636B.7000503@redhat.com> References: <4A57636B.7000503@redhat.com> Message-ID: <20090713180748.GD3453@redhat.com> * Omair Majid [2009-07-10 11:51]: > Hi, > > This patch makes Netx use the version based download protocol for JNLP > files. > > Netx tries to use the version based download protocol whenever possible > to download files. This wasn't being done for JNLP file that were > specified as extensions by other JNLP files. This patch fixes the issue > making JNLP applications like aerith[1] work. This is also required to > run JavaFX applications. > > While adding that support, I noticed that function arguments that > involved Urls and versions were inconsistent: some used function(URL, > Version, blah) while others used function(URL, blah, Version). I have > tried to fix them to be function(URL, Version, blah) consistently. > > ChangeLog: > 2009-07-10 Omair Majid > > * rt/net/sourceforge/jnlp/JNLPFile.java > (JNLPFile): Delegate to the Version-based constructor. > (JNLPFile): New constructor. > (JNLPFile): Modified to take an additional version argument used in > downloading the JNLP file. > (openURL): Take an additional version argument and use when > downloading the URL. > * rt/net/sourceforge/jnlp/Launcher.java > (toFile): Use the new JNLPFile constructor. > * rt/net/sourceforge/jnlp/cache/Resource.java > (Resource): Rearrange argument order. > (getResource): Likewise. Fix parameters to constructor. > * rt/net/sourceforge/jnlp/cache/ResourceTracker.java > (addResource): Fix arguments to Resource.getResource. > * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java > (getInstance): Take additional version argument and useit when > creating a JNLPFile. > (initializeExtensions): Use the extension version when requesting a > JNLPClassLoader. > > Looks good. One question though.. why are the order of arguments to Resource() and getResource() being changed? Deepak > Any comments? > > Cheers, > Omair > > [1] https://aerith.dev.java.net/ > diff -r 7acbff01007f rt/net/sourceforge/jnlp/JNLPFile.java > --- a/rt/net/sourceforge/jnlp/JNLPFile.java Thu Jul 09 17:29:13 2009 -0400 > +++ b/rt/net/sourceforge/jnlp/JNLPFile.java Fri Jul 10 11:11:59 2009 -0400 > @@ -138,21 +138,36 @@ > * @throws ParseException if the JNLP file was invalid > */ > public JNLPFile(URL location, boolean strict) throws IOException, ParseException { > - this(location, strict, JNLPRuntime.getDefaultUpdatePolicy()); > + this(location, (Version) null, strict); > + } > + > + /** > + * Create a JNLPFile from a URL and a Version checking for updates using > + * the default policy. > + * > + * @param location the location of the JNLP file > + * @param version the version of the JNLP file > + * @param strict whether to enforce the spec when > + * @throws IOException if an IO exception occurred > + * @throws ParseException if the JNLP file was invalid > + */ > + public JNLPFile(URL location, Version version, boolean strict) throws IOException, ParseException { > + this(location, version, strict, JNLPRuntime.getDefaultUpdatePolicy()); > } > > /** > - * Create a JNLPFile from a URL checking for updates using the > - * specified policy. > + * Create a JNLPFile from a URL and a version, checking for updates > + * using the specified policy. > * > * @param location the location of the JNLP file > + * @param version the version of the JNLP file > * @param strict whether to enforce the spec when > * @param policy the update policy > * @throws IOException if an IO exception occurred > * @throws ParseException if the JNLP file was invalid > */ > - public JNLPFile(URL location, boolean strict, UpdatePolicy policy) throws IOException, ParseException { > - Node root = Parser.getRootNode(openURL(location, policy)); > + public JNLPFile(URL location, Version version, boolean strict, UpdatePolicy policy) throws IOException, ParseException { > + Node root = Parser.getRootNode(openURL(location, version, policy)); > parse(root, strict, location); > > this.fileLocation = location; > @@ -186,13 +201,13 @@ > * Open the jnlp file URL from the cache if there, otherwise > * download to the cache. Called from constructor. > */ > - private static InputStream openURL(URL location, UpdatePolicy policy) throws IOException { > + private static InputStream openURL(URL location, Version version, UpdatePolicy policy) throws IOException { > if (location == null || policy == null) > throw new IllegalArgumentException(R("NullParameter")); > > try { > ResourceTracker tracker = new ResourceTracker(false); // no prefetch > - tracker.addResource(location, null/*version*/, policy); > + tracker.addResource(location, version , policy); > > return tracker.getInputStream(location); > } > diff -r 7acbff01007f rt/net/sourceforge/jnlp/Launcher.java > --- a/rt/net/sourceforge/jnlp/Launcher.java Thu Jul 09 17:29:13 2009 -0400 > +++ b/rt/net/sourceforge/jnlp/Launcher.java Fri Jul 10 11:11:59 2009 -0400 > @@ -337,10 +337,10 @@ > JNLPFile file = null; > > try { > - file = new JNLPFile(location, true, updatePolicy); // strict > + file = new JNLPFile(location, (Version) null, true, updatePolicy); // strict > } > catch (ParseException ex) { > - file = new JNLPFile(location, false, updatePolicy); > + file = new JNLPFile(location, (Version) null, false, updatePolicy); > > // only here if strict failed but lax did not fail > LaunchException lex = > diff -r 7acbff01007f rt/net/sourceforge/jnlp/cache/Resource.java > --- a/rt/net/sourceforge/jnlp/cache/Resource.java Thu Jul 09 17:29:13 2009 -0400 > +++ b/rt/net/sourceforge/jnlp/cache/Resource.java Fri Jul 10 11:11:59 2009 -0400 > @@ -95,7 +95,7 @@ > /** > * Create a resource. > */ > - private Resource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { > + private Resource(URL location, Version requestVersion, UpdatePolicy updatePolicy) { > this.location = location; > this.requestVersion = requestVersion; > this.updatePolicy = updatePolicy; > @@ -105,9 +105,9 @@ > * Return a shared Resource object representing the given > * location and version. > */ > - public static Resource getResource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { > + public static Resource getResource(URL location, Version requestVersion, UpdatePolicy updatePolicy) { > synchronized (resources) { > - Resource resource = new Resource(location, updatePolicy, requestVersion); > + Resource resource = new Resource(location, requestVersion, updatePolicy); > > int index = resources.indexOf(resource); > if (index >= 0) { // return existing object > diff -r 7acbff01007f rt/net/sourceforge/jnlp/cache/ResourceTracker.java > --- a/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Thu Jul 09 17:29:13 2009 -0400 > +++ b/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Fri Jul 10 11:11:59 2009 -0400 > @@ -168,7 +168,7 @@ > if (location == null) > throw new IllegalArgumentException("location==null"); > > - Resource resource = Resource.getResource(location, updatePolicy, version); > + Resource resource = Resource.getResource(location, version, updatePolicy); > boolean downloaded = false; > > synchronized (resources) { > diff -r 7acbff01007f rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java > --- a/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Thu Jul 09 17:29:13 2009 -0400 > +++ b/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Fri Jul 10 11:11:59 2009 -0400 > @@ -51,6 +51,7 @@ > import net.sourceforge.jnlp.PluginBridge; > import net.sourceforge.jnlp.ResourcesDesc; > import net.sourceforge.jnlp.SecurityDesc; > +import net.sourceforge.jnlp.Version; > import net.sourceforge.jnlp.cache.CacheUtil; > import net.sourceforge.jnlp.cache.ResourceTracker; > import net.sourceforge.jnlp.cache.UpdatePolicy; > @@ -232,13 +233,15 @@ > * location. > * > * @param location the file's location > + * @param version the file's version > * @param policy the update policy to use when downloading resources > */ > - public static JNLPClassLoader getInstance(URL location, UpdatePolicy policy) throws IOException, ParseException, LaunchException { > + public static JNLPClassLoader getInstance(URL location, Version version, UpdatePolicy policy) > + throws IOException, ParseException, LaunchException { > JNLPClassLoader loader = (JNLPClassLoader) urlToLoader.get(location); > > if (loader == null) > - loader = getInstance(new JNLPFile(location, false, policy), policy); > + loader = getInstance(new JNLPFile(location, version, false, policy), policy); > > return loader; > } > @@ -256,7 +259,7 @@ > //if (ext != null) { > for (int i=0; i < ext.length; i++) { > try { > - JNLPClassLoader loader = getInstance(ext[i].getLocation(), updatePolicy); > + JNLPClassLoader loader = getInstance(ext[i].getLocation(), ext[i].getVersion(), updatePolicy); > loaderList.add(loader); > } > catch (Exception ex) { From omajid at redhat.com Mon Jul 13 11:28:15 2009 From: omajid at redhat.com (Omair Majid) Date: Mon, 13 Jul 2009 14:28:15 -0400 Subject: RFE: Patch to fix jar signature verification In-Reply-To: <20090710224447.GA32059@redhat.com> References: <20090710224447.GA32059@redhat.com> Message-ID: <4A5B7CBF.2080205@redhat.com> Deepak Bhole wrote: > Hi, > > Currently, we use JarInputStream when reading the jar to verify > signatures. JarInputStream does not work unless manifest file is the > first file in the jar. As a result, signed jars end up being treated as > unsigned, causing those applets to not work. > > This patch fixes that by using JarFile instead, which does not have the > "manifest must be first" restriction. > > Fixes: > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=325 > https://bugzilla.redhat.com/show_bug.cgi?id=502318 > > ChangeLog: > > * plugin/icedtea/sun/applet/PluginMessageConsumer.java: Fix minor typo in > how max worker count is interpreted. > * rt/net/sourceforge/jnlp/tools/JarSigner.java: use JarFile instead of > JarInputstream when verifying jars. > Looks good to me! Cheers, Omair From dbhole at redhat.com Mon Jul 13 11:48:41 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Mon, 13 Jul 2009 14:48:41 -0400 Subject: RFE: Patch to fix jar signature verification In-Reply-To: <4A5B7CBF.2080205@redhat.com> References: <20090710224447.GA32059@redhat.com> <4A5B7CBF.2080205@redhat.com> Message-ID: <20090713184841.GE3453@redhat.com> * Omair Majid [2009-07-13 14:28]: > Deepak Bhole wrote: >> Hi, >> >> Currently, we use JarInputStream when reading the jar to verify >> signatures. JarInputStream does not work unless manifest file is the >> first file in the jar. As a result, signed jars end up being treated as >> unsigned, causing those applets to not work. >> >> This patch fixes that by using JarFile instead, which does not have the >> "manifest must be first" restriction. >> >> Fixes: >> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=325 >> https://bugzilla.redhat.com/show_bug.cgi?id=502318 >> >> ChangeLog: >> >> * plugin/icedtea/sun/applet/PluginMessageConsumer.java: Fix minor typo in >> how max worker count is interpreted. >> * rt/net/sourceforge/jnlp/tools/JarSigner.java: use JarFile instead of >> JarInputstream when verifying jars. >> > > Looks good to me! > Thanks! Just realized that I already accidentally committed the changes on Friday, when I committed the new plugin code. The rt/ directory is common to both old and new plugins .. so it went along with that. I guess there is nothing to do for this one. Thanks for reviewing! Deepak From omajid at redhat.com Mon Jul 13 11:47:10 2009 From: omajid at redhat.com (Omair Majid) Date: Mon, 13 Jul 2009 14:47:10 -0400 Subject: RFC: Netx - Use version based download protocol for JNLP files In-Reply-To: <20090713180748.GD3453@redhat.com> References: <4A57636B.7000503@redhat.com> <20090713180748.GD3453@redhat.com> Message-ID: <4A5B812E.10100@redhat.com> Deepak Bhole wrote: > * Omair Majid [2009-07-10 11:51]: >> Hi, >> >> This patch makes Netx use the version based download protocol for JNLP >> files. >> >> Netx tries to use the version based download protocol whenever possible >> to download files. This wasn't being done for JNLP file that were >> specified as extensions by other JNLP files. This patch fixes the issue >> making JNLP applications like aerith[1] work. This is also required to >> run JavaFX applications. >> >> While adding that support, I noticed that function arguments that >> involved Urls and versions were inconsistent: some used function(URL, >> Version, blah) while others used function(URL, blah, Version). I have >> tried to fix them to be function(URL, Version, blah) consistently. >> >> ChangeLog: >> 2009-07-10 Omair Majid >> >> * rt/net/sourceforge/jnlp/JNLPFile.java >> (JNLPFile): Delegate to the Version-based constructor. >> (JNLPFile): New constructor. >> (JNLPFile): Modified to take an additional version argument used in >> downloading the JNLP file. >> (openURL): Take an additional version argument and use when >> downloading the URL. >> * rt/net/sourceforge/jnlp/Launcher.java >> (toFile): Use the new JNLPFile constructor. >> * rt/net/sourceforge/jnlp/cache/Resource.java >> (Resource): Rearrange argument order. >> (getResource): Likewise. Fix parameters to constructor. >> * rt/net/sourceforge/jnlp/cache/ResourceTracker.java >> (addResource): Fix arguments to Resource.getResource. >> * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java >> (getInstance): Take additional version argument and useit when >> creating a JNLPFile. >> (initializeExtensions): Use the extension version when requesting a >> JNLPClassLoader. >> >> > > Looks good. One question though.. why are the order of arguments to > Resource() and getResource() being changed? > Obviously I didnt do a good job explaining this in the original email. There are many functions in Netx that require a URL, a Version and an UpdatePolicy: $ find -iname '*java' | xargs grep 'URL.*Policy' ./cache/ResourceTracker.java: public void addResource(URL location, Version version, UpdatePolicy updatePolicy) { ./cache/CacheUtil.java: public static URL getCachedResource(URL location, Version version, UpdatePolicy policy) { ./cache/Resource.java: private Resource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { ./cache/Resource.java: public static Resource getResource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { ./Launcher.java: resourceTracker.addResource(splashImageURL, file.getFileVersion(), updatePolicy); These functions dont have a consistent argument order. Some take (URL, Version, UpdatePolicy) while others take (URL, UpdatePolicy, Version). I wanted to make the order consistent. To me, URL and Version are much more strongly related than URL and UpdatePolicy, so I tried to fix everything to be (URL, Version, UpdatePolicy). Is that a sensible change to make? Cheers, Omair From braden at endoframe.com Mon Jul 13 12:01:47 2009 From: braden at endoframe.com (Braden McDaniel) Date: Mon, 13 Jul 2009 15:01:47 -0400 Subject: Finding OpenJDK include paths In-Reply-To: <4A5B39F5.9080000@redhat.com> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> Message-ID: <4A5B849B.3060903@endoframe.com> On 7/13/09 9:43 AM, Omair Majid wrote: > Braden McDaniel wrote: >> When building a Fedora package that uses JNI, I've found it necessary to >> set CPPFLAGS as such: >> >> CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" >> >> Is there any more clever mechanism available? >> > > You might want to take a look at this: > http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 Thanks... Looks like the answer is "no". :-/ -- Braden McDaniel e-mail: Jabber: From aph at redhat.com Mon Jul 13 12:07:18 2009 From: aph at redhat.com (Andrew Haley) Date: Mon, 13 Jul 2009 20:07:18 +0100 Subject: Finding OpenJDK include paths In-Reply-To: <4A5B849B.3060903@endoframe.com> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> <4A5B849B.3060903@endoframe.com> Message-ID: <4A5B85E6.4090107@redhat.com> Braden McDaniel wrote: > On 7/13/09 9:43 AM, Omair Majid wrote: >> Braden McDaniel wrote: >>> When building a Fedora package that uses JNI, I've found it necessary to >>> set CPPFLAGS as such: >>> >>> CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" >>> >>> Is there any more clever mechanism available? >>> >> >> You might want to take a look at this: >> http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 > > Thanks... Looks like the answer is "no". :-/ Try had as I can, I can't think of anything better. Looks perfect to me! :-) Andrew. From dbhole at redhat.com Mon Jul 13 12:16:01 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Mon, 13 Jul 2009 15:16:01 -0400 Subject: RFC: Netx - Use version based download protocol for JNLP files In-Reply-To: <4A5B812E.10100@redhat.com> References: <4A57636B.7000503@redhat.com> <20090713180748.GD3453@redhat.com> <4A5B812E.10100@redhat.com> Message-ID: <20090713191601.GF3453@redhat.com> * Omair Majid [2009-07-13 14:47]: > Deepak Bhole wrote: >> * Omair Majid [2009-07-10 11:51]: >>> Hi, >>> >>> This patch makes Netx use the version based download protocol for >>> JNLP files. >>> >>> Netx tries to use the version based download protocol whenever >>> possible to download files. This wasn't being done for JNLP file >>> that were specified as extensions by other JNLP files. This patch >>> fixes the issue making JNLP applications like aerith[1] work. This >>> is also required to run JavaFX applications. >>> >>> While adding that support, I noticed that function arguments that >>> involved Urls and versions were inconsistent: some used function(URL, >>> Version, blah) while others used function(URL, blah, Version). I >>> have tried to fix them to be function(URL, Version, blah) >>> consistently. >>> >>> ChangeLog: >>> 2009-07-10 Omair Majid >>> >>> * rt/net/sourceforge/jnlp/JNLPFile.java >>> (JNLPFile): Delegate to the Version-based constructor. >>> (JNLPFile): New constructor. >>> (JNLPFile): Modified to take an additional version argument used in >>> downloading the JNLP file. >>> (openURL): Take an additional version argument and use when >>> downloading the URL. >>> * rt/net/sourceforge/jnlp/Launcher.java >>> (toFile): Use the new JNLPFile constructor. >>> * rt/net/sourceforge/jnlp/cache/Resource.java >>> (Resource): Rearrange argument order. >>> (getResource): Likewise. Fix parameters to constructor. >>> * rt/net/sourceforge/jnlp/cache/ResourceTracker.java >>> (addResource): Fix arguments to Resource.getResource. >>> * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java >>> (getInstance): Take additional version argument and useit when >>> creating a JNLPFile. >>> (initializeExtensions): Use the extension version when requesting a >>> JNLPClassLoader. >>> >>> >> >> Looks good. One question though.. why are the order of arguments to >> Resource() and getResource() being changed? >> > > Obviously I didnt do a good job explaining this in the original email. > There are many functions in Netx that require a URL, a Version and an > UpdatePolicy: > > $ find -iname '*java' | xargs grep 'URL.*Policy' > ./cache/ResourceTracker.java: public void addResource(URL location, > Version version, UpdatePolicy updatePolicy) { > ./cache/CacheUtil.java: public static URL getCachedResource(URL > location, Version version, UpdatePolicy policy) { > ./cache/Resource.java: private Resource(URL location, UpdatePolicy > updatePolicy, Version requestVersion) { > ./cache/Resource.java: public static Resource getResource(URL > location, UpdatePolicy updatePolicy, Version requestVersion) { > ./Launcher.java: resourceTracker.addResource(splashImageURL, > file.getFileVersion(), updatePolicy); > > These functions dont have a consistent argument order. Some take (URL, > Version, UpdatePolicy) while others take (URL, UpdatePolicy, Version). I > wanted to make the order consistent. To me, URL and Version are much > more strongly related than URL and UpdatePolicy, so I tried to fix > everything to be (URL, Version, UpdatePolicy). Is that a sensible change > to make? > Fair enough. Okay, looks good. Assuming you have tested it, go ahead and commit. Deepak > Cheers, > Omair From omajid at redhat.com Mon Jul 13 12:21:01 2009 From: omajid at redhat.com (Omair Majid) Date: Mon, 13 Jul 2009 19:21:01 +0000 Subject: changeset in /hg/icedtea6: Netx: Use version based download prot... Message-ID: changeset 96da5a90598a in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=96da5a90598a description: Netx: Use version based download protocol for JNLP files too 2009-07-13 Omair Majid * rt/net/sourceforge/jnlp/JNLPFile.java (JNLPFile): Delegate to the Version-based constructor. (JNLPFile): New constructor. (JNLPFile): Modified to take an additional version argument used in downloading the JNLP file. (openURL): Take an additional version argument and use when downloading the URL. * rt/net/sourceforge/jnlp/Launcher.java (toFile): Use the new JNLPFile constructor. * rt/net/sourceforge/jnlp/cache/Resource.java (Resource): Rearrange argument order. (getResource): Likewise. Fix parameters to constructor. * rt/net/sourceforge/jnlp/cache/ResourceTracker.java (addResource): Fix arguments to Resource.getResource. * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java (getInstance): Take additional version argument and use it when creating a JNLPFile. (initializeExtensions): Use the extension version when requesting a JNLPClassLoader. diffstat: 6 files changed, 59 insertions(+), 19 deletions(-) ChangeLog | 22 +++++++++++ rt/net/sourceforge/jnlp/JNLPFile.java | 35 ++++++++++++------ rt/net/sourceforge/jnlp/Launcher.java | 4 +- rt/net/sourceforge/jnlp/cache/Resource.java | 6 +-- rt/net/sourceforge/jnlp/cache/ResourceTracker.java | 2 - rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java | 9 +++- diffs (183 lines): diff -r dd1ce0a6da73 -r 96da5a90598a ChangeLog --- a/ChangeLog Fri Jul 10 19:02:10 2009 -0400 +++ b/ChangeLog Mon Jul 13 15:22:34 2009 -0400 @@ -1,3 +1,25 @@ 2009-07-10 Deepak Bhole + + * rt/net/sourceforge/jnlp/JNLPFile.java + (JNLPFile): Delegate to the Version-based constructor. + (JNLPFile): New constructor. + (JNLPFile): Modified to take an additional version argument used in + downloading the JNLP file. + (openURL): Take an additional version argument and use when downloading + the URL. + * rt/net/sourceforge/jnlp/Launcher.java + (toFile): Use the new JNLPFile constructor. + * rt/net/sourceforge/jnlp/cache/Resource.java + (Resource): Rearrange argument order. + (getResource): Likewise. Fix parameters to constructor. + * rt/net/sourceforge/jnlp/cache/ResourceTracker.java + (addResource): Fix arguments to Resource.getResource. + * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java + (getInstance): Take additional version argument and use it when creating a + JNLPFile. + (initializeExtensions): Use the extension version when requesting a + JNLPClassLoader. + 2009-07-10 Deepak Bhole * Makefile.am: Update makefile to pick up plugin C++ files from new diff -r dd1ce0a6da73 -r 96da5a90598a rt/net/sourceforge/jnlp/JNLPFile.java --- a/rt/net/sourceforge/jnlp/JNLPFile.java Fri Jul 10 19:02:10 2009 -0400 +++ b/rt/net/sourceforge/jnlp/JNLPFile.java Mon Jul 13 15:22:34 2009 -0400 @@ -138,21 +138,36 @@ public class JNLPFile { * @throws ParseException if the JNLP file was invalid */ public JNLPFile(URL location, boolean strict) throws IOException, ParseException { - this(location, strict, JNLPRuntime.getDefaultUpdatePolicy()); - } - - /** - * Create a JNLPFile from a URL checking for updates using the - * specified policy. + this(location, (Version) null, strict); + } + + /** + * Create a JNLPFile from a URL and a Version checking for updates using + * the default policy. * * @param location the location of the JNLP file + * @param version the version of the JNLP file + * @param strict whether to enforce the spec when + * @throws IOException if an IO exception occurred + * @throws ParseException if the JNLP file was invalid + */ + public JNLPFile(URL location, Version version, boolean strict) throws IOException, ParseException { + this(location, version, strict, JNLPRuntime.getDefaultUpdatePolicy()); + } + + /** + * Create a JNLPFile from a URL and a version, checking for updates + * using the specified policy. + * + * @param location the location of the JNLP file + * @param version the version of the JNLP file * @param strict whether to enforce the spec when * @param policy the update policy * @throws IOException if an IO exception occurred * @throws ParseException if the JNLP file was invalid */ - public JNLPFile(URL location, boolean strict, UpdatePolicy policy) throws IOException, ParseException { - Node root = Parser.getRootNode(openURL(location, policy)); + public JNLPFile(URL location, Version version, boolean strict, UpdatePolicy policy) throws IOException, ParseException { + Node root = Parser.getRootNode(openURL(location, version, policy)); parse(root, strict, location); this.fileLocation = location; @@ -186,13 +201,13 @@ public class JNLPFile { * Open the jnlp file URL from the cache if there, otherwise * download to the cache. Called from constructor. */ - private static InputStream openURL(URL location, UpdatePolicy policy) throws IOException { + private static InputStream openURL(URL location, Version version, UpdatePolicy policy) throws IOException { if (location == null || policy == null) throw new IllegalArgumentException(R("NullParameter")); try { ResourceTracker tracker = new ResourceTracker(false); // no prefetch - tracker.addResource(location, null/*version*/, policy); + tracker.addResource(location, version , policy); return tracker.getInputStream(location); } diff -r dd1ce0a6da73 -r 96da5a90598a rt/net/sourceforge/jnlp/Launcher.java --- a/rt/net/sourceforge/jnlp/Launcher.java Fri Jul 10 19:02:10 2009 -0400 +++ b/rt/net/sourceforge/jnlp/Launcher.java Mon Jul 13 15:22:34 2009 -0400 @@ -337,10 +337,10 @@ public class Launcher { JNLPFile file = null; try { - file = new JNLPFile(location, true, updatePolicy); // strict + file = new JNLPFile(location, (Version) null, true, updatePolicy); // strict } catch (ParseException ex) { - file = new JNLPFile(location, false, updatePolicy); + file = new JNLPFile(location, (Version) null, false, updatePolicy); // only here if strict failed but lax did not fail LaunchException lex = diff -r dd1ce0a6da73 -r 96da5a90598a rt/net/sourceforge/jnlp/cache/Resource.java --- a/rt/net/sourceforge/jnlp/cache/Resource.java Fri Jul 10 19:02:10 2009 -0400 +++ b/rt/net/sourceforge/jnlp/cache/Resource.java Mon Jul 13 15:22:34 2009 -0400 @@ -95,7 +95,7 @@ public class Resource { /** * Create a resource. */ - private Resource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { + private Resource(URL location, Version requestVersion, UpdatePolicy updatePolicy) { this.location = location; this.requestVersion = requestVersion; this.updatePolicy = updatePolicy; @@ -105,9 +105,9 @@ public class Resource { * Return a shared Resource object representing the given * location and version. */ - public static Resource getResource(URL location, UpdatePolicy updatePolicy, Version requestVersion) { + public static Resource getResource(URL location, Version requestVersion, UpdatePolicy updatePolicy) { synchronized (resources) { - Resource resource = new Resource(location, updatePolicy, requestVersion); + Resource resource = new Resource(location, requestVersion, updatePolicy); int index = resources.indexOf(resource); if (index >= 0) { // return existing object diff -r dd1ce0a6da73 -r 96da5a90598a rt/net/sourceforge/jnlp/cache/ResourceTracker.java --- a/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Fri Jul 10 19:02:10 2009 -0400 +++ b/rt/net/sourceforge/jnlp/cache/ResourceTracker.java Mon Jul 13 15:22:34 2009 -0400 @@ -168,7 +168,7 @@ public class ResourceTracker { if (location == null) throw new IllegalArgumentException("location==null"); - Resource resource = Resource.getResource(location, updatePolicy, version); + Resource resource = Resource.getResource(location, version, updatePolicy); boolean downloaded = false; synchronized (resources) { diff -r dd1ce0a6da73 -r 96da5a90598a rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java --- a/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Fri Jul 10 19:02:10 2009 -0400 +++ b/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java Mon Jul 13 15:22:34 2009 -0400 @@ -51,6 +51,7 @@ import net.sourceforge.jnlp.PluginBridge import net.sourceforge.jnlp.PluginBridge; import net.sourceforge.jnlp.ResourcesDesc; import net.sourceforge.jnlp.SecurityDesc; +import net.sourceforge.jnlp.Version; import net.sourceforge.jnlp.cache.CacheUtil; import net.sourceforge.jnlp.cache.ResourceTracker; import net.sourceforge.jnlp.cache.UpdatePolicy; @@ -232,13 +233,15 @@ public class JNLPClassLoader extends URL * location. * * @param location the file's location + * @param version the file's version * @param policy the update policy to use when downloading resources */ - public static JNLPClassLoader getInstance(URL location, UpdatePolicy policy) throws IOException, ParseException, LaunchException { + public static JNLPClassLoader getInstance(URL location, Version version, UpdatePolicy policy) + throws IOException, ParseException, LaunchException { JNLPClassLoader loader = (JNLPClassLoader) urlToLoader.get(location); if (loader == null) - loader = getInstance(new JNLPFile(location, false, policy), policy); + loader = getInstance(new JNLPFile(location, version, false, policy), policy); return loader; } @@ -256,7 +259,7 @@ public class JNLPClassLoader extends URL //if (ext != null) { for (int i=0; i < ext.length; i++) { try { - JNLPClassLoader loader = getInstance(ext[i].getLocation(), updatePolicy); + JNLPClassLoader loader = getInstance(ext[i].getLocation(), ext[i].getVersion(), updatePolicy); loaderList.add(loader); } catch (Exception ex) { From omajid at redhat.com Mon Jul 13 12:26:25 2009 From: omajid at redhat.com (Omair Majid) Date: Mon, 13 Jul 2009 15:26:25 -0400 Subject: RFC: Netx - Use version based download protocol for JNLP files In-Reply-To: <20090713191601.GF3453@redhat.com> References: <4A57636B.7000503@redhat.com> <20090713180748.GD3453@redhat.com> <4A5B812E.10100@redhat.com> <20090713191601.GF3453@redhat.com> Message-ID: <4A5B8A61.20904@redhat.com> Deepak Bhole wrote: > * Omair Majid [2009-07-13 14:47]: >> Deepak Bhole wrote: >>> * Omair Majid [2009-07-10 11:51]: >>>> Hi, >>>> >>>> This patch makes Netx use the version based download protocol for >>>> JNLP files. >>>> >>>> Netx tries to use the version based download protocol whenever >>>> possible to download files. This wasn't being done for JNLP file >>>> that were specified as extensions by other JNLP files. This patch >>>> fixes the issue making JNLP applications like aerith[1] work. This >>>> is also required to run JavaFX applications. >>>> >>>> While adding that support, I noticed that function arguments that >>>> involved Urls and versions were inconsistent: some used function(URL, >>>> Version, blah) while others used function(URL, blah, Version). I >>>> have tried to fix them to be function(URL, Version, blah) >>>> consistently. >>>> >>>> ChangeLog: >>>> 2009-07-10 Omair Majid >>>> >>>> * rt/net/sourceforge/jnlp/JNLPFile.java >>>> (JNLPFile): Delegate to the Version-based constructor. >>>> (JNLPFile): New constructor. >>>> (JNLPFile): Modified to take an additional version argument used in >>>> downloading the JNLP file. >>>> (openURL): Take an additional version argument and use when >>>> downloading the URL. >>>> * rt/net/sourceforge/jnlp/Launcher.java >>>> (toFile): Use the new JNLPFile constructor. >>>> * rt/net/sourceforge/jnlp/cache/Resource.java >>>> (Resource): Rearrange argument order. >>>> (getResource): Likewise. Fix parameters to constructor. >>>> * rt/net/sourceforge/jnlp/cache/ResourceTracker.java >>>> (addResource): Fix arguments to Resource.getResource. >>>> * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java >>>> (getInstance): Take additional version argument and useit when >>>> creating a JNLPFile. >>>> (initializeExtensions): Use the extension version when requesting a >>>> JNLPClassLoader. >>>> >>>> >>> Looks good. One question though.. why are the order of arguments to >>> Resource() and getResource() being changed? >>> >> Obviously I didnt do a good job explaining this in the original email. >> There are many functions in Netx that require a URL, a Version and an >> UpdatePolicy: >> >> $ find -iname '*java' | xargs grep 'URL.*Policy' >> ./cache/ResourceTracker.java: public void addResource(URL location, >> Version version, UpdatePolicy updatePolicy) { >> ./cache/CacheUtil.java: public static URL getCachedResource(URL >> location, Version version, UpdatePolicy policy) { >> ./cache/Resource.java: private Resource(URL location, UpdatePolicy >> updatePolicy, Version requestVersion) { >> ./cache/Resource.java: public static Resource getResource(URL >> location, UpdatePolicy updatePolicy, Version requestVersion) { >> ./Launcher.java: resourceTracker.addResource(splashImageURL, >> file.getFileVersion(), updatePolicy); >> >> These functions dont have a consistent argument order. Some take (URL, >> Version, UpdatePolicy) while others take (URL, UpdatePolicy, Version). I >> wanted to make the order consistent. To me, URL and Version are much >> more strongly related than URL and UpdatePolicy, so I tried to fix >> everything to be (URL, Version, UpdatePolicy). Is that a sensible change >> to make? >> > > Fair enough. Okay, looks good. Assuming you have tested it, go ahead and > commit. > Thanks. Pushed as changeset 96da5a90598a. Cheers, Omair From Dalibor.Topic at Sun.COM Mon Jul 13 15:42:47 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Tue, 14 Jul 2009 00:42:47 +0200 Subject: Finding OpenJDK include paths In-Reply-To: <4A5B85E6.4090107@redhat.com> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> <4A5B849B.3060903@endoframe.com> <4A5B85E6.4090107@redhat.com> Message-ID: <4A5BB867.4040803@sun.com> Andrew Haley wrote: > Braden McDaniel wrote: >> On 7/13/09 9:43 AM, Omair Majid wrote: >>> Braden McDaniel wrote: >>>> When building a Fedora package that uses JNI, I've found it necessary to >>>> set CPPFLAGS as such: >>>> >>>> CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" >>>> >>>> Is there any more clever mechanism available? >>>> >>> You might want to take a look at this: >>> http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 >> Thanks... Looks like the answer is "no". :-/ > > Try had as I can, I can't think of anything better. Looks perfect > to me! :-) > Any volunteers for pkg-confiscating it? cheers, dslibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin H?ring From braden at endoframe.com Mon Jul 13 17:26:34 2009 From: braden at endoframe.com (Braden McDaniel) Date: Mon, 13 Jul 2009 20:26:34 -0400 Subject: Finding OpenJDK include paths In-Reply-To: <4A5BB867.4040803@sun.com> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> <4A5B849B.3060903@endoframe.com> <4A5B85E6.4090107@redhat.com> <4A5BB867.4040803@sun.com> Message-ID: <1247531194.28314.982.camel@localhost> On Tue, 2009-07-14 at 00:42 +0200, Dalibor Topic wrote: > Andrew Haley wrote: > > Braden McDaniel wrote: > >> On 7/13/09 9:43 AM, Omair Majid wrote: > >>> Braden McDaniel wrote: > >>>> When building a Fedora package that uses JNI, I've found it necessary to > >>>> set CPPFLAGS as such: > >>>> > >>>> CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" > >>>> > >>>> Is there any more clever mechanism available? > >>>> > >>> You might want to take a look at this: > >>> http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 > >> Thanks... Looks like the answer is "no". :-/ > > > > Try had as I can, I can't think of anything better. Looks perfect > > to me! :-) > > > > Any volunteers for pkg-confiscating it? Given that such a thing should be JDK-neutral, the question becomes, "Who owns it?" Looking at Fedora packages, the logical place seems like jpackage-utils. Does that seem sane/practical? -- Braden McDaniel From xerxes at zafena.se Tue Jul 14 03:24:40 2009 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Tue, 14 Jul 2009 12:24:40 +0200 Subject: RFC: shark + llvm2.6svn api change ConstantFP::get implementation have been moved to LLVMContext Message-ID: <4A5C5CE8.3030108@zafena.se> The attached patch fixes the build error that orgin from the r75546 change of the llvm 2.6 svn tip. http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090713/080939.html For some reason beyond my understanding the ConstantFP::get implementation have been moved from lib/VMCore/Constants to getConstantFP in lib/VMCore/LLVMContext . Should we push this change to shark or wait some days to see if the implementation moves back to Constants again in llvm ? ... ct\"" -DHOTSPOT_BUILD_USER="\"xerxes\"" -DHOTSPOT_LIB_ARCH=\"i386\" -DJRE_RELEASE_VERSION="\"1.6.0_0-b16\"" -DHOTSPOT_VM_DISTRO="\"OpenJDK\"" -DSHARK -I/usr/local/include -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -g -fPIC -Woverloaded-virtual -DSHARK_LLVM_VERSION=26 -fpic -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -g -m32 -pipe -O3 -fno-strict-aliasing -DVM_LITTLE_ENDIAN -Wpointer-arith -Wconversion -Wsign-compare -c -o sharkBuilder.o /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkBuilder.cpp In file included from ../generated/incls/_sharkBuilder.cpp.incl:3, from /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkBuilder.cpp:27: /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/llvmValue.hpp: In static member function 'static llvm::Constant* LLVMValue::jfloat_constant(jfloat)': /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/llvmValue.hpp:46: error: no matching function for call to 'llvm::ConstantFP::get(const llvm::Type*, jfloat&)' /usr/local/include/llvm/Constants.h:257: note: candidates are: static llvm::ConstantFP* llvm::ConstantFP::get(const llvm::APFloat&) /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/llvmValue.hpp: In static member function 'static llvm::Constant* LLVMValue::jdouble_constant(jdouble)': /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/llvmValue.hpp:54: error: no matching function for call to 'llvm::ConstantFP::get(const llvm::Type*, jdouble&)' /usr/local/include/llvm/Constants.h:257: note: candidates are: static llvm::ConstantFP* llvm::ConstantFP::get(const llvm::APFloat&) In file included from ../generated/incls/_sharkBlock.cpp.incl:3, from /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/sharkBlock.cpp:27: /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/llvmValue.hpp: In static member function 'static llvm::Constant* LLVMValue::jfloat_constant(jfloat)': /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/llvmValue.hpp:46: error: no matching function for call to 'llvm::ConstantFP::get(const llvm::Type*, jfloat&)' /usr/local/include/llvm/Constants.h:257: note: candidates are: static llvm::ConstantFP* llvm::ConstantFP::get(const llvm::APFloat&) /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/llvmValue.hpp: In static member function 'static llvm::Constant* LLVMValue::jdouble_constant(jdouble)': /home/xerxes/icedtea6/openjdk-ecj/hotspot/src/share/vm/shark/llvmValue.hpp:54: error: no matching function for call to 'llvm::ConstantFP::get(const llvm::Type*, jdouble&)' /usr/local/include/llvm/Constants.h:257: note: candidates are: static llvm::ConstantFP* llvm::ConstantFP::get(const llvm::APFloat&) make[7]: *** [sharkBuilder.o] Error 1 Cheers Xerxes -------------- next part -------------- A non-text attachment was scrubbed... Name: llvmValue.hpp_LLVMContext_ConstantFP.patch Type: text/x-patch Size: 1160 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090714/7bdb7ed0/attachment.bin From gbenson at redhat.com Tue Jul 14 03:34:05 2009 From: gbenson at redhat.com (Gary Benson) Date: Tue, 14 Jul 2009 11:34:05 +0100 Subject: RFC: shark + llvm2.6svn api change ConstantFP::get implementation have been moved to LLVMContext In-Reply-To: <4A5C5CE8.3030108@zafena.se> References: <4A5C5CE8.3030108@zafena.se> Message-ID: <20090714103404.GB3177@redhat.com> Xerxes R?nby wrote: > The attached patch fixes the build error that orgin from the r75546 > change of the llvm 2.6 svn tip. > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090713/080939.html > > For some reason beyond my understanding the ConstantFP::get > implementation have been moved from lib/VMCore/Constants to > getConstantFP in lib/VMCore/LLVMContext . Should we push this > change to shark or wait some days to see if the implementation > moves back to Constants again in llvm ? Commit away. As I understand it, the constants code was leaking things between functions, and the LLVMContext stuff is an attempt to address this. I think you need to expect more of the same in the next few days as they move other stuff in there. Cheers, Gary -- http://gbenson.net/ From xerxes at zafena.se Tue Jul 14 03:53:15 2009 From: xerxes at zafena.se (Xerxes R?nby) Date: Tue, 14 Jul 2009 10:53:15 +0000 Subject: changeset in /hg/icedtea6: 2009-07-14 Xerxes R?nby changeset b788f2c0fe74 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=b788f2c0fe74 description: 2009-07-14 Xerxes R?nby * ports/hotspot/src/share/vm/shark/llvmValue.hpp (jfloat_constant): Handle LLVM 2.6 svn r75546 API change. llvm::ConstantFP::get have been moved to llvm::LLVMContext::getConstantFP. (jdouble_constant): Likewise. diffstat: 2 files changed, 16 insertions(+), 2 deletions(-) ChangeLog | 8 ++++++++ ports/hotspot/src/share/vm/shark/llvmValue.hpp | 10 ++++++++-- diffs (47 lines): diff -r 96da5a90598a -r b788f2c0fe74 ChangeLog --- a/ChangeLog Mon Jul 13 15:22:34 2009 -0400 +++ b/ChangeLog Tue Jul 14 12:55:48 2009 +0200 @@ -1,3 +1,11 @@ 2009-07-13 Omair Majid + + * ports/hotspot/src/share/vm/shark/llvmValue.hpp + (jfloat_constant): Handle LLVM 2.6 svn r75546 API change. + llvm::ConstantFP::get have been moved to + llvm::LLVMContext::getConstantFP. + (jdouble_constant): Likewise. + 2009-07-13 Omair Majid * rt/net/sourceforge/jnlp/JNLPFile.java diff -r 96da5a90598a -r b788f2c0fe74 ports/hotspot/src/share/vm/shark/llvmValue.hpp --- a/ports/hotspot/src/share/vm/shark/llvmValue.hpp Mon Jul 13 15:22:34 2009 -0400 +++ b/ports/hotspot/src/share/vm/shark/llvmValue.hpp Tue Jul 14 12:55:48 2009 +0200 @@ -39,20 +39,26 @@ class LLVMValue : public AllStatic { } #if SHARK_LLVM_VERSION >= 26 static llvm::Constant* jfloat_constant(jfloat value) + { + return llvm::getGlobalContext().getConstantFP(SharkType::jfloat_type(), value); + } #else static llvm::ConstantFP* jfloat_constant(jfloat value) -#endif { return llvm::ConstantFP::get(SharkType::jfloat_type(), value); } +#endif #if SHARK_LLVM_VERSION >= 26 static llvm::Constant* jdouble_constant(jdouble value) + { + return llvm::getGlobalContext().getConstantFP(SharkType::jdouble_type(), value); + } #else static llvm::ConstantFP* jdouble_constant(jdouble value) -#endif { return llvm::ConstantFP::get(SharkType::jdouble_type(), value); } +#endif static llvm::ConstantPointerNull* null() { return llvm::ConstantPointerNull::get(SharkType::jobject_type()); From Dalibor.Topic at Sun.COM Tue Jul 14 04:02:07 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Tue, 14 Jul 2009 13:02:07 +0200 Subject: Finding OpenJDK include paths In-Reply-To: <1247531194.28314.982.camel@localhost> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> <4A5B849B.3060903@endoframe.com> <4A5B85E6.4090107@redhat.com> <4A5BB867.4040803@sun.com> <1247531194.28314.982.camel@localhost> Message-ID: <4A5C65AF.8000607@sun.com> Braden McDaniel wrote: > On Tue, 2009-07-14 at 00:42 +0200, Dalibor Topic wrote: >> Andrew Haley wrote: >>> Braden McDaniel wrote: >>>> On 7/13/09 9:43 AM, Omair Majid wrote: >>>>> Braden McDaniel wrote: >>>>>> When building a Fedora package that uses JNI, I've found it necessary to >>>>>> set CPPFLAGS as such: >>>>>> >>>>>> CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" >>>>>> >>>>>> Is there any more clever mechanism available? >>>>>> >>>>> You might want to take a look at this: >>>>> http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 >>>> Thanks... Looks like the answer is "no". :-/ >>> Try had as I can, I can't think of anything better. Looks perfect >>> to me! :-) >>> >> Any volunteers for pkg-confiscating it? > > Given that such a thing should be JDK-neutral, the question becomes, > "Who owns it?" > > Looking at Fedora packages, the logical place seems like jpackage-utils. > Does that seem sane/practical? > That's probably a good question for the Fedora lists. cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin H?ring From aph at redhat.com Tue Jul 14 06:05:55 2009 From: aph at redhat.com (Andrew Haley) Date: Tue, 14 Jul 2009 14:05:55 +0100 Subject: Finding OpenJDK include paths In-Reply-To: <4A5C65AF.8000607@sun.com> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> <4A5B849B.3060903@endoframe.com> <4A5B85E6.4090107@redhat.com> <4A5BB867.4040803@sun.com> <1247531194.28314.982.camel@localhost> <4A5C65AF.8000607@sun.com> Message-ID: <4A5C82B3.2040001@redhat.com> Dalibor Topic wrote: > Braden McDaniel wrote: >> On Tue, 2009-07-14 at 00:42 +0200, Dalibor Topic wrote: >>> Andrew Haley wrote: >>>> Braden McDaniel wrote: >>>>> On 7/13/09 9:43 AM, Omair Majid wrote: >>>>>> Braden McDaniel wrote: >>>>>>> When building a Fedora package that uses JNI, I've found it necessary to >>>>>>> set CPPFLAGS as such: >>>>>>> >>>>>>> CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" >>>>>>> >>>>>>> Is there any more clever mechanism available? >>>>>>> >>>>>> You might want to take a look at this: >>>>>> http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 >>>>> Thanks... Looks like the answer is "no". :-/ >>>> Try had as I can, I can't think of anything better. Looks perfect >>>> to me! :-) >>>> >>> Any volunteers for pkg-confiscating it? >> Given that such a thing should be JDK-neutral, the question becomes, >> "Who owns it?" >> >> Looking at Fedora packages, the logical place seems like jpackage-utils. >> Does that seem sane/practical? That's where it is: $ rpm -ql jpackage-utils ... /usr/share/java /usr/share/java-1.3.1 ... A few other packages install it as well. Andrew. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 06:53:36 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 13:53:36 +0000 Subject: [Bug 333] JVM crashes when try load LibGlade file Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=333 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID ------- Comment #6 from jon.vanalten at redhat.com 2009-07-14 13:53 ------- I've tried out this test case using (separately) IcedTea/openJDK and Sun's proprietary JDK, crash occurs under both. I think it's safe to say that Mark's suspicion is reasonably correct. I suggest report to glade devs. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 06:56:17 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 13:56:17 +0000 Subject: [Bug 297] icedtea crash maybe because of libpolyester ... Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=297 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Comment #3 from jon.vanalten at redhat.com 2009-07-14 13:56 ------- This appears to be fixed in current version. If applicable, reopen and include specific instructions to reproduce. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 07:01:53 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 14:01:53 +0000 Subject: [Bug 298] An unexpected error has been detected by Java Runtime Environment: Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=298 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME ------- Comment #2 from jon.vanalten at redhat.com 2009-07-14 14:01 ------- Cannot reproduce. Reopen with appropriate info if necessary. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 07:04:55 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 14:04:55 +0000 Subject: [Bug 299] eclipse crashes during file download in a tomcat test scenario Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=299 ------- Comment #3 from jon.vanalten at redhat.com 2009-07-14 14:04 ------- Hi, As noted crash log does not help to find the problem if we cannot reproduce the issue. If this is still happening please comment with more info. (otherwise will close bug in 1 week). thx -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 07:08:31 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 14:08:31 +0000 Subject: [Bug 302] JRE fatal error Problematic frame Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=302 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME ------- Comment #5 from jon.vanalten at redhat.com 2009-07-14 14:08 ------- Assuming lack of response indicates problem resolved using methods described. If not, please reopen and post 1) fresh crash log and 2) details of version for openjdk, azureus/vuze, and xulrunner. thx -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 08:38:45 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 15:38:45 +0000 Subject: [Bug 334] allow specifying explicit target arch Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=334 ------- Comment #4 from jon.vanalten at redhat.com 2009-07-14 15:38 ------- These were committed to openjdk6 on May 18 as: changeset 1550 802bb547f651 and slight correction: changeset 1553 ea3bc7968a1c Is this wanted in 7 also? -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 08:39:54 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 15:39:54 +0000 Subject: [Bug 334] allow specifying explicit target arch Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=334 ------- Comment #5 from jon.vanalten at redhat.com 2009-07-14 15:39 ------- ehrm s/openjdk6/icedtea6 -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From braden at endoframe.com Tue Jul 14 08:52:14 2009 From: braden at endoframe.com (Braden McDaniel) Date: Tue, 14 Jul 2009 11:52:14 -0400 Subject: Finding OpenJDK include paths In-Reply-To: <4A5C65AF.8000607@sun.com> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> <4A5B849B.3060903@endoframe.com> <4A5B85E6.4090107@redhat.com> <4A5BB867.4040803@sun.com> <1247531194.28314.982.camel@localhost> <4A5C65AF.8000607@sun.com> Message-ID: <1247586734.10688.57.camel@localhost> On Tue, 2009-07-14 at 13:02 +0200, Dalibor Topic wrote: > Braden McDaniel wrote: > > On Tue, 2009-07-14 at 00:42 +0200, Dalibor Topic wrote: > >> Andrew Haley wrote: > >>> Braden McDaniel wrote: > >>>> On 7/13/09 9:43 AM, Omair Majid wrote: > >>>>> Braden McDaniel wrote: > >>>>>> When building a Fedora package that uses JNI, I've found it necessary to > >>>>>> set CPPFLAGS as such: > >>>>>> > >>>>>> CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" > >>>>>> > >>>>>> Is there any more clever mechanism available? > >>>>>> > >>>>> You might want to take a look at this: > >>>>> http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 > >>>> Thanks... Looks like the answer is "no". :-/ > >>> Try had as I can, I can't think of anything better. Looks perfect > >>> to me! :-) > >>> > >> Any volunteers for pkg-confiscating it? > > > > Given that such a thing should be JDK-neutral, the question becomes, > > "Who owns it?" > > > > Looking at Fedora packages, the logical place seems like jpackage-utils. > > Does that seem sane/practical? > > > > That's probably a good question for the Fedora lists. Well, if that's the answer here, that explains why there's no pkg-config file. It's not a question for the Fedora lists because distribution-specific packages don't need to be in the business of adding ad hoc pkg-config metadata. It might be a question for a jpackage.org mailing list. But it's pertinent here, too, because this sort of thing needs not to happen in isolation. -- Braden McDaniel From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 09:10:05 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 16:10:05 +0000 Subject: [Bug 340] files with "ibm confidential" header files Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=340 ------- Comment #4 from jon.vanalten at redhat.com 2009-07-14 16:10 ------- IANAL but it does seem sketchy, and AFAIK this questionable license/copyright issue is why these files are removed by fsg.sh. As Andrew points out, this is an upstream issue and that is where a bug should be filed. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From Dalibor.Topic at Sun.COM Tue Jul 14 09:25:59 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Tue, 14 Jul 2009 18:25:59 +0200 Subject: Finding OpenJDK include paths In-Reply-To: <1247586734.10688.57.camel@localhost> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> <4A5B849B.3060903@endoframe.com> <4A5B85E6.4090107@redhat.com> <4A5BB867.4040803@sun.com> <1247531194.28314.982.camel@localhost> <4A5C65AF.8000607@sun.com> <1247586734.10688.57.camel@localhost> Message-ID: <4A5CB197.5000105@sun.com> Braden McDaniel wrote: > On Tue, 2009-07-14 at 13:02 +0200, Dalibor Topic wrote: >> Braden McDaniel wrote: >>> On Tue, 2009-07-14 at 00:42 +0200, Dalibor Topic wrote: >>>> Andrew Haley wrote: >>>>> Braden McDaniel wrote: >>>>>> On 7/13/09 9:43 AM, Omair Majid wrote: >>>>>>> Braden McDaniel wrote: >>>>>>>> When building a Fedora package that uses JNI, I've found it necessary to >>>>>>>> set CPPFLAGS as such: >>>>>>>> >>>>>>>> CPPFLAGS="-I/usr/lib/jvm/java/include -I/usr/lib/jvm/java/include/linux" >>>>>>>> >>>>>>>> Is there any more clever mechanism available? >>>>>>>> >>>>>>> You might want to take a look at this: >>>>>>> http://article.gmane.org/gmane.linux.redhat.fedora.java/3017 >>>>>> Thanks... Looks like the answer is "no". :-/ >>>>> Try had as I can, I can't think of anything better. Looks perfect >>>>> to me! :-) >>>>> >>>> Any volunteers for pkg-confiscating it? >>> Given that such a thing should be JDK-neutral, the question becomes, >>> "Who owns it?" >>> >>> Looking at Fedora packages, the logical place seems like jpackage-utils. >>> Does that seem sane/practical? >>> >> That's probably a good question for the Fedora lists. > > Well, if that's the answer here, that explains why there's no pkg-config > file. There is no pkg-config file because no one made one, afaik. It would be cool to have one, though. ;) It may, for example, make sense to come up with a mechanism to generate pkg-config files in Fedora through some RPM macro for JNI interface providing packages in general in an automated fashion, rather then maintaining them for each such package manually. It's hard to tell for me at least without consulting the experts on packaging such applications for their corresponding operating system. That's why I suggested asking on the Fedora lists. cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin H?ring From Dalibor.Topic at Sun.COM Tue Jul 14 09:36:15 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Tue, 14 Jul 2009 18:36:15 +0200 Subject: Finding OpenJDK include paths In-Reply-To: <4A5CB197.5000105@sun.com> References: <1247475027.6944.8503.camel@localhost> <4A5B39F5.9080000@redhat.com> <4A5B849B.3060903@endoframe.com> <4A5B85E6.4090107@redhat.com> <4A5BB867.4040803@sun.com> <1247531194.28314.982.camel@localhost> <4A5C65AF.8000607@sun.com> <1247586734.10688.57.camel@localhost> <4A5CB197.5000105@sun.com> Message-ID: <4A5CB3FF.4050009@sun.com> Dalibor Topic wrote: > It's hard to tell for me at least without consulting the experts on packaging > such applications for their corresponding operating system. That's why I suggested > asking on the Fedora lists. Speaking of that, as Andrew Haley pointed out on IRC, the utility of such a pkg-config file would be limited, given that distributions install OpenJDK into /usr/lib/jvm/java - i.e. the path to include files is the same across Fedora, Ubuntu, etc. cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin H?ring From aph at redhat.com Tue Jul 14 09:43:18 2009 From: aph at redhat.com (Andrew Haley) Date: Tue, 14 Jul 2009 17:43:18 +0100 Subject: OpenJDK 6 Certification for Ubuntu 9.04 (jaunty) Message-ID: <4A5CB5A6.70902@redhat.com> In https://lists.ubuntu.com/archives/ubuntu-devel-announce/2009-July/000587.html Matthias Klose wrote: > The Ubuntu Java development team is pleased to announce completed > certification of OpenJDK 6 for Ubuntu 9.04, continuing Ubuntu's tradition of > integrating the latest and greatest open source technologies into a > high-quality, easy-to-use Linux distribution. > > After signing the Sun TCK agreement earlier this year, Java developers > went to work with the certification process and received final > certification from Sun in late May. And you didn't announce it till now. Such amazing self-control. :-) > This certification means that the OpenJDK 6 package included with Ubuntu > 9.04 now passes the rigorous testing of the Java SE Test Compatibility Kit > (TCK) and is compatible with the Java(TM) SE 6 platform on the amd64 (x86_64) > and i386 (ix86) architectures. Congratulations, and welcome to the club! I was beginning to wonder if Red Hat and Fedora were going to be the only member for ever. Andrew. From dbhole at redhat.com Tue Jul 14 09:59:38 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Tue, 14 Jul 2009 16:59:38 +0000 Subject: changeset in /hg/icedtea6: Clean up directory structure of .java... Message-ID: changeset dae4c1447578 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=dae4c1447578 description: Clean up directory structure of .java files before any significant amount of history gets written. This change does not alter any of the java code, just moves it around to a cleaner location. The only code change is in Makefile.am to adapt to the new location, and another minor change that affects only np plugin build. diffstat: 60 files changed, 7066 insertions(+), 6995 deletions(-) ChangeLog | 68 Makefile.am | 37 plugin/icedteanp/java/netscape/javascript/JSException.java | 140 plugin/icedteanp/java/netscape/javascript/JSObject.java | 263 + plugin/icedteanp/java/netscape/javascript/JSProxy.java | 58 plugin/icedteanp/java/netscape/javascript/JSRunnable.java | 72 plugin/icedteanp/java/netscape/javascript/JSUtil.java | 59 plugin/icedteanp/java/sun/applet/AppletSecurityContextManager.java | 71 plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java | 76 plugin/icedteanp/java/sun/applet/GetWindowPluginCallRequest.java | 75 plugin/icedteanp/java/sun/applet/JavaConsole.java | 365 + plugin/icedteanp/java/sun/applet/PasswordAuthenticationDialog.java | 241 + plugin/icedteanp/java/sun/applet/PluginAppletSecurityContext.java | 1307 ++++++ plugin/icedteanp/java/sun/applet/PluginAppletViewer.java | 1988 ++++++++++ plugin/icedteanp/java/sun/applet/PluginCallRequest.java | 85 plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java | 62 plugin/icedteanp/java/sun/applet/PluginClassLoader.java | 51 plugin/icedteanp/java/sun/applet/PluginCookieInfoRequest.java | 122 plugin/icedteanp/java/sun/applet/PluginCookieStore.java | 73 plugin/icedteanp/java/sun/applet/PluginDebug.java | 51 plugin/icedteanp/java/sun/applet/PluginException.java | 53 plugin/icedteanp/java/sun/applet/PluginMain.java | 319 + plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java | 119 plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java | 121 plugin/icedteanp/java/sun/applet/PluginObjectStore.java | 132 plugin/icedteanp/java/sun/applet/PluginProxyInfoRequest.java | 85 plugin/icedteanp/java/sun/applet/PluginProxySelector.java | 195 plugin/icedteanp/java/sun/applet/PluginStreamHandler.java | 479 ++ plugin/icedteanp/java/sun/applet/RequestQueue.java | 77 plugin/icedteanp/java/sun/applet/TestEnv.java | 172 plugin/icedteanp/java/sun/applet/VoidPluginCallRequest.java | 67 plugin/icedteanp/netscape/javascript/JSException.java | 140 plugin/icedteanp/netscape/javascript/JSObject.java | 263 - plugin/icedteanp/netscape/javascript/JSProxy.java | 58 plugin/icedteanp/netscape/javascript/JSRunnable.java | 72 plugin/icedteanp/netscape/javascript/JSUtil.java | 59 plugin/icedteanp/sun/applet/AppletSecurityContextManager.java | 71 plugin/icedteanp/sun/applet/GetMemberPluginCallRequest.java | 76 plugin/icedteanp/sun/applet/GetWindowPluginCallRequest.java | 75 plugin/icedteanp/sun/applet/JavaConsole.java | 365 - plugin/icedteanp/sun/applet/PasswordAuthenticationDialog.java | 241 - plugin/icedteanp/sun/applet/PluginAppletSecurityContext.java | 1307 ------ plugin/icedteanp/sun/applet/PluginAppletViewer.java | 1988 ---------- plugin/icedteanp/sun/applet/PluginCallRequest.java | 85 plugin/icedteanp/sun/applet/PluginCallRequestFactory.java | 62 plugin/icedteanp/sun/applet/PluginClassLoader.java | 51 plugin/icedteanp/sun/applet/PluginCookieInfoRequest.java | 122 plugin/icedteanp/sun/applet/PluginCookieStore.java | 73 plugin/icedteanp/sun/applet/PluginDebug.java | 51 plugin/icedteanp/sun/applet/PluginException.java | 53 plugin/icedteanp/sun/applet/PluginMain.java | 319 - plugin/icedteanp/sun/applet/PluginMessageConsumer.java | 119 plugin/icedteanp/sun/applet/PluginMessageHandlerWorker.java | 121 plugin/icedteanp/sun/applet/PluginObjectStore.java | 132 plugin/icedteanp/sun/applet/PluginProxyInfoRequest.java | 85 plugin/icedteanp/sun/applet/PluginProxySelector.java | 195 plugin/icedteanp/sun/applet/PluginStreamHandler.java | 479 -- plugin/icedteanp/sun/applet/RequestQueue.java | 77 plugin/icedteanp/sun/applet/TestEnv.java | 172 plugin/icedteanp/sun/applet/VoidPluginCallRequest.java | 67 diffs (truncated from 14375 to 500 lines): diff -r b788f2c0fe74 -r dae4c1447578 ChangeLog --- a/ChangeLog Tue Jul 14 12:55:48 2009 +0200 +++ b/ChangeLog Tue Jul 14 13:04:20 2009 -0400 @@ -1,3 +1,71 @@ 2009-07-14 Xerxes R??nby + + * Makefile.am: Fix npplugin build. + * plugin/icedteanp/java/netscape/javascript/JSException.java: Moved from + the plugin/icedteanp/netscape/javascript/ hierarchy. + * plugin/icedteanp/java/netscape/javascript/JSObject.java: Same. + * plugin/icedteanp/java/netscape/javascript/JSProxy.java: Same. + * plugin/icedteanp/java/netscape/javascript/JSRunnable.java: Same. + * plugin/icedteanp/java/netscape/javascript/JSUtil.java: Same. + * plugin/icedteanp/java/sun/applet/AppletSecurityContextManager.java: + Moved from the plugin/icedteanp/sun/applet hierarchy. + * plugin/icedteanp/java/sun/applet/GetMemberPluginCallRequest.java: Same. + * plugin/icedteanp/java/sun/applet/GetWindowPluginCallRequest.java: Same. + * plugin/icedteanp/java/sun/applet/JavaConsole.java: Same. + * plugin/icedteanp/java/sun/applet/PasswordAuthenticationDialog.java: + Same. + * plugin/icedteanp/java/sun/applet/PluginAppletSecurityContext.java: Same. + * plugin/icedteanp/java/sun/applet/PluginAppletViewer.java: Same. + * plugin/icedteanp/java/sun/applet/PluginCallRequest.java: Same. + * plugin/icedteanp/java/sun/applet/PluginCallRequestFactory.java: Same. + * plugin/icedteanp/java/sun/applet/PluginClassLoader.java: Same. + * plugin/icedteanp/java/sun/applet/PluginCookieInfoRequest.java: Same. + * plugin/icedteanp/java/sun/applet/PluginCookieStore.java: Same. + * plugin/icedteanp/java/sun/applet/PluginDebug.java: Same. + * plugin/icedteanp/java/sun/applet/PluginException.java: Same. + * plugin/icedteanp/java/sun/applet/PluginMain.java: Same. + * plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java: Same. + * plugin/icedteanp/java/sun/applet/PluginMessageHandlerWorker.java: Same. + * plugin/icedteanp/java/sun/applet/PluginObjectStore.java: Same. + * plugin/icedteanp/java/sun/applet/PluginProxyInfoRequest.java: Same. + * plugin/icedteanp/java/sun/applet/PluginProxySelector.java: Same. + * plugin/icedteanp/java/sun/applet/PluginStreamHandler.java: Same. + * plugin/icedteanp/java/sun/applet/RequestQueue.java: Same. + * plugin/icedteanp/java/sun/applet/TestEnv.java: Same. + * plugin/icedteanp/java/sun/applet/VoidPluginCallRequest.java: Same. + * plugin/icedteanp/netscape/javascript/JSException.java: Moved to + the plugin/icedteanp/java/netscape/javascript/ heirarchy. + * plugin/icedteanp/netscape/javascript/JSObject.java: Same. + * plugin/icedteanp/netscape/javascript/JSProxy.java: Same. + * plugin/icedteanp/netscape/javascript/JSRunnable.java: Same. + * plugin/icedteanp/netscape/javascript/JSUtil.java: Same. + * plugin/icedteanp/sun/applet/AppletSecurityContextManager.java: Moved to + the plugin/icedteanp/java/sun/applet/ heirarchy. + * plugin/icedteanp/sun/applet/GetMemberPluginCallRequest.java: Same. + * plugin/icedteanp/sun/applet/GetWindowPluginCallRequest.java: Same. + * plugin/icedteanp/sun/applet/JavaConsole.java: Same. + * plugin/icedteanp/sun/applet/PasswordAuthenticationDialog.java: Same. + * plugin/icedteanp/sun/applet/PluginAppletSecurityContext.java: Same. + * plugin/icedteanp/sun/applet/PluginAppletViewer.java: Same. + * plugin/icedteanp/sun/applet/PluginCallRequest.java: Same. + * plugin/icedteanp/sun/applet/PluginCallRequestFactory.java: Same. + * plugin/icedteanp/sun/applet/PluginClassLoader.java: Same. + * plugin/icedteanp/sun/applet/PluginCookieInfoRequest.java: Same. + * plugin/icedteanp/sun/applet/PluginCookieStore.java: Same. + * plugin/icedteanp/sun/applet/PluginDebug.java: Same. + * plugin/icedteanp/sun/applet/PluginException.java: Same. + * plugin/icedteanp/sun/applet/PluginMain.java: Same. + * plugin/icedteanp/sun/applet/PluginMessageConsumer.java: Same. + * plugin/icedteanp/sun/applet/PluginMessageHandlerWorker.java: Same. + * plugin/icedteanp/sun/applet/PluginObjectStore.java: Same. + * plugin/icedteanp/sun/applet/PluginProxyInfoRequest.java: Same. + * plugin/icedteanp/sun/applet/PluginProxySelector.java: Same. + * plugin/icedteanp/sun/applet/PluginStreamHandler.java: Same. + * plugin/icedteanp/sun/applet/RequestQueue.java: Same. + * plugin/icedteanp/sun/applet/TestEnv.java: Same. + * plugin/icedteanp/sun/applet/VoidPluginCallRequest.java: Same. + + 2009-07-14 Xerxes R??nby * ports/hotspot/src/share/vm/shark/llvmValue.hpp diff -r b788f2c0fe74 -r dae4c1447578 Makefile.am --- a/Makefile.am Tue Jul 14 12:55:48 2009 +0200 +++ b/Makefile.am Tue Jul 14 13:04:20 2009 -0400 @@ -13,17 +13,20 @@ ICEDTEAPLUGIN_TARGET = IcedTeaNPPlugin.s ICEDTEAPLUGIN_TARGET = IcedTeaNPPlugin.so PLUGIN_PATCH = patches/icedtea-liveconnect.patch LIVECONNECT_DIR = -C lib/rt netscape +NPPLUGIN_DIR=$(abs_top_srcdir)/plugin/icedteanp else if ENABLE_PLUGIN ICEDTEAPLUGIN_CLEAN = clean-IcedTeaPlugin ICEDTEAPLUGIN_TARGET = IcedTeaPlugin.so PLUGIN_PATCH = patches/icedtea-liveconnect.patch LIVECONNECT_DIR = -C lib/rt netscape +NPPLUGIN_DIR = else ICEDTEAPLUGIN_CLEAN = ICEDTEAPLUGIN_TARGET = PLUGIN_PATCH = LIVECONNECT_DIR = +NPPLUGIN_DIR = endif endif @@ -66,7 +69,7 @@ distclean-local: clean-copy clean-jtreg rm -rf visualvm rm -rf netbeans if ENABLE_NPPLUGIN - rm -f IcedTeaNPPlugin.o IcedTeaNPPlugin.so + rm -f $(NPPLUGIN_DIR)/*.o $(NPPLUGIN_DIR)/IcedTeaNPPlugin.so else if ENABLE_PLUGIN rm -f IcedTeaPlugin.o IcedTeaPlugin.so @@ -781,9 +784,9 @@ stamps/patch.stamp: stamps/patch-fsg.sta fi if ENABLE_NPPLUGIN - cp -a $(abs_top_srcdir)/plugin/icedteanp/sun/applet/*java openjdk/jdk/src/share/classes/sun/applet/ + cp -a $(abs_top_srcdir)/plugin/icedteanp/java/sun/applet/*java openjdk/jdk/src/share/classes/sun/applet/ mkdir -p rt - cp -a $(abs_top_srcdir)/plugin/icedteanp/netscape rt/ + cp -a $(abs_top_srcdir)/plugin/icedteanp/java/netscape rt/ else if ENABLE_PLUGIN cp -a $(abs_top_srcdir)/plugin/icedtea/sun/applet/*java openjdk/jdk/src/share/classes/sun/applet/ @@ -1106,9 +1109,9 @@ stamps/icedtea.stamp: stamps/bootstrap-d mkdir -p $(BUILD_OUTPUT_DIR)/j2sdk-image/jre/lib/ext mkdir -p $(BUILD_OUTPUT_DIR)/j2re-image/lib/ext if ENABLE_NPPLUGIN - cp -pPRf IcedTeaNPPlugin.so \ + cp -pPRf $(NPPLUGIN_DIR)/IcedTeaNPPlugin.so \ $(BUILD_OUTPUT_DIR)/j2sdk-image/jre/lib/$(INSTALL_ARCH_DIR) - cp -pPRf IcedTeaNPPlugin.so \ + cp -pPRf $(NPPLUGIN_DIR)/IcedTeaNPPlugin.so \ $(BUILD_OUTPUT_DIR)/j2re-image/lib/$(INSTALL_ARCH_DIR) else if ENABLE_PLUGIN @@ -1191,9 +1194,9 @@ stamps/icedtea-debug.stamp: stamps/boots mkdir -p $(BUILD_OUTPUT_DIR)-debug/j2sdk-image/jre/lib/ext mkdir -p $(BUILD_OUTPUT_DIR)-debug/j2re-image/lib/ext if ENABLE_NPPLUGIN - cp -pPRf IcedTeaNPPlugin.so \ + cp -pPRf $(NPPLUGIN_DIR)/IcedTeaNPPlugin.so \ $(BUILD_OUTPUT_DIR)-debug/j2sdk-image/jre/lib/$(INSTALL_ARCH_DIR) - cp -pPRf IcedTeaNPPlugin.so \ + cp -pPRf $(NPPLUGIN_DIR)/IcedTeaNPPlugin.so \ $(BUILD_OUTPUT_DIR)-debug/j2re-image/lib/$(INSTALL_ARCH_DIR) else if ENABLE_PLUGIN @@ -1614,7 +1617,7 @@ NPPLUGIN_OBJECTS=IcedTeaNPPlugin.o IcedT IcedTeaPluginUtils.o IcedTeaNPPlugin_objects: - (cd plugin/icedteanp + cd $(NPPLUGIN_DIR); \ if [ -e $(abs_top_srcdir)/.hg ] && which $(HG) >/dev/null; then \ revision="-r`(cd $(abs_top_srcdir); $(HG) tip --template '{rev}')`" ; \ fi ; \ @@ -1627,24 +1630,24 @@ IcedTeaNPPlugin_objects: $(GLIB_CFLAGS) \ $(GTK_CFLAGS) \ $(MOZILLA_CFLAGS) \ - -fPIC -c $(NPPLUGIN_SRC) - ) + -fPIC -c $(NPPLUGIN_SRC); \ + cd ../ IcedTeaNPPlugin.so: IcedTeaNPPlugin_objects - (cd plugin/icedteanp + cd $(NPPLUGIN_DIR); \ $(CXX) $(CXXFLAGS) \ $(NPPLUGIN_OBJECTS) \ $(GLIB_LIBS) \ $(GTK_LIBS) \ $(MOZILLA_LIBS)\ - -shared -o $@ - ) + -shared -o $@; \ + cd ../ clean-IcedTeaNPPlugin: - (cd plugin/icedteanp - rm -f $(NPPLUGIN_OBJECTS) - rm -f IcedTeaNPPlugin.so - ) + cd $(NPPLUGIN_DIR);\ + rm -f *.o; \ + rm -f IcedTeaNPPlugin.so; \ + cd ../ else if ENABLE_PLUGIN # IcedTeaPlugin.so. diff -r b788f2c0fe74 -r dae4c1447578 plugin/icedteanp/java/netscape/javascript/JSException.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/plugin/icedteanp/java/netscape/javascript/JSException.java Tue Jul 14 13:04:20 2009 -0400 @@ -0,0 +1,140 @@ +/* -*- Mode: Java; tab-width: 8; c-basic-offset: 4 -*- + * + * ***** BEGIN LICENSE BLOCK ***** + * Version: MPL 1.1/GPL 2.0/LGPL 2.1 + * + * The contents of this file are subject to the Mozilla Public License Version + * 1.1 (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * http://www.mozilla.org/MPL/ + * + * Software distributed under the License is distributed on an "AS IS" basis, + * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License + * for the specific language governing rights and limitations under the + * License. + * + * The Original Code is Mozilla Communicator client code, released + * March 31, 1998. + * + * The Initial Developer of the Original Code is + * Netscape Communications Corporation. + * Portions created by the Initial Developer are Copyright (C) 1998 + * the Initial Developer. All Rights Reserved. + * + * Contributor(s): + * + * Alternatively, the contents of this file may be used under the terms of + * either of the GNU General Public License Version 2 or later (the "GPL"), + * or the GNU Lesser General Public License Version 2.1 or later (the "LGPL"), + * in which case the provisions of the GPL or the LGPL are applicable instead + * of those above. If you wish to allow use of your version of this file only + * under the terms of either the GPL or the LGPL, and not to allow others to + * use your version of this file under the terms of the MPL, indicate your + * decision by deleting the provisions above and replace them with the notice + * and other provisions required by the GPL or the LGPL. If you do not delete + * the provisions above, a recipient may use your version of this file under + * the terms of any one of the MPL, the GPL or the LGPL. + * + * ***** END LICENSE BLOCK ***** */ + +package netscape.javascript; + +/** + * JSException is an exception which is thrown when JavaScript code + * returns an error. + */ + +public +class JSException extends RuntimeException { + public static final int EXCEPTION_TYPE_EMPTY = -1; + public static final int EXCEPTION_TYPE_VOID = 0; + public static final int EXCEPTION_TYPE_OBJECT = 1; + public static final int EXCEPTION_TYPE_FUNCTION = 2; + public static final int EXCEPTION_TYPE_STRING = 3; + public static final int EXCEPTION_TYPE_NUMBER = 4; + public static final int EXCEPTION_TYPE_BOOLEAN = 5; + public static final int EXCEPTION_TYPE_ERROR = 6; + + public String filename; + public int lineno; + public String source; + public int tokenIndex; + public int wrappedExceptionType; + public Object wrappedException; + + /** + * Constructs a JSException without a detail message. + * A detail message is a String that describes this particular exception. + * + * @deprecated Not for public use in future versions. + */ + public JSException() { + super(); + filename = "unknown"; + lineno = 0; + source = ""; + tokenIndex = 0; + wrappedExceptionType = EXCEPTION_TYPE_EMPTY; + } + + /** + * Constructs a JSException with a detail message. + * A detail message is a String that describes this particular exception. + * @param s the detail message + * + * @deprecated Not for public use in future versions. + */ + public JSException(String s) { + super(s); + filename = "unknown"; + lineno = 0; + source = ""; + tokenIndex = 0; + wrappedExceptionType = EXCEPTION_TYPE_EMPTY; + } + + /** + * Constructs a JSException with a wrapped JavaScript exception object. + * This constructor needs to be public so that Java users can throw + * exceptions to JS cleanly. + */ + public JSException(int wrappedExceptionType, Object wrappedException) { + super(); + this.wrappedExceptionType = wrappedExceptionType; + this.wrappedException = wrappedException; + } + + /** + * Constructs a JSException with a detail message and all the + * other info that usually comes with a JavaScript error. + * @param s the detail message + * + * @deprecated Not for public use in future versions. + */ + public JSException(String s, String filename, int lineno, + String source, int tokenIndex) { + super(s); + this.filename = filename; + this.lineno = lineno; + this.source = source; + this.tokenIndex = tokenIndex; + wrappedExceptionType = EXCEPTION_TYPE_EMPTY; + } + + /** + * Instance method getWrappedExceptionType returns the int mapping of the + * type of the wrappedException Object. + */ + public int getWrappedExceptionType() { + return wrappedExceptionType; + } + + /** + * Instance method getWrappedException. + */ + public Object getWrappedException() { + return wrappedException; + } + +} + diff -r b788f2c0fe74 -r dae4c1447578 plugin/icedteanp/java/netscape/javascript/JSObject.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/plugin/icedteanp/java/netscape/javascript/JSObject.java Tue Jul 14 13:04:20 2009 -0400 @@ -0,0 +1,263 @@ +/* -*- Mode: Java; tab-width: 8; c-basic-offset: 4 -*- + * + * ***** BEGIN LICENSE BLOCK ***** + * Version: MPL 1.1/GPL 2.0/LGPL 2.1 + * + * The contents of this file are subject to the Mozilla Public License Version + * 1.1 (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * http://www.mozilla.org/MPL/ + * + * Software distributed under the License is distributed on an "AS IS" basis, + * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License + * for the specific language governing rights and limitations under the + * License. + * + * The Original Code is Mozilla Communicator client code, released + * March 31, 1998. + * + * The Initial Developer of the Original Code is + * Netscape Communications Corporation. + * Portions created by the Initial Developer are Copyright (C) 1998 + * the Initial Developer. All Rights Reserved. + * + * Contributor(s): + * + * Alternatively, the contents of this file may be used under the terms of + * either of the GNU General Public License Version 2 or later (the "GPL"), + * or the GNU Lesser General Public License Version 2.1 or later (the "LGPL"), + * in which case the provisions of the GPL or the LGPL are applicable instead + * of those above. If you wish to allow use of your version of this file only + * under the terms of either the GPL or the LGPL, and not to allow others to + * use your version of this file under the terms of the MPL, indicate your + * decision by deleting the provisions above and replace them with the notice + * and other provisions required by the GPL or the LGPL. If you do not delete + * the provisions above, a recipient may use your version of this file under + * the terms of any one of the MPL, the GPL or the LGPL. + * + * ***** END LICENSE BLOCK ***** */ + +/* more doc todo: + * threads + * gc + * + * + */ + +package netscape.javascript; + +import java.applet.Applet; + +import sun.applet.PluginAppletViewer; +import sun.applet.PluginDebug; + + + +/** + * JSObject allows Java to manipulate objects that are + * defined in JavaScript. + * Values passed from Java to JavaScript are converted as + * follows:
    + *
  • JSObject is converted to the original JavaScript object + *
  • Any other Java object is converted to a JavaScript wrapper, + * which can be used to access methods and fields of the java object. + * Converting this wrapper to a string will call the toString method + * on the original object, converting to a number will call the + * doubleValue method if possible and fail otherwise. Converting + * to a boolean will try to call the booleanValue method in the + * same way. + *
  • Java arrays are wrapped with a JavaScript object that understands + * array.length and array[index] + *
  • A Java boolean is converted to a JavaScript boolean + *
  • Java byte, char, short, int, long, float, and double are converted + * to JavaScript numbers + *
+ * Values passed from JavaScript to Java are converted as follows:
    + *
  • objects which are wrappers around java objects are unwrapped + *
  • other objects are wrapped with a JSObject + *
  • strings, numbers and booleans are converted to String, Double, + * and Boolean objects respectively + *
+ * This means that all JavaScript values show up as some kind + * of java.lang.Object in Java. In order to make much use of them, + * you will have to cast them to the appropriate subclass of Object, + * e.g. (String) window.getMember("name"); or + * (JSObject) window.getMember("document");. + */ +public final class JSObject { + /* the internal object data */ + private long internal; + + /** + * initialize + */ + private static void initClass() { + PluginDebug.debug ("JSObject.initClass"); + } + + static { + PluginDebug.debug ("JSObject INITIALIZER"); + } + + /** + * it is illegal to construct a JSObject manually + */ + // FIXME: make private! + public JSObject(int jsobj_addr) { + PluginDebug.debug ("JSObject int CONSTRUCTOR"); + internal = jsobj_addr; + } + + public JSObject(long jsobj_addr) { + PluginDebug.debug ("JSObject long CONSTRUCTOR"); + internal = jsobj_addr; + } + + /** + * Retrieves a named member of a JavaScript object. + * Equivalent to "this.name" in JavaScript. + */ + public Object getMember(String name) + { + PluginDebug.debug ("JSObject.getMember " + name); + + Object o = PluginAppletViewer.getMember(internal, name); + PluginDebug.debug ("JSObject.getMember GOT " + o); + return o; + } + + + /** + * Retrieves an indexed member of a JavaScript object. + * Equivalent to "this[index]" in JavaScript. + */ + // public Object getMember(int index) { return getSlot(index); } + public Object getSlot(int index) + { + PluginDebug.debug ("JSObject.getSlot " + index); + + return PluginAppletViewer.getSlot(internal, index); + } + + + /** + * Sets a named member of a JavaScript object. + * Equivalent to "this.name = value" in JavaScript. + */ + public void setMember(String name, Object value) + { + PluginDebug.debug ("JSObject.setMember " + name + " " + value); + + PluginAppletViewer.setMember(internal, name, value); + } + + /** + * Sets an indexed member of a JavaScript object. + * Equivalent to "this[index] = value" in JavaScript. + */ + // public void setMember(int index, Object value) { + // setSlot(index, value); + // } + public void setSlot(int index, Object value) + { + PluginDebug.debug ("JSObject.setSlot " + index + " " + value); + + PluginAppletViewer.setSlot(internal, index, value); From doko at ubuntu.com Tue Jul 14 10:02:25 2009 From: doko at ubuntu.com (Matthias Klose) Date: Tue, 14 Jul 2009 13:02:25 -0400 Subject: OpenJDK 6 Certification for Ubuntu 9.04 (jaunty) In-Reply-To: <4A5CB5A6.70902@redhat.com> References: <4A5CB5A6.70902@redhat.com> Message-ID: <4A5CBA21.6070801@ubuntu.com> Andrew Haley schrieb: > In https://lists.ubuntu.com/archives/ubuntu-devel-announce/2009-July/000587.html > Matthias Klose wrote: > >> The Ubuntu Java development team is pleased to announce completed >> certification of OpenJDK 6 for Ubuntu 9.04, continuing Ubuntu's tradition of >> integrating the latest and greatest open source technologies into a >> high-quality, easy-to-use Linux distribution. >> >> After signing the Sun TCK agreement earlier this year, Java developers >> went to work with the certification process and received final >> certification from Sun in late May. > > And you didn't announce it till now. Such amazing self-control. :-) well, we had a bug in the fontconfig configuration file leading to too large vertical layout in dialogs, which was fixed in an update, and this update did migrate to jaunty-updates last Friday. >> This certification means that the OpenJDK 6 package included with Ubuntu >> 9.04 now passes the rigorous testing of the Java SE Test Compatibility Kit >> (TCK) and is compatible with the Java(TM) SE 6 platform on the amd64 (x86_64) >> and i386 (ix86) architectures. > > Congratulations, and welcome to the club! I was beginning to wonder if Red Hat > and Fedora were going to be the only member for ever. And many thanks for guiding me through the setup for the TCK! So it should be possible to certify the Debian packages as well (maybe not the ones in lenny, but more likely a backport). I will not do this myself, the certification is time consuming. If somebody wants to get involved with the certification of the Debian OpenJDK-6 packages (after doing the paperwork of signing the TCK and the SCA), please let me know, and I'll help where I can. Matthias From dbhole at redhat.com Tue Jul 14 10:08:07 2009 From: dbhole at redhat.com (Deepak Bhole) Date: Tue, 14 Jul 2009 17:08:07 +0000 Subject: changeset in /hg/icedtea6: Fix date in ChangeLog entry from prev... Message-ID: changeset 119501af9b1c in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=119501af9b1c description: Fix date in ChangeLog entry from previous commit. Bad me for copying+pasting :/ diffstat: 1 file changed, 1 insertion(+), 1 deletion(-) ChangeLog | 2 +- diffs (9 lines): diff -r dae4c1447578 -r 119501af9b1c ChangeLog --- a/ChangeLog Tue Jul 14 13:04:20 2009 -0400 +++ b/ChangeLog Tue Jul 14 13:12:50 2009 -0400 @@ -1,4 +1,4 @@ 2009-07-10 Deepak Bhole +2009-07-14 Deepak Bhole * Makefile.am: Fix npplugin build. * plugin/icedteanp/java/netscape/javascript/JSException.java: Moved from From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 13:47:47 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 20:47:47 +0000 Subject: [Bug 356] keytool doesn't handle SHA384withECDSA signatures Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=356 jon.vanalten at redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID ------- Comment #4 from jon.vanalten at redhat.com 2009-07-14 20:47 ------- I'll be the first to admit I know little about nss, but it looks like you're absolutely correct as some others have had similar issues: https://bugzilla.redhat.com/show_bug.cgi?id=492124 May I suggest that you post these details (or simply a link to this bug) in a new nss bug on the Red Hat bugzilla: https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora I'd do so myself but it's not my itch to scratch :D (more importantly, someone with more intimate knowledge of the issue could contribute more meaningfully to the report). >From the above convo and the bits I've read elsewhere on the subject it seems this is not an IcedTea bug, so I'm closing this. Feel free to reopen if I am mistaken. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 14:05:22 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 21:05:22 +0000 Subject: [Bug 356] keytool doesn't handle SHA384withECDSA signatures Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=356 ------- Comment #5 from doko at ubuntu.com 2009-07-14 21:05 ------- are you sure about closing the report? At least java.security needs to be aware of the new security provider. One possibility would be a configure check in IcedTea, and modification of the java.security file. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 14:46:31 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 21:46:31 +0000 Subject: [Bug 356] keytool doesn't handle SHA384withECDSA signatures Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=356 ------- Comment #6 from jon.vanalten at redhat.com 2009-07-14 21:46 ------- Fairly sure. From Andreas Sterbenz's 2006 blog posting linked by Kostis in comment #2 and #3, programs wishing to use this (not new) provider should add it (ie "Security.insertProviderAt(nss, 1);" at runtime, and set up config file as described. So unless I have misunderstood completely, this is not a build or configure issue for IcedTea. Furthermore, http://blogs.sun.com/andreas/entry/elliptic_curve_cryptography_in_java indicates that the use of ECC depends on NSS library specifically compiled with ECC support. All signs point to Fedora's NSS library not being compiled as such. Thus the recommendation to open Red Hat bug wrt the nss (really I should say nss-devel) package. If you know something I don't (which is entirely likely), please reopen the report and add info as required. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 15:04:45 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 22:04:45 +0000 Subject: [Bug 356] keytool doesn't handle SHA384withECDSA signatures Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=356 ------- Comment #7 from doko at ubuntu.com 2009-07-14 22:04 ------- it's keytool from OpenJDK which does need this support to add the certificate to the keystore, and read it again. -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From bugzilla-daemon at icedtea.classpath.org Tue Jul 14 16:43:50 2009 From: bugzilla-daemon at icedtea.classpath.org (bugzilla-daemon at icedtea.classpath.org) Date: Tue, 14 Jul 2009 23:43:50 +0000 Subject: [Bug 356] keytool doesn't handle SHA384withECDSA signatures Message-ID: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=356 gnu_andrew at member.fsf.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID | ------- Comment #8 from gnu_andrew at member.fsf.org 2009-07-14 23:43 ------- I don't think keytool needs to be altered. We could however have NSS support enabled out of the box. We are in a better position than Sun in that we are not distributing proprietary standalone binaries, and can instead depend on NSS. Thus, it seems, from reading these blogs, that we could detect NSS using autoconf and generate the configuration, rather than leaving it to the end user. The other issue is that Fedora's NSS doesn't have elliptic curve support. This needs fixing in Fedora with the bug Jon mentioned. You'll be glad to know that a pure Java implementation of elliptic curve cryptography is slated for JDK7; http://openjdk.java.net/projects/jdk7/features/#f73 -- Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. From xerxes at zafena.se Wed Jul 15 03:21:25 2009 From: xerxes at zafena.se (=?ISO-8859-1?Q?Xerxes_R=E5nby?=) Date: Wed, 15 Jul 2009 12:21:25 +0200 Subject: RFC: shark + llvm2.6svn api change ConstantInt::get and ConstantArray::get implementation have been moved to LLVMContext Message-ID: <4A5DADA5.2030404@zafena.se> Patch to fix build errors with LLVM API changes in svn r75703 ConstantInt::get and ConstantArray::get implementation have been moved to LLVMContext http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090713/081100.html Cheers Xerxes -------------- next part -------------- A non-text attachment was scrubbed... Name: ConstantInt_ConstantArray_moved_to_LLVMContext.patch Type: text/x-patch Size: 3356 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090715/8bb524ab/attachment.bin From gbenson at redhat.com Wed Jul 15 03:29:31 2009 From: gbenson at redhat.com (Gary Benson) Date: Wed, 15 Jul 2009 11:29:31 +0100 Subject: RFC: shark + llvm2.6svn api change ConstantInt::get and ConstantArray::get implementation have been moved to LLVMContext In-Reply-To: <4A5DADA5.2030404@zafena.se> References: <4A5DADA5.2030404@zafena.se> Message-ID: <20090715102930.GA3179@redhat.com> Hi Xerxes, Please commit this. Feel free to commit similar API fixes in future, you're pretty good at them :) Cheers, Gary Xerxes R?nby wrote: > Patch to fix build errors with LLVM API changes in svn r75703 > ConstantInt::get and ConstantArray::get implementation have been > moved to LLVMContext > > http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090713/081100.html > > Cheers > Xerxes > Index: icedtea6/ports/hotspot/src/share/vm/shark/llvmValue.hpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/llvmValue.hpp 2009-07-15 11:34:29.000000000 +0200 > +++ icedtea6/ports/hotspot/src/share/vm/shark/llvmValue.hpp 2009-07-15 11:39:21.000000000 +0200 > @@ -27,15 +27,27 @@ > public: > static llvm::ConstantInt* jbyte_constant(jbyte value) > { > +#if SHARK_LLVM_VERSION >= 26 > + return llvm::getGlobalContext().getConstantInt(SharkType::jbyte_type(), value, true); > +#else > return llvm::ConstantInt::get(SharkType::jbyte_type(), value, true); > +#endif > } > static llvm::ConstantInt* jint_constant(jint value) > { > +#if SHARK_LLVM_VERSION >= 26 > + return llvm::getGlobalContext().getConstantInt(SharkType::jint_type(), value, true); > +#else > return llvm::ConstantInt::get(SharkType::jint_type(), value, true); > +#endif > } > static llvm::ConstantInt* jlong_constant(jlong value) > { > +#if SHARK_LLVM_VERSION >= 26 > + return llvm::getGlobalContext().getConstantInt(SharkType::jlong_type(), value, true); > +#else > return llvm::ConstantInt::get(SharkType::jlong_type(), value, true); > +#endif > } > #if SHARK_LLVM_VERSION >= 26 > static llvm::Constant* jfloat_constant(jfloat value) > @@ -67,6 +79,10 @@ > public: > static llvm::ConstantInt* intptr_constant(intptr_t value) > { > +#if SHARK_LLVM_VERSION >= 26 > + return llvm::getGlobalContext().getConstantInt(SharkType::intptr_type(), value, false); > +#else > return llvm::ConstantInt::get(SharkType::intptr_type(), value, false); > +#endif > } > }; > Index: icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp > =================================================================== > --- icedtea6.orig/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp 2009-07-15 11:40:21.000000000 +0200 > +++ icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp 2009-07-15 11:44:42.000000000 +0200 > @@ -187,9 +187,15 @@ > { > Constant *const_name; > if (value->hasName()) > +#if SHARK_LLVM_VERSION >= 26 > + const_name = getGlobalContext().getConstantArray(value->getName()); > + else > + const_name = getGlobalContext().getConstantArray("unnamed_value"); > +#else > const_name = ConstantArray::get(value->getName()); > else > const_name = ConstantArray::get("unnamed_value"); > +#endif > > Value *name = CreatePtrToInt( > CreateStructGEP( > @@ -260,10 +266,18 @@ > CallInst *SharkBuilder::CreateMemoryBarrier(BarrierFlags flags) > { > Value *args[] = { > +#if SHARK_LLVM_VERSION >= 26 > + getGlobalContext().getConstantInt(Type::Int1Ty, (flags & BARRIER_LOADLOAD) ? 1 : 0), > + getGlobalContext().getConstantInt(Type::Int1Ty, (flags & BARRIER_LOADSTORE) ? 1 : 0), > + getGlobalContext().getConstantInt(Type::Int1Ty, (flags & BARRIER_STORELOAD) ? 1 : 0), > + getGlobalContext().getConstantInt(Type::Int1Ty, (flags & BARRIER_STORESTORE) ? 1 : 0), > + getGlobalContext().getConstantInt(Type::Int1Ty, 0)}; > +#else > ConstantInt::get(Type::Int1Ty, (flags & BARRIER_LOADLOAD) ? 1 : 0), > ConstantInt::get(Type::Int1Ty, (flags & BARRIER_LOADSTORE) ? 1 : 0), > ConstantInt::get(Type::Int1Ty, (flags & BARRIER_STORELOAD) ? 1 : 0), > ConstantInt::get(Type::Int1Ty, (flags & BARRIER_STORESTORE) ? 1 : 0), > ConstantInt::get(Type::Int1Ty, 0)}; > +#endif > return CreateCall(llvm_memory_barrier_fn(), args, args + 5); > } -- http://gbenson.net/ From xerxes at zafena.se Wed Jul 15 03:54:14 2009 From: xerxes at zafena.se (Xerxes R?nby) Date: Wed, 15 Jul 2009 10:54:14 +0000 Subject: changeset in /hg/icedtea6: 2009-07-15 Xerxes R?nby changeset 438cbd2f7252 in /hg/icedtea6 details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=438cbd2f7252 description: 2009-07-15 Xerxes R?nby * ports/hotspot/src/share/vm/shark/llvmValue.hpp (jbyte_constant): Handle LLVM 2.6 svn r75703 API change. llvm::ConstantInt::get have been moved to llvm::LLVMContext::getConstantInt. (jint_constant): Likewise. (jlong_constant): Likewise. (intptr_constant): Likewise. * ports/hotspot/src/share/vm/shark/sharkBuilder.cpp (SharkBuilder::CreateMemoryBarrier): Likewise. (SharkBuilder::CreateDump): llvm::ConstantArray::get have been moved to llvm::LLVMContext::getConstantArray. diffstat: 3 files changed, 44 insertions(+) ChangeLog | 14 ++++++++++++++ ports/hotspot/src/share/vm/shark/llvmValue.hpp | 16 ++++++++++++++++ ports/hotspot/src/share/vm/shark/sharkBuilder.cpp | 14 ++++++++++++++ diffs (101 lines): diff -r 119501af9b1c -r 438cbd2f7252 ChangeLog --- a/ChangeLog Tue Jul 14 13:12:50 2009 -0400 +++ b/ChangeLog Wed Jul 15 12:56:10 2009 +0200 @@ -1,3 +1,17 @@ 2009-07-14 Deepak Bhole + + * ports/hotspot/src/share/vm/shark/llvmValue.hpp + (jbyte_constant): Handle LLVM 2.6 svn r75703 API change. + llvm::ConstantInt::get have been moved to + llvm::LLVMContext::getConstantInt. + (jint_constant): Likewise. + (jlong_constant): Likewise. + (intptr_constant): Likewise. + * ports/hotspot/src/share/vm/shark/sharkBuilder.cpp + (SharkBuilder::CreateMemoryBarrier): Likewise. + (SharkBuilder::CreateDump): llvm::ConstantArray::get have been + moved to llvm::LLVMContext::getConstantArray. + 2009-07-14 Deepak Bhole * Makefile.am: Fix npplugin build. diff -r 119501af9b1c -r 438cbd2f7252 ports/hotspot/src/share/vm/shark/llvmValue.hpp --- a/ports/hotspot/src/share/vm/shark/llvmValue.hpp Tue Jul 14 13:12:50 2009 -0400 +++ b/ports/hotspot/src/share/vm/shark/llvmValue.hpp Wed Jul 15 12:56:10 2009 +0200 @@ -27,15 +27,27 @@ class LLVMValue : public AllStatic { public: static llvm::ConstantInt* jbyte_constant(jbyte value) { +#if SHARK_LLVM_VERSION >= 26 + return llvm::getGlobalContext().getConstantInt(SharkType::jbyte_type(), value, true); +#else return llvm::ConstantInt::get(SharkType::jbyte_type(), value, true); +#endif } static llvm::ConstantInt* jint_constant(jint value) { +#if SHARK_LLVM_VERSION >= 26 + return llvm::getGlobalContext().getConstantInt(SharkType::jint_type(), value, true); +#else return llvm::ConstantInt::get(SharkType::jint_type(), value, true); +#endif } static llvm::ConstantInt* jlong_constant(jlong value) { +#if SHARK_LLVM_VERSION >= 26 + return llvm::getGlobalContext().getConstantInt(SharkType::jlong_type(), value, true); +#else return llvm::ConstantInt::get(SharkType::jlong_type(), value, true); +#endif } #if SHARK_LLVM_VERSION >= 26 static llvm::Constant* jfloat_constant(jfloat value) @@ -67,6 +79,10 @@ class LLVMValue : public AllStatic { public: static llvm::ConstantInt* intptr_constant(intptr_t value) { +#if SHARK_LLVM_VERSION >= 26 + return llvm::getGlobalContext().getConstantInt(SharkType::intptr_type(), value, false); +#else return llvm::ConstantInt::get(SharkType::intptr_type(), value, false); +#endif } }; diff -r 119501af9b1c -r 438cbd2f7252 ports/hotspot/src/share/vm/shark/sharkBuilder.cpp --- a/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp Tue Jul 14 13:12:50 2009 -0400 +++ b/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp Wed Jul 15 12:56:10 2009 +0200 @@ -187,9 +187,15 @@ CallInst* SharkBuilder::CreateDump(llvm: { Constant *const_name; if (value->hasName()) +#if SHARK_LLVM_VERSION >= 26 + const_name = getGlobalContext().getConstantArray(value->getName()); + else + const_name = getGlobalContext().getConstantArray("unnamed_value"); +#else const_name = ConstantArray::get(value->getName()); else const_name = ConstantArray::get("unnamed_value"); +#endif Value *name = CreatePtrToInt( CreateStructGEP( @@ -260,10 +266,18 @@ CallInst *SharkBuilder::CreateMemoryBarr CallInst *SharkBuilder::CreateMemoryBarrier(BarrierFlags flags) { Value *args[] = { +#if SHARK_LLVM_VERSION >= 26 + getGlobalContext().getConstantInt(Type::Int1Ty, (flags & BARRIER_LOADLOAD) ? 1 : 0), + getGlobalContext().getConstantInt(Type::Int1Ty, (flags & BARRIER_LOADSTORE) ? 1 : 0), + getGlobalContext().getConstantInt(Type::Int1Ty, (flags & BARRIER_STORELOAD) ? 1 : 0), + getGlobalContext().getConstantInt(Type::Int1Ty, (flags & BARRIER_STORESTORE) ? 1 : 0), + getGlobalContext().getConstantInt(Type::Int1Ty, 0)}; +#else ConstantInt::get(Type::Int1Ty, (flags & BARRIER_LOADLOAD) ? 1 : 0), ConstantInt::get(Type::Int1Ty, (flags & BARRIER_LOADSTORE) ? 1 : 0), ConstantInt::get(Type::Int1Ty, (flags & BARRIER_STORELOAD) ? 1 : 0), ConstantInt::get(Type::Int1Ty, (flags & BARRIER_STORESTORE) ? 1 : 0), ConstantInt::get(Type::Int1Ty, 0)}; +#endif return CreateCall(llvm_memory_barrier_fn(), args, args + 5); } From ahughes at redhat.com Wed Jul 15 05:37:19 2009 From: ahughes at redhat.com (Andrew John Hughes) Date: Wed, 15 Jul 2009 12:37:19 +0000 Subject: changeset in /hg/icedtea: Fix build on systems without java.util... Message-ID: changeset 2341c4735ea7 in /hg/icedtea details: http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=2341c4735ea7 description: Fix build on systems without java.util.Scanner. 2009-07-15 Andrew John Hughes * Makefile.am: Turn on euctw patch for systems without java.util.Scanner. * patches/ecj/icedtea-euctw.patch: Remove java.util.Scanner from GenerateEUC_TW.java diffstat: 3 files changed, 42 insertions(+), 1 deletion(-) ChangeLog | 8 ++++++++ Makefile.am | 3 ++- patches/ecj/icedtea-euctw.patch | 32 ++++++++++++++++++++++++++++++++ diffs (64 lines): diff -r e2ff1b52131d -r 2341c4735ea7 ChangeLog --- a/ChangeLog Tue Jul 14 19:44:20 2009 +0100 +++ b/ChangeLog Wed Jul 15 13:39:06 2009 +0100 @@ -1,3 +1,11 @@ 2009-07-14 Andrew John Hughes + + * Makefile.am: + Turn on euctw patch for systems without + java.util.Scanner. + * patches/ecj/icedtea-euctw.patch: + Remove java.util.Scanner from GenerateEUC_TW.java + 2009-07-14 Andrew John Hughes * patches/icedtea-messageutils.patch, diff -r e2ff1b52131d -r 2341c4735ea7 Makefile.am --- a/Makefile.am Tue Jul 14 19:44:20 2009 +0100 +++ b/Makefile.am Wed Jul 15 13:39:06 2009 +0100 @@ -2501,7 +2501,8 @@ SCANNER_PATCHES = patches/ecj/icedtea-sp patches/ecj/icedtea-dbcs.patch if LACKS_JAVA_UTIL_SCANNER -ICEDTEA_ECJ_PATCHES += $(SCANNER_PATCHES) +ICEDTEA_ECJ_PATCHES += $(SCANNER_PATCHES) \ + patches/ecj/icedtea-euctw.patch else if CP40630 ICEDTEA_ECJ_PATCHES += $(SCANNER_PATCHES) diff -r e2ff1b52131d -r 2341c4735ea7 patches/ecj/icedtea-euctw.patch --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/patches/ecj/icedtea-euctw.patch Wed Jul 15 13:39:06 2009 +0100 @@ -0,0 +1,32 @@ +diff -Nru openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java +--- openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java 2009-07-15 13:08:40.000000000 +0100 ++++ openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateEUC_TW.java 2009-07-15 13:12:08.000000000 +0100 +@@ -27,7 +27,6 @@ + + import java.io.*; + import java.util.ArrayList; +-import java.util.Scanner; + import java.util.Formatter; + import java.util.regex.*; + import java.nio.charset.*; +@@ -42,16 +41,16 @@ + } + + private static String getCopyright(File f) throws IOException { +- Scanner s = new Scanner(f, "ISO-8859-1"); ++ BufferedReader r = ++ new BufferedReader(new InputStreamReader(new FileInputStream(f), "ISO-8859-1")); + StringBuilder sb = new StringBuilder(); +- while (s.hasNextLine()) { +- String ln = s.nextLine(); ++ for (String ln = r.readLine(); ln != null; ln = r.readLine()) { + sb.append(ln + "\n"); + // assume we have the copyright as the first comment + if (ln.matches("^\\s\\*\\/$")) + break; + } +- s.close(); ++ r.close(); + return sb.toString(); + } + From ahughes at redhat.com Wed Jul 15 05:37:19 2009 From: ahughes at redhat.com (Andrew John Hughes) Date: Wed, 15 Jul 2009 12:37:19 +0000 Subject: changeset in /hg/icedtea: Bump to b64. Message-ID: changeset e2ff1b52131d in /hg/icedtea details: http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=e2ff1b52131d description: Bump to b64. 2009-07-14 Andrew John Hughes * patches/icedtea-messageutils.patch, * patches/icedtea-toolkit.patch: Dropped, committed upstream by Lillian. * Makefile.am: Bump to b64. * patches/ecj/icedtea-dbcs.patch, * patches/ecj/icedtea.patch, * patches/icedtea-linker-libs-order.patch, * patches/icedtea-webstart.patch: Recreated. diffstat: 8 files changed, 107 insertions(+), 153 deletions(-) ChangeLog | 12 ++ Makefile.am | 36 +++---- patches/ecj/icedtea-dbcs.patch | 6 - patches/ecj/icedtea.patch | 152 +++++++++++++------------------ patches/icedtea-linker-libs-order.patch | 12 +- patches/icedtea-messageutils.patch | 12 -- patches/icedtea-toolkit.patch | 11 -- patches/icedtea-webstart.patch | 19 +-- diffs (truncated from 613 to 500 lines): diff -r e944184d6eda -r e2ff1b52131d ChangeLog --- a/ChangeLog Thu Jul 09 19:52:10 2009 +0100 +++ b/ChangeLog Tue Jul 14 19:44:20 2009 +0100 @@ -1,3 +1,15 @@ 2009-07-09 Andrew John Hughes + + * patches/icedtea-messageutils.patch, + * patches/icedtea-toolkit.patch: + Dropped, committed upstream by Lillian. + * Makefile.am: Bump to b64. + * patches/ecj/icedtea-dbcs.patch, + * patches/ecj/icedtea.patch, + * patches/icedtea-linker-libs-order.patch, + * patches/icedtea-webstart.patch: + Recreated. + 2009-07-09 Andrew John Hughes * patches/ecj/icedtea-pr40616.patch: diff -r e944184d6eda -r e2ff1b52131d Makefile.am --- a/Makefile.am Thu Jul 09 19:52:10 2009 +0100 +++ b/Makefile.am Tue Jul 14 19:44:20 2009 +0100 @@ -1,20 +1,20 @@ OPENJDK_VERSION = b63 -OPENJDK_VERSION = b63 - -OPENJDK_CHANGESET = 57f7e028c7ad -CORBA_CHANGESET = d20e45cd539f -JAXP_CHANGESET = ae449e9c04c1 -JAXWS_CHANGESET = 5b9e8315aab2 -JDK_CHANGESET = 6388560a8d7e -LANGTOOLS_CHANGESET = 5c2c81120555 -HOTSPOT_CHANGESET = 32c83fb84370 - -OPENJDK_MD5SUM = 01a2fe09452d8579fb251120e37dc45a -CORBA_MD5SUM = 865e397135e2b9f8e4a256b4146b6852 -JAXP_MD5SUM = 008c8971c40aca1759dd0129a025f9b8 -JAXWS_MD5SUM = 86d18ba378cb83a2bd33b334c7bd610e -JDK_MD5SUM = 68b034a7d0906a0f7b471e080b45407a -LANGTOOLS_MD5SUM = 5ff432cec3ddf86ae5dbd147da1a7f92 -HOTSPOT_MD5SUM = a97947d03665b39b806ddcf2e48b9fc8 +OPENJDK_VERSION = b64 + +OPENJDK_CHANGESET = 269c1ec4435d +CORBA_CHANGESET = 047dd27fddb6 +JAXP_CHANGESET = a10eec7a1edf +JAXWS_CHANGESET = d1788e8fd315 +JDK_CHANGESET = d799a225c668 +LANGTOOLS_CHANGESET = d8f23a81d46f +HOTSPOT_CHANGESET = ba36394eb84b + +OPENJDK_MD5SUM = 377e7f1139d876175dd85629220213c9 +CORBA_MD5SUM = 203e6eb0231ae7848a501ee40fcc256d +JAXP_MD5SUM = b57ed800ab149e44d4d53525cf58e9a7 +JAXWS_MD5SUM = 768509b4a24dc8e3b060e68e71081f48 +JDK_MD5SUM = dab8727958b03ff1b7992a50545479c3 +LANGTOOLS_MD5SUM = bf1a06f7d30febfb332658b6d7ef5fa5 +HOTSPOT_MD5SUM = 1ffa3dd169e18e9679c56b13c04a0de9 CACAO_VERSION = 0.99.4 CACAO_MD5SUM = 63220327925ace13756ae334c55a3baa @@ -2037,7 +2037,6 @@ ICEDTEA_PATCHES = \ patches/icedtea-override-redirect-metacity.patch \ patches/icedtea-shark-build.patch \ patches/hotspot/$(HSBUILD)/icedtea-shark-build.patch \ - patches/icedtea-toolkit.patch \ patches/icedtea-security-updates.patch \ patches/icedtea-jdk-docs-target.patch \ patches/icedtea-mbeanintrospector.patch \ @@ -2053,7 +2052,6 @@ ICEDTEA_PATCHES = \ patches/icedtea-arch.patch \ patches/icedtea-signed-types.patch \ patches/icedtea-lc_ctype.patch \ - patches/icedtea-messageutils.patch \ patches/icedtea-xjc.patch \ patches/icedtea-renderer-crossing.patch \ patches/icedtea-tests-jdk.patch \ diff -r e944184d6eda -r e2ff1b52131d patches/ecj/icedtea-dbcs.patch --- a/patches/ecj/icedtea-dbcs.patch Thu Jul 09 19:52:10 2009 +0100 +++ b/patches/ecj/icedtea-dbcs.patch Tue Jul 14 19:44:20 2009 +0100 @@ -1,6 +1,6 @@ diff -Nru openjdk-ecj.orig/jdk/make/tool diff -Nru openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java ---- openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java 2009-07-08 18:00:55.000000000 +0100 -+++ openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java 2009-07-08 23:45:44.000000000 +0100 +--- openjdk-ecj.orig/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java 2009-07-14 18:00:31.000000000 +0100 ++++ openjdk-ecj/jdk/make/tools/src/build/tools/charsetmapping/GenerateDBCS.java 2009-07-14 18:08:30.000000000 +0100 @@ -27,7 +27,6 @@ import java.io.*; import java.util.Arrays; @@ -10,7 +10,7 @@ diff -Nru openjdk-ecj.orig/jdk/make/tool import java.util.regex.*; import java.nio.charset.*; @@ -38,9 +37,8 @@ - static Pattern mPattern = Pattern.compile("(\\p{XDigit}++)\\s++(\\p{XDigit}++)(\\s++#.*)?"); + static Pattern mPattern = Pattern.compile("(?:0x)?(\\p{XDigit}++)\\s++(?:0x)?(\\p{XDigit}++)(?:\\s++#.*)?"); public static void genDBCS(String args[]) throws Exception { - Scanner s = new Scanner(new File(args[0], args[2])); diff -r e944184d6eda -r e2ff1b52131d patches/ecj/icedtea.patch --- a/patches/ecj/icedtea.patch Thu Jul 09 19:52:10 2009 +0100 +++ b/patches/ecj/icedtea.patch Tue Jul 14 19:44:20 2009 +0100 @@ -1,6 +1,6 @@ diff -Nru openjdk-ecj.orig/corba/make/co diff -Nru openjdk-ecj.orig/corba/make/com/sun/corba/se/Makefile openjdk-ecj/corba/make/com/sun/corba/se/Makefile --- openjdk-ecj.orig/corba/make/com/sun/corba/se/Makefile 2009-03-30 17:13:01.000000000 +0100 -+++ openjdk-ecj/corba/make/com/sun/corba/se/Makefile 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/corba/make/com/sun/corba/se/Makefile 2009-07-14 17:47:13.000000000 +0100 @@ -42,7 +42,7 @@ # the rmic iiop backend needs some classes that are part of the impl/util # package. These classes use log wrappers, so they must be built after @@ -12,7 +12,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co diff -Nru openjdk-ecj.orig/corba/make/com/sun/corba/se/org/Makefile openjdk-ecj/corba/make/com/sun/corba/se/org/Makefile --- openjdk-ecj.orig/corba/make/com/sun/corba/se/org/Makefile 1970-01-01 01:00:00.000000000 +0100 -+++ openjdk-ecj/corba/make/com/sun/corba/se/org/Makefile 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/corba/make/com/sun/corba/se/org/Makefile 2009-07-14 17:47:13.000000000 +0100 @@ -0,0 +1,38 @@ +# +# Copyright 2001-2005 Sun Microsystems, Inc. All Rights Reserved. @@ -54,7 +54,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co +include $(BUILDDIR)/common/Classes.gmk diff -Nru openjdk-ecj.orig/corba/make/common/Defs.gmk openjdk-ecj/corba/make/common/Defs.gmk --- openjdk-ecj.orig/corba/make/common/Defs.gmk 2009-03-30 17:13:01.000000000 +0100 -+++ openjdk-ecj/corba/make/common/Defs.gmk 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/corba/make/common/Defs.gmk 2009-07-14 17:47:13.000000000 +0100 @@ -53,6 +53,13 @@ _OUTPUTDIR=$(TOPDIR)/build/$(PLATFORM)-$(ARCH) @@ -88,8 +88,8 @@ diff -Nru openjdk-ecj.orig/corba/make/co vpath %.java $(VPATH.java) vpath %.class $(CLASSBINDIR) diff -Nru openjdk-ecj.orig/corba/make/common/Defs-linux.gmk openjdk-ecj/corba/make/common/Defs-linux.gmk ---- openjdk-ecj.orig/corba/make/common/Defs-linux.gmk 2009-07-01 13:42:16.000000000 +0100 -+++ openjdk-ecj/corba/make/common/Defs-linux.gmk 2009-07-01 13:52:45.000000000 +0100 +--- openjdk-ecj.orig/corba/make/common/Defs-linux.gmk 2009-07-14 17:37:18.000000000 +0100 ++++ openjdk-ecj/corba/make/common/Defs-linux.gmk 2009-07-14 17:47:13.000000000 +0100 @@ -276,7 +276,7 @@ fi; \ done) @@ -101,7 +101,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co # We want to privatize JVM symbols on Solaris. This is so the user can diff -Nru openjdk-ecj.orig/corba/make/common/Rules.gmk openjdk-ecj/corba/make/common/Rules.gmk --- openjdk-ecj.orig/corba/make/common/Rules.gmk 2009-03-30 23:07:09.000000000 +0100 -+++ openjdk-ecj/corba/make/common/Rules.gmk 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/corba/make/common/Rules.gmk 2009-07-14 17:47:13.000000000 +0100 @@ -201,8 +201,10 @@ $(ECHO) "# Java sources to be compiled: (listed in file $(JAVA_SOURCE_LIST))"; \ $(CAT) $(JAVA_SOURCE_LIST); \ @@ -117,7 +117,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co diff -Nru openjdk-ecj.orig/corba/make/common/shared/Defs-java.gmk openjdk-ecj/corba/make/common/shared/Defs-java.gmk --- openjdk-ecj.orig/corba/make/common/shared/Defs-java.gmk 2009-03-30 23:07:09.000000000 +0100 -+++ openjdk-ecj/corba/make/common/shared/Defs-java.gmk 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/corba/make/common/shared/Defs-java.gmk 2009-07-14 17:47:13.000000000 +0100 @@ -120,31 +120,14 @@ JAVACFLAGS += $(OTHER_JAVACFLAGS) @@ -158,7 +158,7 @@ diff -Nru openjdk-ecj.orig/corba/make/co ifdef JAVAC diff -Nru openjdk-ecj.orig/corba/make/org/omg/sources/Makefile openjdk-ecj/corba/make/org/omg/sources/Makefile --- openjdk-ecj.orig/corba/make/org/omg/sources/Makefile 2009-03-30 17:13:01.000000000 +0100 -+++ openjdk-ecj/corba/make/org/omg/sources/Makefile 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/corba/make/org/omg/sources/Makefile 2009-07-14 17:47:13.000000000 +0100 @@ -93,8 +93,6 @@ POAHELHOLFILES = $(POA_GENERATED_HELP_HOL_java:%=$(GENSRCDIR)/%) @@ -237,7 +237,7 @@ diff -Nru openjdk-ecj.orig/corba/make/or diff -Nru openjdk-ecj.orig/corba/make/sun/rmi/corbalogsources/Makefile openjdk-ecj/corba/make/sun/rmi/corbalogsources/Makefile --- openjdk-ecj.orig/corba/make/sun/rmi/corbalogsources/Makefile 2009-03-30 23:07:09.000000000 +0100 -+++ openjdk-ecj/corba/make/sun/rmi/corbalogsources/Makefile 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/corba/make/sun/rmi/corbalogsources/Makefile 2009-07-14 17:47:13.000000000 +0100 @@ -172,7 +172,6 @@ ACTIVATIONFILES = $(com_sun_corba_se_spi_activation_java:%=$(GENSRCDIR)/%) @@ -256,7 +256,7 @@ diff -Nru openjdk-ecj.orig/corba/make/su diff -Nru openjdk-ecj.orig/jaxp/make/build.xml openjdk-ecj/jaxp/make/build.xml --- openjdk-ecj.orig/jaxp/make/build.xml 2009-06-30 14:24:48.000000000 +0100 -+++ openjdk-ecj/jaxp/make/build.xml 2009-07-01 13:55:31.000000000 +0100 ++++ openjdk-ecj/jaxp/make/build.xml 2009-07-14 17:47:13.000000000 +0100 @@ -71,7 +71,10 @@ diff -Nru openjdk-ecj.orig/jaxp/make/Makefile openjdk-ecj/jaxp/make/Makefile ---- openjdk-ecj.orig/jaxp/make/Makefile 2009-07-01 13:42:16.000000000 +0100 -+++ openjdk-ecj/jaxp/make/Makefile 2009-07-01 13:52:45.000000000 +0100 +--- openjdk-ecj.orig/jaxp/make/Makefile 2009-07-14 17:37:17.000000000 +0100 ++++ openjdk-ecj/jaxp/make/Makefile 2009-07-14 17:47:13.000000000 +0100 @@ -92,7 +92,7 @@ endif @@ -292,8 +292,8 @@ diff -Nru openjdk-ecj.orig/jaxp/make/Mak ifdef ALT_OUTPUTDIR diff -Nru openjdk-ecj.orig/jaxws/make/build.properties openjdk-ecj/jaxws/make/build.properties ---- openjdk-ecj.orig/jaxws/make/build.properties 2009-07-01 13:42:16.000000000 +0100 -+++ openjdk-ecj/jaxws/make/build.properties 2009-07-01 13:52:45.000000000 +0100 +--- openjdk-ecj.orig/jaxws/make/build.properties 2009-07-14 17:37:18.000000000 +0100 ++++ openjdk-ecj/jaxws/make/build.properties 2009-07-14 17:47:13.000000000 +0100 @@ -37,7 +37,7 @@ # set the following to -version to verify the versions of javac being used javac.version.opt = @@ -305,7 +305,7 @@ diff -Nru openjdk-ecj.orig/jaxws/make/bu javac.memoryInitialSize = 128m diff -Nru openjdk-ecj.orig/jaxws/make/build.xml openjdk-ecj/jaxws/make/build.xml --- openjdk-ecj.orig/jaxws/make/build.xml 2009-06-30 14:24:56.000000000 +0100 -+++ openjdk-ecj/jaxws/make/build.xml 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/jaxws/make/build.xml 2009-07-14 17:47:13.000000000 +0100 @@ -93,7 +93,10 @@ diff -Nru openjdk-ecj.orig/jaxws/make/Makefile openjdk-ecj/jaxws/make/Makefile ---- openjdk-ecj.orig/jaxws/make/Makefile 2009-07-01 13:42:16.000000000 +0100 -+++ openjdk-ecj/jaxws/make/Makefile 2009-07-01 13:52:45.000000000 +0100 +--- openjdk-ecj.orig/jaxws/make/Makefile 2009-07-14 17:37:17.000000000 +0100 ++++ openjdk-ecj/jaxws/make/Makefile 2009-07-14 17:47:13.000000000 +0100 @@ -92,8 +92,8 @@ endif @@ -342,7 +342,7 @@ diff -Nru openjdk-ecj.orig/jaxws/make/Ma ifdef ALT_OUTPUTDIR diff -Nru openjdk-ecj.orig/jdk/make/common/BuildToolJar.gmk openjdk-ecj/jdk/make/common/BuildToolJar.gmk --- openjdk-ecj.orig/jdk/make/common/BuildToolJar.gmk 2009-03-30 17:23:03.000000000 +0100 -+++ openjdk-ecj/jdk/make/common/BuildToolJar.gmk 2009-07-01 13:52:45.000000000 +0100 ++++ openjdk-ecj/jdk/make/common/BuildToolJar.gmk 2009-07-14 17:47:13.000000000 +0100 @@ -43,7 +43,8 @@ @$(prep-target) @$(MKDIR) -p $(BUILDTOOLCLASSDIR) @@ -354,57 +354,33 @@ diff -Nru openjdk-ecj.orig/jdk/make/comm -C $(BUILDTOOLCLASSDIR) $(PKGDIR) \ $(BOOT_JAR_JFLAGS) || $(RM) $@ diff -Nru openjdk-ecj.orig/jdk/make/common/Release.gmk openjdk-ecj/jdk/make/common/Release.gmk ---- openjdk-ecj.orig/jdk/make/common/Release.gmk 2009-07-01 13:42:20.000000000 +0100 -+++ openjdk-ecj/jdk/make/common/Release.gmk 2009-07-01 13:52:45.000000000 +0100 -@@ -652,10 +652,23 @@ - $(RES_JAR_ARGLIST): $(RES_JAR_FILELIST) - $(prep-target) - $(SED) -e "s@^@-C $(CLASSBINDIR) @" $< > $@ --$(RESOURCES_JAR): $(RES_JAR_ARGLIST) $(JAR_MANIFEST_FILE) -+$(RESOURCES_JAR): \ -+ $(if $(JAR_KNOWS_ATFILE),$(RES_JAR_FILELIST),$(RES_JAR_ARGLIST)) \ -+ $(JAR_MANIFEST_FILE) +--- openjdk-ecj.orig/jdk/make/common/Release.gmk 2009-07-14 17:37:19.000000000 +0100 ++++ openjdk-ecj/jdk/make/common/Release.gmk 2009-07-14 17:54:01.000000000 +0100 +@@ -650,10 +650,21 @@ + RESOURCES_JAR=$(ABS_TEMPDIR)/resources-orig.jar + $(RESOURCES_JAR): $(RES_JAR_FILELIST) $(JAR_MANIFEST_FILE) $(prep-target) +ifneq (,$(JAR_KNOWS_ATFILE)) -+ (cd $(CLASSBINDIR) && \ - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ -- @$(RES_JAR_ARGLIST) $(BOOT_JAR_JFLAGS) -+ $(JAR_JFLAGS) @$(RES_JAR_FILELIST)) + $(CD) $(CLASSBINDIR) && \ + $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ + @$(RES_JAR_FILELIST) $(BOOT_JAR_JFLAGS) +- @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) ++ @$(CD) $(CLASSBINDIR) +else ifneq (,$(JAR_ACCEPTS_STDIN_LIST)) + (cd $(CLASSBINDIR) && $(CAT) $(RES_JAR_FILELIST) | \ -+ $(BOOT_JAR_CMD) c0mf@ $(JAR_MANIFEST_FILE) $@ \ -+ $(JAR_JFLAGS)) -+else -+ (cd $(CLASSBINDIR) && \ -+ $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ -+ $(JAR_JFLAGS) `cat $(RES_JAR_FILELIST)`) -+endif - @$(java-vm-cleanup) - - # Create jsse.jar containing SunJSSE implementation classes -@@ -711,10 +724,18 @@ - $(RT_JAR_ARGLIST): $(RT_JAR_FILELIST) - $(prep-target) - $(SED) -e "s@^@-C $(CLASSBINDIR) @" $< > $@ --$(RT_JAR): $(RT_JAR_ARGLIST) $(JAR_MANIFEST_FILE) -+$(RT_JAR): $(if $(JAR_KNOWS_ATFILE),$(RT_JAR_FILELIST),$(RT_JAR_ARGLIST)) \ -+ $(JAR_MANIFEST_FILE) - $(prep-target) -+ifneq (,$(JAR_KNOWS_ATFILE)) -+ (cd $(CLASSBINDIR) && $(CAT) $(RT_JAR_FILELIST) | \ + $(BOOT_JAR_CMD) c0mf@ $(JAR_MANIFEST_FILE) $@ \ + $(BOOT_JAR_JFLAGS)) +else + (cd $(CLASSBINDIR) && \ - $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ -- @$(RT_JAR_ARGLIST) $(BOOT_JAR_JFLAGS) -+ $(BOOT_JAR_JFLAGS) `$(CAT) $(RT_JAR_FILELIST)`) ++ $(BOOT_JAR_CMD) c0mf $(JAR_MANIFEST_FILE) $@ \ ++ $(BOOT_JAR_JFLAGS) `cat $(RES_JAR_FILELIST)`) +endif - @$(java-vm-cleanup) - - # Meta-index construction to make core class loaders lazier -@@ -945,19 +966,6 @@ - @$(java-vm-cleanup) ++ $(java-vm-cleanup) + + # Create jsse.jar containing SunJSSE implementation classes + JSSE_JAR=$(ABS_TEMPDIR)/jsse-orig.jar +@@ -944,19 +955,6 @@ + @$(CD) $(CLASSBINDIR) && $(java-vm-cleanup) $(CP) $(LIBDIR)/tools.jar $(JDK_IMAGE_DIR)/lib/tools.jar @# - @# lib/ct.sym @@ -423,7 +399,7 @@ diff -Nru openjdk-ecj.orig/jdk/make/comm @# CORBA supported orb.idl and ir.idl should be copied to lib @# $(CP) $(LIBDIR)/orb.idl $(JDK_IMAGE_DIR)/lib/orb.idl -@@ -1034,16 +1042,6 @@ +@@ -1033,16 +1031,6 @@ $(CP) $(PLATFORM_SRC)/bin/java_md.h $(JDK_IMAGE_DIR)/src/launcher $(CD) $(JDK_IMAGE_DIR)/src && $(ZIPEXE) -qr ../src.zip * $(RM) -r $(JDK_IMAGE_DIR)/src @@ -442,7 +418,7 @@ diff -Nru openjdk-ecj.orig/j