Fixing undefined ia64_double_zero
Dr Andrew John Hughes
ahughes at redhat.com
Thu Dec 2 09:55:29 PST 2010
On 11:54 Thu 02 Dec , Bob Vandette wrote:
> I re-introduced some old IA64 workaround logic with this changeset.
> changeset: 1593:126ea7725993
> user: bobv
> date: Tue Aug 03 08:13:38 2010 -0400
> summary: 6953477: Increase portability and flexibility of building Hotspot
> As I understand, the work-around below is no longer needed. I'll put together a webrev
> and push a fix but since I have no way of building for IA64 targets, I want to make sure
> that this is the only change causing the IA64 build to fail. I intend on removing
> everything except line 1292.
> - 1288 #ifdef IA64
> - 1289 // IA64 gcc bug
> - 1290 r = ( f == 0.0f ) ? (jdouble) f : (jdouble) f + ia64_double_zero;
> - 1291 #else
> 1292 r = (jdouble) f;
> - 1293 #endif
> Gary, have you successfully built all of the Zero targets/architectures since this changeset?
> changeset: 1732:3dc12ef8735e
> parent: 1728:dfb38ea7da17
> user: bobv
> date: Thu Oct 07 15:12:57 2010 -0400
> summary: 6989297: Integrate additional portability improvements
> I've tried to make sure that I don't break the Zero builds with my changes but we don't
> validate these targets here at Oracle.
As discussed in
reintroducing the logic in 6989297 broke the ia64 build. I'm not sure
why this change was made if you don't even build on ia64. Removing
the workaround was a change made way back on 04-04-2008 in IcedTea,
and was then upstreamed by Gary as part of upstreaming Zero.
According to Matthias, ia64 now builds when we revert this fix in
IcedTea6, so please do the same in the upstream JDK repositories.
> Bob Vandette
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the distro-pkg-dev