[icedtea-web] RFC: remove version check when parsing jnlp files

Omair Majid omajid at redhat.com
Wed Dec 8 07:43:30 PST 2010


The attached patch removes the explicit check for jnlp spec version when 
parsing a JNLP file.

A number of JNLP files that I have come across contain invalid spec 
number - the only valid spec numbers that I know of are 1.0, 1.5 and 6.0 
(and updates). If Netx encounters a spec number that it does not 
recognize, it current fails by throwing a ParseException. Over the 
years, more and more spec numbers were added as "supported" in order to 
be compatible with JNLP files that were perfectly valid but contained an 
invalid spec number. With this patch, I am removing this check: Netx 
will attempt to run all JNLP files without looking at the spec number.

This patch is for HEAD only.

2010-12-08  Omair Majid  <omajid at redhat.com>

     * netx/net/sourceforge/jnlp/JNLPFile.java
     (getSupportedVersions): Removed.
     * netx/net/sourceforge/jnlp/Parser.java: Remove supportedVersions.
     (Parser(JNLPFile,URL,Node,boolean,boolean)): Remove check for
     supported version.
     (getSupportedVersions): Remove method.
     * netx/net/sourceforge/jnlp/resources/Messages.properties:
     Remove PSpecUnsupported.

Any thoughts or comments?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-explicit-version-check-01.patch
Type: text/x-patch
Size: 2422 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101208/d45f7434/remove-explicit-version-check-01.patch 

More information about the distro-pkg-dev mailing list