[icedtea-web] RFC: depend on sun.misc and remove local HexDumpEncoder and CharacterEncoder
omajid at redhat.com
Wed Dec 8 10:30:49 PST 2010
IcedTea-Web contains the classes
net.sourceforge.jnlp.tools.CharacterEncoder. These classes are copies of
those in sun.misc pacakge. In fact, diff -w shows that the only
differences are in license headers (the Sun->Oracle name change).
Copying code like this does not help with maintenance. I propose that we
remove these classes from IcedTea-Web and instead depend on the classes
in the JDK (similar to how we deal with Base64Encoder). The attached
patch accomplishes this.
Of course, the ideal solution would be to depend on a proper public API
for this sort of thing, but we want to avoid adding extra dependencies
to IcedTea-Web for now.
Any thoughts or comments?
2010-12-08 Omair Majid <omajid at redhat.com>
* configure.ac: Add check for sun.misc.HexDumpEncoder
* netx/net/sourceforge/jnlp/security/CertsInfoPane.java: Import
sun.misc.HexDumpEncoder. Remove import of
* netx/net/sourceforge/jnlp/tools/CharacterEncoder.java: Remove
* netx/net/sourceforge/jnlp/tools/HexDumpEncoder.java: Remove file.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 18393 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101208/eae38797/use-hexdumpencoder-from-jdk-01.patch
More information about the distro-pkg-dev