[icedtea-web] RFC: depend on sun.misc and remove local HexDumpEncoder and CharacterEncoder
omajid at redhat.com
Wed Dec 8 11:08:48 PST 2010
On 12/08/2010 01:44 PM, Dr Andrew John Hughes wrote:
> On 13:30 Wed 08 Dec , Omair Majid wrote:
>> IcedTea-Web contains the classes
>> net.sourceforge.jnlp.tools.HexDumpEncoder and
>> net.sourceforge.jnlp.tools.CharacterEncoder. These classes are copies of
>> those in sun.misc pacakge. In fact, diff -w shows that the only
>> differences are in license headers (the Sun->Oracle name change).
>> Copying code like this does not help with maintenance. I propose that we
>> remove these classes from IcedTea-Web and instead depend on the classes
>> in the JDK (similar to how we deal with Base64Encoder). The attached
>> patch accomplishes this.
>> Of course, the ideal solution would be to depend on a proper public API
>> for this sort of thing, but we want to avoid adding extra dependencies
>> to IcedTea-Web for now.
>> Any thoughts or comments?
> Can you file a bug for this as for the other sun.* dependencies? Then
> reference it in configure.ac.
Done. Filed as IcedTea bug 605.
> Otherwise, good to commit. It doesn't help to have verbatim copies of
> such code in the tree.
Thanks for the review. Pushed to HEAD.
More information about the distro-pkg-dev