[icedtea-web] RFC: fix whitespace in parsing text
omajid at redhat.com
Mon Dec 13 13:13:55 PST 2010
On 12/13/2010 02:49 PM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com> [2010-12-08 16:53]:
>> On 12/08/2010 03:45 PM, Deepak Bhole wrote:
>>> Also, do you have an example jnlp where this is an issue?
>> No, I have never seen such a JNLP file anywhere (otherwise I might
>> have brought this up sooner) but it is easy to modify an existing
>> jnlp to demonstrate this issue. The attached file contains an
>> example. When run (with a recent version of IcedTea-Web), it should
>> show a dialog asking to confirm shortcut creation. The title should
>> show the word FireFox which does not appear in the jnlp file (but
>> two words Fire and Fox do).
>> I dont think this patch is a must-have right now, but it would be
>> nice to have as it future-proofs a few things. Hopefully with it, we
>> will avoid sanitization bugs like what happened with
>> XDesktopEntryFile again.
> Fair enough. Okay for HEAD.
Thanks for the review. Pushed to HEAD.
More information about the distro-pkg-dev