[RFC] Updated: Systemtap tapset test suite.
Dr Andrew John Hughes
ahughes at redhat.com
Thu Jul 29 08:47:52 PDT 2010
On 29 July 2010 15:29, <jon.vanalten at redhat.com> wrote:
> Some time back I posted a version of this, got some feedback, addressed the feedback, with the end result appearing here. I've since updated the Makefile.am target to reflect changes to build directories, and fixed a couple of correctness issues (doh! noob mistake, wasn't zeroing some memory before writing strings into it; not sure why this wasn't causing me problems before). It would be great to get this committed. This would catch issues before they go out the door. I have two questions before I commit (if people think this is okay). Right now the jstaptest.pl script returns a failure condition if any tests fail, which Make then of course detects and stops. Is this the right approach, or should the script simply return OK all the time? Also, right now the tapsetcheck target is a dependency for make check, does anyone have a problem with this test being run automatically?
>  http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-March/008808.html
>  https://bugzilla.redhat.com/show_bug.cgi?id=613822
>  http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=527
I can't really comment on the details of the systemtap changes, but
the build changes look ok. The only change I'd make there would be to
remove the ENABLE_SYSTEMTAP if block from clean. You should always
clean up, even if the particular configuration hasn't got systemtap
enabled (a ./configure --enable-systemtap; make; ./configure
--enable-cacao; make; make clean scenario is one such scenario where
this would cause problems).
I'll try it out here as soon as I have a clean IcedTea6 tree to apply it to.
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the distro-pkg-dev