Updated Zero and Shark; disabled ARM interpreter
Andrew John Hughes
ahughes at redhat.com
Mon May 10 03:50:58 PDT 2010
On 10 May 2010 11:48, Gary Benson <gbenson at redhat.com> wrote:
> Hi all,
> After discussing this with xranby and doko on IRC it was decided to
> commit the Zero and Shark update and to disable the ARM interpreter
> until it is updated.
This is to HEAD?
> This commit fixes PR icedtea/323, and updates Shark to use the new
> stack overflow detection code that was committed to Zero on Friday.
> Gary Benson wrote:
>> Hi all,
>> Building on my commit of this morning, this patch adds the new frame
>> anchor code to Zero and Shark to fix PR icedtea/323. It also updates
>> Shark to use the new stack overflow code that Zero now has.
>> Committing this will break the ARM interpreter, which needs updating.
>> Currently last_Java_sp is set to the address of the top Zero frame
>> wherever the frame anchor is set up. It needs changing such that
>> last_Java_sp is set to the thread->zero_stack()->sp() (and the new
>> field last_Java_fp gets set to what last_Java_sp used to be set to).
>> There is a deoptimizer sefault (PR icedtea/484) which cannot be
>> applied to icedtea6 until this patch is applied. That change will
>> also require work on the ARM interpreter. I've kept that separate
>> from this commit so as not to break two things at once.
>> What are people's opinions on this? Should I commit now, or should
>> I wait? I guess I need to hear from Ed (unless anybody else is able
>> to make the ARM interpreter changes?)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the distro-pkg-dev