[RFC][plugin]: fix concurrency problems in PAV.java
dlila at redhat.com
Wed Apr 13 07:45:29 PDT 2011
> That is a concurrency related fix. Please put it in that patch.
In which patch? The first one? It's already in the first one.
However, if all concurrency fixes should go in the same patch,
I have some others that I have to put in. I'll post the 3rd version
----- Original Message -----
> * Denis Lila <dlila at redhat.com> [2011-04-13 10:30]:
> > > Did you change any functionality in destroyApplet or is it just
> > > spacing/style fixes?
> > In the first patch the only functionality change in destroyApplet
> > is this (and there are no spacing changes):
> > - if (applets.containsKey(identifier))
> > - applets.get(identifier).dispose();
> > + PluginAppletViewer pav = applets.get(identifier);
> > + if (pav != null)
> > + pav.dispose();
> > Is that ok?
> > Regards,
> > Denis.
> > ----- Original Message -----
> > > * Denis Lila <dlila at redhat.com> [2011-04-12 17:24]:
> > > > > Andrew posted some valid concerns in another thread. After
> > > > > those
> > > > > are
> > > > > all resolved, OK from me.
> > > >
> > > > I replied to that e-mail. Some of those were invalid
> > > > and I pointed those out. The others I think were good
> > ...<snip>
More information about the distro-pkg-dev