[RFC] changes to CommitPolicy
jvanek at redhat.com
Thu Aug 4 06:58:30 PDT 2011
On 08/04/2011 03:55 PM, Saad Mohammad wrote:
> [. . .]
> On 08/04/2011 09:39 AM, Deepak Bhole wrote:
>> "IcedTea-Web code changes/new feature should be accompanied with
>> > >appropriate tests. If no tests are added/modified, changes should be
>> > >accompanied with an explanation as to why."
> Where would we store our explanation if no tests are accompanied with the new changes?
I think that write them to the email with review request is enough. Altho I think write them into changelog is vaste of space. What is your opinion?
> Also, can IcedTea-Web run all tests automatically after they are added to the test directory? Or would the programmer need to modify the makefile.am every time a new test is added?
> [. . .]
Most of the reproducers should be enough when added into directory (.../icedtea-web/tests/jnlp_tests/simple - see also readme), but some cases maybe will need their own build infrastructure. (or maybe extending current one).
More information about the distro-pkg-dev