[icedtea-web] RFC: Fix for PR779: IcedTea-Web plug-in hardcodes jpi-version to 1.6.0
dbhole at redhat.com
Wed Aug 31 07:07:11 PDT 2011
* Dr Andrew John Hughes <ahughes at redhat.com> [2011-08-30 19:48]:
> On 13:36 Tue 30 Aug , Deepak Bhole wrote:
> > Hi,
> > Attached patch fixes PR779:
> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=779
> > It makes the jpi-version dynamic rather than static.
> > Okay for HEAD and 1.1?
> > Cheers,
> > Deepak
> No, this patch is incorrect. There is no guarantee that the javac
> used to build will be of the same JDK version used at runtime,
> or even that it will be installed (your previous JRE patches allow
> IcedTea-Web to work without a JDK remember?)
> You should check the java.version property instead. As you hardcode
> the JRE into the binaries, that's a safer bet as to what will be
> used at runtime.
Doh. Okay, I will have to push this to 1.1.2+ then.
Checking against java.version will require a fair bit of rework. I will
look into it.
> Andrew :)
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> Support Free Java!
> Contribute to GNU Classpath and IcedTea
> PGP Key: F5862A37 (https://keys.indymedia.org/)
> Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the distro-pkg-dev