[icedtea-web] RFC: small cleanup in ControlPanel
dbhole at redhat.com
Tue Jan 4 11:16:54 PST 2011
* Omair Majid <omajid at redhat.com> [2011-01-04 13:36]:
> On 12/17/2010 04:49 PM, Omair Majid wrote:
> >The attached patch cleans up some code in the ControlPanel, and in the
> >process removes dependencies on JNLPRuntime.
> >2010-12-17 Omair Majid <omajid at redhat.com>
> >* netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java: Remove
> >JNLPRuntime import. Remove configBrowserCommand.
> >(SettingsPanel.toString): Add Override annotation.
> >(createMainSettingsPanel): Remove call to loadConfiguration.
> >(loadConfiguration): Remove method. Setting the browser command
> >should be handled by the appropriate panel.
> >(main): Remove call to JNLPRuntime.initialize and just create a new
> >DeploymentConfiguration object. Clarify TODO comment.
> Any comments? Ok to commit?
Looks good to me. OK for head.
More information about the distro-pkg-dev