[RFC][icedtea6]: jtreg test fix.
dlila at redhat.com
Thu Jun 16 05:58:01 PDT 2011
> Approved for both.
Thanks. I think I'll wait a couple of days and give
swing-dev time to answer my RFC. If I can push it to
jdk8, we can just do a backport, instead of putting
it in icedtea6/patches.
> Is there a reason you aren't applying fixes to 1.8 & 1.9?
If you mean this test specifically, I'm not applying it
to 1.8 and 1.9 because this test doesn't exist there
(it was introduced by a backport of a fix from a few
days ago, and that only went into 1.10 and head).
If you mean `why didn't the backport that introduced
this test go into 1.8 and 1.9' that's because the bug
that motivated it was reported against 1.10. If you
would like me to push all these backports I've been doing
to 1.8 and 1.9 too, I'd be happy to do it.
----- Original Message -----
> On 14:45 Wed 15 Jun , Denis Lila wrote:
> > Hi.
> > Attached is a fix for the regression test I
> > backported a few days ago. The test used to
> > hang indefinitely because it created a JFrame
> > and never disposed it. Even when the test failed
> > with an NPE and thread "main" was killed by it,
> > didn't end because the undisposed frame kept the
> > awt threads alive.
> > The patch adds a finally block which disposes the
> > frame.
> > ChangeLog:
> > 2011-06-15 Denis Lila <dlila at redhat.com>
> > * Makefile.am: Add patch.
> > * patches/jtreg-bug7036148-test.patch:
> > Fix regression test. It used to never end, regardless of
> > success/failure.
> > Ok to push? (to head and 1.10, since that's where the
> > backport that introduced this problem went)
> > Regards,
> > Denis.
> Andrew :)
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> Support Free Java!
> Contribute to GNU Classpath and IcedTea
> PGP Key: F5862A37 (https://keys.indymedia.org/)
> Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the distro-pkg-dev