[RFC][icedtea6-pulse-audio]: Start recording corked.
omajid at redhat.com
Mon Jun 20 07:03:35 PDT 2011
On 06/17/2011 05:15 PM, Denis Lila wrote:
>> Thanks for the explanation. Th patch itself looks good to me. Okay for
> Thanks for the review.
> I pushed it.
> I attached a new patch. This one should be the final* one.
> It fixes the latency problem, which was the reason for this
> whole thing.
> 2011-06-17 Denis Lila<dlila at redhat.com>
> * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataLine.java
> (bufferSize): Remove.
> (getBufferSize): Return stream.getBufferSize().
> * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourceDataLine.java
> (connectLine): Improve formatting.
> * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioTargetDataLine.java
> (connectLine): Set up flags to adjust the latency, if needed.
> * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/Stream.java
> (bufAttr, bufAttrMutex): New members.
> (setBufAttr, bufferAttrCallback): New methods. They both set bufAttr.
> (getBufferSize): Return the current buffer size.
> (connectForRecording): Add a flags argument to allow callers to chose the
> (stateCallback): When the stream is ready, set the buffer attributes to
> the actual ones used by the server.
> * pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c
> (buf_attr_changed_callback): New function.
> Set the buffer attribute callback.
Looks good to me.
More information about the distro-pkg-dev