[RFC][icedtea6-pulse-audio]: Start recording corked.
dlila at redhat.com
Mon Jun 20 11:06:30 PDT 2011
I pushed this, but it seems I introduced a rather serious
(but very easy to fix) regression.
The attached patch fixes it.
I'm sorry about this. I must have made a mistake when testing
after adding the STATE_ and FLAG_ prefixes, and not tested the
Anyway, the ChangeLog entry is:
2011-06-20 Denis Lila <dlila at redhat.com>
(SET_STREAM_ENUM): Add an underscore after java_prefix so that
the produced string matches the names in Stream.java.
Ok to push? I tested this properly, and it works.
----- Original Message -----
> On 06/17/2011 05:15 PM, Denis Lila wrote:
> >> Thanks for the explanation. Th patch itself looks good to me. Okay
> >> for
> >> HEAD.
> > Thanks for the review.
> > I pushed it.
> > I attached a new patch. This one should be the final* one.
> > It fixes the latency problem, which was the reason for this
> > whole thing.
> > ChangeLog:
> > 2011-06-17 Denis Lila<dlila at redhat.com>
> > *
> > pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataLine.java
> > (bufferSize): Remove.
> > (getBufferSize): Return stream.getBufferSize().
> > *
> > pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourceDataLine.java
> > (connectLine): Improve formatting.
> > *
> > pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioTargetDataLine.java
> > (connectLine): Set up flags to adjust the latency, if needed.
> > *
> > pulseaudio/src/java/org/classpath/icedtea/pulseaudio/Stream.java
> > (bufAttr, bufAttrMutex): New members.
> > (setBufAttr, bufferAttrCallback): New methods. They both set
> > bufAttr.
> > (getBufferSize): Return the current buffer size.
> > (connectForRecording): Add a flags argument to allow callers to
> > chose the
> > flags.
> > (stateCallback): When the stream is ready, set the buffer
> > attributes to
> > the actual ones used by the server.
> > *
> > pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c
> > (buf_attr_changed_callback): New function.
> > (Java_org_classpath_icedtea_pulseaudio_Stream_native_1pa_1stream_1new):
> > Set the buffer attribute callback.
> Looks good to me.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 922 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110620/0499183d/pa_stream_constants_proper_names.patch
More information about the distro-pkg-dev