Reviewer needed: backport of 6956668 fix into IcedTea6 HEAD
Dr Andrew John Hughes
ahughes at redhat.com
Thu Jun 23 09:35:00 PDT 2011
On 13:16 Thu 23 Jun , Pavel Tisnovsky wrote:
> Hi all,
> is it possible to backport following fix into IcedTea6 HEAD please?
> 6956668: misbehavior of XOR operator (^) with int
> Summary: optimize cmp_ne(xor(X,1),0) to cmp_eq(X,0) only for boolean
> values X.
> Reviewed-by: never
> hg diff created against recent IcedTea6 HEAD version is stored in an
> attachment (including NEWS entry). Checked on RHEL 5.6 x86_64.
> Here's ChangeLog entry:
> 2011-06-23 Pavel Tisnovsky <ptisnovs at redhat.com>
> * Makefile.am: added new patch
> * NEWS: updated with backport
> * patches/openjdk/6956668_misbehavior_of_XOR_operator_with_int
> Backport of 6956668 fix.
> Can anybody please review this change?
> Thank you in advance,
Can you make that first underscore in the file name a hyphen for consistency
(i.e. 6956668-misbehaviour rather than 6956668_misbehaviour). Good to go
with that change.
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the distro-pkg-dev