[RFC][Icedtea-Web]: more refactoring + dead code removal
dlila at redhat.com
Wed Mar 2 07:50:11 PST 2011
I've been looking at the java side of the plugin more
and I think we should make the attached changes. Mostly
they're removing unused code (in one case (a String.split call)
the code is executed, but it's still useless).
Other than that, I've made some declarations private/static/final,
and in a few cases moved code around so it was easier to read
(like grouping static variables together, and moving a constructor
closer to the top of the class, where the variable declarations are).
I also fixed a typo (I think it was a typo).
I'm a bit uneasy about some of these changes. In particular, removing
the SecurityManager argument to PluginMessageHandlerWorker and removing
the creation of pav in PluginStreamHandler, so some feedback would be nice.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 14300 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110302/73e9496d/moreCleanup.patch
More information about the distro-pkg-dev