[RFC][Icedtea-Web]: more refactoring + dead code removal
omajid at redhat.com
Wed Mar 2 09:31:18 PST 2011
On 03/02/2011 12:09 PM, Dr Andrew John Hughes wrote:
> On 10:50 Wed 02 Mar , Denis Lila wrote:
>> I've been looking at the java side of the plugin more
>> and I think we should make the attached changes. Mostly
>> they're removing unused code (in one case (a String.split call)
>> the code is executed, but it's still useless).
>> Other than that, I've made some declarations private/static/final,
>> and in a few cases moved code around so it was easier to read
>> (like grouping static variables together, and moving a constructor
>> closer to the top of the class, where the variable declarations are).
>> I also fixed a typo (I think it was a typo).
>> I'm a bit uneasy about some of these changes. In particular, removing
>> the SecurityManager argument to PluginMessageHandlerWorker and removing
>> the creation of pav in PluginStreamHandler, so some feedback would be nice.
>> Thank you,
> I'll leave the code review to Deepak, but has anyone tried running FindBugs
> on the plugin and NetX codebases?
I have :
Bugs count: 168
But I havent been too eager on fixing all the problems.
More information about the distro-pkg-dev