Reviewer needed - fix for IcedTea bug#637
Dr Andrew John Hughes
ahughes at redhat.com
Tue Mar 8 12:58:30 PST 2011
On 20:19 Tue 08 Mar , Mark Wielaard wrote:
> On Tue, 2011-03-08 at 18:04 +0100, Pavel Tisnovsky wrote:
> > Dr Andrew John Hughes wrote:
> > > On 10:22 Tue 08 Mar , Pavel Tisnovsky wrote:
> > >> +jtregcheck-summary:
> > >
> > > This is still wrong and hasn't been fixed.
> > May I add test/jtreg-summary.log to the dependency line?
> Why would you want to do that?
> That would defeat the purpose of the target.
> It would not be run again after it once created that file.
> This isn't a "real" target is it? It is a target you use to get the
> current summary of the results ran so far.
> Maybe I am missing something.
Given this new target kills off jtreg processes, I don't see how you'd
run it to get a current summary. Neither would such a target be
a dependency of jtregcheck as it's never fulfilled.
What you're thinking of is an independent target where the whole thing is
for i in hotspot langtools jdk; do \
if [ -e test/check-$$i.log ] ; then
echo "--------------- jtreg console summary for $$i ---------------"; \
egrep -v '^(Passed:|Directory|Re[a-z]+\ written\ to)' test/check-$$i.log; \
done | tee test/jtreg-summary.log
and which nothing depends on. While the tests are running, make jtregcheck-summary
would be called independently and print the current status. That's a nice
idea, but not what this patch is doing.
The current jtregcheck target runs after all required checks have been
run, prints a summary and kills off any processes floating around.
This change breaks this ordering for no apparent gain. We now have
a pointless jtregcheck with no body and a jtregcheck-summary which
can run at any time and start killing processes.
I see the point in making the check-x targets returning an error value.
This change to the summary has no value and just breaks the Makefile
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the distro-pkg-dev