/hg/release/icedtea6-1.8: PR632: 6878713.patch breaks shark zero...
mark at klomp.org
Fri Mar 25 06:46:35 PDT 2011
On Fri, 2011-03-25 at 13:28 +0000, Dr Andrew John Hughes wrote:
> > > Where was this reviewed?
> > See this thread:
> > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-March/013107.html
> How is that a review when there is no patch attached?
The actual patch was up earlier in the thread. Matthias just asked if it
was relevant for backporting and I agreed. Since the patch mentions a
bug number you could also look that up if you are curious, it has a lot
more disscusion about the original issue:
> There is an issue with the patch that needs correcting. The NEWS entry is filed
> under 'Backports' whereas I don't believe this is an upstream backport. It should
> be under 'Bug fixes'.
OK, noted for next time. Thanks.
> Has it been tested on both HotSpot configurations in 1.8?
That is the responsibility of the person committing to the branch.
> What about 1.9?
I haven't tried personally with any branch, just the trunk which I am
> > And please only quote the relevant bits in your email.
> Again, the whole patch is relevant. I now can't comment on it because you removed it.
Really, I get the feeling you are overly pedantic.
But I cannot figure out why.
I just tried to be helpful when Matthias asked if I thought it was a
good idea to backport that patch. And I thought it was, even though I
don't use that branch myself, but obviously Matthias does.
More information about the distro-pkg-dev