[RFC][plugin]: fix fixme
asu at redhat.com
Wed Mar 30 07:11:17 PDT 2011
----- Original Message -----
> This patch implements the fixme in PluginObjectStore
> using the "wrapped" idea in that comment. It also
> synchronizes modifications to the 3 hash maps because,
> afaics, they can be called concurrently.
> +2011-03-30 Denis Lila <dlila at redhat.com>
> + * plugin/icedteanp/java/sun/applet/PluginObjectStore.java
> + (wrapped): New static variable.
> + (getNextID): New function.
> + (reference): Using getNextID and synchronized.
> + (unreference): Synchronized.
> + (dump): Improve iteration.
> Any criticism is always welcome.
> Thank you,
+ if (wrapped)
+ return nextUniqueIdentifier++;
Are we not worried about the identifiers going into negatives?
I think there's an extra space before the return.
Other than that, the patch looks ok to me.
More information about the distro-pkg-dev