[icedtea-web] RFC: add unit tests for the jnlp parser
omajid at redhat.com
Thu Mar 31 09:54:39 PDT 2011
>>> How is the NanoXML issue progressing? It would be good to have a status update
>>> on things and the progress towards the various releases of IcedTea-Web now 1.0
>>> is done.
>> Sorry, I must have forgotten to make a note of this. Generally I try and
>> keep http://icedtea.classpath.org/wiki/IcedTea-Web#Release_Plans
> I don't check the wiki regularly anyway. I'd expect stuff to be discussed on the
> mailing list then documented on the wiki.
>> Anyway, it's mostly done. I wrote these parser unit tests to
>> test that my NanoXML changes did not break anything. I will clean up
>> that patch and post it after these unit tests are committed (so we can
>> see any regressions). Assuming Deepak is fine with it, it can go in
>> before 1.1 is released.
> Yeah I think we (mainly Deepak as maintainer) need to define clearly where we draw
> a line under 1.1.
I was testing the remove-NanoXML patch when I discovered some potential
issues. One in particular is how comments in the beginning of the file
before the <?xml?> declaration are not allowed by the XML standard, but
used in some jnlp files. Using a DOM-based parser causes exceptions
parsing those jnlp files. Since this is a regression, I will not do it
now. Perhaps after or around the same time as tagsoup support.
More information about the distro-pkg-dev