[icedtea-web] RFC: PR788: Elluminate Live! is not working

Omair Majid omajid at redhat.com
Mon Oct 24 06:59:13 PDT 2011

On 10/24/2011 09:35 AM, Jiri Vanek wrote:
> On 10/20/2011 08:49 PM, Omair Majid wrote:
>> On 10/20/2011 08:52 AM, Jiri Vanek wrote:
>>> Hi. This is reproducer for this fix which Omair posted some time ago.
>>> When I was creating this simple behaviour, I was surprised that some
>>> cases are falling.

>> Would it be possible to rename the jars to make it clear which one of
>> the two exists and which one doesn't?
> Renamed... O:)

>> The indentation looks a little off here.
> fixed.

Thanks. The changes look good to me.

> Btw... For speed up the code-coverage by unittest and reproducers, I
> think that directory "tests" should be taken out from review process
> duty for new tests. What do you think?

I am not so sure this will help; test cases are part of the code we have 
to maintain. I think it's a good idea to have this code reviewed as well.


More information about the distro-pkg-dev mailing list