[rfc][icedtea-web] fixing failing unittests CodeBaseClassLoaderTest.java

Jiri Vanek jvanek at redhat.com
Wed Aug 1 09:26:54 PDT 2012

Those three tests have started to fail with NPE. I'm not sure if test is just badly written or 
IcedTea web is broken (but as there are no regressions in reproducers then I'm turning to badly 
written  test)

Please note once more, I'm not sure if fix this test this way is correct, or we have really got 
regression in CodeBaseClassLoader

But IMHO we should not have jnlp file null for anything except pure applet.
If this is correct, then this null should be probably thrown from
  new SecurityDesc(HERE, SecurityDesc.SANDBOX_PERMISSIONS, null) this contcructor (after check for 
javaws/applet) ??

2012-08-01  Jiri Vanek  <jvanek at redhat.com>

	* tests/netx/unit/net/sourceforge/jnlp/runtime/CodeBaseClassLoaderTest.java:
	(testResourceLoadSuccessCaching) (testResourceLoadFailureCaching)
	(testParentClassLoaderIsAskedForClasses) - internal JNLPFile's
	(getSecurity) null in SecurityDesc constructorrepalced by this.
	(testNullFileSecurityDesc) new test to ensure NPE in null JNLPFile case


Best regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: codeBaseLoaderTest.patch
Type: text/x-patch
Size: 3103 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20120801/12158d89/codeBaseLoaderTest.patch 

More information about the distro-pkg-dev mailing list