[PATCH 0 of 2] Add CompressedOops support to jstack.stp and tests

Jon VanAlten jon.vanalten at redhat.com
Wed Aug 8 10:35:55 PDT 2012

----- Original Message -----
> From: "Mark Wielaard" <mjw at redhat.com>
> To: distro-pkg-dev at openjdk.java.net
> Cc: "Yasumasa Suenaga" <suenaga.yasumasa at lab.ntt.co.jp>, "Jon VanAlten" <jon.vanalten at redhat.com>
> Sent: Monday, August 6, 2012 10:30:50 AM
> Subject: [PATCH 0 of 2] Add CompressedOops support to jstack.stp and tests
> Hi,
> Yasumasa Suenaga wrote a patch to jstack.stp to add support for
> CompressedOops when hotspot uses it (which is using less than 64-bits
> for object references when the heap is small enough, so needs some
> decoding support in jstack.stp). I only tweaked some indenting of the
> original patch.

Great!  The workings of jstack.stp are magic to me so I won't comment
on this part.

> The second patch adds some tests to the jstaptest.pl to tests
> everything.
> Some of the new tests fail before the jstack.stp patch and succeed
> after.
> Jon, could you take a look at this patch? It does a bit more than
> just
> adding support to test_jstack() to take an argument to pass to the
> java
> process. It also makes it a little easier to only run either only the
> check-tapset-jstack or only the check-tapset-probes target. Since the
> tapset-probes test take so long, that is really convenient when you
> are testing jstack.stp changes/tests.

This looks fine to me.  Yes, being able to run each separately (via
make target even!) is a nice improvement.  The tiniest spelling nit:

+        (test_jstack): Takse argument to pass to java process.


Otherwise, good to go!


More information about the distro-pkg-dev mailing list