[PATCH] jstaptest.pl: Expect non-zero value for hotspot.jni.NewObjectA.return

Jon VanAlten jon.vanalten at redhat.com
Wed Aug 8 10:43:51 PDT 2012

----- Original Message -----
> From: "Mark Wielaard" <mjw at redhat.com>
> To: distro-pkg-dev at openjdk.java.net
> Cc: "Jon VanAlten" <jon.vanalten at redhat.com>
> Sent: Monday, August 6, 2012 11:20:53 AM
> Subject: [PATCH] jstaptest.pl: Expect non-zero value for hotspot.jni.NewObjectA.return
> Hi Jon,
> While testing the tapset-jstack support I kept getting one failure
> for the tapset-probe tests. hotspot.jni.NewObjectA.return is
> expecting
> to get a zero return value. But that doesn't make sense to me since
> it would only return zero on failure, and the test program does seem
> to want the call to succeed. The similar hotspot.jni.NewObject.return
> and hotspot.jni.NewObjectV.return do expect a non-zero return. So I
> changed hotspot.jni.NewObjectA.return to expect the same.
> I don't know why I hadn't noticed this before. Maybe because this
> systemtap bug could occasionally get something wrong and I never
> investigated deeply before?
> http://sourceware.org/bugzilla/show_bug.cgi?id=14434
> Anyway, with this in place make check-tapset gets a perfect score
> each and every time. Does it look sane?

Hey Mark,

Yes it does, and good catch!  OK to commit AFAICT.


More information about the distro-pkg-dev mailing list