[rfc][icedtea] makefiel part of fix of rhbz 580478
omajid at redhat.com
Fri Jan 6 08:13:26 PST 2012
On 01/06/2012 11:04 AM, Dr Andrew John Hughes wrote:
> On 10:58 Fri 06 Jan , Omair Majid wrote:
>> On 01/06/2012 02:20 AM, Dr Andrew John Hughes wrote:
>>> Mostly fine, but you can use configure to do the replacement and it'll automatically handle
>>> removal too.
>> Yes, that's true. But as I mentioned in my review, this approach will
>> continue working once we fully support 'make install' (along with custom
>> prefixes and destdirs), while the configure approach will not work as well.
>> We had this discussion a while back when we were trying to add shell
>> scripts to serve as launchers in icedtea-web:
> Yeah, I'm still of the mind that this is the best solution, rather than maintaining our
> own. If someone is going to override prefix only via make, they deserve all they get IMHO.
> Is there somewhere that actually recommends/documents doing that?
> If we really want to support it, it's something that can be looked at on HEAD but
> I want the least disruptive change for the release branches and that's the one that uses
FWIW, I am fine with this new patch too.
More information about the distro-pkg-dev